GNU bug report logs - #53939
[PATCH] gnu: emacs-subed: Update to 1.0.3.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53939 in the body.
You can then email your comments to 53939 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-subed: Update to 1.0.3.
Date: Fri, 11 Feb 2022 19:45:59 +0530

[0001-gnu-emacs-subed-Update-to-1.0.3.patch (text/patch, inline)]

From 533ee184f6ff682d1b5d91798e9e6a5ffebe4592 Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
Date: Fri, 11 Feb 2022 19:38:56 +0530
Subject: [PATCH] gnu: emacs-subed: Update to 1.0.3.

* gnu/packages/emacs-xyz.scm (emacs-subed): Update to 1.0.3.
[source]: Use url-fetch.
[arguments]: Remove phase chdir-subed, enable tests.
[native-inputs]: Add emacs-buttercup.
[license]: Add CC0.
---
 gnu/packages/emacs-xyz.scm | 31 +++++++++++++++----------------
 1 file changed, 15 insertions(+), 16 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8397162c1d..c1df8ca470 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6166,34 +6166,33 @@ (define-public emacs-sudo-edit
     (license license:gpl3+)))
 
 (define-public emacs-subed
-  ;; XXX: Upstream does not tag releases.  Commit below matches version bump.
-  (let ((commit "9a660ed88600e9aff741051c28a9e638cd5df5f5"))
     (package
       (name "emacs-subed")
-      (version "1.0.2")
+      (version "1.0.3")
       (source (origin
-                (method git-fetch)
-                (uri (git-reference
-                      (url "https://github.com/sachac/subed")
-                      (commit commit)))
-                (file-name (git-file-name name version))
+                (method url-fetch)
+                (uri (string-append "https://elpa.nongnu.org/nongnu/subed-"
+                                    version ".tar"))
                 (sha256
                  (base32
-                  "1biczfg8cl9sy02yx7nmf5ma7mdjsmi27v93x1gaw4zjwj8fmlkg"))))
-      (build-system emacs-build-system)
+                  "0wibakmp1lhfyr6sifb7f3jcqp2s5sy0z37ad9n1n9rhj5q8yhzg"))))
       (arguments
-       `(#:phases (modify-phases %standard-phases
-                    (add-after 'unpack 'chdir-subed
-                      (lambda _
-                        (chdir "subed"))))))
+       (list
+        #:tests? #t
+        #:test-command #~(list "make" "test-only")))
+      (native-inputs
+       (list emacs-buttercup))
+      (build-system emacs-build-system)
       (home-page "https://elpa.nongnu.org/nongnu/subed.html")
       (synopsis "Major mode for editing subtitles")
       (description
        "@code{subed} is an Emacs major mode for editing subtitles while
-playing the corresponding video with mpv.  At the moment, the only supported
+playing the corresponding video with @code{mpv}.  At the moment, the only supported
 formats are SubRip (@file{.srt}), WebVTT (@file{.vtt}), and Advanced
 SubStation Alpha (@file{.ass}).")
-      (license license:gpl3+))))
+      ;; Package released under GPL-3.0-or-later.  `screenshot.jpg'
+      ;; and `AUTHORS.org' licensed under CC-0.
+      (license (list license:gpl3+ license:cc0))))
 
 (define-public emacs-miniedit
   (package

base-commit: a4667135284db2f0956a87fc7444c866b046ad31
-- 
2.34.0

Message #10 received at 53939-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
Cc: 53939-done <at> debbugs.gnu.org
Subject: Re: [bug#53939] [PATCH] gnu: emacs-subed: Update to 1.0.3.
Date: Fri, 11 Feb 2022 22:43:18 +0100

Hello,

Jai Vetrivelan <jaivetrivelan <at> gmail.com> writes:

> From 533ee184f6ff682d1b5d91798e9e6a5ffebe4592 Mon Sep 17 00:00:00 2001
> From: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
> Date: Fri, 11 Feb 2022 19:38:56 +0530
> Subject: [PATCH] gnu: emacs-subed: Update to 1.0.3.
>
> * gnu/packages/emacs-xyz.scm (emacs-subed): Update to 1.0.3.

Thank you.

> +      ;; Package released under GPL-3.0-or-later.  `screenshot.jpg'
> +      ;; and `AUTHORS.org' licensed under CC-0.
> +      (license (list license:gpl3+ license:cc0))))

We are not shipping any of these, so I removed the CC0 license.

I fixed the indendation an pushed.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.