GNU bug report logs - #53929
[PATCH] gnu: Add python-onlykey

Previous Next

Full log

Message #29 received at 53929 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pāladhammika <paladhammika <at> protonmail.com>
Cc: 53929 <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#53929: [PATCH] gnu: Add python-onlykey
Date: Tue, 05 Apr 2022 18:09:10 +0200

Hi Pāladhammika,

A friendly reminder:

  https://issues.guix.gnu.org/53929

TIA,
Ludo’.

Ludovic Courtès <ludo <at> gnu.org> skribis:

> Hi Pāladhammika,
>
> Pāladhammika <paladhammika <at> protonmail.com> skribis:
>
>> I see. Took the Nix package definition as an example (https://github.com/NixOS/nixpkgs/blob/7adc9c14ec74b27358a8df9b973087e351425a79/pkgs/tools/security/onlykey-cli/default.nix#L25) which turned off tests.
>
> In Guix the QA standard is to run tests by default.  When tests cannot
> be run for some reason, we add a short comment next to #:tests? #f
> explaining why.
>
> Could you take this and Maxime’s other comments into account and send an
> updated patch?
>
> Thanks in advance!
>
> Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.