GNU bug report logs - #53929
[PATCH] gnu: Add python-onlykey

Previous Next

Package: guix-patches;

Reported by: Pāladhammika <paladhammika <at> protonmail.com>

Date: Thu, 10 Feb 2022 21:31:02 UTC

Severity: normal

Tags: patch

Full log


View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pāladhammika <paladhammika <at> protonmail.com>
Cc: 53929 <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: [bug#53929] [PATCH] gnu: Add python-onlykey
Date: Sun, 06 Mar 2022 22:23:22 +0100
Hi Pāladhammika,

Pāladhammika <paladhammika <at> protonmail.com> skribis:

> I see. Took the Nix package definition as an example (https://github.com/NixOS/nixpkgs/blob/7adc9c14ec74b27358a8df9b973087e351425a79/pkgs/tools/security/onlykey-cli/default.nix#L25) which turned off tests.

In Guix the QA standard is to run tests by default.  When tests cannot
be run for some reason, we add a short comment next to #:tests? #f
explaining why.

Could you take this and Maxime’s other comments into account and send an
updated patch?

Thanks in advance!

Ludo’.




This bug report was last modified 3 years and 47 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.