From unknown Sat Aug 16 13:03:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53915 <53915@debbugs.gnu.org> To: bug#53915 <53915@debbugs.gnu.org> Subject: Status: No way of replacing an input in modify-input syntax structure but keep all the outputs Reply-To: bug#53915 <53915@debbugs.gnu.org> Date: Sat, 16 Aug 2025 20:03:47 +0000 retitle 53915 No way of replacing an input in modify-input syntax structure= but keep all the outputs reassign 53915 guix submitter 53915 Gordon Quad severity 53915 important thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 10 05:09:51 2022 Received: (at submit) by debbugs.gnu.org; 10 Feb 2022 10:09:51 +0000 Received: from localhost ([127.0.0.1]:54050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI6Od-0003g4-EO for submit@debbugs.gnu.org; Thu, 10 Feb 2022 05:09:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:41684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI6Ob-0003fx-W5 for submit@debbugs.gnu.org; Thu, 10 Feb 2022 05:09:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nI6Ob-0007Su-SS for bug-guix@gnu.org; Thu, 10 Feb 2022 05:09:49 -0500 Received: from [2a01:7e00::f03c:91ff:fedf:2cc7] (port=47980 helo=mail.niflheim.info) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nI6OZ-0005GR-HY for bug-guix@gnu.org; Thu, 10 Feb 2022 05:09:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=niflheim.info; s=20151211; h=Content-Type:MIME-Version:Message-ID:Subject: To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ii2MjgIjMbvLeM+C5RNK8hvS+HL8y90qB2Ftk5vCWQY=; b=bdx0XOJy0j6ZjV0ysxz5aLK8lU H3bI65ch+/QWUFp8oaWeANKJYz8BMad05Ipgs6JD5Qq0tDNKo6rWMistMqvM/pIhlE7hZMuX+dL39 KflCmnn9IIfqxCxzdBUwocRETDOsxP4eM9X+XbaEUQYeUFjwCJwEm32s2j+FHrX9YwLY=; Received: from niflheim.info ([10.112.10.1] helo=citadel.info) by mail.niflheim.info with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nI6OW-00051q-WF for bug-guix@gnu.org; Thu, 10 Feb 2022 10:09:45 +0000 Date: Thu, 10 Feb 2022 10:09:41 +0000 From: Gordon Quad To: bug-guix@gnu.org Subject: No way of replacing an input in modify-input syntax structure but keep all the outputs Message-ID: <20220210100941.nwmrbgm7qt34dv3v@citadel.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:7e00::f03c:91ff:fedf:2cc7 (failed) Received-SPF: pass client-ip=2a01:7e00::f03c:91ff:fedf:2cc7; envelope-from=gordon@niflheim.info; helo=mail.niflheim.info X-Spam_score_int: 20 X-Spam_score: 2.0 X-Spam_bar: ++ X-Spam_report: (2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SBL_CSS=3.335, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: poppler package include glib as a native-input with "bin" output. If I am doing the following: (package/inherit poppler (native-inputs (modify-inputs (package-native-inputs poppler) (replace "glib" my-glib)))) Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [2a01:7e00:0:0:f03c:91ff:fedf:2cc7 listed in] [zen.spamhaus.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=gordon%40niflheim.info; ip=209.51.188.17; r=debbugs.gnu.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: poppler package include glib as a native-input with "bin" output. If I am doing the following: (package/inherit poppler (native-inputs (modify-inputs (package-native-inputs poppler) (replace "glib" my-glib)))) Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [2a01:7e00:0:0:f03c:91ff:fedf:2cc7 listed in] [zen.spamhaus.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=gordon%40niflheim.info;ip=209.51.188.17;r=debbugs.gnu.org] -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager poppler package include glib as a native-input with "bin" output. If I am doing the following: (package/inherit poppler (native-inputs (modify-inputs (package-native-inputs poppler) (replace "glib" my-glib)))) poppler's build will fail becuase replace syntax will replace "glib" package erasing its outputs. I can specify output explicitly by doing (replace "glib" (my-glib "bin")) in this case, but that makes mass input modification difficult (e.g. if i want to replace all instances of glib to my-glib). That said there is a value in having such behaviour for replace syntax in case for example if I replace package with my own version that has no extra outputs, so it would be nice to have both options available. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 10 15:04:07 2022 Received: (at 53915) by debbugs.gnu.org; 10 Feb 2022 20:04:07 +0000 Received: from localhost ([127.0.0.1]:57195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIFfj-00024X-B4 for submit@debbugs.gnu.org; Thu, 10 Feb 2022 15:04:07 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:35426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIFfh-000240-WF for 53915@debbugs.gnu.org; Thu, 10 Feb 2022 15:04:06 -0500 Received: by mail-ed1-f65.google.com with SMTP id f17so12922475edd.2 for <53915@debbugs.gnu.org>; Thu, 10 Feb 2022 12:04:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=oY2t8NfsFVcSqbG19wz3iWmZvzf+GIn8t6k6MXRQCdo=; b=L4oMTcqdk0V7dvpSN1bjvDbmp000RV8oKbeFY7SZo8IP9kTVyyCeB2dcVDp1SLo0gv biNvkLndKtaK97Fpw8Z9bAyU/TMPuk84NQadhA4Nm40KA5g4orm0/9VzOs+YpnMxgipr YuHg2gLpsXfHUFFPg9vQsn5ubSEVMUHQKxQG4wMVy6prwCieTSFlD9+o1yYR65AliBBT MgBYqCMky53QlqEHdW+HCwmJEnrTZOVfkCb/Pan9f5ym5pGgYnbXDK10ZVDgqe0RcsaT 0s978K0hoJkqajYo+Z4j9B8/iNAK+IM4oZdw22KO4fHBJG/8d60WOrE4i2pbIWCVZAqA bjeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=oY2t8NfsFVcSqbG19wz3iWmZvzf+GIn8t6k6MXRQCdo=; b=uR++gxcDZH/D/wcgeigY6B0vFZeheWeq/va7z5PuLvWu9uM7NI5vhawx8LTImuIM7a /3B2FugOSf3h2GnmWfsdPE7/O5xvJpNSPR9c/Ts8TVi+yPGz7zybTQPnWfgQUm4E2R7k FB4nW9jMSzbLm3BIu42JhzXNz2Nb/qPF/SYq6RRxKHHMhTsYw95gOdNdXFRdtwL+XSbR 9sfK0/0J7wANauTQxe0r26rKbISGxPrq348ZFaj9IWU62DAyc3hFl9YntlyIcuf3tn8E 9p/8VZuS+MWOsoLMinPmetsYtYA2aok0B/gTCCn0w/IhRVitWaigh0pMZUiMqSfgxdhk wIRQ== X-Gm-Message-State: AOAM530vezk89YTyPEIdN0NE+1ieQLUdCKagWoW53hzGt74SHnBRM7KT 5iyBu/5/WI7K/ydxDYcFPec= X-Google-Smtp-Source: ABdhPJy82x5gyNjLrngYfFyKJLJNuaHENfaA3+aoFjM48CmQhnFKtjU6o3prnTSN/4aX8bRLJMESSw== X-Received: by 2002:a05:6402:12d5:: with SMTP id k21mr10219809edx.138.1644523439651; Thu, 10 Feb 2022 12:03:59 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id bt6sm7419839ejb.222.2022.02.10.12.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 12:03:59 -0800 (PST) Message-ID: <0dac06dbcb20fa32baf87df3460ebc102652f31e.camel@gmail.com> Subject: Re: No way of replacing an input in modify-input syntax structure but keep all the outputs From: Liliana Marie Prikler To: Gordon Quad , 53915@debbugs.gnu.org Date: Thu, 10 Feb 2022 21:03:56 +0100 In-Reply-To: <20220210100941.nwmrbgm7qt34dv3v@citadel.info> References: <20220210100941.nwmrbgm7qt34dv3v@citadel.info> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53915 Cc: ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Donnerstag, dem 10.02.2022 um 10:09 +0000 schrieb Gordon Quad: > poppler package include glib as a native-input with "bin" output. > > If I am doing the following: > > (package/inherit poppler >     (native-inputs >         (modify-inputs (package-native-inputs poppler) >             (replace "glib" my-glib)))) > > poppler's build will fail becuase replace syntax will replace "glib" > package erasing its outputs. I can specify output explicitly by doing > (replace "glib" (my-glib "bin")) in this case, but that makes mass > input modification difficult (e.g. if i want to replace all instances > of glib to my-glib). I think the problem here is that "glib" serves double duty as both "glib:out" and "glib:bin". IMHO we should probably add the output argument to the label (with a colon separator, of course) if one is given. I'm CC'ing Ludo because he implemented the feature and might know more than me regarding its design. Cheers From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 11 05:26:24 2022 Received: (at 53915) by debbugs.gnu.org; 11 Feb 2022 10:26:24 +0000 Received: from localhost ([127.0.0.1]:58389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIT8C-0004Td-HM for submit@debbugs.gnu.org; Fri, 11 Feb 2022 05:26:24 -0500 Received: from citadel.niflheim.info ([178.79.169.204]:49870 helo=mail.niflheim.info) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIT8B-0004TR-58 for 53915@debbugs.gnu.org; Fri, 11 Feb 2022 05:26:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=niflheim.info; s=20151211; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EBbOyXM+p/9HUUFq79doagAvbRLCwDsjAqtqEWM/reg=; b=LM6bKiMjrULIQjc81+fwPGMJKj RDuNwxBG922GRQi73BDQ0yfmpt6qj6Mw02h5MySSjXOHn90+uxXamOV+xt1fmOwZiVlZ1xQU3FqZ9 SfmLkLClRzS/jQCgXK5ygwHk2nKTGCYSEtRlSzAb/KP6T2Fy1p8YlcLzpLzHscNTzqns=; Received: from niflheim.info ([10.112.10.1] helo=citadel.info) by mail.niflheim.info with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nIT84-0000CO-L3; Fri, 11 Feb 2022 10:26:16 +0000 Date: Fri, 11 Feb 2022 10:26:14 +0000 From: Gordon Quad To: Liliana Marie Prikler Subject: Re: No way of replacing an input in modify-input syntax structure but keep all the outputs Message-ID: <20220211102614.rxbfjemppztfhlb2@citadel.info> References: <20220210100941.nwmrbgm7qt34dv3v@citadel.info> <0dac06dbcb20fa32baf87df3460ebc102652f31e.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0dac06dbcb20fa32baf87df3460ebc102652f31e.camel@gmail.com> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53915 Cc: 53915@debbugs.gnu.org, ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Feb 10, 2022 at 09:03:56PM +0100, Liliana Marie Prikler wrote: > Am Donnerstag, dem 10.02.2022 um 10:09 +0000 schrieb Gordon Quad: > > poppler package include glib as a native-input with "bin" output. > > > > If I am doing the following: > > > > (package/inherit poppler > >     (native-inputs > >         (modify-inputs (package-native-inputs poppler) > >             (replace "glib" my-glib)))) > > > > poppler's build will fail becuase replace syntax will replace "glib" > > package erasing its outputs. I can specify output explicitly by doing > > (replace "glib" (my-glib "bin")) in this case, but that makes mass > > input modification difficult (e.g. if i want to replace all instances > > of glib to my-glib). > I think the problem here is that "glib" serves double duty as both > "glib:out" and "glib:bin". IMHO we should probably add the output > argument to the label (with a colon separator, of course) if one is > given. > > I'm CC'ing Ludo because he implemented the feature and might know more > than me regarding its design. Well, just grepping the code for glib I found plenty of places where it is specified as ("glib" ,glib "bin"), and glib is the only package that I checked so far. So what you telling me that official policy is to use labeling convesion as "package:output" but not all the old code converted to that yet? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 11:01:39 2022 Received: (at control) by debbugs.gnu.org; 8 Mar 2022 16:01:39 +0000 Received: from localhost ([127.0.0.1]:57470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRcHL-0008KB-JH for submit@debbugs.gnu.org; Tue, 08 Mar 2022 11:01:39 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:29516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRcHK-0008Dt-L3 for control@debbugs.gnu.org; Tue, 08 Mar 2022 11:01:39 -0500 X-IronPort-AV: E=Sophos;i="5.90,165,1643670000"; d="scan'208";a="25070531" Received: from unknown (HELO ribbon) ([193.50.110.159]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2022 17:01:32 +0100 Date: Tue, 08 Mar 2022 17:01:31 +0100 Message-Id: <87a6e05t7o.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #53915 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) severity 53915 important quit From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 11:11:49 2022 Received: (at 53915) by debbugs.gnu.org; 8 Mar 2022 16:11:49 +0000 Received: from localhost ([127.0.0.1]:57483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRcRA-0000sc-SX for submit@debbugs.gnu.org; Tue, 08 Mar 2022 11:11:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRcR9-0000sP-MO for 53915@debbugs.gnu.org; Tue, 08 Mar 2022 11:11:48 -0500 Received: from [2001:470:142:3::e] (port=40574 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRcR4-00061E-AT; Tue, 08 Mar 2022 11:11:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ZS99613wbfJte1GK9WrHXM8Fz7dXV2h6vUBWKHJ9inQ=; b=M1WzcBbala9lrUcY3iaz +w5+Li5yJ6Lb3U3izsNma82zjTKxfnb3dFeAXLORs/c1/4TYmX6pa7HpMC3hYLCeGjuacZvmDm4pJ 5AIkdogOhHup+kz8HEe0vKOkq8hJawYq+nT6yMhAD3t0/vFa/q0p6vmeZbutrcJcN9f9Gbne5VGNu rG2+d83o+kdliQ3bUBtZMSLK8Ys1eUlIIkhKANZKoWui/+2gDy33jZUvoxlTuN8MLUla79oA5w8O+ d2y0f0uJQp8bvkOyYwX/OqZY41MwKQumf95hUccRiGjLhGldaDAhs4meCYLoojHci3cnO+8AG5epB kJhf96doFXEuCQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38512 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRcR1-00055o-Se; Tue, 08 Mar 2022 11:11:42 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Gordon Quad Subject: Re: bug#53915: No way of replacing an input in modify-input syntax structure but keep all the outputs References: <20220210100941.nwmrbgm7qt34dv3v@citadel.info> Date: Tue, 08 Mar 2022 17:11:36 +0100 In-Reply-To: <20220210100941.nwmrbgm7qt34dv3v@citadel.info> (Gordon Quad's message of "Thu, 10 Feb 2022 10:09:41 +0000") Message-ID: <87zgm04e6f.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53915 Cc: 53915@debbugs.gnu.org, Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Gordon Quad skribis: > poppler package include glib as a native-input with "bin" output. > > If I am doing the following: > > (package/inherit poppler > (native-inputs > (modify-inputs (package-native-inputs poppler) > (replace "glib" my-glib)))) > > poppler's build will fail becuase replace syntax will replace "glib" > package erasing its outputs. Indeed: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> ,use(gnu packages pdf) scheme@(guile-user)> ,use(guix) scheme@(guile-user)> (package-native-inputs poppler) $4 =3D (("pkg-config" #) ("glib" # "bin") ("gobject-introspection" #)) scheme@(guile-user)> (package-propagated-inputs poppler) $5 =3D (("glib" #)) scheme@(guile-user)> (modify-inputs (append $5 $4) (replace "glib" xpdf)) $6 =3D (("glib" #)= ("pkg-config" #) ("glib" #) ("gobject-introspection" #)) --8<---------------cut here---------------end--------------->8--- We see that both =E2=80=98glib=E2=80=99 packages have been replaced, but th= e =E2=80=9Cbin=E2=80=9D part has been removed from the second one. With the patch below, we get more sensible behavior: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> (modify-inputs (append $5 $4) (replace "glib" xpdf)) $8 =3D (("glib" #)= ("pkg-config" #) ("glib" # "bin") ("gobject-introspection" #)) --8<---------------cut here---------------end--------------->8--- If that makes sense to you, I=E2=80=99ll go ahead with this change and adju= st documentation accordingly. Thanks for bringing it up! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/packages.scm b/guix/packages.scm index 3f0262602d..288ae37523 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -1091,11 +1091,11 @@ (define (replace-input name replacement inputs) "Replace input NAME by REPLACEMENT within INPUTS." (map (lambda (input) (match input - (((? string? label) . _) + (((? string? label) _ . outputs) (if (string=? label name) (match replacement ;does REPLACEMENT specify an output? ((_ _) (cons label replacement)) - (_ (list label replacement))) + (_ (cons* label replacement outputs))) input)))) inputs)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 15:28:52 2022 Received: (at 53915) by debbugs.gnu.org; 8 Mar 2022 20:28:52 +0000 Received: from localhost ([127.0.0.1]:57994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRgRw-00066X-5e for submit@debbugs.gnu.org; Tue, 08 Mar 2022 15:28:52 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:43538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRgRu-00066K-P0 for 53915@debbugs.gnu.org; Tue, 08 Mar 2022 15:28:51 -0500 Received: by mail-ed1-f68.google.com with SMTP id b24so207369edu.10 for <53915@debbugs.gnu.org>; Tue, 08 Mar 2022 12:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=fOBPHxuAgGFxgIQ68muQhLvBhqb8gOW6LTWw3HBhhd0=; b=jn0BXCmc0e/MoOpzabtnk/p45V8F/sOzS2OmrqgPGuefPC3t8dewb3aovHgzjMo0d+ N/hIJNBGfMLmTrCP/JSMd+Mu3b3sVUfaEe4wCW0GhUbUBUjAJin9tbfQKkAuSyvuGIJw 3fSXOTC14M4wFIg4uogrBlru/irIV/y2xPNKm+wOTNxdnME/cWr3dK+uRVpBxRUXyR9f BhRPOjBdWUWHO4Bb3bpvYp6A2p0uZ1PZCRIHB5sO5LP7TW2p74mzUdPC33WNYWTfPDZF +R99IaP1XpDPo8YuXwey5m51OMHAH9X8Fy4NfJG+CthYHQzjTNDY8L5urtyYqfeK4PGo LR8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=fOBPHxuAgGFxgIQ68muQhLvBhqb8gOW6LTWw3HBhhd0=; b=bPL1rTTLoHJBfwilvE2/MbW/zQy9if2MJ6UFTJ/0d2IfkuvF61dRe+G2tBShNcUYHi DNH+7o+Juh1yDlwkEVo0YOUoK9WU73XYn8jeQRaBtEuvWwgo4bOjc60MqZ8PRt7XsLmj 4COf2HVUeNQaAfmvOokE5E8hRFch1PrPgxCN2BRs5w1IJX1JfHdRT5ews0lZYIHG+V+3 QRST8GGqKpSlQ7srQe+sPw2O/ND0kd5XJb90VL6aW7PVUGY+n8wbc24Yj5mqbln2RnTr K5Cfq80LfBK1Z09wcg8kdIc4WUTi82R+CydvQ+o3x4FsS6gAf3jD2z9puX8qVGZ5SDLP qZSw== X-Gm-Message-State: AOAM533aOeJ1u7rIsNl3AZvzozJ3kQQAewLMZgk05Lq2ddSBWBo5nioM n8e9i628Q/E0mkFtpf9Eclc= X-Google-Smtp-Source: ABdhPJzEzIHzdF25+MCfK/OnL1IrFjrvI8UGoAUHQTYb6h7LAreQgBl1QTz9L2TJK7QYKLJ5baQwnw== X-Received: by 2002:a05:6402:5191:b0:40f:b9e0:4d1b with SMTP id q17-20020a056402519100b0040fb9e04d1bmr18042400edd.149.1646771324899; Tue, 08 Mar 2022 12:28:44 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g2-20020aa7c842000000b0041314b98872sm8016923edt.22.2022.03.08.12.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 12:28:44 -0800 (PST) Message-ID: <33debb0b55b52a09d268c07ec8f2355f928de62a.camel@gmail.com> Subject: Re: bug#53915: No way of replacing an input in modify-input syntax structure but keep all the outputs From: Liliana Marie Prikler To: Ludovic =?ISO-8859-1?Q?Court=E8s?= , Gordon Quad Date: Tue, 08 Mar 2022 21:28:43 +0100 In-Reply-To: <87zgm04e6f.fsf@gnu.org> References: <20220210100941.nwmrbgm7qt34dv3v@citadel.info> <87zgm04e6f.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53915 Cc: 53915@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Dienstag, dem 08.03.2022 um 17:11 +0100 schrieb Ludovic Courtès: > [...] > With the patch below, we get more sensible behavior: > > --8<---------------cut here---------------start------------->8--- > scheme@(guile-user)> (modify-inputs (append $5 $4) >                        (replace "glib" xpdf)) > $8 = (("glib" # 7f9b1457c9a0>) ("pkg-config" # pkg-config@0.29.2 gnu/packages/pkg-config.scm:36 7f9b13a30580>) > ("glib" # > "bin") ("gobject-introspection" # gobject-introspection@1.66.1 gnu/packages/glib.scm:428 > 7f9b12994e70>)) > --8<---------------cut here---------------end--------------->8--- > > If that makes sense to you, I’ll go ahead with this change and adjust > documentation accordingly. Sounds better than my own suggestion, since it'll keep working the way it did even when labels are eventually dropped. If more control is needed, we can always later extend it to support (replace ("label" "output") (package output)). WDYT? Cheers From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 16 10:54:04 2022 Received: (at 53915-done) by debbugs.gnu.org; 16 Mar 2022 14:54:04 +0000 Received: from localhost ([127.0.0.1]:52007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUV2K-0001JQ-Hw for submit@debbugs.gnu.org; Wed, 16 Mar 2022 10:54:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUV2I-0001Iv-I7 for 53915-done@debbugs.gnu.org; Wed, 16 Mar 2022 10:54:02 -0400 Received: from [2001:470:142:3::e] (port=33240 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUV29-0003GT-Ml; Wed, 16 Mar 2022 10:53:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Ss9VO6c9cxgmuLbvGyymOb7L+eeJgehq9jrJscJx6q8=; b=jGQS8XM8jdvad/qExuiW fQXSuZJnm+YKQmsFP32sm7PusteRi9Mzv+UCSmqrvjzu4Xqxcuv0P8iXQmW2Kc9BYhhcc0x0kcJAe QDVI2ZRcub5s0/UQDMi4nEQM3BUx/Q48O37+0cyHxPSW1nUtWRwck0v+xctSOvtl3aewaPn92g7Tu pSjL3A2YLK24ed5hjArZ9TlhdIdNfWynw02xeAqS69dbFMoFqJqufD7UgE8a1YGmgFAkujX63VY6Y BY3sB3Qcmqa8OH2BIhIkw4Z1USqavfwXUMgSzMvUapM1Qwfs7svweWKjiBfhNmfTI9UGWWdUInLSn ROMmO3h4nBEZuQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:63830 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUV28-00032k-5z; Wed, 16 Mar 2022 10:53:53 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Liliana Marie Prikler Subject: Re: bug#53915: No way of replacing an input in modify-input syntax structure but keep all the outputs References: <20220210100941.nwmrbgm7qt34dv3v@citadel.info> <87zgm04e6f.fsf@gnu.org> <33debb0b55b52a09d268c07ec8f2355f928de62a.camel@gmail.com> Date: Wed, 16 Mar 2022 15:53:49 +0100 In-Reply-To: <33debb0b55b52a09d268c07ec8f2355f928de62a.camel@gmail.com> (Liliana Marie Prikler's message of "Tue, 08 Mar 2022 21:28:43 +0100") Message-ID: <87k0cuc5j6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53915-done Cc: 53915-done@debbugs.gnu.org, Gordon Quad X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Liliana Marie Prikler skribis: > Am Dienstag, dem 08.03.2022 um 17:11 +0100 schrieb Ludovic Court=C3=A8s: >> [...] >> With the patch below, we get more sensible behavior: >>=20 >> --8<---------------cut here---------------start------------->8--- >> scheme@(guile-user)> (modify-inputs (append $5 $4) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (replace "glib= " xpdf)) >> $8 =3D (("glib" #> 7f9b1457c9a0>) ("pkg-config" #> pkg-config@0.29.2=C2=A0gnu/packages/pkg-config.scm:36 7f9b13a30580>) >> ("glib" # >> "bin") ("gobject-introspection" #> gobject-introspection@1.66.1=C2=A0gnu/packages/glib.scm:428 >> 7f9b12994e70>)) >> --8<---------------cut here---------------end--------------->8--- >>=20 >> If that makes sense to you, I=E2=80=99ll go ahead with this change and a= djust >> documentation accordingly. > Sounds better than my own suggestion, since it'll keep working the way > it did even when labels are eventually dropped. Pushed with tests in 00dfff84c66c5c6aa4853684419a92befe55d4b4. > If more control is needed, we can always later extend it to support > (replace ("label" "output") (package output)). WDYT? I=E2=80=99d rather not: the goal of =E2=80=98modify-inputs=E2=80=99 is to p= rovide an interface that works as if input labels didn=E2=80=99t exist, with an eye on removing= them entirely in the future: https://guix.gnu.org/en/blog/2021/the-big-change/ Regardless, we=E2=80=99ll have to keep an eye on all these corner cases and= to adjust the plan accordingly. Thanks! Ludo=E2=80=99. From unknown Sat Aug 16 13:03:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 14 Apr 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator