GNU bug report logs - #53910
29.0.50; context-menu-mode breaks help in read-only buffers

Previous Next

Full log

Message #87 received at 53910 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: martin rudalics <rudalics <at> gmx.at>, Lars Ingebrigtsen <larsi <at> gnus.org>,
 Ergus <spacibba <at> aol.com>, Drew Adams <drew.adams <at> oracle.com>,
 "53910 <at> debbugs.gnu.org" <53910 <at> debbugs.gnu.org>
Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode
 breaks help in read-only buffers
Date: Sun, 20 Feb 2022 20:56:15 +0200

>> If `context-menu-mode` is intended to work only on displayed buffers,
>> is it really important to ensure that it also doesn't fail on
>> non-window buffers?
>
> Yes, a :filter function in a keymap should not make such assumptions
> (nor have side-effects, as a general rule).

I can't find a way to prevent :filter from executing on context menus in help
buffers, so I just removed `help-buffer-under-preparation` from :filter.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.