From unknown Mon Aug 18 14:16:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53910 <53910@debbugs.gnu.org> To: bug#53910 <53910@debbugs.gnu.org> Subject: Status: 29.0.50; context-menu-mode breaks help in read-only buffers Reply-To: bug#53910 <53910@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:16:12 +0000 retitle 53910 29.0.50; context-menu-mode breaks help in read-only buffers reassign 53910 emacs submitter 53910 Ergus severity 53910 normal tag 53910 confirmed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 09 19:16:55 2022 Received: (at submit) by debbugs.gnu.org; 10 Feb 2022 00:16:55 +0000 Received: from localhost ([127.0.0.1]:53123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHx8o-0001Wb-Tc for submit@debbugs.gnu.org; Wed, 09 Feb 2022 19:16:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:53948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHx8n-0001WU-BV for submit@debbugs.gnu.org; Wed, 09 Feb 2022 19:16:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHx8m-0002zJ-Df for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 19:16:53 -0500 Received: from sonic314-14.consmr.mail.bf2.yahoo.com ([74.6.132.124]:36107) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHx8h-00031e-FD for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 19:16:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1644452203; bh=ULX/v4F92uccBNtWEGDF9EXqR8anSdoXLs9VyXRAAkg=; h=Date:From:To:Subject:References:From:Subject:Reply-To; b=I6gd7ECaS93NRT8ep6GVgUUDFyx6KF5LPUFWEI/tZrWbOsOjp5CFaZkpsmKPFkFjAofQBm7RW7pbfbQgEcT8sxbJN+i3PDtOfilWE8vwJaLCZEB9D4eySZmzOt4svgMjqxddv5QYp5PjmaMVbKqKxSviz/PSO8n0PVGWvWEs2BmE5RCEU5opSOBUnlYv7cp8PudX2xXYdygB+4PmfYB1ZfCxbC3YTNAqAbLGrwh0fl/cu8C6x/lImxJs8ZnoB2xtIVXOaNAqBCeHiAs5p4j2HhSrgSVxxXjMTwkZFwdK9hdTpAf5/D2OT3M9MbQxVyB9IsCoMjzhyJ4OXZKBO1nWMA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644452203; bh=u+RRRrm7/ofklf5768pCT9NHHEuA/3DfYkIdW8jzOcH=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=YS+5LJ4ETTrPUqilELIJlReLS9H2Vol1ni9HGEWyrhNEA7v72IADgOiOikfBaZLT2DqfgQBxSZi2RWP+cxXWLw9ZwCN/HozvuOCrUtFGqvImrvM+FL5asKNJAWlg24UlbNdg8LRb9tO8AaxRv7XBOzvC0uU9h36JljCW+xH5LIXYkoFWI2pOoKDofj4Prnz6lYarFaPLR1QvfOqEOerxpqToG28PabxPzOcmJ1Zzs3mvMaCp0USNhCHqK/mTLuGsbBhLtnC91IF79ZkWgKFM8ZWam3nQ49P1NBQDCcxMJSbSuMiCI0nEjp/3DxPUNv0Pkk0y3qLu36okOpkb8WTx9g== X-YMail-OSG: aFoBVHYVM1kWdSKfbIqcQpmlia0pYhkulIO2quX6OVvFOOcCSUmVcXXriI4sEGv mBNp8TVbAioaeDZKp4kIgKC6Iks70Tz7pw8dnOXXD9eru6rAPYNIjjZhIOVzgvJwduwJa10GtUWx dOY1FCjBV9kg7U8Ein0PdzJdSg4UFJ.K6DqcAFwugY2NCtSpyQdifuaAS7oEvPKU08cUi2uklhL5 _Hwihe93K9_yZoq2DWXkI5jXAcBfgDC9cGKPGSxC.aYLwvZx3ZFI6g1.oTfhAJZ5lGBYxP46Db5Z 3cejsIxDzsBNMvLOHJU1umSRLWMpbnOO3y7vO55M.h6B1fdfOlfWWqzlroezHRBA7M1k93Y64Hh3 N4AHlRphnjMphAgTBOF3PEDR8MpfMzOowTOBXTfXCNSaNPornPANfR.equ1Vw5l3ulsVptSeVCBL _7HLEZ1YGKBW.EJC4o3W9uVpKS86c6Olzbesw69gNhOOuWP7EUWBBApRH00ZFmxPgylRDwecgue8 lCmR5fRkOnY1Cwx_8PSIUv8qriHc5HCOcKL33dyCy.pL0FZIlC6GF6UmTygiK18It5AEJ0Nlnto8 j978iP735c0qnEp3Wp8hSdtxoWsRWTcFghQuDeJn1vR899Plbi0xkQWdmyx23dnAIyY2FYjpmisW oA0t_G9xk4nlbmdtOo4Psd5OqmBrlMmNSNoZY6G1NjDzY4.eyJ2BPKbBJI7iQCQ8P1h02s6Rf8Ij jaGBeGlsWuPfeO5UAxpYR90c2QWhcKnROJt2rTJMwnlTb7iww0eL09ADpV4RCBy8f.JFPXqN3eqf 91VEoLbniTQ0nDuuxS1qtZXbAor7A7Wz31ucJkdIQVJpAc3asUNtySzpQRGQbq7cCm8dTjwL8dtk AjCsOUP.VPJ2n3fEJsvc24_D9VaGWaZHPLnScyI5L.OPkeeeHGrJS01bTmFhS0TL9ZPpQx31qK9q DvkH.QB_omRLFjxwWI4kiOW85qNBHCQi_Z8hP_kL5PY9OH6anjpCBiUSWmOCDhmapEQOYh7tg0xM 7vbyQCE.zB3Aq1HgMC2Yt1iMRShHT0rnxHSxQLkvuXWfE35y4DStotoVh.pmXkzOkDgbkpvyUWRz 0DmqF3yt3wTdm2CNOXD.cbpAbYx.KTNk9lGMfNrahRObVL5CUdPWFnsobqRN8GnAmSmJ6y9QbjVl 03_xaKcko1LZ4oNA.fNuyQoxc2mGPJm1oUFjhg9SsSMdJH9nyz9LZ2E.b3nf1F.jGtlNTrlCNPDB bQpFGEhrVnyfbRE5cmxyPq_qpxIr33Ce9FyadLvFJo_WIl18EhsEsgKHATaxGWdfTL5kcAsFdrQA 8t4LYuAMVU__KThrRbcaI_R1lOWNq0_YfbPbAvr30GrPS1QSUSRDStjMEbmwRWvhwR74TzDq2sZV GraMi5NmmG463f8MLvEEqJZg.JBU6s82ZVKtCMYH34HTHXV1tN7qenBjuftTiQJwGd_BvXWTCHRx MQQwjy3oMPhJgwBId0.IBk4kncwgQsRi8mlemi.fXEDWenb44z0TrJNjckaF3s._.UaW_UFJqSJb cOmznwcntJXShmbGoqFaeWFXLLSFxsahI.Ws8P1MFnJeQBilTOXhABVjmRsD4N3qqKD6uLUbL.eY tIQA8Srvc6wCodsyBGJ9wlTxMSZm0bYLDPTjfzKRcCEvh6.kixi_E0XWqZglolZaMekjOIRzu78G rc44FaaGm8.NbC4p81CstwcBhU7us.raR1pdo4Zvom.YAXAfbbw9Dx7RB6BLUFwSUypgEFBNFqZF tqXbbcCaNy1fd3ELJTyTdjzdyVAA1KkicFRC0sli9Gz7mj.T78mNkCWG8HFvV88q.jb9hj8byb1C aQx3U6uGxtCnWcrnxZnjIOqYAA6T5OVy7QU2PnGf6nkWNqcKct3oSuLDCsrcJi.BN_Kff7WMDfVw TYikI88QvPHUCNFxtqv1LiOem5H_L8DlM18CyfSmMbf1v0IsCvsacvJaT1aPZuDN2fTg7N59xBBO qFnzbAciRJLIvZgk6hk1dHdBrxzITVTGairSUqgB_RWWfB53WHVzqTpoz1p1ezRmsOUkq7YMKraN E2a4aK8.EUkjABIGAxUDECK7RcrPmIVnXxoiG0dnvtHe5ZPsx6H5K0cVFfmOraPrbn2MVByiMlWd 5fM2FUdmDovjCeEDLEeOoLEyGAdoYT7fwzAnlDGMuD2rzp8P60aTnYB7jiMYKxEA- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Thu, 10 Feb 2022 00:16:43 +0000 Received: by kubenode517.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 3ce15092a88d24761b17dcd701175cf4; Thu, 10 Feb 2022 00:16:38 +0000 (UTC) Date: Thu, 10 Feb 2022 01:16:00 +0100 From: Ergus To: bug-gnu-emacs@gnu.org Subject: 29.0.50; context-menu-mode breaks help in read-only buffers Message-ID: <20220210001600.vjiuqzoiuuzzj54c@Ergus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> X-Mailer: WebService/1.1.19724 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5633 Received-SPF: pass client-ip=74.6.132.124; envelope-from=spacibba@aol.com; helo=sonic314-14.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi recently I found that I can't access help on read-only buffers like *Occur*. To reproduce: emacs -Q M-x context-menu-mode C-h b I get this text inserted in the buffer: ` context-menu-open` And an out of range message. `describe-buffer-bindings: Args out of range: #, 173, 174` So there is the bug. Exposed initially by this: emacs -Q M-x toggle-read-only M-x context-menu-mode C-h b Just a message is shown in the echo area like an error because the buffer is read only (and such text can't be inserted...). BTW: I toggled the debug-on-entry and tried the second set of steps and debugger was not triggered, so I am not sure if this is another issue. Best, Ergus. In GNU Emacs 29.0.50 (build 62, x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo version 1.17.4) of 2022-02-09 built on Ergus Repository revision: f06915c93c0755a708f9c600e90674c68b5326dc Repository branch: master System Description: Arch Linux Configured using: 'configure --prefix=/home/ergo/.local/ --with-mailutils --with-json --with-x-toolkit=gtk3 --with-xft --with-wide-int --with-modules --with-cairo --with-harfbuzz --with-native-compilation --with-pgtk' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: global-auto-revert-mode: t xclip-mode: t electric-pair-mode: t flyspell-mode: t company-mode: t flycheck-mode: t diff-hl-margin-mode: t counsel-mode: t ivy-mode: t composable-mark-mode: t composable-mode: t repeat-mode: t xterm-mouse-mode: t minibuffer-depth-indicate-mode: t winner-mode: t save-place-mode: t delete-selection-mode: t savehist-mode: t global-display-fill-column-indicator-mode: t display-fill-column-indicator-mode: t global-display-line-numbers-mode: t display-line-numbers-mode: t which-key-mode: t override-global-mode: t eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: ~/gits/emacs_clones/composable/composable-mark hides /home/ergo/.config/emacs/elpa/composable-20201024.1458/composable-mark ~/gits/emacs_clones/composable/composable hides /home/ergo/.config/emacs/elpa/composable-20201024.1458/composable /home/ergo/.config/emacs/elpa/transient-20220130.1941/transient hides /home/ergo/.local/share/emacs/29.0.50/lisp/transient Features: (shadow sort mail-extr autorevert filenotify xclip emacsbug message mailcap yank-media rmc puny rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair flyspell-correct-ivy flyspell-correct flyspell ispell company-semantic company-template company-capf company flycheck json map find-func dash pcase diff-hl-margin diff-hl-dired diff-hl log-view pcvs-util vc-dir ewoc vc vc-dispatcher diff-mode thingatpt amx comp comp-cstr warnings s cape counsel xdg advice xref project dired dired-loaddefs compile text-property-search comint ansi-color swiper ivy-avy avy ivy flx ivy-faces ivy-overlay colir color term/tmux term/xterm xterm init composable composable-mark repeat xt-mouse mb-depth edmacro kmacro simple-16-theme winner ring saveplace delsel savehist display-fill-column-indicator display-line-numbers diminish which-key cl-extra help-mode use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core disp-table info ede/auto eieio-base cl-seq eieio seq subr-x byte-opt bytecomp byte-compile cconv eieio-core cl-macs gv eieio-loaddefs cl-loaddefs cl-lib tex-site rx slime-autoloads early-init iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 258691 16183) (symbols 48 17962 1) (strings 32 61649 6520) (string-bytes 1 2099350) (vectors 16 29163) (vector-slots 8 540047 206780) (floats 8 183 979) (intervals 56 347 0) (buffers 992 11)) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 10 02:08:34 2022 Received: (at 53910) by debbugs.gnu.org; 10 Feb 2022 07:08:34 +0000 Received: from localhost ([127.0.0.1]:53538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI3ZC-0004xC-5H for submit@debbugs.gnu.org; Thu, 10 Feb 2022 02:08:34 -0500 Received: from quimby.gnus.org ([95.216.78.240]:44540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI3Yw-0004wU-KZ for 53910@debbugs.gnu.org; Thu, 10 Feb 2022 02:08:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=B6aas5mF3kgD8SIj3h7vz+fvPgPAtbSMmeHdqrLLZu4=; b=LT1alhgJ1s4paDNwgGbMjyCRFS WIhFmmMkiofKlYNcazUjj+iGRLxOQSNeRkDbwLMNCUSO2wyJ7uaMgk6U8BPfMzz+s5DCqXeHBmiZ+ WFqwyRhd4r+fkEnVjb5/n/vxMSgBrcI/QruFuiBZRBa1MmGrFwGrHHuZhPEUFzkQIOUU=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nI3Yn-0003hD-FK; Thu, 10 Feb 2022 08:08:12 +0100 From: Lars Ingebrigtsen To: Ergus Subject: Re: bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> X-Now-Playing: Ultra =?utf-8?Q?Nat=C3=A9's?= _Is It Love? Ultra =?utf-8?Q?Nat=C3=A9?= Best Remixes Volume 1_: "Rejoicing (Gospel Stomp Mix)" Date: Thu, 10 Feb 2022 08:08:04 +0100 In-Reply-To: <20220210001600.vjiuqzoiuuzzj54c@Ergus> (Ergus's message of "Thu, 10 Feb 2022 01:16:00 +0100") Message-ID: <87mtizdwrv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Ergus writes: > Exposed initially by this: > > emacs -Q > M-x toggle-read-only > M-x context-menu-mode > C-h b > > Just a message is shown in the echo area like an error because the > buffer is read only (and such [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53910 Cc: 53910@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ergus writes: > Exposed initially by this: > > emacs -Q > M-x toggle-read-only > M-x context-menu-mode > C-h b > > Just a message is shown in the echo area like an error because the > buffer is read only (and such text can't be inserted...). > > BTW: I toggled the debug-on-entry and tried the second set of steps and > debugger was not triggered, so I am not sure if this is another issue. I can reproduce this bug, and I can't get a backtrace either, even with debug-on-signal, which is unusual. I had a brief peek at context-menu-mode to see whether it was obvious what was breaking, but nothing really stood out (but then again, I'm not very familiar with that code). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 10 02:08:27 2022 Received: (at control) by debbugs.gnu.org; 10 Feb 2022 07:08:27 +0000 Received: from localhost ([127.0.0.1]:53536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI3Z4-0004wr-Tv for submit@debbugs.gnu.org; Thu, 10 Feb 2022 02:08:27 -0500 Received: from quimby.gnus.org ([95.216.78.240]:44554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI3Z2-0004wc-Sk for control@debbugs.gnu.org; Thu, 10 Feb 2022 02:08:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aaiW3H8Mbf//kUPP9p8DeUrD6AmWtBvXcFH7w6rJyoc=; b=anRtZwB5/Cs1Oi0iR+xBLfs1p1 HOYUkRQe2jvvltbMJDjXFZ7i/Tr4Urxo1DC2zjvM9LaeMADSjsv7+lDylMz3dGk4gGKXxwHT9U8OO TqjaWIKRlOJFZvi/YPrP0/wlQvMCLg+ReVClOhrHBpCnyfISABFb3C8HQaefCAvViCJU=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nI3Yv-0003hO-4T for control@debbugs.gnu.org; Thu, 10 Feb 2022 08:08:19 +0100 Date: Thu, 10 Feb 2022 08:08:14 +0100 Message-Id: <87leyjdwrl.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #53910 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 53910 + confirmed quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 53910 + confirmed quit From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 10 03:26:56 2022 Received: (at 53910) by debbugs.gnu.org; 10 Feb 2022 08:26:56 +0000 Received: from localhost ([127.0.0.1]:53806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI4n2-00022D-GL for submit@debbugs.gnu.org; Thu, 10 Feb 2022 03:26:56 -0500 Received: from mout.gmx.net ([212.227.17.22]:46693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI4n0-00021r-N8 for 53910@debbugs.gnu.org; Thu, 10 Feb 2022 03:26:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1644481606; bh=Eurx0lB7n+BERf0xh8h5I51FJTqBnD6f/did/RPuZ/U=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=EG5ZWiXxoVT0wynWvxcHXKiX10QS+VSACxG1udFEjzmpfMOMVUv/1C5JSm1VxjNfO u06aTT5YzKXxvIGCgipAELsG1wsR2NS0NglS82++r47GDuyvV9wIgMx2gOD+innUq4 t/+7daAgmt0dXSR+mo1SH/95ztxyQ2Cr5aZ8e2gI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.154]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3se8-1oHV701k92-00zq6M; Thu, 10 Feb 2022 09:26:46 +0100 Content-Type: multipart/mixed; boundary="------------w5NemV0bLlNWyQXVGBkjFxG6" Message-ID: Date: Thu, 10 Feb 2022 09:26:45 +0100 MIME-Version: 1.0 Subject: Re: bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Content-Language: en-US To: Ergus , 53910@debbugs.gnu.org References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> From: martin rudalics In-Reply-To: <20220210001600.vjiuqzoiuuzzj54c@Ergus> X-Provags-ID: V03:K1:dFT7SPnS12w4VEdpTO49E/jMB6hQt7/ccOYf0/JodufbsYmkaie JF2EzuMfgdFp1P0Y8NRJTgrPmTgHwZeFtedRr+UO7ypUakKGlxu9Gfz00KxZ3oLzybylVxn 2JZ5RTNjwbEhRrYq8fTieDTnixzM7WGDbo4t6YhBlBzeS1/yGzmQnjhXgzFieyo6IPP8aRv rNOQXA/Ivw5oKDRijLPWA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:wD26JnXVLjQ=:JM3AV+qkdAzE9niAhryGMq NJNSw8wbqAkDFmF0HAkgjTEdOjyH3rhC7CCunav6Xqp8A4/ja9m5qtVeUX8QLfOy66PnNF6w4 rCaJpqHsF1oZBXWaCWy6Mm85n1cdvwsoE+A2E3QrM6EwDevxjNbExV6jsOrVNayMQU2+k/Vvt gVGp+SmirRUa4pXSfEvysu4tjFbBtJ6kLOzsyXjfIBI/IRZU3EgGaIggnyp3zDilOTVGIyQxr jHwdC9Pe/pJcsBRa5/5KxYgyNxa8+8Tvq1jqcVhgv1bKaSO4jzU6tRTTo1NtV4WaBK52mgYgR qh+j4aSUoriKvC2Z2G0ZvHNO2gH/w9XV1dKcRWBawEQNAJg4+S5bheDBREcjG1ZaNM9PzGcZG zPWkxqxNQ6OUHu8dc/8UaobtxEpzrpVlBCiEvNZJG6TIO7uylhsKCNj3nn4yU1zC69g0B/Qru Mr7mBiZM5Oy/kvzm6SA/Is8EWxkNfwm74mFbCqq3RscElRkwGDCWB3vz1pHn+x8702NPOUhai nA0mZSayGVWdFVMzankuE7yQ/ZnTYrukKUAbAh506XQg/0ztEC5L0rB244N9+WnVB/J2ry7Pr heWf92V+bETLR+Lyx9oAacOEmK8KhzQ13tVy8bPu0xkvNeOkn4FXf+bCMYAlTouFfc5HJmaii V7cwyqQ7og0ooKUsQ+2b08TL84gGjpZ0t24JS4R8XBYjhVEnRmxDphUTyiZ3WAhlElNoVdocZ jbyqgTltxv4wcIYDVWz9vj4fU82Aw8V0hOVYPOupQhEXTPMSoz4DGiQTL0immSEVwRWM62PJH 6fXbBuDXS5k3l2cMItW2p6q8dVzt6+oEP+ii5QRbUKfIML4Vh2hiK8o1ARXtOpMON+jJF+unz E/pb5ZBCSmY0QlzZzfN6m/KDPbHdGl18k84jSifiqL8bOo2HtbMsAZqSRiSiZB9HcSzmkTcnG s+FhmRNHNUF2ufqo1/sbfMrOKizjTpvlMK3rI1O1dL1u8DvqBjkynIcwwnQkKzZFO+DlAGuqZ Uf09vuRb/Im9L7fMF9oYIQxUh4F0B8CIR+xTz6t5wMOLhs7ZXC/QdhlOz8QU/47C6Ox8BrHHK udyFTnjIfOb0OM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------w5NemV0bLlNWyQXVGBkjFxG6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > `describe-buffer-bindings: Args out of range: #, 173, 174` Please try the attached diff. martin --------------w5NemV0bLlNWyQXVGBkjFxG6 Content-Type: text/x-patch; charset=UTF-8; name="help.el.diff" Content-Disposition: attachment; filename="help.el.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvaGVscC5lbCBiL2xpc3AvaGVscC5lbAppbmRleCA5NzViZTQ5 N2U3Li41YjcwNDc0OTU4IDEwMDY0NAotLS0gYS9saXNwL2hlbHAuZWwKKysrIGIvbGlzcC9o ZWxwLmVsCkBAIC0xMzQ5LDcgKzEzNDksOCBAQCBkZXNjcmliZS1tYXAtdHJlZQogICAgICAg KHNhdmUtZXhjdXJzaW9uCiAgICAgICAgIChnb3RvLWNoYXIgc3RhcnQtcG9pbnQpCiAgICAg ICAgICh3aGVuIChlb2xwKQotICAgICAgICAgIChkZWxldGUtcmVnaW9uIChwb2ludCkgKDEr IChwb2ludCkpKSkKKyAgICAgICAgICAoZGVsZXRlLXJlZ2lvbgorICAgICAgICAgICAocG9p bnQpIChtaW4gKDErIChwb2ludCkpIChwb2ludC1tYXgpKSkpCiAgICAgICAgIChpbnNlcnQK ICAgICAgICAgIChjb25jYXQKICAgICAgICAgICAoaWYgdGl0bGUK --------------w5NemV0bLlNWyQXVGBkjFxG6-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 10 03:59:20 2022 Received: (at 53910) by debbugs.gnu.org; 10 Feb 2022 08:59:20 +0000 Received: from localhost ([127.0.0.1]:53911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI5IO-0007fU-CE for submit@debbugs.gnu.org; Thu, 10 Feb 2022 03:59:20 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI5IN-0007et-6W for 53910@debbugs.gnu.org; Thu, 10 Feb 2022 03:59:19 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id ABE44FF807; Thu, 10 Feb 2022 08:59:09 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Organization: LINKOV.NET References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> Date: Thu, 10 Feb 2022 10:54:29 +0200 In-Reply-To: <87mtizdwrv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 10 Feb 2022 08:08:04 +0100") Message-ID: <86y22jxfsq.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: Ergus , 53910@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> M-x context-menu-mode >> C-h b >> >> Just a message is shown in the echo area like an error because the >> buffer is read only (and such text can't be inserted...). > > I can reproduce this bug, and I can't get a backtrace either, even with > debug-on-signal, which is unusual. > > I had a brief peek at context-menu-mode to see whether it was obvious > what was breaking, but nothing really stood out (but then again, I'm not > very familiar with that code). I can't reproduce this bug in Emacs 28, only in Emacs 29. This means that the problem is new. In describe-map this line switches buffers from *Help* to the window buffer: (eq definition (lookup-key tail (vector event) t)) And indeed (with-temp-buffer (message "%S" (current-buffer)) (lookup-key (cddr context-menu-mode-map) [down-mouse-3] t) (message "%S" (current-buffer))) displays: # # This is because of this line recently added to context-menu-map: (select-window (posn-window (event-start click))) that switches buffers. But the question remains: does describe-map really need to build the complete context menu or should it ignore its :filter keyword? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 10 06:36:00 2022 Received: (at 53910) by debbugs.gnu.org; 10 Feb 2022 11:36:00 +0000 Received: from localhost ([127.0.0.1]:54151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI7k0-0006Jr-0N for submit@debbugs.gnu.org; Thu, 10 Feb 2022 06:36:00 -0500 Received: from quimby.gnus.org ([95.216.78.240]:47628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nI7jy-0006Jd-2H for 53910@debbugs.gnu.org; Thu, 10 Feb 2022 06:35:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uS2CgX2wvgxPjK8z2k6qMrng2hX1ch9pXsxMfGCmF+M=; b=ORiRVTESU3zRiyDln2gEWZe5C6 mGn/3qxhfLWDnG+j9nP3wtKMMJ7+gVd6Bf+Ze4kfdIE6Dbq0+FeP26rbd99pKBe6z9MCrygC5cdWJ PkJAJkSkdPc+hs8PcSE7Nw+r1ao/F9ARJm2wzfWKibw8oNuWxatJVBfoP1oIU4hfMNFY=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nI7jo-00061q-Fd; Thu, 10 Feb 2022 12:35:51 +0100 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEVHJR9AKixHJBtm gJus3PWsrq2/YCvjn2L///8rhcJvAAAAAWJLR0QIht6VegAAAAd0SU1FB+YCCgsRATE/HVwAAAGX SURBVDjLdZRdbsMgDIBptAs0ygEI1d63LNrzopjxOk3QHmCFXCBprj+DIdA/S+0Dn2x/GAhjD2O3 Z+JhcPYEIBHtR4p9Xmc7JnrY4o1XrKo4q3ybFsDEgJGWKFoYXYweOlqLGTKBcwBYimgPCfzBUGyl auAzERjKfTRwdG5aQneZzN8Z4wf4ds5Is7lpbczYErDKZ+HP2aM5zc4NCLyWNUZarWCFWSkltfnF Hl5r1lJqrWfQYH21uYvAmJM5LiiwGLssk5yZB6glc+8QQxj7AdRmBGRbswimFePip1Wn/SFArZXi ck5jDEBoORFwFr4K4LVihgVsyzeAWrHWCiMvSr1moGVRCqelNgB1kZG11jlreWt/uiS2wE8B6HQD CVoZNFAjudHyE3jxxz5FUPYIpzvdaHnQepB8u6JUuI3Tja8IWjKuo2/SIgBph0vU2tHDaeB0N0Yh nkzrHnQZPBwj3W4tc/ehAFda0VckrbgTl7QIHEDmJ4pvfAPlox64yBn4GUgZeD95Aa6/IyVgVfjH N16JJxm0/g/Ah/XmIQnAfgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wMi0xMFQxMToxNzowMSsw MDowMBRilT4AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDItMTBUMTE6MTc6MDErMDA6MDBlPy2C AAAAAElFTkSuQmCC X-Now-Playing: Instant Life's _I turned my best friends into slaves_: "Sleeping Lexicon" Date: Thu, 10 Feb 2022 12:35:46 +0100 In-Reply-To: <86y22jxfsq.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 10 Feb 2022 10:54:29 +0200") Message-ID: <87o83f7y3x.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > (with-temp-buffer > (message "%S" (current-buffer)) > (lookup-key (cddr context-menu-mode-map) [down-mouse-3] t) > (message "%S" (current-buffer))) > > displays: > > # > #, 53910@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Juri Linkov writes: > (with-temp-buffer > (message "%S" (current-buffer)) > (lookup-key (cddr context-menu-mode-map) [down-mouse-3] t) > (message "%S" (current-buffer))) > > displays: > > # > # > > This is because of this line recently added to context-menu-map: > > (select-window (posn-window (event-start click))) > > that switches buffers. > > But the question remains: does describe-map really need to build > the complete context menu or should it ignore its :filter keyword? Hm... I don't know, but I don't think a call to `lookup-key' should result in a different buffer being selected in any case. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 10 13:59:02 2022 Received: (at 53910) by debbugs.gnu.org; 10 Feb 2022 18:59:02 +0000 Received: from localhost ([127.0.0.1]:57142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIEej-0006MI-Tl for submit@debbugs.gnu.org; Thu, 10 Feb 2022 13:59:02 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:49395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIEeh-0006Lv-Og; Thu, 10 Feb 2022 13:59:00 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3B04040007; Thu, 10 Feb 2022 18:58:51 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Organization: LINKOV.NET References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> Date: Thu, 10 Feb 2022 20:58:13 +0200 In-Reply-To: <87o83f7y3x.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 10 Feb 2022 12:35:46 +0100") Message-ID: <86iltmpn0a.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: Ergus , 53910@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 53910 29.0.50 thanks >> This is because of this line recently added to context-menu-map: >> >> (select-window (posn-window (event-start click))) >> >> that switches buffers. >> >> But the question remains: does describe-map really need to build >> the complete context menu or should it ignore its :filter keyword? > > Hm... I don't know, but I don't think a call to `lookup-key' should > result in a different buffer being selected in any case. It was surprising that select-window invoked on the same selected window switches the buffer to the originally displayed window-buffer. Maybe Martin could explain this. Anyway, this is fixed now by not calling select-window on the already selected window. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 11 03:31:26 2022 Received: (at 53910) by debbugs.gnu.org; 11 Feb 2022 08:31:26 +0000 Received: from localhost ([127.0.0.1]:58191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIRKw-0001XL-JC for submit@debbugs.gnu.org; Fri, 11 Feb 2022 03:31:26 -0500 Received: from mout.gmx.net ([212.227.17.21]:44317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIRKv-0001X8-1i for 53910@debbugs.gnu.org; Fri, 11 Feb 2022 03:31:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1644568276; bh=yMa0MrniPAQf3rlZY2ualymvSVmqpsxxGiEtowLrLGE=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=BSqjDDTSPtYKzD4uPTq6QHGYadiG3doZAjgbf+OndUOyRgXSWyKr4l8DqsejwE1iG b0WMKVCvduPzuorO/KfWgnsIHfl2/AAEv455reJ1Z5ZShfaC8YIy9dYbEhREBK/Kv8 v2quhWPwXeE8Ku8FyOK9r8DS4EvmZBwTtbe3VERE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([213.142.97.184]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MCKBm-1nQio53OaY-009NqR; Fri, 11 Feb 2022 09:31:16 +0100 Message-ID: Date: Fri, 11 Feb 2022 09:31:13 +0100 MIME-Version: 1.0 Subject: Re: bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Content-Language: en-US To: Juri Linkov , Lars Ingebrigtsen References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86iltmpn0a.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 X-Provags-ID: V03:K1:DXLke89FSUmh9doA4TOh4g8cQK/vSsokg6kf8kNy+lVvJFF0aqC 0CojxbWu9zdiRXNNOsg66URtiS901DTBIUNZkkuwLgzvxZn2xLbI1IAQY3ImmsJ8TFQNcTp MJjSg/00SCv/0qlJGZlYUywKblZxpGYUIrR8MBf1OJDddluMz6hfp5vt1tqAcR8vlGO2tbw r3U+3COZ/Z4YJlxVjy88w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:cMHy9hdJxks=:f88or7sIhda3mJK4cE5sWt d3B05H6Gv17UxzTnZDlA/fuX4sqOh9wQovFiEbYk1Ba59sqrao/ABFM4+VCe0lv3OW/V9EL7q /bng1VvG/WqWN8a2HKPQpOts4SRrGg5S7pMpE+91h8GGzYot5/8apxC1KXgMziyz4/6kMnWSZ JeYUhmKRy5XPoazUu88OzCpEDRPjudMjOgB2L2n1einXG7qwlQe4Er2C7gdMAf5nMMUm2drcP hRkw0y/JzG3EqmUCY/41G7jYpdhSKQN1wTWHjSfmLWAvOM3DAXEkiWLCv3hul8NPmH3MDYXqV YHEttB71QtFX+ES8RSudj+r0RMjJtagomKWOMmMlGbFaW1ZfETIs7qvtwvbGrfUyi3ufwoI5g G/RkJyBWHGMUMADOtUx3L3wVDUQFN1gfgq5kaT1eTVJej5xAkBQHj0sssZ2ODNkTAoxaCWzDT ciuqudSD4JEda8CoeOZOpopC0+kXcdCEVxZRMV12yz0qeIc6ib1JXzy26dT51XeVlNHFUz1nG oQ9GEdOjbXEN+zPiMnY1mxtZu4USDJJooW5ufvRdQcK0Mx4kmzQGhJaLatGLYwn1N4SxJGyiv rbiEKOWAJ4HkWdXbJGasTLg5XZ0pIg/FWbIMjmMzEsmKUZLaP0oxrstnua+iV+mlblxSHoNhc Qn6wiABWI4/YuI78C2kJLnpyRdjNCkyIUorssotCTaItKRXaJdGqj+Zj/o91DCtS2RwcZKUeZ d/eFVcjJhNRrfT8SceC13sVBvAqP+JAqPqwU6LJvfwDV666k1Sobzdzng34KOFeUKmB6N5Fel 23nfW/bW46BUwwQcijWZIPOCSy3HhSjmFNdNRM3Oqi2XWMP+aUj6cd2vmpVWeETQo628gu0f5 1ogYPXoCjyAf6Y4gbpAgsQFap5196L9WxLF5wVWzJ9VKdj1kbYqM/+w6knEWMSeAISE5aoE/S qRDA6eB44fKQwDQCesC8cIAn2FgndNNzsfz1CQlH9DMwwnbQs78lkspfWDPB+SwVH0Hsa7cqg dshl6gHepgNQElSANx3Rta4itjAoK4c9pDpJ6O9kDsRkOBHxuq5fuVtHkHWC1jzvVaRKear2k d2+iLHbiV0jteU= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: Ergus , 53910@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) ID4gSXQgd2FzIHN1cnByaXNpbmcgdGhhdCBzZWxlY3Qtd2luZG93IGludm9rZWQgb24gdGhl IHNhbWUgc2VsZWN0ZWQgd2luZG93DQogPiBzd2l0Y2hlcyB0aGUgYnVmZmVyIHRvIHRoZSBv cmlnaW5hbGx5IGRpc3BsYXllZCB3aW5kb3ctYnVmZmVyLg0KID4gTWF5YmUgTWFydGluIGNv dWxkIGV4cGxhaW4gdGhpcy4NCg0KRG8geW91IG1lYW4gdGhhdA0KDQood2l0aC10ZW1wLWJ1 ZmZlcg0KICAgKGxldCAoKGJ1ZmZlciAoY3VycmVudC1idWZmZXIpKSkNCiAgICAgKHNlbGVj dC13aW5kb3cgKHNlbGVjdGVkLXdpbmRvdykpDQogICAgIChtZXNzYWdlICJiZWZvcmUgJVMg YWZ0ZXIgJVMiIGJ1ZmZlciAoY3VycmVudC1idWZmZXIpKSkpDQoNCmlzIHN1cnByaXNpbmc/ ICBCdXQgJ3NlbGVjdC13aW5kb3cnIG9ubHkgZG9lcw0KDQogICBJbiBhZGRpdGlvbiwgbWFr ZSBXSU5ET1figJlzIGJ1ZmZlciBjdXJyZW50IGFuZCBzZXQgaXRzDQogICBidWZmZXLigJlz IHZhbHVlIG9mIOKAmHBvaW504oCZIHRvIHRoZSB2YWx1ZSBvZiBXSU5ET1figJlzIOKAmHdp bmRvdy1wb2ludOKAmS4NCg0KYXMgYWR2ZXJ0aXNlZC4gIE9yIGRvIHlvdSBtZWFuIHNvbWV0 aGluZyBlbHNlPw0KDQptYXJ0aW4NCg== From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 11 03:45:54 2022 Received: (at 53910) by debbugs.gnu.org; 11 Feb 2022 08:45:54 +0000 Received: from localhost ([127.0.0.1]:58225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIRYv-0001u8-SX for submit@debbugs.gnu.org; Fri, 11 Feb 2022 03:45:54 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:60455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIRYu-0001ti-Ls for 53910@debbugs.gnu.org; Fri, 11 Feb 2022 03:45:53 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id ACA4F200012; Fri, 11 Feb 2022 08:45:44 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Organization: LINKOV.NET References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> Date: Fri, 11 Feb 2022 10:40:17 +0200 In-Reply-To: (martin rudalics's message of "Fri, 11 Feb 2022 09:31:13 +0100") Message-ID: <86wni13ifi.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: Lars Ingebrigtsen , Ergus , 53910@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> It was surprising that select-window invoked on the same selected window >> switches the buffer to the originally displayed window-buffer. >> Maybe Martin could explain this. > > Do you mean that > > (with-temp-buffer > (let ((buffer (current-buffer))) > (select-window (selected-window)) > (message "before %S after %S" buffer (current-buffer)))) > > is surprising? But 'select-window' only does > > In addition, make WINDOW’s buffer current and set its > buffer’s value of ‘point’ to the value of WINDOW’s ‘window-point’. > > as advertised. Or do you mean something else? Yep, this is what I meant. I expected it no-op in this case, but the documented behavior is fine. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 11 11:46:52 2022 Received: (at 53910) by debbugs.gnu.org; 11 Feb 2022 16:46:52 +0000 Received: from localhost ([127.0.0.1]:60868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIZ4O-0002cg-Ht for submit@debbugs.gnu.org; Fri, 11 Feb 2022 11:46:52 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:38598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIZ4L-0002cW-0w for 53910@debbugs.gnu.org; Fri, 11 Feb 2022 11:46:50 -0500 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21BEJpXj026356; Fri, 11 Feb 2022 16:46:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=z8aZaA35ioAlhd1uuFZulTeJyo4tu59cd8iqD4r77wM=; b=cBy4QhYOjENboBgiB/CIXgGYzqjfQ1omE34Hsl5nzYeJsGQP/63K1930POM2ADq/t4SX lwdYP9GNQAJ3qhuuZThOFw+sEmCymstVqFjOOBj28ca/rH3IwQBRyKH1J+wlqrHha5cx 6PWn864KertqBq47FaLlH6OK0olFue2Onje90YykE86kmX1FUZa1wXtoJ5r8jISy72gC 9wOZwaNQ6cDsTPH6ZIfW+Xa+ebNmwZ+wRVajLPrtOe/xnugan3GEykaggr3OAp1AkJ7S RN09whW2LhSFXcoG0yv/b/5dYyp9uIBgMCcJzjU6Wi751t/iJobO+s6FgmT5+EZ3Tmt7 yA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3e54ykk6nk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 11 Feb 2022 16:46:46 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21BGfjAF008130; Fri, 11 Feb 2022 16:46:45 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2044.outbound.protection.outlook.com [104.47.56.44]) by aserp3020.oracle.com with ESMTP id 3e1h2cpeh5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 11 Feb 2022 16:46:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wa4BT31vZ748J9etjFCaq1Di56c04OiTJplmlqm+zR/qyHXz4dh01jZIeQmo3UbsYtrRKvENjetbtqjgUCTQwJZgIyWizEYv3M+MOi4YUB5aczih5ydyjBRjgHP+4kfwdJq3k1c+t1Bd/JCctNGXJ7ZApHXO2H+UYEYC6ZlhrUY2nENrlpp8b1852qo1a0LFa9dzUEg6hCIltWcZD2zLLl6woHcSvZSuIngag9Smg9KOnYGf7XR4o1Q0LAIf/vzBDPvDAXKta+m5PvzbxxOFTIAjcfhlFNdKkRzQXRIxfI3WNn33R9rrPjR1lEUV3apbABRFimt+xzx49tJRW41QjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z8aZaA35ioAlhd1uuFZulTeJyo4tu59cd8iqD4r77wM=; b=lMss6yO3e0AYkMWeC7zUT4dOs2nI/dCQrEihazWN6/zO2Z2X5YxzgKrOBkUsGFHGusWlYrSOTImWKldyJZrO0ZvEKCt2m6ub73zPyxaPZGf6CTkIWfDCEZWbyu1wIr24CcF5X4HBabHIUN9PyAGByl3gf8DVoY4yBAZr3heUFtqyBeTmOHe0cWxZ55lTgSM0YqguRvyJmQdSRsiJ7RfFGblMnXZ6VN7eAzurVt7dlpBAu9ZQ7WAeFyR1ZsB5zHMYtloSMgDfWFALhlXB3wKsxmqNb27W7DEe/zkdGY0u6oeicGomMtF6GL77yyLgzvduQ7+Cg6S6Iilew4QEdRYVvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z8aZaA35ioAlhd1uuFZulTeJyo4tu59cd8iqD4r77wM=; b=goH2yevhqB70jxZ7mHUXGipg5IN3Rs6ur0dwiydmabOeLfHxi/o7EJG6HR3MWKc0vhBmetaZAT73TCQRFRFipj+ShYAaYGGyZw5Z/PQeAEleCAPrM7EPbGLFUPK/xy+ejr/xXhGQRfmssFfiVssNLPVFuH6ye1tXfKi4vtYLWCk= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by MWHPR10MB1870.namprd10.prod.outlook.com (2603:10b6:300:10a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb 2022 16:46:43 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%7]) with mapi id 15.20.4951.019; Fri, 11 Feb 2022 16:46:43 +0000 From: Drew Adams To: Juri Linkov , martin rudalics Subject: RE: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Thread-Topic: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Thread-Index: AQHYHydW1Xsr1CXi+UOfhLbwH4PqSKyOjrvQ Date: Fri, 11 Feb 2022 16:46:43 +0000 Message-ID: References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> In-Reply-To: <86wni13ifi.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17c65e2a-a917-469a-fc57-08d9ed7e15e3 x-ms-traffictypediagnostic: MWHPR10MB1870:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5elLO/ZyWh1vR/7WAyhdWIZe1eF8m3Dvh6Ag+ATYq2MmNO5uKwlK/YqEbKEHOTp2gp9czY6/N4as7zxAFbqI7AUw6fAGigetb86Cd/27oCpPeVafjlKY7uN6RFCGLy46Ysp7r7+u2UH8PkONBWHWZukG5KqdG9n0sXTbbNU+Gdo2/s9iJT7q4AMyGAAw+3k1QsEkoMqGgjl5os3hYlZSIUoMP9yHMbgKbN4DtiwLZLUogDP7g7zhOTgyqQC7atnldjQZXB1x6INH2Tk++7Ot+JAnaUNrIMbRCjF7VK2rNOr2YywpR+K7dK2uixR3rEqwcYBGjFMK4abKET+F8uHQuGscSQjtgHlTow0uOT2etsRl5d4Ay8vQU15rfWuMWKPViGz9mhy2dmvl/nejhpi9xs+U/a7fYXNj8uQ2vbimyNB53McFfhJeTXa0E4xwQmJqfdosIWRgR0njtZTN1XRuuUtMMaPOIazPL09V4eZfTpIpYtBTg1y40m/E1JhYIgBSnWlx9stf+QLWG2GaZ4boPhcwV4We1Yd7wHoKBMr9c+m7Ce1IrynmQnczlZb1e7mTMPoARPLt7A/CXY5jiTCiwg8GcKezEmSImeNc3RKPjGppzcs6fB0mW9Lwwd4Dt2aUsl17bsgbFBVtjYTy+XFoIj6/qRq0qcZaQ3p5i53U1S4VMeXRVUQy0mXw22rczD5UHnSMyqOwZclkMPHzo+f1/A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(9686003)(122000001)(4744005)(44832011)(83380400001)(316002)(33656002)(52536014)(6506007)(7696005)(5660300002)(71200400001)(508600001)(110136005)(54906003)(2906002)(55016003)(38070700005)(76116006)(66476007)(64756008)(66556008)(4326008)(8676002)(8936002)(66446008)(38100700002)(186003)(26005)(66946007)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NnFxSHNSa0Q1Q2UzL1VEbHpzMkRnYm5lVzFRdkYrSTFleWpJbkdGaDhBUkFj?= =?utf-8?B?VFI1WmRBS1BYcG1jWVNRS3lMY2RNcm80SXh0RmFJNDZHY3YyajVaL0NYR1pT?= =?utf-8?B?ZDlIZ3VERTRpa2xQRitCVzdSdTJXa0lvQXUrZERkMklNelkyd3lzckNoaWVW?= =?utf-8?B?NDFFdUNRTlhXbFNMQUZwelBXM0lUQ1VzUlAvRGowNGpBK254REpla1ByeXdF?= =?utf-8?B?VWV0MGlia1RmK3BnL0QzWHR3eFNxclV1dHZPNmxLOEhwOTJVbjYvcktFOEd0?= =?utf-8?B?aFdzbUxkQ2ZLYm5yNnJIK0dNUTFJZkZydG1yMmU3NmxVQWM3Z3pyODRUMGU3?= =?utf-8?B?U3hoTVFmUFRBRnFFNEx4eXdLaG5DZVJuZnJTKzFFYkZuKy9abzh6Z3JkeXpv?= =?utf-8?B?dHdUdDBsTWhZZFMrbTlVNmdjMDhlWURZeEltRDZ6SSszQmMxY1pHMzA5b095?= =?utf-8?B?NGU5a2lQeGFSTzQvNlZ4R1hoV2ltZEJpcUtXZXBzbTB4cHYwMkdkR1BWYWo0?= =?utf-8?B?RFBNcjg4c09rZDRuRjIvdGcyd2RVY2ZDSDFWVTU5RHRrVTQ2T3ZoMVQrUkZI?= =?utf-8?B?WUhrcmVVU2FNRFFiRm52dTgvR28zWmNPeWZ0UXRibDlzL3h3dUlUdVhzU2g4?= =?utf-8?B?Z1g4ZGhRaVZTNEkrcXBUb3lSUjlKWHJqVHpPT2puRm55enBnSXorWGxPU2Zx?= =?utf-8?B?VDNZQWxWTHM4NGFkVTF3N0ZBQmRYWUNPWE5Fbzkybm5BTlMySXJwYjJwY05a?= =?utf-8?B?ZHBmVHdFbDFRdjNyclBNVlNXV1JpR0VmVE94bmErQWptY21QWW8wWDdNQXd6?= =?utf-8?B?ZklQSU1nQng2VFZsdmpHTFRiV3FrMWF3SkNLQVhZNjNzWDZQTEVvbzJMOFVP?= =?utf-8?B?MG4wNWJjb0R5TEZLR2ozWXpCdEZzN1lpQjdvd1JpMU12WklXWHhyS2ZnNWRx?= =?utf-8?B?QXljK2hOVGZlMUVlTXhoSy90UUtGSm1TVkU0U01BS1R4Q3pxRzRHS05MckZ1?= =?utf-8?B?R3ZzSnRNWVg0MisrT25MTTh1TFRWV2cyakJLc3JyeGRwcnpIS3daZ0JoRDM0?= =?utf-8?B?OWxUYzlBOHVMYWo2ZWJKSVB0NVFhTlVjY1IwOUNCV0Z4dDRIVlJpVkFYK2dB?= =?utf-8?B?WXVhbzV4cXJaYWMvZS9TaFBERDVRc1I5bGY5cW5ObGZTUjVRWXJvamlXbWRD?= =?utf-8?B?S0N5cXZwLytOM0FTU0h5a3k3UEErK01JQktoakx4QWFpcWtEb2h5UmV5dW1Q?= =?utf-8?B?QnZKZ2wxMk9MVVJHaHZrcytlQ2FPcTJrRjQ4Mnlhbld3VkcwSGkvZlB6MStE?= =?utf-8?B?YVhqTUk5Y0pRV1czZHVmTTV0ZHJ2T1BDdjZzSlJMbC9seVpES2ljS1o1RFBS?= =?utf-8?B?V3BhblVkdklqN3hNZEJ1V3NvY3lzTlpHaDhyZGk4dGt3N3l3czRKeHFxai9W?= =?utf-8?B?UlBrS09YZVhUZ2VwMkFscENsUWNyd0R4RGRIM0VUcXdkRW5za09ya0dnTkRY?= =?utf-8?B?c2RaQ3BwbkxWMWNyRDVBQ3ZpT05IWFhVTXMwdHFURHp6eDBiRWYwWUFOeXdT?= =?utf-8?B?aldnS3IwN3FLbTk1OENsS1B3UzRhWnlMTFpVZlBLZTEvcWQwQ1R1MU9GWEVa?= =?utf-8?B?RzNjOW04Uy9wVklPcTZIaHl3RXdsNnBTQTQ3RnZKTk0wQkdYK2RaeElLbnl4?= =?utf-8?B?MUtXSi9LY2JZRERKbllib1ZCOStJRWlFc1IvWXBxMkFTdkJBdSt6NDFDMTFE?= =?utf-8?B?TkNXL1FGL2hpNWZwVXl4cFV1cEhucmlwTit0cXRnU0JldjlmU0pQNHMwSk93?= =?utf-8?B?aDVSWS9rTGc3K1hEMXVyL2Y1U256NWhScHkvSXhmU1hya0Z5Qk1QWndGWGJQ?= =?utf-8?B?NDVSMkkwU3R6QVM4NWl0eXkzRXhPeUQyU0NGNFc5VnY2WHdJTXhtWjRrdU9i?= =?utf-8?B?Zmd5SVhkZ25SVWVZS1QwRWlmZEZvcWIzbVV4VjljU3lHcWpPN3J2d1cxaXhK?= =?utf-8?B?MFB5UVV3M0hUQ3lGRytENmdkM2RQYU1nYXFLRWF0dEFTWkpoQzlzbGhhbVZh?= =?utf-8?B?OTZtRVFodUtNYU14MXdKNjJPQVRJcFRpMzQyQUo3MXRtcnVsQ1hLK3NVQ25Z?= =?utf-8?B?Uzk0UUlsdUpXdVJmN0NzSTZoMW9nNTcrQkdmRmNLeHlXN1FVSDMrazFBcXc3?= =?utf-8?B?Z1E9PQ==?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17c65e2a-a917-469a-fc57-08d9ed7e15e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 16:46:43.7779 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iJ/SK4tRz5jZO0yoOTjxYnraTnGnc8sKC3d95szm03vag1xtky6B16H2DmNavQISYkmCowM32NQBwylnz1ZK3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1870 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10255 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 bulkscore=0 phishscore=0 malwarescore=0 mlxlogscore=890 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202110091 X-Proofpoint-GUID: X-p5Z8ZXr7ZpS8e5SveNksZczIg1k7ff X-Proofpoint-ORIG-GUID: X-p5Z8ZXr7ZpS8e5SveNksZczIg1k7ff X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: Lars Ingebrigtsen , Ergus , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiA+ICh3aXRoLXRlbXAtYnVmZmVyDQo+ID4gICAobGV0ICgoYnVmZmVyIChjdXJyZW50LWJ1ZmZl cikpKQ0KPiA+ICAgICAoc2VsZWN0LXdpbmRvdyAoc2VsZWN0ZWQtd2luZG93KSkNCj4gPiAgICAg KG1lc3NhZ2UgImJlZm9yZSAlUyBhZnRlciAlUyIgYnVmZmVyIChjdXJyZW50LWJ1ZmZlcikpKSkN Cj4gPg0KPiA+IGlzIHN1cnByaXNpbmc/ICBCdXQgJ3NlbGVjdC13aW5kb3cnIG9ubHkgZG9lcw0K PiA+DQo+ID4gICBJbiBhZGRpdGlvbiwgbWFrZSBXSU5ET1figJlzIGJ1ZmZlciBjdXJyZW50IGFu ZCBzZXQgaXRzDQo+ID4gICBidWZmZXLigJlzIHZhbHVlIG9mIOKAmHBvaW504oCZIHRvIHRoZSB2 YWx1ZSBvZiBXSU5ET1figJlzIOKAmHdpbmRvdy1wb2ludOKAmS4NCj4gPg0KPiA+IGFzIGFkdmVy dGlzZWQuICBPciBkbyB5b3UgbWVhbiBzb21ldGhpbmcgZWxzZT8NCj4gDQo+IFllcCwgdGhpcyBp cyB3aGF0IEkgbWVhbnQuICBJIGV4cGVjdGVkIGl0IG5vLW9wDQo+IGluIHRoaXMgY2FzZSwgYnV0 IHRoZSBkb2N1bWVudGVkIGJlaGF2aW9yIGlzIGZpbmUuDQoNCk1heWJlIGl0IHdvdWxkIGhlbHAg dG8gZHJhdyBzb21lIG1vcmUgYXR0ZW50aW9uDQp0byB0aGlzIGluIHRoZSBkb2Mgc29tZWhvdz8N Cg0KSSBkb24ndCBmaW5kIHRoaXMgb2J2aW91cyBhdCBhbGwsIGV2ZW4gaWYgdGhlIGRvYw0KZG9l cyBzcGVjaWZ5IGl0LiAgVGhlIGZ1bmN0aW9uIG5hbWVzIGRvbid0IGdpdmUNCnRoZSBpbXByZXNz aW9uIHRoYXQgdGhlIGJlaGF2aW9yIHlvdSBzcGVhayBvZiBpcw0KcGFydCBvZiB0aGUgd2hhdCB0 aGUgZnVuY3Rpb25zIGRvLg0K From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 12 12:15:55 2022 Received: (at 53910) by debbugs.gnu.org; 12 Feb 2022 17:15:55 +0000 Received: from localhost ([127.0.0.1]:35549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIw03-0006rd-BG for submit@debbugs.gnu.org; Sat, 12 Feb 2022 12:15:55 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:37719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIw00-0006rB-Sk for 53910@debbugs.gnu.org; Sat, 12 Feb 2022 12:15:53 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3C34E60005; Sat, 12 Feb 2022 17:15:43 +0000 (UTC) From: Juri Linkov To: Drew Adams Subject: Re: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Organization: LINKOV.NET References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> Date: Sat, 12 Feb 2022 19:05:03 +0200 In-Reply-To: (Drew Adams's message of "Fri, 11 Feb 2022 16:46:43 +0000") Message-ID: <86pmns10kw.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: martin rudalics , Lars Ingebrigtsen , Ergus , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > But 'select-window' only does >> > >> > In addition, make WINDOW’s buffer current and set its >> > buffer’s value of ‘point’ to the value of WINDOW’s ‘window-point’. >> > >> > as advertised. Or do you mean something else? >> >> Yep, this is what I meant. I expected it no-op >> in this case, but the documented behavior is fine. > > Maybe it would help to draw some more attention > to this in the doc somehow? > > I don't find this obvious at all, even if the doc > does specify it. The function names don't give > the impression that the behavior you speak of is > part of the what the functions do. I don't know, maybe the docstring could warn about this case too. What worries me more is that the following idiom is not always safe: (with-selected-window (or window (selected-window)) body ...) because it might switch the buffer of the already selected window. This idiom is used to prevent duplicating body in e.g.: (if window (with-selected-window window body ...) ;; Else call `body' in the selected window: body ...) To avoid this problem, maybe the macro `with-selected-window' could select the window only if it is non-nil, like this: diff --git a/lisp/subr.el b/lisp/subr.el index a78af09c40..2e528f5c8c 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -4224,7 +4224,8 @@ with-selected-window (internal--before-with-selected-window ,window))) (save-current-buffer (unwind-protect - (progn (select-window (car save-selected-window--state) 'norecord) + (progn (when (car save-selected-window--state) + (select-window (car save-selected-window--state) 'norecord)) ,@body) (internal--after-with-selected-window save-selected-window--state))))) Then this could be used even when 'window' is nil: (with-selected-window window body ...) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 13 03:49:25 2022 Received: (at 53910) by debbugs.gnu.org; 13 Feb 2022 08:49:25 +0000 Received: from localhost ([127.0.0.1]:36264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJAZR-00089W-Bc for submit@debbugs.gnu.org; Sun, 13 Feb 2022 03:49:25 -0500 Received: from mout.gmx.net ([212.227.17.22]:47115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJAZP-00089H-JF for 53910@debbugs.gnu.org; Sun, 13 Feb 2022 03:49:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1644742152; bh=YSiWKL5WwkxtiJ7+Doan5fO665ihNd4sEkFHZY7T/BE=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=WhNaVSIl+ffxNstTu0STJoGqsPcitAdQAMoiZ79iGPntLxfuH71/Lzj7fHxS3Q6sh cLF7Nbt1aDryzNOTWa/zxKRIH5YSWa8GAhkVUMJwLiGdn/fOilQRRBI4Cgg1mQ5v73 fGQoc4/Zj3Izw4cEkcrEkt9wcIeSxCfIXKU4WnWY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.197]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N5GE1-1oJxyH2vXJ-011DO1; Sun, 13 Feb 2022 09:49:12 +0100 Message-ID: <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> Date: Sun, 13 Feb 2022 09:49:10 +0100 MIME-Version: 1.0 Subject: Re: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Content-Language: en-US To: Juri Linkov , Drew Adams References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86pmns10kw.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:4yGufGl3n5viWBTYPt4rOnZmGjmRgxjLAQWlHSpjOvb1i6mEBRI brC6FyVy9e9QlKzYMMuuCphwNFHtK9N8QSjeo49vGwAQnLJwg5YM2V1p4NkUXR0HEufQxAg dKPlpVNuXA0ui+8+e9Xtt5aUgDBkFFZcTUTHW6Z2k+yFpDEPuI2X6EnMWffRZlSvvmekpeG reECWgTSZlymXcQD8THHA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:MKZFRf9sO4E=:66AVHRRyniAmcmvAYgc0BA kTUA5RwHnQJJJ4Z4NPPK2Bt71Ck4AAWTJdAJyjp9nWChphtthfsqjapiQ/ULI5PcjIujzGVGD fsYO8rJk2NkTj83oqQ+8ml7OgZTjdQmNmTHwuIgJhMc92n7OaTwhBr6cQIIcvWsPQO6/vyknW yOcC4fjd5PMKE84TfdVVrwWEVdmNQhDVo/q4DBisyhoB54VylyxCgE5bpbhbrGhLO94aWl9GK ZxSPP9z0sp8TRvzo8qlLovxKy66+9oGDOe5vt0rbHoCWbdc9NNuKGE1EHQhvXcIis8KC386h0 kYR7StamWb5tr3DND64TVc4YETPRDQbY3DWrf9v2bXHQcmPKxZMZN0fGWHtnynJmiAZ2jp+wm mXVkhyEBvTv+Xc5Ips0DEpnPVvGU/Q17QolQ09R+mUrvpEJ52soDb1hiWeCbEBsm8Y6vojtON SUd7iZHl8JWrhdO47DFEvL8oMVhoPujAaJKjXnxJF9ms+l0sLiRFJG7BHjMFO1t4VyABV3tvY ZMtnwvGU6UDTNL1t8N1Tdc/3BV58v50QDnMD6oYaKdyCHe+nQ1CSxr6qVxXBbEe5liG2U+wTb Yupcuv9a9Um+jANRfNNS5vYcCXk4Hm7dD/vvwJLnbb4JvPK5NqBh7FFXJwNlJ0q/LlD5vEPQQ 5KqS3dMuOVbJ294eI94+Pxkn+3lJTmKz6ZADLODksdXAe632qraJgProQ5ttW3idIwt6YkZ+G UWZFtOWZj0up0vJQOE9CZ6PefLQQnvH3zZGnaMYxuNCMom+Kly6R91hQ47WWRCoTI+BU7re7b Jno9rMomHgccZF4dezF/WZ5ljszGKQNBtJ0CE/76uWUMzCfUJmHD8+34/J4zCyXRXsFEqjGQR bLoZ0l6w6kb0ByO+PSSIjvVuluadSUUQRAn4PXPaGDYkz4Jl19TKDQU1/+iqgwdW5DZi4F7tc Xz1IKaMtv80xRaXgMRX+NLXSf8N2/yuEsBQjvbsfUjD89D6HHxkfR+p+UG98jgyr8hguxiakS LPL5yhvyWE2E0ib0UaPp0c/1QEK9XAvspuJJLfta/oT1pTeywW3lZR1eutAZUwk5qWqXqAQVF djSjBeL5ivlx6Q= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: Lars Ingebrigtsen , Ergus , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > What worries me more is that the following idiom is not always safe: > > (with-selected-window (or window (selected-window)) > body > ...) > > because it might switch the buffer of the already selected window. IIUC you mean that it might make another buffer current? But the whole idea of selecting a window is that it gets you in a consistent state where, for example, the window is the selected window of its frame which is also the selected frame and point returns the position of point of the selected window. Everything else is of evil (on the Lisp level). I don't know why you need that idiom in tab-line.el but, for example, the completely misguided (defun window-safely-shrinkable-p (&optional window) "Return t if WINDOW can be shrunk without shrinking other windows. WINDOW defaults to the selected window." (with-selected-window (or window (selected-window)) (let ((edges (window-edges))) (or (= (nth 2 edges) (nth 2 (window-edges (previous-window)))) (= (nth 0 edges) (nth 0 (window-edges (next-window)))))))) should be written as (defun window-safely-shrinkable-p (&optional window) "Return t if WINDOW can be shrunk without shrinking other windows. WINDOW defaults to the selected window." (let ((edges (window-edges window))) (or (= (nth 2 edges) (nth 2 (window-edges (previous-window window)))) (= (nth 0 edges) (nth 0 (window-edges (next-window window))))))) So I'd urge you to rewrite the tab-line functions in a more safe way. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 13 13:56:49 2022 Received: (at 53910) by debbugs.gnu.org; 13 Feb 2022 18:56:49 +0000 Received: from localhost ([127.0.0.1]:38887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJK3F-0007Bv-0S for submit@debbugs.gnu.org; Sun, 13 Feb 2022 13:56:49 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:49577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJK3B-0007Bf-Mb for 53910@debbugs.gnu.org; Sun, 13 Feb 2022 13:56:47 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 371C1FF80B; Sun, 13 Feb 2022 18:56:36 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Organization: LINKOV.NET References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> Date: Sun, 13 Feb 2022 20:50:10 +0200 In-Reply-To: <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> (martin rudalics's message of "Sun, 13 Feb 2022 09:49:10 +0100") Message-ID: <861r06vbos.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: Lars Ingebrigtsen , Ergus , Drew Adams , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> What worries me more is that the following idiom is not always safe: >> >> (with-selected-window (or window (selected-window)) >> body >> ...) >> >> because it might switch the buffer of the already selected window. > > IIUC you mean that it might make another buffer current? But the whole > idea of selecting a window is that it gets you in a consistent state > where, for example, the window is the selected window of its frame which > is also the selected frame and point returns the position of point of > the selected window. Everything else is of evil (on the Lisp level). Indeed, what describe-bindings does by calling context-menu after switching buffers is evil. Here is another attempt to prevent this: diff --git a/lisp/mouse.el b/lisp/mouse.el index 4c0d455808..1ad6fd089b 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -541,7 +541,9 @@ context-menu-ffap (defvar context-menu-entry `(menu-item ,(purecopy "Context Menu") ,(make-sparse-keymap) - :filter ,(lambda (_) (context-menu-map))) + :filter ,(lambda (_) (unless help-buffer-under-preparation + ;; No need to build menu to describe keys + (context-menu-map)))) "Menu item that creates the context menu and can be bound to a mouse key.") > I don't know why you need that idiom in tab-line.el but, for example, > the completely misguided > > (defun window-safely-shrinkable-p (&optional window) > "Return t if WINDOW can be shrunk without shrinking other windows. > WINDOW defaults to the selected window." > (with-selected-window (or window (selected-window)) > (let ((edges (window-edges))) > (or (= (nth 2 edges) (nth 2 (window-edges (previous-window)))) > (= (nth 0 edges) (nth 0 (window-edges (next-window)))))))) > > should be written as > > (defun window-safely-shrinkable-p (&optional window) > "Return t if WINDOW can be shrunk without shrinking other windows. > WINDOW defaults to the selected window." > (let ((edges (window-edges window))) > (or (= (nth 2 edges) (nth 2 (window-edges (previous-window window)))) > (= (nth 0 edges) (nth 0 (window-edges (next-window window))))))) > > So I'd urge you to rewrite the tab-line functions in a more safe way. While it's possible to use the 'window' argument in all functions used in window-safely-shrinkable-p, tab-line functions use functions that don't accept the 'window' argument, e.g. current-buffer, kill-buffer. But there is no problem for tab-line to select the already selected window since it operates on windows. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 17 14:14:11 2022 Received: (at 53910) by debbugs.gnu.org; 17 Feb 2022 19:14:11 +0000 Received: from localhost ([127.0.0.1]:52705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKmEE-00017e-PA for submit@debbugs.gnu.org; Thu, 17 Feb 2022 14:14:10 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKmEC-00017P-NN for 53910@debbugs.gnu.org; Thu, 17 Feb 2022 14:14:09 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9FEFE806A3; Thu, 17 Feb 2022 14:14:02 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 40CA8802B7; Thu, 17 Feb 2022 14:14:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1645125241; bh=nWDhLgrxJI+tn6vor4skpCw7A+HY5No26GEmqYbdn50=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cp+NYKypgfuvst/SLRgWPTEoi7bNrYDOvottxKEVJvvDA3dwGjOmFgTNbUSbjZGlE CFpVJMa9vdDKbm8GwOs5pBMMuU5O4pLzs3WnkDmFgWOBAwrCba5xTXte4iljNFVycZ /xQqMELS2nshB0gxe/bruDYm2nvvDrsY/i+mxXBCS7VExW20qC0JFucEVnk49XSWwT ff4cCIGJko0tTbajed2MGMq/QSr83lqGkrPmr5uGO+j4dBAwxV4JbhNEAJAzXiLeBc XBwWiNtX+wtnmC83gQO7bGfd+tlwlc9JEUyFsjNxHMe4/J/ZLYoGNJTfLQIJxA/Lne 2F4LfTDxn2udQ== Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EE931120B33; Thu, 17 Feb 2022 14:14:00 -0500 (EST) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Message-ID: References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> Date: Thu, 17 Feb 2022 14:13:59 -0500 In-Reply-To: <861r06vbos.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 13 Feb 2022 20:50:10 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53910 Cc: martin rudalics , Lars Ingebrigtsen , Ergus , Drew Adams , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > --- a/lisp/mouse.el > +++ b/lisp/mouse.el > @@ -541,7 +541,9 @@ context-menu-ffap > > (defvar context-menu-entry > `(menu-item ,(purecopy "Context Menu") ,(make-sparse-keymap) > - :filter ,(lambda (_) (context-menu-map))) > + :filter ,(lambda (_) (unless help-buffer-under-preparation > + ;; No need to build menu to describe keys > + (context-menu-map)))) > "Menu item that creates the context menu and can be bound to a mouse key.") FWIW, I find this hideous. `mouse.el` should not depend on `help-*` variables. > While it's possible to use the 'window' argument in all functions used > in window-safely-shrinkable-p, tab-line functions use functions that > don't accept the 'window' argument, e.g. current-buffer, kill-buffer. `window-buffer` is the function that returns the "current" buffer of a window. As for `kill-buffer`, I'm not sure what window arg you'd like to use by I suspect (kill-buffer (window-buffer )) is what you're after. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 17 14:31:57 2022 Received: (at 53910) by debbugs.gnu.org; 17 Feb 2022 19:31:57 +0000 Received: from localhost ([127.0.0.1]:52716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKmVR-0001Yf-JG for submit@debbugs.gnu.org; Thu, 17 Feb 2022 14:31:57 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:48411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKmVO-0001YP-SY for 53910@debbugs.gnu.org; Thu, 17 Feb 2022 14:31:56 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 516B840005; Thu, 17 Feb 2022 19:31:44 +0000 (UTC) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Organization: LINKOV.NET References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> Date: Thu, 17 Feb 2022 21:30:13 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 17 Feb 2022 14:13:59 -0500") Message-ID: <868ru9jnp6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: martin rudalics , Lars Ingebrigtsen , Ergus , Drew Adams , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> (defvar context-menu-entry >> `(menu-item ,(purecopy "Context Menu") ,(make-sparse-keymap) >> - :filter ,(lambda (_) (context-menu-map))) >> + :filter ,(lambda (_) (unless help-buffer-under-preparation >> + ;; No need to build menu to describe keys >> + (context-menu-map)))) >> "Menu item that creates the context menu and can be bound to a mouse key.") > > FWIW, I find this hideous. `mouse.el` should not depend on `help-*` variables. I know, but there are too many problems when help functions are trying to build the context menu in a non-displayed buffer. Is there another way to prevent this? Recently this was changed: - `(menu-item ,(purecopy "Context Menu") ignore + `(menu-item ,(purecopy "Context Menu") ,(make-sparse-keymap) to prevent where-is-internal from running context-menu-map by describe-mode in the wrong buffer, but this was not enough. >> While it's possible to use the 'window' argument in all functions used >> in window-safely-shrinkable-p, tab-line functions use functions that >> don't accept the 'window' argument, e.g. current-buffer, kill-buffer. > > `window-buffer` is the function that returns the "current" buffer of a > window. As for `kill-buffer`, I'm not sure what window arg you'd like > to use by I suspect (kill-buffer (window-buffer )) is what > you're after. Maybe (kill-buffer (window-buffer )) has the same effect when used in any window, but (bury-buffer (window-buffer )) definitely should be called in the required window, because `bury-buffer` uses `nil` for the WINDOW args, e.g.: (set-window-dedicated-p nil nil) (switch-to-prev-buffer nil 'bury) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 17 15:12:48 2022 Received: (at 53910) by debbugs.gnu.org; 17 Feb 2022 20:12:48 +0000 Received: from localhost ([127.0.0.1]:52733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKn8y-0002X5-Fn for submit@debbugs.gnu.org; Thu, 17 Feb 2022 15:12:48 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKn8v-0002Wq-Fd for 53910@debbugs.gnu.org; Thu, 17 Feb 2022 15:12:47 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 560884424B9; Thu, 17 Feb 2022 15:12:39 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C26734424B2; Thu, 17 Feb 2022 15:12:37 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1645128757; bh=pcdJAsR3LjAWS3x55XYGzTIInJNO4bKaaESQtGHKz2Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RRS2CQjrSqW5tisU5s/hoOspuI2AYPnlz0ZyzMjxC18eLBYdNrYghBHRnTG6Rh+FR Ua7PGP3PzfiI1rXzYBFZSr3xwCvZbBO+brZtV2GhBjzaVAn7MV/ySVK825+HIGW5k8 in0aXvEgLXKowfRQFQWj1BudWMbWmVc4uwz/eu8qBU4V2zaArT9VOBXSBHLvCG+QCL fAWaPl2c1zrQb7FT2ADPujlP28RK0D9NJfBvuX4ugVqcjouY0xogKmeLo/+SWs7FuZ akntJ6CGOopnVcyMIdSkzpFtRj0wZMOQYlzFgkYy8WPnbcVCAd5tvT51y2scoM2T8U bIgXJmdCjjQVA== Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 831EF12023D; Thu, 17 Feb 2022 15:12:37 -0500 (EST) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Message-ID: References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> Date: Thu, 17 Feb 2022 15:12:36 -0500 In-Reply-To: <868ru9jnp6.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 17 Feb 2022 21:30:13 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53910 Cc: martin rudalics , Lars Ingebrigtsen , Ergus , Drew Adams , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>> (defvar context-menu-entry >>> `(menu-item ,(purecopy "Context Menu") ,(make-sparse-keymap) >>> - :filter ,(lambda (_) (context-menu-map))) >>> + :filter ,(lambda (_) (unless help-buffer-under-preparation >>> + ;; No need to build menu to describe keys >>> + (context-menu-map)))) >>> "Menu item that creates the context menu and can be bound to a mouse key.") >> FWIW, I find this hideous. `mouse.el` should not depend on `help-*` variables. > I know, but there are too many problems when help functions are trying > to build the context menu in a non-displayed buffer. Those are bugs in the context-menu functions that need to be fixed because they'll bite us sooner or later in other cases anyway. In a sense, we should be happy to have such an easy way to trigger those bugs ;-) > Is there another way to prevent this? I think a slightly cleaner way (if you want to keep such a workaround rather than chase&fix the underlying bugs) is to move the var to `mouse.el` and call it `inhibit-context-menu`, and then let-bind at the appropriate place with a prominent comment explaining why we're using such a hack. > Maybe (kill-buffer (window-buffer )) has the same effect > when used in any window, but (bury-buffer (window-buffer )) > definitely should be called in the required window, Indeed, there are several function that need the right `selected-window` and where you can't pass an explicit window instead, and `bury-buffer` is one of them. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 18 02:53:08 2022 Received: (at 53910) by debbugs.gnu.org; 18 Feb 2022 07:53:09 +0000 Received: from localhost ([127.0.0.1]:53361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKy4i-0001tu-MS for submit@debbugs.gnu.org; Fri, 18 Feb 2022 02:53:08 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:54399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKy4g-0001tO-GF for 53910@debbugs.gnu.org; Fri, 18 Feb 2022 02:53:07 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 71DB9C000E; Fri, 18 Feb 2022 07:52:55 +0000 (UTC) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Organization: LINKOV.NET References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> Date: Fri, 18 Feb 2022 09:44:14 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 17 Feb 2022 15:12:36 -0500") Message-ID: <86fsogocwx.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: martin rudalics , Lars Ingebrigtsen , Ergus , Drew Adams , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>>> (defvar context-menu-entry >>>> `(menu-item ,(purecopy "Context Menu") ,(make-sparse-keymap) >>>> - :filter ,(lambda (_) (context-menu-map))) >>>> + :filter ,(lambda (_) (unless help-buffer-under-preparation >>>> + ;; No need to build menu to describe keys >>>> + (context-menu-map)))) >>>> "Menu item that creates the context menu and can be bound to a mouse key.") >>> FWIW, I find this hideous. `mouse.el` should not depend on `help-*` variables. >> I know, but there are too many problems when help functions are trying >> to build the context menu in a non-displayed buffer. > > Those are bugs in the context-menu functions that need to be fixed > because they'll bite us sooner or later in other cases anyway. > In a sense, we should be happy to have such an easy way to trigger those > bugs ;-) If `context-menu-mode` is intended to work only on displayed buffers, is it really important to ensure that it also doesn't fail on non-window buffers? I think the bug is in these functions that are trying to call `context-menu-map` in a non-window buffer, in this case the bug in the Help functions. Then indeed instead of using `help-buffer-under-preparation` in `mouse.el`, maybe it should be fixed in `describe-map` somehow to not call `lookup-key` that creates the context menu with: (eq definition (lookup-key tail (vector event) t)) >> Is there another way to prevent this? > > I think a slightly cleaner way (if you want to keep such a workaround > rather than chase&fix the underlying bugs) is to move the var to > `mouse.el` and call it `inhibit-context-menu`, and then let-bind at the > appropriate place with a prominent comment explaining why we're using > such a hack. Then this means using something like this in `describe-map`: (let ((inhibit-context-menu t)) (eq definition (lookup-key tail (vector event) t))) But indeed, this looks like a workaround. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 18 03:32:58 2022 Received: (at 53910) by debbugs.gnu.org; 18 Feb 2022 08:32:59 +0000 Received: from localhost ([127.0.0.1]:53411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKyhG-0002tE-Ny for submit@debbugs.gnu.org; Fri, 18 Feb 2022 03:32:58 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKyhE-0002t1-QZ for 53910@debbugs.gnu.org; Fri, 18 Feb 2022 03:32:57 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7CBF510018C; Fri, 18 Feb 2022 03:32:50 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DEAAD100135; Fri, 18 Feb 2022 03:32:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1645173168; bh=ybEA2/xIWpMvRZWrhZUKAKUCEk8VkP+yWI/cuW+moH0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Fy94dQwLYhxy9dZycHiMjSSiQwSdNqZv7yysSrZ/YWcuJZ28csfNuXSdpT2FUTaSk OTK2Vs9qOnW5wScJ2Lqg/ikC5+Ob5joeBaUEWeycvcQqkh7b8wgQNyocBLeyGbLCcK 4k5NNyVczbRsTO77n0AaMaGBfxhDl5AuORj5mZFRVOmcBxwuVCIN67ALJcXbd0BKdc jM0psmo2y876h499XsdtrHpOUvnGFwTtjMHl666zgLIZRu2E4LQFZ6W1ypEJ+jp75x vKrpuLVsvKglCkOGWGzCYYSaWz4L0cssZxJ2tmX69YysGygmEaf+Uw27wOcVQvXH14 f5PIfHYaYtqiw== Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 99CFA1202E6; Fri, 18 Feb 2022 03:32:48 -0500 (EST) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Message-ID: References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <86fsogocwx.fsf@mail.linkov.net> Date: Fri, 18 Feb 2022 03:32:40 -0500 In-Reply-To: <86fsogocwx.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 18 Feb 2022 09:44:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53910 Cc: martin rudalics , Lars Ingebrigtsen , Ergus , Drew Adams , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > If `context-menu-mode` is intended to work only on displayed buffers, > is it really important to ensure that it also doesn't fail on > non-window buffers? Yes, a :filter function in a keymap should not make such assumptions (nor have side-effects, as a general rule). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 19 04:41:28 2022 Received: (at 53910) by debbugs.gnu.org; 19 Feb 2022 09:41:28 +0000 Received: from localhost ([127.0.0.1]:56907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLMF6-0000zE-18 for submit@debbugs.gnu.org; Sat, 19 Feb 2022 04:41:28 -0500 Received: from mout.gmx.net ([212.227.17.22]:48961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLMF4-0000z1-AL for 53910@debbugs.gnu.org; Sat, 19 Feb 2022 04:41:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1645263673; bh=ptKQbld2mJzbB240gmfpF2peV20Te7WJ5S+qqxjYIVg=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=i2AIR1LF+9a6ixStqnupsG3/lO2RUYdBr1VUCV1ysjfiKk/xlAgyHhes9LqeHb2HR +1PiW5RJ8Yy6t3tc9a5s0/QrXvd/8fCFAeRQQ1J5JceJd0a69jZ7eZQmrW3dN1S6b+ kagO5Ryr9KFAh2YlenKE1CZu/pRUklLmIeQZBzb8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([46.125.249.118]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MBUm7-1nYEvm2cdr-00CzB4; Sat, 19 Feb 2022 10:41:13 +0100 Message-ID: <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> Date: Sat, 19 Feb 2022 10:41:09 +0100 MIME-Version: 1.0 Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Content-Language: en-US To: Juri Linkov , Stefan Monnier References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <868ru9jnp6.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:nQzTSy3ammP9YbB8iZcs2d6TuUlVdSBvV4+Rkd1dtnXirsUfPCy n9qzxC/lhG88NOY65I/iwHEANQe2TnrxGFS8YG6aKak2ZWgu2OsvCjIBNTYBXhilotBVoqE RUrLMmVlWe0nHqrUBbIRcjSzItyEePeUxnDoSNcK5uxk67h35nmmN+SBYb+bRvEVFg1GoBq Z9gbk+EJAOpvbvsI1NtKg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:B6Y3Adze3sk=:Rn1GUtnVD1mhY7yWAqy6Nl iWqO1uEw0VSrZH1p2qynalIhqdJxNQb8BAv9aStAkX0HMghXGA02+eJ5DF0y4pzBupKL+tQ6B BuG/AiHZtRmtZHguxjCrYCyODDVSVgIOe0+ktaA5iYLGDEXLi5ieksTEHj3idlrAf06LFdKoX phHMuQFj3+IybRJLRSQWNLr76SMHtHIPvolA9rGX5ndRZQ7auN1RFc4SLOL/q95ps/0axwvcy 6F+WarK/7U8mFkMIPoyahPoEzLCEegmaHzP2npxzLekU376CO6Pz7JOa5Ygh89Y6OiMFY6AJK EvVA8xnQss2NOq5mFW+nPL6OYT1p9eRqdvZVNPjuvuaPLMrfi9Q+2xT+SO/+xWE+5hLNyIFlj x906s8ScwbceG7wjLCGGlNZN78nIFxou/vk9jZcQsJLpXildLks1GHSgBerN16aVe7xLzrjvt I8ZrahsRGFg3mEG8GXXPUfeW2QYU9xGUrlKzDd3NV87JF0gxM+YS7M1uGRLq6l3ks0Dl3+5BY cxDLn+UtPSBiVaGP5wkEw2fTz/AHGPeUrdTcP8kW3aWQER1XMKFnfuU0xzlYLm0Hai+f06n6p t9TE8lwpd0pb/Bo3DO7outqRKPaQV3cigbQsFYh8AaBHKFAv0ejIrpXkebPUMz+DtieRydzMW H35cxLwZ+1eFA7pehDfDy2wy0QRMeOs31YdF/0fWtVW2/Y4fEzQO2DJin9VM4StMbsriAWrSM ZKmvHHpcDYhs3Jqm9itry8aqxLpvrfBh0PDBgGYdWKv/t89wdpcHaaex7pO++CN65B7ACqOcI LMlZ2ySjDHt794ZDnin46PZeVSRHmR3ZR/Y9u3+2fo6A3vKhtWvinXelMEBpP234+UFfj37zN YV79GcFYASYMi2tRAXrvqZ4Z6eS3e6UgBFdRIalvqqt3s39kHhEqca6pcD/TSIWFqM+lxZmM6 JoCkoSvnCG5DhXKs8MKPTaZOKYXtUt/tkVpcqrtWucuknpETlwRlfuxX896Sms6Vw4NSL6jXn AjL275u9qaKHdCGVrIS4W1tYVN4pSczIzRWxxsKOqB7X6nCjAF7dUHfNv3gdpAWf414X64yCa hdck4WR07XiDWk= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: Lars Ingebrigtsen , Ergus , Drew Adams , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Maybe (kill-buffer (window-buffer )) has the same effect > when used in any window, but (bury-buffer (window-buffer )) > definitely should be called in the required window, because `bury-buffer` > uses `nil` for the WINDOW args, e.g.: > > (set-window-dedicated-p nil nil) > (switch-to-prev-buffer nil 'bury) I recommend against calling 'bury-buffer' in Lisp code: A function that does If BUFFER-OR-NAME is nil or omitted, bury the current buffer. Also, if BUFFER-OR-NAME is nil or omitted, remove the current buffer from the selected window if it is displayed there. is clearly intended for interactive use only. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 19 07:26:28 2022 Received: (at 53910) by debbugs.gnu.org; 19 Feb 2022 12:26:28 +0000 Received: from localhost ([127.0.0.1]:57034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLOom-0005Gr-3M for submit@debbugs.gnu.org; Sat, 19 Feb 2022 07:26:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLOoj-0005Gc-PH for 53910@debbugs.gnu.org; Sat, 19 Feb 2022 07:26:26 -0500 Received: from [2001:470:142:3::e] (port=57210 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLOod-0003Co-7O; Sat, 19 Feb 2022 07:26:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pvAJeV+BiRf/XQJMAuC0lyPvXCOaoojf1G+fb6ioUW8=; b=MUJVd5CvobGc 6KBpE+0FEHRzQTvSXo7AfETHetII6IjdW/3HCRXe2L6prN+9wPKBLc4IwzexY6dYXs92qRPHh60Mk aScoL/F+7axuoJPyKKyR84vzpLqj1hqmy3Tl1JLlE7LhdhU8dXGl08kl3Mm63e3VMzG7/Kzt/zHkJ BcUaw9Pjx6AGCXF9GfPwfGjMwrzuwX+ahoQ7UQ2K5GGwHNxcvrmY4A1zmxM7PGM4jjGE34fzaYQxN j4u2sTb2ENS4xpHSkgxzALf3rNv60vhoPEdxz5S9zrKo9FT473LHtn7l7xKjVa+ES4y5tzTShRfNW R8xrE/Mgys++pKG/aNdgnA==; Received: from [87.69.77.57] (port=1111 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLOoc-0008RP-LR; Sat, 19 Feb 2022 07:26:18 -0500 Date: Sat, 19 Feb 2022 14:26:18 +0200 Message-Id: <83a6enyrdh.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> (message from martin rudalics on Sat, 19 Feb 2022 10:41:09 +0100) Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53910 Cc: 53910@debbugs.gnu.org, larsi@gnus.org, spacibba@aol.com, monnier@iro.umontreal.ca, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 19 Feb 2022 10:41:09 +0100 > From: martin rudalics > Cc: Lars Ingebrigtsen , Ergus , > "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> > > I recommend against calling 'bury-buffer' in Lisp code: A function that > does > > If BUFFER-OR-NAME is nil or omitted, bury the > current buffer. Also, if BUFFER-OR-NAME is nil or omitted, > remove the current buffer from the selected window if it is > displayed there. > > is clearly intended for interactive use only. What exactly do you mean by "interactive use only"? Several commands invoke bury-buffer as part of their job -- or do you consider that to be "interactive use" as well? From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 19 09:38:52 2022 Received: (at 53910) by debbugs.gnu.org; 19 Feb 2022 14:38:52 +0000 Received: from localhost ([127.0.0.1]:57189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLQsu-0006vK-Cl for submit@debbugs.gnu.org; Sat, 19 Feb 2022 09:38:52 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLQsr-0006v6-Uc for 53910@debbugs.gnu.org; Sat, 19 Feb 2022 09:38:50 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CD51C4409D0; Sat, 19 Feb 2022 09:38:43 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 679494409E2; Sat, 19 Feb 2022 09:38:42 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1645281522; bh=pRFcRhggjvzfMcedE89nE8WaIOWn4hNdsXgkvEwEttk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eB6yFGnbM4fKu3GDv+fa6qWr9SkdDl3DHk410LM2Wy5p09Jfx1LLvilC9ErMMMPaX p4IvF1QPc7NfrmfgqA5Vzq71cS3Nnb4g0hpzzp91m22Cf/dSNrtmZVMmy/WZDcJcxf v1MMO2ba3PCFT9nrKeAnzU5oFv29tm3pkXAW5mtCpCG72ZHkqQYOoiRgTX/eSxyPzg Jp9pvnyIKCzl52yUQWw8vOyNdmnK/PkWDSmIlBocUKI6hFoArCrfbxZ3u3BKBEbINH KjmodWQnf9EBmLs7DBZ3Ts+wf9jAqxkrQPSwNZfAiKQp+bcGb0O7EY7b9JnRyXhPyt LSA0UXrsCvOVA== Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1EBAB120B1B; Sat, 19 Feb 2022 09:38:42 -0500 (EST) From: Stefan Monnier To: martin rudalics Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Message-ID: References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> Date: Sat, 19 Feb 2022 09:38:40 -0500 In-Reply-To: <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> (martin rudalics's message of "Sat, 19 Feb 2022 10:41:09 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53910 Cc: "53910@debbugs.gnu.org" <53910@debbugs.gnu.org>, Lars Ingebrigtsen , Ergus , Drew Adams , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I recommend against calling 'bury-buffer' in Lisp code: A function that > does > > If BUFFER-OR-NAME is nil or omitted, bury the > current buffer. Also, if BUFFER-OR-NAME is nil or omitted, > remove the current buffer from the selected window if it is > displayed there. > > is clearly intended for interactive use only. I think I understand why you say that but the interactive spec only allows passing nil as argument, so maybe calling `bury-buffer` with a nil argument should not be done from Elisp, but if calling `bury-buffer` *in general* should not be done for Elisp, then we can simplify the docstring ;-) Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 19 12:07:18 2022 Received: (at 53910) by debbugs.gnu.org; 19 Feb 2022 17:07:18 +0000 Received: from localhost ([127.0.0.1]:58649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLTCY-0002jQ-8s for submit@debbugs.gnu.org; Sat, 19 Feb 2022 12:07:18 -0500 Received: from mout.gmx.net ([212.227.17.22]:39947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLTCW-0002jB-LN for 53910@debbugs.gnu.org; Sat, 19 Feb 2022 12:07:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1645290425; bh=eZBdjfLbe8RY24phRAbBaziQA6eCZHM16m5c6i2ABTY=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=E0mWL5dKQHMFFL+CYdExkkYzy8QlPwrYL4uwZe/5FsbFHEPTnCM3iyuKOHqmylrQl ZZacLj9QSbrMf0mjTGuDRhSoQXfNJOwlgayMwIwQeYKiRPoTaNS6wMgEKTwv47Run1 xE/NhyFKVj2BDH6E/qx5eIiQWilVysiDPhGQA97g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([46.125.249.118]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4Qwg-1oMtDD1psE-011VPP; Sat, 19 Feb 2022 18:07:05 +0100 Message-ID: <54befa08-3bce-1d86-4e8b-e3cc4246da0b@gmx.at> Date: Sat, 19 Feb 2022 18:07:03 +0100 MIME-Version: 1.0 Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Content-Language: en-US To: Eli Zaretskii References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> <83a6enyrdh.fsf@gnu.org> From: martin rudalics In-Reply-To: <83a6enyrdh.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:UDmVUSNGMjQA3LslkjuowpPOYxWxBDwoAJq1iDSio2KwtfyhLC0 72oHa89BY298U4HGfG4YR+twlYtewhe3gPdyPAyWgaW2fSDUSuDq2wtR7Uyk7eXow1jZ0Nn qsVlXyc+ZUUSLHjUuiDAt8g2bmgZsCTKuM5/j4hbe7h59eEezXbJADdBWMxMBR5eabTnlP3 mO3fJziDppp5djcauQ6Vg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:raaQHKDB2Ds=:5Yhb9U14StYbMY0oB00lQZ NSKVaev4AD37/WUE0i7aJInHaJxfIINsfC1O8frVjydm+QNi2uxgj8OIpSfXNizZ12lLdgErt +p6p0b2cCp7QDqG4poBs+Ta/Ka/emNqdFqZ0MU/cAt4tkKwQpR0HDw0Nkcom+qZb0CjhD6gFr kSMD96/3GIEkU5JofCAz25CNL5/9U0fcjIykIeko7Bux0zM4bjGQT3fIKG6jPvUgPPVYWVGjz jrT0mZ9Bbg4CyjDo5ZjSIaDmtkM0EZTqSWDin07B4qwB6u2grvbW8KudjRAOZVV9VwwRroarK QfEL+uw9TKXO7KY04A7OAC2JqsceXYEVYeRSGSYrHXroY6SMcgSo/9GuPwPeXnlpwQxImEkzX GvE+7jeZ4RKIF/f46xFk8xBbrDFA9rmcorUGy/xR/doU2xxXoS+ySWhSzhN1OJfhu7MFcuRlh rrJ/z+O5gACbwOpdLD+uCJvK/sr/Al9luLPI2YNPMA9xzD6IFiAaYcNwDVv6lxdC9S0kuJADV 2DGGr3FgRiIze0hVPIln32hZS0uOAwGLspJGQPTm6C4nZazhpfVQxm3xgAxuAxTLWHQGU7bAB 0/dtmbw0OVc2ZD73Eh0jyKc9U2sX2WYCLroAQDJcyOPFeI3d8p7Fbqo25k0Ovs6ApffmuII5I GHGBWiki7WNma26VhBAox3gIHh3NZxXS5I5JwwfdgvXjVhGIaT20IfgsEXH04a3LiKVaUos/h kahSZYmZEOGgjXznCFybjHadoOURmXnAVPVeYE1B/qbQ/HecLiKUpvDwayLZzCmIlyb+uU2Gc Icl6M1y30ys13/+TztYGg4zEqwFzQXSlnUNiHzmVIptrKjwxOm2ghp45lsDjeBcFndt42PSzE OGY5Dl0hhUD1NLrb+FuRBMgpVvnxCIa2o2jgXom+Ey9kzzBvqSYndmdI7QMYvMWH852K5i5Vb gv6hDVJKA6A2C27z2X6lfQEuMFwRfVI9z8T7Am5l3aODkFYkOsJTBKrK2oybx04KbcscnYeIW HjCDIZ66GwukaOIXaYl3uzrieb5HsATwAOctIZayUs6WlHV4nutHMTp76WOwhzbI0rooPu/lZ mC6h7ZQ5785W3E= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: 53910@debbugs.gnu.org, larsi@gnus.org, spacibba@aol.com, monnier@iro.umontreal.ca, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > What exactly do you mean by "interactive use only"? Several commands > invoke bury-buffer as part of their job -- or do you consider that to > be "interactive use" as well? No. Consider the following two forms: (defun foo (&optional buffer) (interactive) (let ((buffer (window-normalize-buffer buffer))) (if (or (and (window-next-sibling) (eq (window-buffer (window-next-sibling)) buffer)) (and (window-prev-sibling) (eq (window-buffer (window-prev-sibling)) buffer))) (bury-buffer buffer) (kill-buffer buffer)))) (defun foo (&optional buffer) (interactive) (if (let ((buffer (window-normalize-buffer buffer))) (or (and (window-next-sibling) (eq (window-buffer (window-next-sibling)) buffer)) (and (window-prev-sibling) (eq (window-buffer (window-prev-sibling)) buffer)))) (bury-buffer buffer) (kill-buffer buffer))) If, after C-x 2, I do M-x foo, the first will leave the windows' buffers unchanged while the second will show another buffer in the selected window. So my conclusion is to never use 'bury-buffer' in Lisp code. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 19 12:22:57 2022 Received: (at 53910) by debbugs.gnu.org; 19 Feb 2022 17:22:57 +0000 Received: from localhost ([127.0.0.1]:58667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLTRd-00037F-9u for submit@debbugs.gnu.org; Sat, 19 Feb 2022 12:22:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLTRY-000370-RM for 53910@debbugs.gnu.org; Sat, 19 Feb 2022 12:22:52 -0500 Received: from [2001:470:142:3::e] (port=36948 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLTRS-00045a-4r; Sat, 19 Feb 2022 12:22:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j8hrMD+z63z5KYcU3Nx+zUatA/pgzr+P3zJYXeRw7sc=; b=LVarGcz0taVT /Q8Qors7jPed17B+loifK6iztH3U0pQOqny7saPHLgqdZhF3ZJc/sm1IGazXUIHbopnlFwDV/uM+D TFemk1EwhHBoFRDdxZyRHKVt4Z1u0lxNQ1yEIBe+yNujR4nfDh8ehJ2cjjlpN9hmo0Ck+HgIH2/uG zjeUAPzVDbmb7WypoUJ6BXlRumn7ZE2lOZaSkow10ujB9xpiz9zw/xUhVpWHKVEVnvmoKOpGsvEax vo+LmEfMZ72pI+Qd4ii5R9R+xSXvoW3cfRK/ydAVRE5pMlM96mC6eCE3SHIA4KQjj+HsxkYa46X/f j5O4J5UtZ6UCu+XgnO32hg==; Received: from [87.69.77.57] (port=3489 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLTRQ-0005Rx-7f; Sat, 19 Feb 2022 12:22:41 -0500 Date: Sat, 19 Feb 2022 19:22:36 +0200 Message-Id: <83y226ydnn.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <54befa08-3bce-1d86-4e8b-e3cc4246da0b@gmx.at> (message from martin rudalics on Sat, 19 Feb 2022 18:07:03 +0100) Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> <83a6enyrdh.fsf@gnu.org> <54befa08-3bce-1d86-4e8b-e3cc4246da0b@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53910 Cc: 53910@debbugs.gnu.org, larsi@gnus.org, spacibba@aol.com, monnier@iro.umontreal.ca, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 19 Feb 2022 18:07:03 +0100 > Cc: juri@linkov.net, monnier@iro.umontreal.ca, larsi@gnus.org, > spacibba@aol.com, 53910@debbugs.gnu.org > From: martin rudalics > > > What exactly do you mean by "interactive use only"? Several commands > > invoke bury-buffer as part of their job -- or do you consider that to > > be "interactive use" as well? > > No. Consider the following two forms: > > (defun foo (&optional buffer) > (interactive) > (let ((buffer (window-normalize-buffer buffer))) > (if (or (and (window-next-sibling) > (eq (window-buffer (window-next-sibling)) buffer)) > (and (window-prev-sibling) > (eq (window-buffer (window-prev-sibling)) buffer))) > (bury-buffer buffer) > (kill-buffer buffer)))) > > (defun foo (&optional buffer) > (interactive) > (if (let ((buffer (window-normalize-buffer buffer))) > (or (and (window-next-sibling) > (eq (window-buffer (window-next-sibling)) buffer)) > (and (window-prev-sibling) > (eq (window-buffer (window-prev-sibling)) buffer)))) > (bury-buffer buffer) > (kill-buffer buffer))) > > If, after C-x 2, I do M-x foo, the first will leave the windows' buffers > unchanged while the second will show another buffer in the selected > window. So my conclusion is to never use 'bury-buffer' in Lisp code. That bury-buffer can be mis-used or abused doesn't mean it should not be used correctly, especially since we do that in many places. Moreover, bury-buffer does little besides bury-buffer-internal, so I still don't understand the emotional reaction. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 20 04:15:02 2022 Received: (at 53910) by debbugs.gnu.org; 20 Feb 2022 09:15:02 +0000 Received: from localhost ([127.0.0.1]:59342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLiJ3-0006VU-PQ for submit@debbugs.gnu.org; Sun, 20 Feb 2022 04:15:02 -0500 Received: from mout.gmx.net ([212.227.17.22]:38503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLiJ2-0006V5-Eq for 53910@debbugs.gnu.org; Sun, 20 Feb 2022 04:15:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1645348485; bh=ZbPH8Z9Gpw90z9X8pxYACFktfWy+MDD468NEhbnGqn8=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=aO6mUKs4YjSueN3T6iNi/SIBarkISoYwYKuXlhYCKbhqux+KWbIf/ICXZ5a8pL7UV V2nKtCq4ZWQxLOenGrfEUGjKI6DBIkgDyRWtSkEgKxDx83tcLPt1HB6r9uhl/Wnxvh gT/aCyyXiVKYCJTvZqfEnoTU1ZlsebgXA9dKa208= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([213.142.96.4]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7zFj-1oGtL42H7D-014yEx; Sun, 20 Feb 2022 10:14:45 +0100 Message-ID: Date: Sun, 20 Feb 2022 10:14:43 +0100 MIME-Version: 1.0 Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Content-Language: en-US To: Stefan Monnier References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> From: martin rudalics In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:I/w/1wMsm6Ffa5DXqtsb4K2TVBgnNkq4E155PWZGtgPImVSTaS8 R8D87leoGVcaFojKwsejBXbWzCn5bhEtZFHWnBmbtaiFTtW1o/T+ESb1im9k7iKlc/8B/N5 jJMejYAxAu3JCxXRd7LBA0qG71jBESsVADA7oXolV5HjATzxMYtVIenMjOBZ+0iZaXYT4Dl Tpsxm0Q84gihhPLiUElkA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:u98IK5YPDWQ=:jYCJPSrzjF34Uk70U9JBwM gy1+VS2wFG7jMAAY/9sQ8gXWPH806h+Vsffk5Ix3oyksd9XqemHqKNbjRNrO/o1ugRowARJGC xh5erP231ckK7Idbqbl3OrRswYuZ+oeRayZ3IrUkJIAym4RO8wC0TH5M4m9oAgpP5npbQffXs 60vDkz3tfk+TlE9+vqGmoxO8PbltG/VqF4wH2KozkQar043qG5YATZG4S0Ob2zjWPU/9gKIRJ chCgzV6y115DU/TP9dlSsqCwv3vQmQHe8Q5fN+KXCJSPIIdPemo8SnNcelIw4o9pkiVKppqgy S/JcDgym5gyqahGZrlhGPtv7f7KwCgriLJRKfuRc4bo7INmVZd2KDz7y8w3SWNY7sQ9Rx85HI uKak7AAQcjtDJCOEuufsXvr2Lm1SjSTMfLqlcs8CfdLraCbiNaYA2WW0b/xVwfySlJmjxF8vH 3Q2XYMwl65hh04+oXUcS0a0LBicb7IdpWXUiqokxjZRrzf9Azdc9D5QOAvXUnCcpIrZtFrI04 upQ0k952eitT1t60LNjk+rDWQi1C7UutAS4wTGfTX00F9RSIhjzHjD5GDR0WgNW1mC4qsVgHk 9W6BiqX7gqel7qdXRQWbyXmDGnfBchboW7xsVwGRMpJjwfSBQrSx1j1sTpN2NAA7pOugngRQZ UzZWiTZGuZHlTYqt3Sh4vMh8+cTTnA+5L22rlUCh3fR89/wZ4ngJfP8cvvWEzbNtRc6U/R9IT HwjPqmH/ov9SnXwXeKxFd+DDnTHQd+VTlDCFSEAoPm0DbH64HUxW5trnK/wiwjedo6WNp3Pzl X/q8NQonhCgzOwoZuFRQBIC/SPvdRykV2HtLTSJF05CK90Gt2nTK9c7wK7MyZpnQYqjFdCX4Z 9EMkjjQGYLS+TbSkk54Zha07oS62PNzUGIV6x/rpj6COSJtv1juBmnv2h3Jkk2JALFt2y+WFF MqIs0M4CwGpDWdjhvw3uZNslAi367N1CLouoc1ygWjYXXakruTMhEou04uwYIaoEjPk9M1hjQ nsO5IsgOaDCxXxNtIi44bPMWiLBFFrFFnPw2idF69AtUDulFWg3CBQlmdfOBLuUra9Ftl9YFz gicAX7ygkH4fZ0= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: "53910@debbugs.gnu.org" <53910@debbugs.gnu.org>, Lars Ingebrigtsen , Ergus , Drew Adams , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I think I understand why you say that but the interactive spec only > allows passing nil as argument, so maybe calling `bury-buffer` with > a nil argument should not be done from Elisp, but if calling > `bury-buffer` *in general* should not be done for Elisp, then we can > simplify the docstring ;-) 'bury-buffer' violates referential transparency in the sense that it does not allow allow a caller to substitute nil for (current-buffer) and vice versa without also changing its semantics. This is against what all other functions with an optional BUFFER-OR-NAME argument do and can only lead to confusion. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 20 04:17:12 2022 Received: (at 53910) by debbugs.gnu.org; 20 Feb 2022 09:17:12 +0000 Received: from localhost ([127.0.0.1]:59346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLiLA-0006ZX-9d for submit@debbugs.gnu.org; Sun, 20 Feb 2022 04:17:12 -0500 Received: from mout.gmx.net ([212.227.17.20]:46017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLiL8-0006ZH-3b for 53910@debbugs.gnu.org; Sun, 20 Feb 2022 04:17:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1645348618; bh=4CyY2QAxsRQyKYH4uVCh9Xocr4THw9YQMuqC/Q/6uwk=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Z5e7Y2bQw3zciHJ0sCOdtlyGqCNJDcLBUv0r1MopCElfhMtxj8bl0pKPl3lwBPJXB kvdbiti996Wo2h1wQUGssnIGQobEGKfPcUBpFjM1ug2nAzJldaAmtR/oxEvOKwHBzg Jf7tkOLaovAFmQFX3eJrV+LxRYuepoglARHp7cXE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([213.142.96.4]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M5fIQ-1nIzJY2Avq-007Fy0; Sun, 20 Feb 2022 10:16:58 +0100 Message-ID: <70c9a41a-4205-bc13-48c9-86dce0d2a4e9@gmx.at> Date: Sun, 20 Feb 2022 10:16:57 +0100 MIME-Version: 1.0 Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Content-Language: en-US To: Eli Zaretskii References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> <83a6enyrdh.fsf@gnu.org> <54befa08-3bce-1d86-4e8b-e3cc4246da0b@gmx.at> <83y226ydnn.fsf@gnu.org> From: martin rudalics In-Reply-To: <83y226ydnn.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:eOx9Z4aV9C+YrRoV/Qump0RPjztWI94QFUjg8tBFuqgunpa7lLB puiqqoklkWx4u3/H1yZIJKhxWyo5at5kfE86bh+6U/6o+Yap2zJiDLO93o0fMGfGdMkr3Xj OH+3Q6k40ML7qQWnAcSAlpoBtpXtqXp/O7VsJAkijYLPXIDlEzKna9Xyc6ReLOMUxETJdH5 P7HzRvfqgPhqxMakOD7cQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:yGHBhycM204=:OUQ7uKJEjMhHinbTFKj2ea PwPsbBelvBr1mcYC2Pnl3HLf5Q0UKH6pX7SJGuNoIRjAf2LnkMhiuk3j/KvEXnJ+OYGomEWNV eILwBsSanymLwn+7qejXrx1TJ/6mSGsXvFdn4RU3wz4MV71CBb6cMDFpeZD6ZNpWzv7ihQqBL XqWuuuc7KhdrLt8VhifBfyIS75nVuUl+71Ksp5FV75M3mSapYRkQlf07GdkTnkuGx/E4CwQK4 XcnSjCLxpACG58vrK6jF5bDBsBk1c0lWUmyDMc9x6JZsrmixsN//AZdJ1VXuddYlr5dWcVfQ1 qArD1SEl5FOkdyJDvcrcE5duvzX51EufV8zwT3d0YIyprEONVMC0ApzO8eFm5RZ0KirfI3bvA rMTLDIJdjem7xHAKQjD/2hlSgVy01CdPjD7LB2xlSEMKrFvElD/rEkJcRZQ7I5tF19EZo02Sp UQJL+zpabxzSdvv+AcdX6SFEiAySw0EIdmu/I42tN12Du7UUAWWvHnc+vyvnoNRnmq2ty8ozq sW0Uk7OPUn+nd2os2ps96iJJPUCx4k5jmDZ5HA1xMqTBC8nqpN9yIQ8gIx2NnNcrGbGA3dMQZ f5VLN4W1AX5jmdB7/jurICMZ2XTD66sBgOcyefdEe1NwVLsg5ON3mFwHFilZlO3cFt0ITYOMk SP2tlfobhy5JMaWi2wqeyqGJHxOzjgnqeS539QpQgQu9cKsLo7aSaWPpoc45RirQp7BmQkvdz w2lU4MLZ7TV0Nrm4jnvWXvdFjtexT4Aj59pnz4VluXcCLnF/ziNNivPOOGVi6asTWP/GVJmxe /x99o1gwP2wNZw9nkDErbI0eC0wd7tRJRLUKIsl8bS42Xc9ADT9m6FcqgdNAZEnfWvNoFV5vC n4wc0nZLoqkAsKXifng4353BXgDGPfea4X8D7YkV47G9NVt6ju+jIOKzRkBNTOaItzw1rL/rt /kdXZHvEbs1NGB4kAvUTKbCZ6DZeYxxTKAY8soNjhgRiRqQ94h/6g4L9D3GxtnYNHQAEP65Zk r1cR+83pY+YBVErJ2bfRmCld8pcF2EkruhqguRVZUqJlOz0MMF7HIHRom1zlbE+JbkSU9j+1A QabS9FrRy0Jl8E= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: 53910@debbugs.gnu.org, larsi@gnus.org, spacibba@aol.com, monnier@iro.umontreal.ca, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > That bury-buffer can be mis-used or abused Do you mean that the functions I posted mis-use or abuse 'bury-buffer'? > doesn't mean it should not > be used correctly, What distinguishes a "correct use" of 'bury-buffer' from an "incorrect" one in your opinion? > especially since we do that in many places. Many of those assign 'bury-buffer' to a key (which is perfectly valid) or call it with an explicit BUFFER-OR-NAME argument (which is also valid but could avoid the extra indirection by calling 'bury-buffer-internal' right away). Problematic are calls without arguments, especially when they are wrapped in 'with-selected-window' like in 'tab-line-close-tab'. > Moreover, bury-buffer does little besides bury-buffer-internal, so I > still don't understand the emotional reaction. What's emotional about a recommendation? My I recommend against calling 'bury-buffer' in Lisp code: has to be seen in the context of Juri's Maybe (kill-buffer (window-buffer )) has the same effect when used in any window, but (bury-buffer (window-buffer )) definitely should be called in the required window, because `bury-buffer` uses `nil` for the WINDOW args, e.g.: (set-window-dedicated-p nil nil) (switch-to-prev-buffer nil 'bury) martin From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 20 09:42:26 2022 Received: (at 53910) by debbugs.gnu.org; 20 Feb 2022 14:42:27 +0000 Received: from localhost ([127.0.0.1]:59768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLnPu-00080z-Mr for submit@debbugs.gnu.org; Sun, 20 Feb 2022 09:42:26 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLnPs-00080l-QZ for 53910@debbugs.gnu.org; Sun, 20 Feb 2022 09:42:25 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5217080539; Sun, 20 Feb 2022 09:42:19 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 06CE680272; Sun, 20 Feb 2022 09:42:18 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1645368138; bh=AIqgJ+m5rrHbnKPB9JlPmG0kmSTJc1cnjlDCVsf71Kw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=h9JTXtuVNmzUA+CieSbi7TBbjtWsTdtO2eNcojADnHg1wW6pWObmaQdnISIID4zJr Rb4d5d+V2DfhmJZ9ZdaX8I6bAJbiSDunFzOb6mDTFy/VzjKxh1hlTIz5jUrULXsTD3 xBk8yXD4LK2jZ2n8xru45Ap6052llJ/LinFdfetDI2Edvafq8qPedj3sr5wC89KN2C 7lia0ZV4/yw5V8tNUx3dGz1dlCzV7Fc+EE56pvB+K62j2g/9CzXV2bMH4f5hH+CN3L KUbKLVrpkL1T64cK+epm7oE78tcB8MAN4MDAAoHRpNDP+MfBuOTYm5PTeFSxvEXkJG STGRDjYfRqwWg== Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B9A2E1204A0; Sun, 20 Feb 2022 09:42:17 -0500 (EST) From: Stefan Monnier To: martin rudalics Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Message-ID: References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> Date: Sun, 20 Feb 2022 09:42:17 -0500 In-Reply-To: (martin rudalics's message of "Sun, 20 Feb 2022 10:14:43 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53910 Cc: "53910@debbugs.gnu.org" <53910@debbugs.gnu.org>, Lars Ingebrigtsen , Ergus , Drew Adams , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > 'bury-buffer' violates referential transparency in the sense that it > does not allow allow a caller to substitute nil for (current-buffer) and > vice versa without also changing its semantics. This is against what > all other functions with an optional BUFFER-OR-NAME argument do and can > only lead to confusion. Yes, its API is weird. We should probably split it into two separate functions. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 20 13:59:10 2022 Received: (at 53910) by debbugs.gnu.org; 20 Feb 2022 18:59:10 +0000 Received: from localhost ([127.0.0.1]:33724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLrQH-0004oT-Bm for submit@debbugs.gnu.org; Sun, 20 Feb 2022 13:59:09 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLrQB-0004nX-MK for 53910@debbugs.gnu.org; Sun, 20 Feb 2022 13:59:04 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id C5739C0008; Sun, 20 Feb 2022 18:58:50 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Organization: LINKOV.NET References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> <83a6enyrdh.fsf@gnu.org> <54befa08-3bce-1d86-4e8b-e3cc4246da0b@gmx.at> <83y226ydnn.fsf@gnu.org> <70c9a41a-4205-bc13-48c9-86dce0d2a4e9@gmx.at> Date: Sun, 20 Feb 2022 20:44:04 +0200 In-Reply-To: <70c9a41a-4205-bc13-48c9-86dce0d2a4e9@gmx.at> (martin rudalics's message of "Sun, 20 Feb 2022 10:16:57 +0100") Message-ID: <86k0dpfnvj.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: 53910@debbugs.gnu.org, larsi@gnus.org, Eli Zaretskii , monnier@iro.umontreal.ca, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Many of those assign 'bury-buffer' to a key (which is perfectly valid) > or call it with an explicit BUFFER-OR-NAME argument (which is also valid > but could avoid the extra indirection by calling 'bury-buffer-internal' > right away). Problematic are calls without arguments, especially when > they are wrapped in 'with-selected-window' like in 'tab-line-close-tab'. Then 'bury-buffer' could have a new optional argument WINDOW, thus changing this line: (not (eq buffer (window-buffer))) to: (not (eq buffer (window-buffer window))) and using WINDOW in other places in 'bury-buffer' too. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 20 13:59:19 2022 Received: (at 53910) by debbugs.gnu.org; 20 Feb 2022 18:59:20 +0000 Received: from localhost ([127.0.0.1]:33729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLrQR-0004p0-8g for submit@debbugs.gnu.org; Sun, 20 Feb 2022 13:59:19 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:50859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLrQL-0004oL-8E for 53910@debbugs.gnu.org; Sun, 20 Feb 2022 13:59:13 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 52036FF803; Sun, 20 Feb 2022 18:58:59 +0000 (UTC) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Organization: LINKOV.NET References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <86fsogocwx.fsf@mail.linkov.net> Date: Sun, 20 Feb 2022 20:56:15 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 18 Feb 2022 03:32:40 -0500") Message-ID: <86ley5e59s.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: martin rudalics , Lars Ingebrigtsen , Ergus , Drew Adams , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> If `context-menu-mode` is intended to work only on displayed buffers, >> is it really important to ensure that it also doesn't fail on >> non-window buffers? > > Yes, a :filter function in a keymap should not make such assumptions > (nor have side-effects, as a general rule). I can't find a way to prevent :filter from executing on context menus in help buffers, so I just removed `help-buffer-under-preparation` from :filter. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 21 04:08:13 2022 Received: (at 53910) by debbugs.gnu.org; 21 Feb 2022 09:08:13 +0000 Received: from localhost ([127.0.0.1]:35015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nM4fp-0000yX-Dl for submit@debbugs.gnu.org; Mon, 21 Feb 2022 04:08:13 -0500 Received: from mout.gmx.net ([212.227.17.22]:57799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nM4fi-0000y7-IZ for 53910@debbugs.gnu.org; Mon, 21 Feb 2022 04:08:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1645434462; bh=0pmmEdGc22YlklktZ18NHTAXkPPfnInQJuAqvOOgaxY=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=i/Tjf//8obfOqW/S0f4Tixmk6wYbrg9FZVP4U6fR+L1l8QbLlLFVR9JfjAlP9jLXm mT3oEshxE4vcumCBIoDGQflxp2LzLNw2ksZSP8doMcbqTXFBNmQ5naHSzT88s5Hok5 5kcBa5vdb64OP0tZxi4cITzsGTm6i4yZa4pEs/s0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.226]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Ma20q-1nj7If3R8m-00W1ZC; Mon, 21 Feb 2022 10:07:41 +0100 Message-ID: <9cfb3de2-e73c-4f96-fe46-94dbc66386de@gmx.at> Date: Mon, 21 Feb 2022 10:07:39 +0100 MIME-Version: 1.0 Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Content-Language: en-US To: Juri Linkov References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> <83a6enyrdh.fsf@gnu.org> <54befa08-3bce-1d86-4e8b-e3cc4246da0b@gmx.at> <83y226ydnn.fsf@gnu.org> <70c9a41a-4205-bc13-48c9-86dce0d2a4e9@gmx.at> <86k0dpfnvj.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86k0dpfnvj.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:Dod3ubA4pu8PvqtPQZWJG90Y7tF5KHDO4vUVKvWKxfZNtdBtABl BUx91qenDCugPqqZ9PRUmA3h04byZonBUH/w2u2mIg5yFXSvwjLkJ3S3Dix16pFhShlLGJn 3Dhx9NUCRDpsYQfHU+8YlDwXiSZ4iA5CghT4+Ld2AEoeU3Zd2rgeugPg2fHS3634RyJ35M0 dUELJUv5TSOYXz2wu6W9A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ADMQKVBbdGc=:rAl2pLpRQeHFVap2KOWyfS Sm4gg2IFKn1K9CpNhX54CEHXieRheegLHGzx54hiYwOpCOUHL9pVOKoke8+DT0xiL5HJzh89Y QRxS9FVSrOrle7/Gvgh7N/bESHAR4lWC9XaHMI3NeprKTpSnRayzKxc/VibgKC4MwoFQ6b4Gz 4CC9cJzRXsFGijKPx84E/OglNP6BHTrOZJe/0GcWG7zFl3B8q5xztHc/UZuHluO4izb0bVJAW +QW32nB0l3n6a6+glpfaggvvVNfRU9OG9SlH9TkV+YvjzHp9OZe8XhyH8USepK6tGwFJ0vmX/ PFCFsp9FiXaRlcW0FKJQETDO8G/RhOA8a8840mkBf6WrEUx/+pHWbs5pw/AMbiCFdAr1jyVwf /Zu2jWFRUIzsPGjPftxWB48StQeVZUWxq6oWzyaGFy775jYCbWTgCskooVNBGK6tf1FjYKQns 5LnP6qQBhMMYxW6PmnOMjFZwTQ5l5VlTHUKUIs2Wf6VXR9iPXxQzS/dP3LG3aaG/Cb1Btc2de onnBCMwf9qFksmj5Oz5NmhSHKiivgW1AFW0SjIoaiwtS2VB+qb2rQllQCCNLFBg71S0FxtjaU c73P2deePnVA7zcGhIASN5zQNKEcp3TpcGOixUWY6jlLbZT0RZuBxhI8LwwGe4En6+WxeCbNK XSGiARgK6y2HIiyyxIQ01YlIn3M8LNJ1tjZopheGjE4b4N0xzaE0QV3Dmk+SYWW1Ukx/y7yrx 9Kgbx2cWsbNqh3kzKkp2R+OAPQrA+m6eOyxNBy5XblANt+KypFd6m2hdwKH8biCfE2pQ+tYzN 9W+ksBvD1S+E3GvYmOFVZtafDm+JpdUK6174LUJIM4+exEUONUMQordZf25GuO1fJVlm7NgKY Yp6KLxjxHhs9BCrZSTff26Qru0/P3QVD0Sbk2DyGkLOuaTPxy7ZGMUf+WCVMcyYin5dFdFz0z Vv5OcvMHGC9DyWqUNWXbf8AveQUXLpAETL5WTK4fmN5pRrLq/qLJvuQbOUwtTtFFV0wx5C3lu 21PxoK4A1L7duu6kyhWqISStAE570k/uHC6iG5qlh0lFsHzI7Qi9gCQpm1876ZwIJ9veWSOYS WpUJUePVGy4HVM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: 53910@debbugs.gnu.org, larsi@gnus.org, Eli Zaretskii , monnier@iro.umontreal.ca, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Then 'bury-buffer' could have a new optional argument WINDOW, > thus changing this line: > > (not (eq buffer (window-buffer))) > > to: > > (not (eq buffer (window-buffer window))) > > and using WINDOW in other places in 'bury-buffer' too. Even without such an argument 'bury-buffer' is complex enough so I doubt that many people will understand what it does in all its consequences. Can you tell how burying a buffer affects the next C-x sequence you type? martin From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 22 12:27:57 2022 Received: (at 53910) by debbugs.gnu.org; 22 Feb 2022 17:27:57 +0000 Received: from localhost ([127.0.0.1]:42539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMYxB-0003sr-Gv for submit@debbugs.gnu.org; Tue, 22 Feb 2022 12:27:57 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:43805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMYx7-0003sL-Qa for 53910@debbugs.gnu.org; Tue, 22 Feb 2022 12:27:54 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 36D5C1C0002; Tue, 22 Feb 2022 17:27:44 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Organization: LINKOV.NET References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> <83a6enyrdh.fsf@gnu.org> <54befa08-3bce-1d86-4e8b-e3cc4246da0b@gmx.at> <83y226ydnn.fsf@gnu.org> <70c9a41a-4205-bc13-48c9-86dce0d2a4e9@gmx.at> <86k0dpfnvj.fsf@mail.linkov.net> <9cfb3de2-e73c-4f96-fe46-94dbc66386de@gmx.at> Date: Tue, 22 Feb 2022 19:10:29 +0200 In-Reply-To: <9cfb3de2-e73c-4f96-fe46-94dbc66386de@gmx.at> (martin rudalics's message of "Mon, 21 Feb 2022 10:07:39 +0100") Message-ID: <86czjesyui.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: 53910@debbugs.gnu.org, larsi@gnus.org, Eli Zaretskii , monnier@iro.umontreal.ca, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Can you tell how burying a buffer affects the next C-x sequence > you type? 'bury-buffer' should remove the buffer from the C-x sequence of previous buffers. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 23 04:29:36 2022 Received: (at 53910) by debbugs.gnu.org; 23 Feb 2022 09:29:36 +0000 Received: from localhost ([127.0.0.1]:43810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMnxo-0005dz-JB for submit@debbugs.gnu.org; Wed, 23 Feb 2022 04:29:36 -0500 Received: from mout.gmx.net ([212.227.17.20]:40227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMnxk-0005dk-Ey for 53910@debbugs.gnu.org; Wed, 23 Feb 2022 04:29:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1645608560; bh=kz1aB0zJ3hnxiWB6oDuTJQSd9TOWPWWPY5dl7zel9vU=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=gN40RIpBk85G3Yw3XDS2arnOpTZKtyMlc+L8mnQb2Y7FKPGsp4k4jGe7zP1BVtQt3 jkJzwcQ/VWj5h+FDGB4NyZY9EJr8ME2FKKUOeyRzpibtleGWyPL7TmN2Ogx7BNMNy2 gOkNFF/dgFoV5L40biAT1EbaayUeP/E2iPmwcIgA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([213.142.97.235]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N1OXT-1oOcqh2Aqx-012tOj; Wed, 23 Feb 2022 10:29:20 +0100 Message-ID: <83b84854-8aec-ed45-3313-06a240f89ad0@gmx.at> Date: Wed, 23 Feb 2022 10:29:18 +0100 MIME-Version: 1.0 Subject: Re: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Content-Language: en-US To: Juri Linkov References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <41b85df6-305f-fe6b-f575-0ff9db616eb9@gmx.at> <83a6enyrdh.fsf@gnu.org> <54befa08-3bce-1d86-4e8b-e3cc4246da0b@gmx.at> <83y226ydnn.fsf@gnu.org> <70c9a41a-4205-bc13-48c9-86dce0d2a4e9@gmx.at> <86k0dpfnvj.fsf@mail.linkov.net> <9cfb3de2-e73c-4f96-fe46-94dbc66386de@gmx.at> <86czjesyui.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86czjesyui.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:2GNo2bYKIyvKWVsj2S81QOHGdICY3/BdnXXjKtn/9dyXu0eKodK Z1C9+0qn+mGpVGAbQnXfqeb+8sEtBaIBYLupiYq7JNxHLVdZSxnO6wAmjApN/LL/YEAVx0q ixbZbA4aqTgBrya+asNh/q+dGYh9SW6hSntmhFhgjx+PAXjGdguSefGumz4NVWIIlXcSNKU V33VB6TPqWqQ/8myrLKMQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:1u9j4spF1SQ=:RwF+CirBJkt0pHWecXj3J0 yCpobr/37fDiLv2Y+z767ur/LB++mlDfyVCnFZ6uouCX0+QMjzQFMPfCHePElGkSwRb1h3tzu L3Na99MESb8K9dAZ1BMMhUbu2gY++VRnQriHRh1KOK2hNKAR30TvnLBz6DRPdSPL/8/w4XE7o LGzy7VEvzEYZdSRqqscM9Lcx8P0B2B8olU4VDn/APNQMSp06lyTnjtDtgiqCEr3pYNBmCxLGf auvXzJZrKSav1LkCepJGhWzDQXc4fgCX1++GHjOrlulvamDRgiJXvluFX5BBxZLsjwze5rKRJ JfnNFcnoiCWdWs7OCJjjl3S4hTLfb/dJSnnP/S99mWTLHQci6QIeGx80Erl8MCTK7tzN6reQg TIow9mh5EeZDoDhwpCDT8DhrckyHD+zsOPpIjZYLxUCZkdErEQGLC2f7fPwNuE0ZEKkqFqcYH PIcO3acJTp+lDHrXO+U5LvhzPr9+DuaMcFJD0j4PFgn0S/XWXvkCYzX0Bsj1syIogIa+hCGXS 01wIbmHjyLA6OKcapwBFvC5OLqXKuJ4urbBDGshXq7IdlnyxWd3SzVj9Ip5cfZ2O89tCo73M3 +98OqTONlI7urTrt6kCyc8FTPNy8SqgL1wOFaYpfMhD5ufLPZsJv+2dHsUzoTKti/8D8E54Qr KteBTcvCAhoM8cTe2L2x+3wY3PzhXowaH14jvGv1N4JaZjYKX9rf4QqitazjBjJLCEHu55Hwg jgvFYpmz7MV5hYxvF9s1YFRMPTE7SxUg7ii+pvBxJgs/9Lv+VU74s0BegjeLA9GArh5i9ieHi XkpbzCgCFiA4qHeRPwubWWCscK/oy0Qs/IuEEM4vmDBDW4Uc6XOxF8GLY+pkmwbTkiMiGn8Eq EjInplMLBv5o8204gB1DcwQWUm16gmq95IMxX/Xq2AJ/fsfKYxVZJlQC3DNvrPrCl9i6xlpnz PTifeWL05fjyTKNzPrP8PhgbCkgZJqccShqul7Ze+b4IwzxCAVAqjaS1vmCfsFUprsiK2tWdV sxEXyvBgkVCDZTCfm6r4mQhcJ3+84M4r69l7HJpq/xW5gIGZX0v32gUcf+SgTR81r9XtvL49P IKF8xW3FJ/tDRA= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53910 Cc: 53910@debbugs.gnu.org, larsi@gnus.org, Eli Zaretskii , monnier@iro.umontreal.ca, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Can you tell how burying a buffer affects the next C-x sequence >> you type? > > 'bury-buffer' should remove the buffer from the C-x sequence > of previous buffers. Completely? And add it to the sequence of next buffers? We could provide an option for that. Personally, I'd profoundly dislike that some application could remove a buffer from a window's list of previous buffers by burying it. And then we would have to decide whether 'unbury-buffer' should switch to the last buffer in the selected window's buffer list or to the last buffer in the selected frame's buffer list. martin From unknown Mon Aug 18 14:16:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 23 Mar 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator