From unknown Sun Jun 15 08:30:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53897 <53897@debbugs.gnu.org> To: bug#53897 <53897@debbugs.gnu.org> Subject: Status: 28.0.91; regression: rcirc overwrites completion-cycle-threshold Reply-To: bug#53897 <53897@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:30:40 +0000 retitle 53897 28.0.91; regression: rcirc overwrites completion-cycle-thresh= old reassign 53897 emacs submitter 53897 Daniel Mendler severity 53897 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 09 06:10:36 2022 Received: (at submit) by debbugs.gnu.org; 9 Feb 2022 11:10:36 +0000 Received: from localhost ([127.0.0.1]:50048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHkrr-0000zl-TA for submit@debbugs.gnu.org; Wed, 09 Feb 2022 06:10:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:34518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHkrq-0000zd-D2 for submit@debbugs.gnu.org; Wed, 09 Feb 2022 06:10:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHkrp-0000Q7-De for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 06:10:34 -0500 Received: from [2a01:4f8:121:346::180] (port=52861 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHkrm-0007Q6-L7 for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 06:10:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:Subject:From:Cc:To :MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MfK+jS29YpbQcPwGMYUM2QrJuwMMA0xBjsk6QeZUDSM=; b=oGy9ZfatKxpgmJfYNYluaDr/si 7pfAsDn4HilaGTN7+Lx0hxMv2mvITHnXptyQ41Phzm29A7JQ+8WB9Zm6SVacSC9uz8v6Qc1XiiDWf 9EwEeHHWfdRNjpG1/osu5ym3gPmGBDwrp9NDH4BrlpHZbgQc0Efz18zVcs0cdEubTc8Y=; Message-ID: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> Date: Wed, 9 Feb 2022 12:10:09 +0100 MIME-Version: 1.0 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Daniel Mendler Subject: 28.0.91; regression: rcirc overwrites completion-cycle-threshold Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f8:121:346::180 (failed) Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) rcirc-mode started to set `completion-cycle-threshold' to t. This setting is intrusive and interferes with user completion setups. It is better left to the user to tweak this setting in their user configuration, since users may want to configure completions coherently across the different modes in Emacs. Note that rcirc.el is the only file/mode which sets `completion-cycle-threshold'. Therefore it is better to revert the change which added this setting. In GNU Emacs 28.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2022-02-09 built on projects Repository revision: 82e74e4559b8becd44f3e7ac0134e2baddd69921 Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 09 07:55:10 2022 Received: (at submit) by debbugs.gnu.org; 9 Feb 2022 12:55:11 +0000 Received: from localhost ([127.0.0.1]:50126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHmV4-0006Ij-Gi for submit@debbugs.gnu.org; Wed, 09 Feb 2022 07:55:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:47564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHmV3-0006IZ-1e for submit@debbugs.gnu.org; Wed, 09 Feb 2022 07:55:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHmUy-0004p7-VY for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 07:55:08 -0500 Received: from mout02.posteo.de ([185.67.36.66]:46887) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHmUw-0002Q3-4S for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 07:55:04 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id F0577240104 for ; Wed, 9 Feb 2022 13:54:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1644411300; bh=R+8rHRTSd8vYK335kF/Hw+Y/S+qDhCgbk94Cmf+Hh0s=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=mY5ZUWSdNyl15v98QC1ugZoEDe2vUNYHQ2waw36E6FwjoNH4xLDcd/IoJEcCEl0To dG9Jra0PAfl7QimMaxnXQ86If9iOLJh3AJB1MDwGJVl5nIteIdVg/PD4lR8/qgzAKo 9AzeCWHS++Q4ZGLIzkH19d8zrBXS7P+HIqlzFrorB4Pc37XPLlQx1jRsnMbFjK50Mj JTIlQwYtA7jcrjFfslgUL26dr1pbSCsIgMn+ILC8vpm2zwnu8vievFlwpiox+5OVr4 yaPAJP5KbCnCkzmgoo3dHvI6Eho3e0TamzJ3mfcUh8md46iuD5KQj1OI3KHD4zQUMw 27mEQNs4Qb7GQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Jv0GB70Z7z6tpc; Wed, 9 Feb 2022 13:54:58 +0100 (CET) From: Philip Kaludercic To: Daniel Mendler Subject: Re: 28.0.91; regression: rcirc overwrites completion-cycle-threshold References: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Wed, 09 Feb 2022 12:54:57 +0000 In-Reply-To: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> (Daniel Mendler's message of "Wed, 9 Feb 2022 12:10:09 +0100") Message-ID: <87v8xo2o9q.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Daniel Mendler writes: > rcirc-mode started to set `completion-cycle-threshold' to t. This > setting is intrusive and interferes with user completion setups. It is > better left to the user to tweak this setting in their user > configuration, since users may want to configure completions coherently > across the different modes in Emacs. Note that rcirc.el is the only > file/mode which sets `completion-cycle-threshold'. Therefore it is > better to revert the change which added this setting. The change that introduced this was that the custom cycling implementation was replaced with one based on completion-at-point (0b367ec), mainly to simplify the code. The reason `completion-cycle-threshold' is set is to preserve the appearance of the previous behaviour, as a complete reversion to completion-at-point seemed like too much of a change. I could imagine introducing a user option to decide what you want to use. My inclination would be to set it to "cycle by default", but it doesn't need that way. Perhaps we could test non-cycling (regular capf) for a while, and see if there are any complaints or other feedback? > In GNU Emacs 28.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, > cairo version 1.16.0) > of 2022-02-09 built on projects > Repository revision: 82e74e4559b8becd44f3e7ac0134e2baddd69921 > Repository branch: emacs-28 > Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 > System Description: Debian GNU/Linux 10 (buster) -- Philip Kaludercic From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 09 09:18:55 2022 Received: (at 53897) by debbugs.gnu.org; 9 Feb 2022 14:18:55 +0000 Received: from localhost ([127.0.0.1]:50284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHno7-0000AU-LC for submit@debbugs.gnu.org; Wed, 09 Feb 2022 09:18:55 -0500 Received: from server.qxqx.de ([178.63.65.180]:37945 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHno5-0000A5-7y for 53897@debbugs.gnu.org; Wed, 09 Feb 2022 09:18:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BbawT1e/DKU57VtGuvq7K767i7l17Ie/PwjqJ1ag0Lc=; b=P+LtYqBkVaSwVGriZCI3TporKs emq5IODaZDFZWHEHRAl9rGR0otFCL4cKRw/0BUQEhC2iKFnBaWnyto8x+eFgQdW10uPPqr7M8b9vT DYTgwaWaC0oBA0Bjc3cy31eDp5Jbj9txuXEPJ61J53eltWmnBdWPZAjNsKK+Z+G6y77Y=; Message-ID: Date: Wed, 9 Feb 2022 15:18:45 +0100 MIME-Version: 1.0 Subject: Re: 28.0.91; regression: rcirc overwrites completion-cycle-threshold Content-Language: en-US To: Philip Kaludercic References: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> <87v8xo2o9q.fsf@posteo.net> From: Daniel Mendler In-Reply-To: <87v8xo2o9q.fsf@posteo.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53897 Cc: 53897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The change that introduced this was that the custom cycling > implementation was replaced with one based on completion-at-point > (0b367ec), mainly to simplify the code. The reason > `completion-cycle-threshold' is set is to preserve the appearance of the > previous behaviour, as a complete reversion to completion-at-point > seemed like too much of a change. I agree with your change to remove rcirc-complete. I greatly appreciate the simplicity of rcirc and it is good that you try to make it even simpler! But rcirc-completion-at-point was already present as Capf on Emacs 27 and there `completion-at-point` didn't lead to cycling. I would not introduce a user configuration, it is easy enough to set completion-cycle-threshold in a hook. Furthermore there is the alternative to use completion-category-defaults to specify the threshold per completion category. You could add the override there. But personally I would avoid doing that. I usually prefer if packages avoid intrusive and opinionated settings and instead try to ensure consistency across Emacs. > I could imagine introducing a user option to decide what you want to > use. My inclination would be to set it to "cycle by default", but it > doesn't need that way. Perhaps we could test non-cycling (regular capf) > for a while, and see if there are any complaints or other feedback? Yes, I would go with normal Capf behavior, which is the usual behavior across all of Emacs. If a user wants to restore rcirc-complete, it seems easy enough to add this to a user configuration? (defun rcirc-complete () (interactive) (let ((completion-cycle-threshold t)) (completion-at-point))) Thanks! From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 13:15:55 2022 Received: (at 53897) by debbugs.gnu.org; 14 Feb 2022 18:15:56 +0000 Received: from localhost ([127.0.0.1]:42510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJftD-00026r-Kb for submit@debbugs.gnu.org; Mon, 14 Feb 2022 13:15:55 -0500 Received: from mout01.posteo.de ([185.67.36.65]:45709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJft9-00026b-4m for 53897@debbugs.gnu.org; Mon, 14 Feb 2022 13:15:55 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id F1449240028 for <53897@debbugs.gnu.org>; Mon, 14 Feb 2022 19:15:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1644862545; bh=oAk+dpufKlziDbK2ihpcsAI29SV5vSpvXIf65GqTeIE=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=R3rUk5mW5n18iT2aRFH9QdbkaJQnMulblNQVRJ/Nfvq7p0tiF0127VfoNh31FgvkV U7DwSPFJ7m82C+N+KvYtaMcnaPndI24X7GFG7STn8XmCwPY7uTTcfX7K0p6VnJ8RYE QMTPc42+FlKadTaxZgG6wMD7ntFcOMu6XDC7K7DUUcDfaOa4gwm4+UQPy4a5FKmMZS coc/lqP65jQLZ8dpbxVfW8gMzKF/RdyaAx3xojL+PbbU+lvSePAT6YD14GrY3O1u/A 8NVEwqP65LOKJ7oFW6jVZqV31W54gXsnoA/3ov8mCo/JzLo+w2zTKpyJyVPKWws6s1 7JD73ePE9gzYQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JyC7z210Fz6tmQ; Mon, 14 Feb 2022 19:15:42 +0100 (CET) From: Philip Kaludercic To: Daniel Mendler Subject: Re: bug#53897: 28.0.91; regression: rcirc overwrites completion-cycle-threshold References: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> <87v8xo2o9q.fsf@posteo.net> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Mon, 14 Feb 2022 18:15:42 +0000 In-Reply-To: (Daniel Mendler's message of "Wed, 9 Feb 2022 15:18:45 +0100") Message-ID: <87bkz9co1d.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53897 Cc: 53897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Daniel Mendler writes: >> The change that introduced this was that the custom cycling >> implementation was replaced with one based on completion-at-point >> (0b367ec), mainly to simplify the code. The reason >> `completion-cycle-threshold' is set is to preserve the appearance of the >> previous behaviour, as a complete reversion to completion-at-point >> seemed like too much of a change. > > I agree with your change to remove rcirc-complete. I greatly appreciate > the simplicity of rcirc and it is good that you try to make it even > simpler! But rcirc-completion-at-point was already present as Capf on > Emacs 27 and there `completion-at-point` didn't lead to cycling. I would > not introduce a user configuration, it is easy enough to set > completion-cycle-threshold in a hook. Hmm, ok, I get your point. My rationale is that rcirc-complete (bound to TAB) used to cycle, and that it was that behaviour that was supposed to be preserved. > Furthermore there is the alternative to use completion-category-defaults > to specify the threshold per completion category. You could add the > override there. But personally I would avoid doing that. I usually > prefer if packages avoid intrusive and opinionated settings and instead > try to ensure consistency across Emacs. I agree. >> I could imagine introducing a user option to decide what you want to >> use. My inclination would be to set it to "cycle by default", but it >> doesn't need that way. Perhaps we could test non-cycling (regular capf) >> for a while, and see if there are any complaints or other feedback? > > Yes, I would go with normal Capf behavior, which is the usual behavior > across all of Emacs. If a user wants to restore rcirc-complete, it seems > easy enough to add this to a user configuration? > > (defun rcirc-complete () > (interactive) > (let ((completion-cycle-threshold t)) > (completion-at-point))) Or, this could be added as rcirc-complete, binding TAB back to this new command and documenting that if you want to complete using the default CAPF, you should rebind it to completion-at-point? > Thanks! -- Philip Kaludercic From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 13:19:06 2022 Received: (at 53897) by debbugs.gnu.org; 14 Feb 2022 18:19:06 +0000 Received: from localhost ([127.0.0.1]:42519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJfwI-0002CQ-DC for submit@debbugs.gnu.org; Mon, 14 Feb 2022 13:19:06 -0500 Received: from server.qxqx.de ([178.63.65.180]:51337 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJfwE-0002Bp-EN for 53897@debbugs.gnu.org; Mon, 14 Feb 2022 13:19:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d0IMEyT/H6QDzU5caFjj8cepTF8S7nklvYsQRY4dTAQ=; b=v2wGFGPKYYQHe4Jjz4sIoMtu02 z9WIPdp7huxst4G9tcveFQBtqz9J795O6IA6RsGvJMaiOHBmDKUuzScyK1WDHdeaF/eXboK6LuiFp NBUieJ0oFvLmDzxJcORPCJ5+xrKYsoh42X4UMajboUeNcNCCaP0DvfGcBM7pNVAbJpSA=; Message-ID: <5525a90a-4613-cf73-a120-19862977d2d2@daniel-mendler.de> Date: Mon, 14 Feb 2022 19:18:53 +0100 MIME-Version: 1.0 Subject: Re: bug#53897: 28.0.91; regression: rcirc overwrites completion-cycle-threshold Content-Language: en-US To: Philip Kaludercic References: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> <87v8xo2o9q.fsf@posteo.net> <87bkz9co1d.fsf@posteo.net> From: Daniel Mendler In-Reply-To: <87bkz9co1d.fsf@posteo.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53897 Cc: 53897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>> I could imagine introducing a user option to decide what you want to >>> use. My inclination would be to set it to "cycle by default", but it >>> doesn't need that way. Perhaps we could test non-cycling (regular capf) >>> for a while, and see if there are any complaints or other feedback? >> >> Yes, I would go with normal Capf behavior, which is the usual behavior >> across all of Emacs. If a user wants to restore rcirc-complete, it seems >> easy enough to add this to a user configuration? >> >> (defun rcirc-complete () >> (interactive) >> (let ((completion-cycle-threshold t)) >> (completion-at-point))) > > Or, this could be added as rcirc-complete, binding TAB back to this new > command and documenting that if you want to complete using the default > CAPF, you should rebind it to completion-at-point? That's an option too. But then you will still keep the old cruft around. I would rather break backward compatibility here and document that binding `completion-cycle-threshold=t` will restore the old behavior. Most users will appreciate that a Capf is directly available, which is more capable than `rcirc-complete`! Daniel From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 13:34:07 2022 Received: (at 53897) by debbugs.gnu.org; 14 Feb 2022 18:34:07 +0000 Received: from localhost ([127.0.0.1]:42526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJgAo-0002ZE-O1 for submit@debbugs.gnu.org; Mon, 14 Feb 2022 13:34:06 -0500 Received: from mout01.posteo.de ([185.67.36.65]:55863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJgAm-0002Yi-Kk for 53897@debbugs.gnu.org; Mon, 14 Feb 2022 13:34:05 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 82C6B240028 for <53897@debbugs.gnu.org>; Mon, 14 Feb 2022 19:33:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1644863637; bh=NF9jYUtgSQ8rSoGOJsGcXZcyvnhnuSb1Xu5218cCr6M=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=EZqHjlohJ+3+KjR9ybITVTMO0rOrAV4b+DU/QxZm0qA+BPZR2+sKIjpycemjor7Hv 23hfVwYwAt1xEH6YGKAFCz7WoINgocON6Qbfh2/SPPcvAA2p7anY6bD4YfxBWmpbMO j9V0arXvxuNbQTc/WYPUM90s7mGkIgdopBZyLmONw2kdjUX1wBoxDDrYAwGS/eg2m2 +kqZV4sEJeJnbuFZzZYWmFWxWEW5JFgskT8TdQkLM3BHNrlbFRIKbK7F3nAO7wCKxE jdISEjAABjPpwQIsEWr8K6tZCTw5QribJ06CENx238l0N7Iroe2b7/2WzE8Dq5fFz2 oJdiFpdL4pseg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JyCY06qR7z6tpX; Mon, 14 Feb 2022 19:33:56 +0100 (CET) From: Philip Kaludercic To: Daniel Mendler Subject: Re: bug#53897: 28.0.91; regression: rcirc overwrites completion-cycle-threshold References: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> <87v8xo2o9q.fsf@posteo.net> <87bkz9co1d.fsf@posteo.net> <5525a90a-4613-cf73-a120-19862977d2d2@daniel-mendler.de> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Mon, 14 Feb 2022 18:33:56 +0000 In-Reply-To: <5525a90a-4613-cf73-a120-19862977d2d2@daniel-mendler.de> (Daniel Mendler's message of "Mon, 14 Feb 2022 19:18:53 +0100") Message-ID: <87v8xhb8mj.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53897 Cc: 53897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Daniel Mendler writes: >>>> I could imagine introducing a user option to decide what you want to >>>> use. My inclination would be to set it to "cycle by default", but it >>>> doesn't need that way. Perhaps we could test non-cycling (regular capf) >>>> for a while, and see if there are any complaints or other feedback? >>> >>> Yes, I would go with normal Capf behavior, which is the usual behavior >>> across all of Emacs. If a user wants to restore rcirc-complete, it seems >>> easy enough to add this to a user configuration? >>> >>> (defun rcirc-complete () >>> (interactive) >>> (let ((completion-cycle-threshold t)) >>> (completion-at-point))) >> >> Or, this could be added as rcirc-complete, binding TAB back to this new >> command and documenting that if you want to complete using the default >> CAPF, you should rebind it to completion-at-point? > > That's an option too. But then you will still keep the old cruft around. > I would rather break backward compatibility here and document that > binding `completion-cycle-threshold=t` will restore the old behavior. > Most users will appreciate that a Capf is directly available, which is > more capable than `rcirc-complete`! I honestly don't know. I understand both sides, but cannot decide. One also has to consider the current stage of Emacs 28 development, and that these kinds of changes aren't appreciated right now. That means disabling completion-cycle-threshold would have to be installed in 29.1. -- Philip Kaludercic From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 15 11:14:42 2022 Received: (at 53897-done) by debbugs.gnu.org; 15 Apr 2022 15:14:42 +0000 Received: from localhost ([127.0.0.1]:60096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfNej-0000k9-Vv for submit@debbugs.gnu.org; Fri, 15 Apr 2022 11:14:42 -0400 Received: from mout01.posteo.de ([185.67.36.65]:52819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfNeg-0000jh-65 for 53897-done@debbugs.gnu.org; Fri, 15 Apr 2022 11:14:40 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4E261240027 for <53897-done@debbugs.gnu.org>; Fri, 15 Apr 2022 17:14:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1650035672; bh=lCoMMXWml/3ZibFep8O4nE75bP7jfQveLBnsAdRENTc=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=ma3PXht545AFn2mYykJiUlppzH/CFUKBtpPLNHeWbNk5yiQkwgU1hpOFEtS48tG5Y BJgR8SoVIYs8ned0mgRmrHxaJc0G/Mg45wunu8XgeOHnCXBsDxGV8r5upYaaG9p+5r QLHJklewSgJoh7SSq/Uk8GpyqPKUAHZv4Yff4EF9+Vulyv/kAIGzN6ZFgb9JBnVJ/h OH9jh8u5rc9Y+wkavOkEheLLc6jTADQBFjqIsv92w8mVQMQOsReN7iFtSppwSLD8/a 6YskBonFcGSoeBuiaRevXIEOvFatl290TsOJv66dpFXVYp+qNQHn3P3FYsxjoLPa7J 72dY1Em8gwtiQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Kg0HC4TzGz9rxQ; Fri, 15 Apr 2022 17:14:31 +0200 (CEST) From: Philip Kaludercic To: Daniel Mendler Subject: Re: bug#53897: 28.0.91; regression: rcirc overwrites completion-cycle-threshold References: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Fri, 15 Apr 2022 15:14:31 +0000 In-Reply-To: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> (Daniel Mendler's message of "Wed, 9 Feb 2022 12:10:09 +0100") Message-ID: <87fsmebcq0.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53897-done Cc: 53897-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This issue should have been resolved by fdd8b591 and the addition of rcirc-cycle-completion-flag (disabled by default). Daniel Mendler writes: > rcirc-mode started to set `completion-cycle-threshold' to t. This > setting is intrusive and interferes with user completion setups. It is > better left to the user to tweak this setting in their user > configuration, since users may want to configure completions coherently > across the different modes in Emacs. Note that rcirc.el is the only > file/mode which sets `completion-cycle-threshold'. Therefore it is > better to revert the change which added this setting. > > In GNU Emacs 28.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, > cairo version 1.16.0) > of 2022-02-09 built on projects > Repository revision: 82e74e4559b8becd44f3e7ac0134e2baddd69921 > Repository branch: emacs-28 > Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 > System Description: Debian GNU/Linux 10 (buster) -- Philip Kaludercic From unknown Sun Jun 15 08:30:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 14 May 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator