From unknown Sun Jun 22 07:52:52 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#53880] [PATCH 0/2] Fix build of protonvpn-cli Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Feb 2022 18:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53880 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53880@debbugs.gnu.org Cc: Josselin Poiret X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164434342319288 (code B ref -1); Tue, 08 Feb 2022 18:04:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Feb 2022 18:03:43 +0000 Received: from localhost ([127.0.0.1]:48573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHUq7-000511-HR for submit@debbugs.gnu.org; Tue, 08 Feb 2022 13:03:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:37048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHUq6-00050u-Hb for submit@debbugs.gnu.org; Tue, 08 Feb 2022 13:03:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHUq6-0002zl-BO for guix-patches@gnu.org; Tue, 08 Feb 2022 13:03:42 -0500 Received: from jpoiret.xyz ([206.189.101.64]:47202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHUq4-0002m6-Hk for guix-patches@gnu.org; Tue, 08 Feb 2022 13:03:42 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id AB055185182; Tue, 8 Feb 2022 18:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1644343418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+nQ3076z1PFWdYyIHcC6MwBsqarvdpQaqzvcFaJtmbs=; b=UbQNGh4wsbPQQTsOBiPOccW6aEK74HIrvsTBY0t2EY0vGrocDmE+K80Vs0uAYJKVhTjbsl spLTkkJxK7aBA3R9iFLryRUG2m4kI35xbdURrjZlVeFHiSPFqCp/0eq+vtyCgC2c1vowXT 9Y/Pq6Kpvft8el86Uc3MGerDRbZYScp4NWbEH6h6N7YVZucjtBfIrdtO/fr+XWLIaK/ktD vTjpeAOwDXKbGHmeES2KZzCUOMc/xmuCP8rpQvdaldHuISbUoE7H42/ZrL3AATDOqR5DtG feXanJJas6Fef/Sod+Gi8+1UWj0WENE7y3rni6JjnA+F0SiO5M2nflaP41WjPQ== From: Josselin Poiret Date: Tue, 8 Feb 2022 19:03:33 +0100 Message-Id: <20220208180333.11502-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Level: **** X-Spamd-Bar: ++++ Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: 22 X-Spam_score: 2.2 X-Spam_bar: ++ X-Spam_report: (2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498, FROM_SUSPICIOUS_NTLD_FP=1.997, PDS_OTHER_BAD_TLD=1.769, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.7 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, These two patches fix the build failure of protonvpn-cli. The first one fixes the wrap target, since the wrapper code now properly handles re-wrapping a wrapped binary. The second removes the sanity-c [...] Content analysis details: (2.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=dev%40jpoiret.xyz; ip=209.51.188.17; r=debbugs.gnu.org] 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hello, These two patches fix the build failure of protonvpn-cli. The first one fixes the wrap target, since the wrapper code now properly handles re-wrapping a wrapped binary. The second removes the sanity-check phase as the main entry point tries to create a directory under ~user, which fails, and setting HOME=/tmp will not work since expanding ~user uses the passwd database. Best, Josselin Poiret (2): gnu: protonvpn-cli: Do not try to wrap the wrapper. gnu: protonvpn-cli: Remove sanity-check phase. gnu/packages/vpn.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.34.0 From unknown Sun Jun 22 07:52:52 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#53880] [PATCH 1/2] gnu: protonvpn-cli: Do not try to wrap the wrapper. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Feb 2022 18:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53880 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53880@debbugs.gnu.org Cc: Josselin Poiret Received: via spool by 53880-submit@debbugs.gnu.org id=B53880.164434354619536 (code B ref 53880); Tue, 08 Feb 2022 18:06:01 +0000 Received: (at 53880) by debbugs.gnu.org; 8 Feb 2022 18:05:46 +0000 Received: from localhost ([127.0.0.1]:48583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHUs5-00054y-TR for submit@debbugs.gnu.org; Tue, 08 Feb 2022 13:05:46 -0500 Received: from jpoiret.xyz ([206.189.101.64]:37802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHUs4-00054p-Mj for 53880@debbugs.gnu.org; Tue, 08 Feb 2022 13:05:44 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id F38B0185182; Tue, 8 Feb 2022 18:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1644343544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rLfl3p5V5/oEGIvYrACbGSXHCyLlXKScqg2FprAR5+A=; b=OtWuLBXbLRAqroTp0XcglFA1v5YQS+ECu/JeiXN0DWoYUnuMckKQce4SxUmPtHNz6iuYY5 N3dTvbn14OFmf2KNVmVvA0s0NDyAyZRvh9JsY3YPywmzl7oHq20da2nd48zdNDgexnSxws Jf5zxs44UQbZ0ijmzDtuG+qxV7q2LcEr5UQCmqXFtJzoTmS44FZkdHb4tkCBDYCXMZGQfp mzrk3/aHRdwP7j26W7u/JB0PZn/2/6cLYDvgRmRxkJezQME3JtQqPjnHk24zihr0uRT9Cu M2gz1TdP5szA7TRpNka0LJA94Cuy8mFxVxcK5NwzhfrcfB5ctR+kh1GYD5kNcQ== From: Josselin Poiret Date: Tue, 8 Feb 2022 19:05:40 +0100 Message-Id: <20220208180542.11619-1-dev@jpoiret.xyz> In-Reply-To: <20220208180333.11502-1-dev@jpoiret.xyz> References: <20220208180333.11502-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/vpn.scm (protonvpn-cli)[arguments]: Try to wrap the original program, and not the wrapper, as wrap-program handles that properly. --- gnu/packages/vpn.scm | 2 +- 1 file changed, 1 inser [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/vpn.scm (protonvpn-cli)[arguments]: Try to wrap the original program, and not the wrapper, as wrap-program handles that properly. --- gnu/packages/vpn.scm | 2 +- 1 file changed, 1 inser [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * gnu/packages/vpn.scm (protonvpn-cli)[arguments]: Try to wrap the original program, and not the wrapper, as wrap-program handles that properly. --- gnu/packages/vpn.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm index 7f1d10d1eb..150dfa31b5 100644 --- a/gnu/packages/vpn.scm +++ b/gnu/packages/vpn.scm @@ -753,7 +753,7 @@ (define-public protonvpn-cli ;; Wrap entrypoint with paths to its hard dependencies. (lambda* (#:key inputs outputs #:allow-other-keys) (let ((entrypoint (string-append (assoc-ref outputs "out") - "/bin/.protonvpn-real"))) + "/bin/protonvpn"))) (wrap-program entrypoint #:sh (search-input-file inputs "bin/bash") `("PATH" ":" prefix -- 2.34.0 From unknown Sun Jun 22 07:52:52 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#53880] [PATCH 2/2] gnu: protonvpn-cli: Remove sanity-check phase. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Feb 2022 18:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53880 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53880@debbugs.gnu.org Cc: Josselin Poiret Received: via spool by 53880-submit@debbugs.gnu.org id=B53880.164434354819546 (code B ref 53880); Tue, 08 Feb 2022 18:06:02 +0000 Received: (at 53880) by debbugs.gnu.org; 8 Feb 2022 18:05:48 +0000 Received: from localhost ([127.0.0.1]:48585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHUs8-00055C-3T for submit@debbugs.gnu.org; Tue, 08 Feb 2022 13:05:48 -0500 Received: from jpoiret.xyz ([206.189.101.64]:37872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHUs5-00054w-LA for 53880@debbugs.gnu.org; Tue, 08 Feb 2022 13:05:45 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id D5A9D1851F2; Tue, 8 Feb 2022 18:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1644343545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ydeNsKsfM1xZ4/mbOi4vMNAaeWh6sBgn9CUX2enmrc4=; b=DvEHewZyetPGiDWydaMRaIeiz+FB3z+lp21E+Q5dozJpA2voWLTzuf5+Zsl1C+i4CNdilH oa82e7QnjyyHwowBdoQWiiTD+N8W7SR3Y9t1dAPWIB5a7wClz+ioAJOt+/FEip5BvH+Njc CmDDQCc9BW1dG7ifdcJIySoe1mzDJp9yQ98jMrvFMNeSQCT0guOg9t46d3zPsrKudBNVSU htaGsAkOuHZDW3Cb1KC+7VRqo4nQ4SC4n/PrFJf97CdUUF9gFpu4T01qI9KIqI6UZLmRbp 6wnRLny1ja+3wXNgQWBDdmYlafmCTSnVPEa0y0PSP1ErsEnM1B62KQB6jpGx9A== From: Josselin Poiret Date: Tue, 8 Feb 2022 19:05:41 +0100 Message-Id: <20220208180542.11619-2-dev@jpoiret.xyz> In-Reply-To: <20220208180333.11502-1-dev@jpoiret.xyz> References: <20220208180333.11502-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/vpn.scm (protonvpn-cli)[arguments]: Remove sanity-check phase. --- gnu/packages/vpn.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm index 150dfa31b5..170ec1b663 100644 --- a/gnu/packages/vpn.scm +++ b/gnu/packages/vpn.scm @@ -768,7 +768,11 @@ (define-public protonvpn-cli "op [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/vpn.scm (protonvpn-cli)[arguments]: Remove sanity-check phase. --- gnu/packages/vpn.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm index 150dfa31b5..170ec1b663 100644 --- a/gnu/packages/vpn.scm +++ b/gnu/packages/vpn.scm @@ -768,7 +768,11 @@ (define-public protonvpn-cli "op [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * gnu/packages/vpn.scm (protonvpn-cli)[arguments]: Remove sanity-check phase. --- gnu/packages/vpn.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm index 150dfa31b5..170ec1b663 100644 --- a/gnu/packages/vpn.scm +++ b/gnu/packages/vpn.scm @@ -768,7 +768,11 @@ (define-public protonvpn-cli "openvpn" "procps" "which"))))) - #t))))) + #t)) + ;; The `protonvpn' script wants to write to `~user' to initialize its + ;; logger, so simply setting HOME=/tmp won't cut it. Remove + ;; sanity-check. + (delete 'sanity-check)))) (native-inputs (list python-docopt)) (inputs -- 2.34.0 From unknown Sun Jun 22 07:52:52 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Josselin Poiret Subject: bug#53880: closed (Re: bug#53880: [PATCH 0/2] Fix build of protonvpn-cli) Message-ID: References: <87h794w790.fsf@waegenei.re> <20220208180333.11502-1-dev@jpoiret.xyz> X-Gnu-PR-Message: they-closed 53880 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 53880@debbugs.gnu.org Date: Sat, 12 Feb 2022 13:22:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1644672122-1853-1" This is a multi-part message in MIME format... ------------=_1644672122-1853-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #53880: [PATCH 0/2] Fix build of protonvpn-cli which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 53880@debbugs.gnu.org. --=20 53880: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D53880 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1644672122-1853-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 53880-done) by debbugs.gnu.org; 12 Feb 2022 13:21:28 +0000 Received: from localhost ([127.0.0.1]:33738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIsLA-0000Sh-6e for submit@debbugs.gnu.org; Sat, 12 Feb 2022 08:21:28 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:35913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIsL7-0000SJ-I6; Sat, 12 Feb 2022 08:21:26 -0500 Received: (Authenticated sender: brice@waegenei.re) by mail.gandi.net (Postfix) with ESMTPSA id 2C9FD20007; Sat, 12 Feb 2022 13:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=waegenei.re; s=gm1; t=1644672078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YC0gAAF5/vDG2cjAE8QCnahGQB9V3ii44/O4K3GjPYo=; b=n0E4ZCchZsoPcxZ29gNuCUKHj98Iaarv5+vDBtP2oQHOH/S0GonEXS+s84kiBZtdqn6wd0 7sF7Srj2cC/bWxp7dG3TuSKlVQVXa2wnoJFP0081T/UwdtkAOpGhoJArEhK6p7fwGxUYqm Bcqe88KE2xe00gJzBN5WdunsU0iF3Xr0mezA9YSpGrLYXyfsMW2oFhv9Mc/TzNeb6mpGu2 csNmlEL5KcfSRo4L5gyJkHJvEgRzkEwmnL8zF6M6SPDbR35zxpotf3oMGCAkeXt1Hx09fy +8RaItK15MF9tr+rrae3LQdMi5+JpFfF2azPFIzLr6sdqCDWcZRKt6MbITf/ig== From: Brice Waegeneire To: Josselin Poiret Subject: Re: bug#53880: [PATCH 0/2] Fix build of protonvpn-cli References: <20220208180333.11502-1-dev@jpoiret.xyz> Date: Sat, 12 Feb 2022 14:21:15 +0100 In-Reply-To: <20220208180333.11502-1-dev@jpoiret.xyz> (Josselin Poiret's message of "Tue, 8 Feb 2022 19:03:33 +0100") Message-ID: <87h794w790.fsf@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: 53880-done Cc: 53855-done@debbugs.gnu.org, 53880-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hello Josselin, Josselin Poiret writes: > Josselin Poiret (2): > gnu: protonvpn-cli: Do not try to wrap the wrapper. > gnu: protonvpn-cli: Remove sanity-check phase. > > gnu/packages/vpn.scm | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Thank you for the patch, it fixes . I've build the package and ran the binary succesfully. It's pushed as 9c8f68f4796f23c11173fa3f90c69bc85b224ac6 with an added copyright header. Cheers, - Brice ------------=_1644672122-1853-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Feb 2022 18:03:43 +0000 Received: from localhost ([127.0.0.1]:48573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHUq7-000511-HR for submit@debbugs.gnu.org; Tue, 08 Feb 2022 13:03:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:37048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHUq6-00050u-Hb for submit@debbugs.gnu.org; Tue, 08 Feb 2022 13:03:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHUq6-0002zl-BO for guix-patches@gnu.org; Tue, 08 Feb 2022 13:03:42 -0500 Received: from jpoiret.xyz ([206.189.101.64]:47202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHUq4-0002m6-Hk for guix-patches@gnu.org; Tue, 08 Feb 2022 13:03:42 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id AB055185182; Tue, 8 Feb 2022 18:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1644343418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+nQ3076z1PFWdYyIHcC6MwBsqarvdpQaqzvcFaJtmbs=; b=UbQNGh4wsbPQQTsOBiPOccW6aEK74HIrvsTBY0t2EY0vGrocDmE+K80Vs0uAYJKVhTjbsl spLTkkJxK7aBA3R9iFLryRUG2m4kI35xbdURrjZlVeFHiSPFqCp/0eq+vtyCgC2c1vowXT 9Y/Pq6Kpvft8el86Uc3MGerDRbZYScp4NWbEH6h6N7YVZucjtBfIrdtO/fr+XWLIaK/ktD vTjpeAOwDXKbGHmeES2KZzCUOMc/xmuCP8rpQvdaldHuISbUoE7H42/ZrL3AATDOqR5DtG feXanJJas6Fef/Sod+Gi8+1UWj0WENE7y3rni6JjnA+F0SiO5M2nflaP41WjPQ== From: Josselin Poiret To: guix-patches@gnu.org Subject: [PATCH 0/2] Fix build of protonvpn-cli Date: Tue, 8 Feb 2022 19:03:33 +0100 Message-Id: <20220208180333.11502-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Level: **** X-Spamd-Bar: ++++ Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: 22 X-Spam_score: 2.2 X-Spam_bar: ++ X-Spam_report: (2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498, FROM_SUSPICIOUS_NTLD_FP=1.997, PDS_OTHER_BAD_TLD=1.769, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.7 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, These two patches fix the build failure of protonvpn-cli. The first one fixes the wrap target, since the wrapper code now properly handles re-wrapping a wrapped binary. The second removes the sanity-c [...] Content analysis details: (2.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=dev%40jpoiret.xyz; ip=209.51.188.17; r=debbugs.gnu.org] 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: submit Cc: Josselin Poiret X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hello, These two patches fix the build failure of protonvpn-cli. The first one fixes the wrap target, since the wrapper code now properly handles re-wrapping a wrapped binary. The second removes the sanity-check phase as the main entry point tries to create a directory under ~user, which fails, and setting HOME=/tmp will not work since expanding ~user uses the passwd database. Best, Josselin Poiret (2): gnu: protonvpn-cli: Do not try to wrap the wrapper. gnu: protonvpn-cli: Remove sanity-check phase. gnu/packages/vpn.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.34.0 ------------=_1644672122-1853-1--