GNU bug report logs - #53872
[PATCH] gnu: maven: Use required logger

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Julien Lepiller <julien <at> lepiller.eu>
Subject: bug#53872: closed (Re: bug#53872: [PATCH] gnu: maven: Use
 required logger)
Date: Mon, 28 Feb 2022 10:01:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#53872: [PATCH] gnu: maven: Use required logger

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 53872 <at> debbugs.gnu.org.

-- 
53872: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53872
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53872-done <at> debbugs.gnu.org
Subject: Re: bug#53872: [PATCH] gnu: maven: Use required logger
Date: Mon, 28 Feb 2022 11:00:00 +0100

With no other answer after more than two weeks since I posted the patch
series, pushed to master as ea23386e084a035e4bc23273fffc3d114b311789 -
9aae8a3e0d53fd0c11b8e98e1fd2d2232598b036. Thanks!

Le Wed, 16 Feb 2022 16:03:23 +0100,
Ludovic Courtès <ludo <at> gnu.org> a écrit :

> Hi,
> 
> Julien Lepiller <julien <at> lepiller.eu> skribis:
> 
> > I figured there was a small issue with our maven package. It warns
> > that the current logger is not supported, and lists no supported
> > logger. This is because I forgot to copy resources in
> > maven-embedder (first patch). I also noticed I missed resources in
> > maven-compat, so I fixed that in the second patch.
> >
> > Then, maven uses its own logger instead of a default one, even if it
> > does support slf4j-simple. The third patch adds
> > maven-slf4j-wrapper. It is essentially a fork of slf4j-simple, but
> > the way it's written requires me to copy most of slf4j-simple's
> > sources. The last patch switches the use of slf4j-simple to
> > maven-slf4j-provider. I checked that java-jmh still builds properly
> > with this change, and no warnings are shown about the logger
> > anymore.  
> 
> I know nothing about Maven but I’d say you can go ahead if the other
> Java folks around here have nothing to say.
> (When do we set up teams? :-))
> 
> Thanks,
> Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: maven: Use required logger
Date: Tue, 8 Feb 2022 10:42:31 +0100

[Message part 4 (text/plain, inline)]

Hi Guix!

I figured there was a small issue with our maven package. It warns that
the current logger is not supported, and lists no supported logger.
This is because I forgot to copy resources in maven-embedder (first
patch). I also noticed I missed resources in maven-compat, so I fixed
that in the second patch.

Then, maven uses its own logger instead of a default one, even if it
does support slf4j-simple. The third patch adds maven-slf4j-wrapper. It
is essentially a fork of slf4j-simple, but the way it's written
requires me to copy most of slf4j-simple's sources. The last patch
switches the use of slf4j-simple to maven-slf4j-provider. I checked
that java-jmh still builds properly with this change, and no warnings
are shown about the logger anymore.

[0001-gnu-maven-embedder-Install-resources.patch (text/x-patch, attachment)]

[0002-gnu-maven-compat-Install-resources.patch (text/x-patch, attachment)]

[0003-gnu-Add-maven-slf4j-provider.patch (text/x-patch, attachment)]

[0004-gnu-maven-Use-maven-slf4j-provider-instead-of-slf4j-.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.