GNU bug report logs - #53829
[PATCH] gnu: Add jj.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53829 in the body.
You can then email your comments to 53829 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add jj.
Date: Sun,  6 Feb 2022 16:50:22 -0500

* gnu/packages/messaging.scm (jj): New variable.
---
 gnu/packages/messaging.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 768642f119..d2735f9d96 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -3118,6 +3118,43 @@ (define-public matterbridge
     (home-page "https://github.com/42wim/matterbridge")
     (license license:asl2.0)))
 
+(define-public jj
+    (package
+      (name "jj")
+      (version "2")
+      (source
+       (origin
+         (method url-fetch)
+         (uri (string-append "https://23.fi/jj/jj-" version ".tar.gz"))
+         (sha256
+          (base32 "02xz2ci93bccvil5iff804mh3zr5iqkf6zx5mxgraz17xg0azlgh"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; There are no tests.
+         #:make-flags
+         (list (string-append "CC=" ,(cc-for-target))
+               (string-append "PREFIX=" %output))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure)
+         (replace 'install
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin")))
+               (install-file "jj" bin)))))))
+      (native-inputs
+        (list pkg-config))
+      (inputs
+        (list glib loudmouth))
+      (home-page "https://23.fi/jj/")
+      (synopsis "FIFO based Jabber client")
+      (description
+"@command{jj} is a simple FIFO and filesystem based Jabber
+client.  @code{jj} is inspired by @code{ii} IRC client.  It is perfect
+for bots and notifications.  Interaction with jj is done by writing and
+reading files from the server directory which jj creates.")
+      (license license:expat)))
+
 (define-public pounce
   (package
     (name "pounce")
-- 
2.35.0

Message #8 received at 53829 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>, 53829 <at> debbugs.gnu.org
Subject: Re: [bug#53829] [PATCH] gnu: Add jj.
Date: Sun, 06 Feb 2022 23:10:24 +0100

[Message part 1 (text/plain, inline)]

jgart via Guix-patches via schreef op zo 06-02-2022 om 16:50 [-0500]:
> +         (list (string-append "CC=" ,(cc-for-target))
> +               (string-append "PREFIX=" %output))

%output -> #$output (put a ,#~ after #:make-flags).

Maybe likewise in 'install' (YMMV)

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 53829 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53829 <at> debbugs.gnu.org
Subject: Re: [bug#53829] [PATCH] gnu: Add jj.
Date: Sun, 6 Feb 2022 20:20:48 -0500

On Sun, 06 Feb 2022 23:10:24 +0100 Maxime Devos <maximedevos <at> telenet.be> wrote:
> jgart via Guix-patches via schreef op zo 06-02-2022 om 16:50 [-0500]:
> > +         (list (string-append "CC=" ,(cc-for-target))
> > +               (string-append "PREFIX=" %output))
> 
> %output -> #$output (put a ,#~ after #:make-flags).
> 
> Maybe likewise in 'install' (YMMV)

Hi Maxime,

Thank you for the review! Could you explain the reason for this change? Is
there a mailing list thread I can read regarding the practice of using
gexps for those variables in #:make-flags. It would be much appreciated.

I'm just trying to understand it a bit better.

all best,

jgart

Message #14 received at 53829 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 53829 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos <at> telenet.be>, jgart <jgart <at> dismail.de>
Subject: [PATCH v2] gnu: Add jj.
Date: Sun,  6 Feb 2022 21:27:53 -0500

* gnu/packages/messaging.scm (jj): New variable.
---

Hi,

Here is version two with the gexps.

thanks,

jgart

 gnu/packages/messaging.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 768642f119..751b9a9766 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -3118,6 +3118,43 @@ (define-public matterbridge
     (home-page "https://github.com/42wim/matterbridge")
     (license license:asl2.0)))
 
+(define-public jj
+    (package
+      (name "jj")
+      (version "2")
+      (source
+       (origin
+         (method url-fetch)
+         (uri (string-append "https://23.fi/jj/jj-" version ".tar.gz"))
+         (sha256
+          (base32 "02xz2ci93bccvil5iff804mh3zr5iqkf6zx5mxgraz17xg0azlgh"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; There are no tests.
+         #:make-flags
+         ,#~(list (string-append "CC=" #$(cc-for-target))
+                  (string-append "PREFIX=" #$output))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure)
+         (replace 'install
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin")))
+               (install-file "jj" bin)))))))
+      (native-inputs
+        (list pkg-config))
+      (inputs
+        (list glib loudmouth))
+      (home-page "https://23.fi/jj/")
+      (synopsis "FIFO based Jabber client")
+      (description
+"@command{jj} is a simple FIFO and filesystem based Jabber
+client.  @code{jj} is inspired by @code{ii} IRC client.  It is perfect
+for bots and notifications.  Interaction with jj is done by writing and
+reading files from the server directory which jj creates.")
+      (license license:expat)))
+
 (define-public pounce
   (package
     (name "pounce")
-- 
2.35.0

Message #17 received at 53829 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>
Cc: 53829 <at> debbugs.gnu.org
Subject: Re: [bug#53829] [PATCH] gnu: Add jj.
Date: Mon, 07 Feb 2022 10:56:02 +0100

[Message part 1 (text/plain, inline)]

jgart schreef op zo 06-02-2022 om 20:20 [-0500]:
> Thank you for the review! Could you explain the reason for this change? Is
> there a mailing list thread I can read regarding the practice of using
> gexps for those variables in #:make-flags. It would be much appreciated.

It is part of the effort to remove the dependency on magic %global-
variables and input labels, see the blog post
<https://guix.gnu.org/en/blog/2021/the-big-change/>. That blog post
doesn't mention %outputs and #$output though.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 53829 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53829 <at> debbugs.gnu.org
Subject: Re: [bug#53829] [PATCH] gnu: Add jj.
Date: Mon, 7 Feb 2022 10:30:45 -0500

On Mon, 07 Feb 2022 10:56:02 +0100 Maxime Devos <maximedevos <at> telenet.be> wrote:
> jgart schreef op zo 06-02-2022 om 20:20 [-0500]:
> > Thank you for the review! Could you explain the reason for this change? Is
> > there a mailing list thread I can read regarding the practice of using
> > gexps for those variables in #:make-flags. It would be much appreciated.
> 
> It is part of the effort to remove the dependency on magic %global-
> variables and input labels, see the blog post
> <https://guix.gnu.org/en/blog/2021/the-big-change/>. That blog post
> doesn't mention %outputs and #$output though.

Thanks for the reference! I'll give it a read.

all best,

jgart

Message #25 received at 53829-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: jgart <jgart <at> dismail.de>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 53829-done <at> debbugs.gnu.org
Subject: Re: bug#53829: [PATCH] gnu: Add jj.
Date: Thu, 03 Mar 2022 23:44:13 +0100

Hi,

jgart <jgart <at> dismail.de> skribis:

> * gnu/packages/messaging.scm (jj): New variable.

[...]

> +(define-public jj
> +    (package
> +      (name "jj")
> +      (version "2")

I passed it through ‘guix style’, …

> +      (arguments
> +       `(#:tests? #f ; There are no tests.
> +         #:make-flags
> +         ,#~(list (string-append "CC=" #$(cc-for-target))

… changed this to avoid ,#~

> +      (description

… and tweaked this.

Committed, thanks!

Ludo’.

Message #28 received at 53829-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 53829-done <at> debbugs.gnu.org
Subject: Re: bug#53829: [PATCH] gnu: Add jj.
Date: Thu, 3 Mar 2022 19:21:57 -0500

On Thu, 03 Mar 2022 23:44:13 +0100 Ludovic Courtès <ludo <at> gnu.org> wrote:
> I passed it through ‘guix style’, …
> 
> > +      (arguments
> > +       `(#:tests? #f ; There are no tests.
> > +         #:make-flags
> > +         ,#~(list (string-append "CC=" #$(cc-for-target))
> 
> … changed this to avoid ,#~
> 
> > +      (description
> 
> … and tweaked this.

Thank you Ludo! Much appreciated.

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.