GNU bug report logs - #53825
[PATCH] gnu: Add sbase.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53825: closed ([PATCH] gnu: Add sbase.)
Date: Thu, 07 Jul 2022 19:58:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 07 Jul 2022 15:57:12 -0400
with message-id <87edywy9uv.fsf_-_ <at> gmail.com>
and subject line Re: bug#53825: [PATCH] gnu: Add sbase.
has caused the debbugs.gnu.org bug report #53825,
regarding [PATCH] gnu: Add sbase.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53825: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53825
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add sbase.
Date: Sun,  6 Feb 2022 12:56:18 -0500

* gnu/packages/suckless.scm (sbase): New variable.
---
 gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 708eb2c338..af7c0a8801 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -988,6 +988,38 @@ (define-public snooze
 running a command.")
     (license license:cc0)))
 
+(define-public sbase
+  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
+        (revision "0"))
+    (package
+      (name "sbase")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/dylanaraps/sbase")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; There are no tests.
+         #:make-flags
+         (list (string-append "CC=" ,(cc-for-target))
+               (string-append "PREFIX=" %output))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure))))
+      (home-page "https://core.suckless.org/sbase/")
+      (synopsis "Collection of unix tools that are portable across unix-systems")
+      (description
+  "@command{sbase} is a collection of unix tools that are portable across
+  unix-systems.")
+      (license license:expat))))
+
 (define-public scron
   (package
     (name "scron")
-- 
2.35.0

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 53825-done <at> debbugs.gnu.org, Xinglu Chen <public <at> yoctocell.xyz>
Subject: Re: bug#53825: [PATCH] gnu: Add sbase.
Date: Thu, 07 Jul 2022 15:57:12 -0400

Hi,

jgart <jgart <at> dismail.de> writes:

> * gnu/packages/suckless.scm (sbase): New variable.
> ---
>
> Hi, 
>
> Here is version 3 with the fix Xinglu mentioned.
>
> I haven't tested all the binaries.
>
> all best,
>
> jgart
>
> https://whereiseveryone.srht.site/
> gemini://whereiseveryone.srht.site/

I've adjusted it like so:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/suckless.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
 ;;; Copyright © 2021 Nikolay Korotkiy <sikmir <at> disroot.org>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1011,19 +1012,19 @@ (define-public sbase
           (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
       (build-system gnu-build-system)
       (arguments
-       `(#:tests? #f ; There are no tests.
-         #:make-flags
-         ,#~(list (string-append "CC=" #$(cc-for-target))
-                  (string-append "PREFIX=" #$output))
-         #:phases
-         (modify-phases %standard-phases
-           (delete 'configure))))
+       (list
+        #:tests? #f                     ;no test suite
+        #:make-flags #~(list (string-append "CC=" #$(cc-for-target))
+                             (string-append "PREFIX=" #$output))
+        #:phases
+        #~(modify-phases %standard-phases
+            (delete 'configure))))
       (home-page "https://core.suckless.org/sbase/")
-      (synopsis "Collection of Unix tools that are portable across unix-systems")
-      (description
-  "@command{sbase} is a collection of Unix tools that are portable across
-  Unix-systems.")
-      (license license:x11))))
+      (synopsis "Collection of UNIX tools")
+      (description "@command{sbase} is a collection of UNIX tools similar to those of GNU
+Coreutils, containing utilities commands such as @command{grep}, @command{cp},
+@command{rm}, etc.")
+      (license license:expat))))
 
 (define-public scron
   (package
--8<---------------cut here---------------end--------------->8---

Reverting the license to Expat as pointed by Maxime, fully capitalizing
UNIX, using a gexp for the phases and adding a few commands to the
description to give a better idea.  I've also removed the bits "portable
across UNIX systems" as on Guix that's not useful (the tools are as
portable as Guix itself is).

Pushed as 5299628b90.

Thanks!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.