GNU bug report logs - #53818
[PATCH 0/3] Add Repology updater

Previous Next

Full log

Message #101 received at 53818 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Xinglu Chen <public <at> yoctocell.xyz>, 53818 <at> debbugs.gnu.org
Subject: Re: [bug#53818] [PATCH v2 5/7] import: Add 'repology' updater.
Date: Mon, 07 Feb 2022 10:50:10 +0100

[Message part 1 (text/plain, inline)]

Xinglu Chen schreef op ma 07-02-2022 om 10:07 [+0100]:
> +(define (latest-release package)
> +  (mock ((guix import json) json-fetch
> +         (lambda* (url #:key cached?)
> +           (json-string->scm %test-json)))
> +        (repology-latest-release package)))

It would be nice to verify the URL.
FWIW, there's a 'with-http-server' macro.
although it might need to be extended a little, see e.g.
<https://issues.guix.gnu.org/53389>.

Also, you are using 'memoize' in repology-fetch-info,
so the memoisation cache needs to be invalidated
(see e.g. tests/minetest.scm), or not, depending
on how 'repology-fetch-info' is used and tests are written.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.