GNU bug report logs - #53815
[PATCH 1/3] gnu: Add libnitrokey.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53815 in the body.
You can then email your comments to 53815 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 1/3] gnu: Add libnitrokey.
Date: Sun, 06 Feb 2022 07:46:46 +0000

[Message part 1 (text/plain, inline)]

Hi,

Here are patches which add GUI tool to interface with Nitrokey hardware token.

----
Petr

[Message part 2 (text/html, inline)]

[0001-gnu-Add-libnitrokey.patch (text/x-patch, attachment)]

[0002-gnu-Add-cppcodec.patch (text/x-patch, attachment)]

[0003-gnu-Add-nitrokey-app.patch (text/x-patch, attachment)]

Message #8 received at 53815 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 53815 <at> debbugs.gnu.org
Subject: Re: [bug#53815] [PATCH 1/3] gnu: Add libnitrokey.
Date: Sun, 06 Feb 2022 10:33:39 +0100

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op zo 06-02-2022 om 07:46 [+0000]:
> +    (arguments
> +     `(#:tests? #f)) ;no test suite

The following looks like (part of) a test suite to me:
<https://github.com/tplgy/cppcodec/blob/master/test/test_cppcodec.cpp>.

> +    (synopsis "Header only C++11 library to encode/decode base64,
> etc.")
> +    (description "This package provide header-only C++11 library to
> +encode/decode base64, base64url, base32, base32hex and hex.")
> +    (license license:expat)))

While the information about being header-only is useful for people
looking to bundle a dependency in their source code, it seems
irrelevant to people using cppcodec via Guix.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 53815 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 53815 <at> debbugs.gnu.org
Subject: Re: [bug#53815] [PATCH 1/3] gnu: Add libnitrokey.
Date: Sun, 06 Feb 2022 10:34:45 +0100

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op zo 06-02-2022 om 07:46 [+0000]:
> +     `(#:tests? #f ;no test suite

I'm seeing a lot of tests at
<https://github.com/Nitrokey/libnitrokey/tree/master/unittest>.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 53815 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 53815 <at> debbugs.gnu.org
Subject: Re: [bug#53815] [PATCH 1/3] gnu: Add libnitrokey.
Date: Sun, 06 Feb 2022 10:36:37 +0100

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op zo 06-02-2022 om 07:46 [+0000]:
> +              (snippet '(begin
> +                          (delete-file-recursively "hidapi")))

Does this have any effect? Looking at
<https://github.com/Nitrokey/libnitrokey>, it looks like 'hidapi' is a
git submodule, which would normally not be included in the checkout
because 'recursive?' has not been found.

If it does have any effect, then wouldn't "tests/catch" in cppcodec
need to be removed as well?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 53815 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 53815 <at> debbugs.gnu.org
Subject: Re: [bug#53815] [PATCH 1/3] gnu: Add libnitrokey.
Date: Sun, 06 Feb 2022 10:38:55 +0100

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op zo 06-02-2022 om 07:46 [+0000]:
> +    (license license:lgpl3)))

Looking at
<https://github.com/Nitrokey/libnitrokey/blob/master/NK_C_API.cc>, the
license appears to be LGPL3+, even though the README just says LGPL3.
Possibly that's only for NK_C_API.cc though (unverified).

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 53815 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53815 <at> debbugs.gnu.org
Subject: [PATCH v2 1/3] gnu: Add libnitrokey
Date: Wed, 09 Feb 2022 09:53:24 +0000

[Message part 1 (text/plain, inline)]

Hi Maxime,

> phodina via Guix-patches via schreef op zo 06-02-2022 om 07:46 [+0000]:
>
> > +    (license license:lgpl3)))
>
> Looking at
>
> https://github.com/Nitrokey/libnitrokey/blob/master/NK_C_API.cc, the
>
> license appears to be LGPL3+, even though the README just says LGPL3.
>
> Possibly that's only for NK_C_API.cc though (unverified).
>

I've checked the code and there is only one change in the license recently but the commit itself is little bit misleading as it has different versions in LICENSE and README.md. There is now a ticket with this question. In the meantime I followed the LICENSE file.

https://github.com/Nitrokey/libnitrokey/issues/211

> +              (snippet '(begin
> +                          (delete-file-recursively "hidapi")))

> Does this have any effect? Looking at
> <https://github.com/Nitrokey/libnitrokey>, it looks like 'hidapi' is a
> git submodule, which would normally not be included in the checkout
> because 'recursive?' has not been found.

> If it does have any effect, then wouldn't "tests/catch" in cppcodec
> need to be removed as well?

You are right, I thought to unbundle just in case all the code but here it's just submodule and it's not cloned.

-- Found PkgConfig: /gnu/store/2b3blhwbag1ial0dhxw7wh4zjxl0cqpk-pkg-config-0.29.2/bin/pkg-config (found version "0.29.2")
-- Found system Catch2, not using bundled version

The Guix libraries are used correctly without any need for manual intervention.

> I'm seeing a lot of tests at <https://github.com/Nitrokey/libnitrokey/tree/master/unittest>.

You're right. This is my mistake as I only saw the tests that require HW token. Now I've enabled the offline tests.


> While the information about being header-only is useful for people
> looking to bundle a dependency in their source code, it seems
> irrelevant to people using cppcodec via Guix.

I've removed this information (FIY I'm C++ programmer so I thought it might be useful :-)
Also the tests for ccpcodec are now enabled.

The patches in the attachment have been rebase to latest master.


----
Petr

[v2-0001-gnu-Add-libnitrokey.patch (text/x-patch, attachment)]

[v2-0003-gnu-Add-nitrokey-app.patch (text/x-patch, attachment)]

[v2-0002-gnu-Add-cppcodec.patch (text/x-patch, attachment)]

Message #25 received at 53815-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 53815-done <at> debbugs.gnu.org
Subject: Re: bug#53815: [PATCH 1/3] gnu: Add libnitrokey.
Date: Mon, 14 Feb 2022 15:52:51 +0100

Hi,

phodina <phodina <at> protonmail.com> skribis:

> From 5f01b5d21f688d9725532f35067e92c49ab423b4 Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Sat, 5 Feb 2022 23:25:44 +0100
> Subject: [PATCH v2 1/3] gnu: Add libnitrokey.
>
> * gnu/packages/security-token.scm (libnitrokey): New variable.

[...]

> From e340d972a40667e693302ddc63354d1ed8b36e6e Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Sat, 5 Feb 2022 23:27:06 +0100
> Subject: [PATCH v2 3/3] gnu: Add nitrokey-app.
>
> * gnu/packages/crates-io.scm (nitrokey-app): New variable.

[...]

> From d44b13f8c44491a521bfaa73a414586f6f59ca37 Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Sat, 5 Feb 2022 23:26:36 +0100
> Subject: [PATCH v2 2/3] gnu: Add cppcodec.
>
> * gnu/packages/crates-io.scm (cppcodec): New variable.

I believe this section addresses Maxime’s comments; I applied all three
patches.

Thank you, and thanks Maxime for reviewing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.