Subject: Re: [bug#53812] [PATCH] gnu: Add emacs-mct.

From: Andrew Tropin <[email-masked]>
Date: Mon, 07 Feb 2022 18:04:26 +0300

On 2022-02-06 22:51, Nicolas Goaziou wrote:

> Hello,
>
> Andrew Tropin <[email-masked]> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-mct): New variable.
>
> Thank you.
>
>> +(define-public emacs-mct
>> +  (package
>> +   (name "emacs-mct")
>> +   (version "0.4.2")
>> +   (source (origin
>> +            (method git-fetch)
>> +            (uri (git-reference
>> +                  (url "https://gitlab.com/protesilaos/mct.git")
>> +                  (commit version)))
>> +            (sha256
>> +             (base32 "0sj9hyxpighspwrm2yimqkdxlhw2yiznaj69ysn2sjd6jn2aqpc6"))
>> +            (file-name (git-file-name name version))))
>> +   (build-system emacs-build-system)
>> +   (license license:gpl3+)
>> +   (home-page "https://protesilaos.com/emacs/mct")
>> +   (synopsis "Enhancement of the default Emacs minibuffer completion UI.")
>
> Synopsis may not end with a period. You may want to run "guix lint" on
> your package definition.
>
>> +   (description "Minibuffer and Completions in Tandem, also known as
>> +mct, or mct.el, is a package that enhances the default minibuffer and
>> +*Completions* buffer of Emacs 27 (or higher) so that they work
>> +together as part of a unified framework. The idea is to make the
>> +presentation and overall functionality be consistent with other
>> +popular, vertically aligned completion UIs while leveraging built-in
>> +functionality.")))
>
> Sentences in description should be separated with two spaces.
>
> Nitpick: license field usually comes last.
>
> Note that upstream mentions this is an Emacs 28+ package, and Guix
> provides only Emacs 27.2. Would it be a bit early to provide this
> package?
>
> Regards,

Attaching v2, seems all the issues and questions are addressed.

From b4878a8adcbae7dd988df4741a39b0e0c27fb92b Mon Sep 17 00:00:00 2001
From: Andrew Tropin <[email-masked]>
Date: Sat, 5 Feb 2022 20:19:52 +0300
Subject: [PATCH v2] gnu: Add emacs-mct.

* gnu/packages/emacs-xyz.scm (emacs-mct): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 444b761116..d7faf6ea6f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30090,3 +30090,26 @@ (define-public emacs-fennel-mode
      "Fennel mode provides font-lock, indentation, navigation, and REPL for
  Fennel code within Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-mct
+  (package
+   (name "emacs-mct")
+   (version "0.4.2")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://gitlab.com/protesilaos/mct.git")
+                  (commit version)))
+            (sha256
+             (base32 "0sj9hyxpighspwrm2yimqkdxlhw2yiznaj69ysn2sjd6jn2aqpc6"))
+            (file-name (git-file-name name version))))
+   (build-system emacs-build-system)
+   (home-page "https://protesilaos.com/emacs/mct")
+   (synopsis "Enhancement of the default Emacs minibuffer completion UI")
+   (description "Minibuffer and Completions in Tandem, also known as mct, or
+mct.el, is a package that enhances the default minibuffer and *Completions*
+buffer of Emacs 27 (or higher) so that they work together as part of a unified
+framework.  The idea is to make the presentation and overall functionality be
+consistent with other popular, vertically aligned completion UIs while
+leveraging built-in functionality.")
+   (license license:gpl3+)))
-- 
2.34.0

-- 
Best regards,
Andrew Tropin