From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 05 18:51:57 2022 Received: (at submit) by debbugs.gnu.org; 5 Feb 2022 23:51:57 +0000 Received: from localhost ([127.0.0.1]:35935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGUqT-0001pn-6P for submit@debbugs.gnu.org; Sat, 05 Feb 2022 18:51:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:48196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGUqR-0001pf-BN for submit@debbugs.gnu.org; Sat, 05 Feb 2022 18:51:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGUqR-0003jE-31 for bug-gnu-emacs@gnu.org; Sat, 05 Feb 2022 18:51:55 -0500 Received: from rgrjr.com ([69.164.211.47]:55632) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGUqP-00063y-BH for bug-gnu-emacs@gnu.org; Sat, 05 Feb 2022 18:51:54 -0500 Received: from rgrjr.com (c-73-16-206-7.hsd1.ma.comcast.net [73.16.206.7]) by rgrjr.com (Postfix on openSUSE) with ESMTP id 4F7101D6BAE for ; Sat, 5 Feb 2022 23:52:02 +0000 (UTC) Received: from orion.rgrjr.com (orion.rgrjr.com [192.168.0.3]) by scorpio.rgrjr.com (Postfix on openSUSE GNU/Linux) with ESMTP id ADCD25FEC6; Sat, 5 Feb 2022 18:51:51 -0500 (EST) From: Bob Rogers To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Incorrect docstring for ietf-drums-get-comment Date: Sat, 05 Feb 2022 18:51:45 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=69.164.211.47; envelope-from=rogers@rgrjr.com; helo=rgrjr.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) In GNU Emacs 29.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2022-02-02 built on orion Repository revision: ed13b0d0f427df333f8e1f9a24015c354da4c62f Repository branch: rgr-ietf-drums-date Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: openSUSE Leap 15.3 In master as of d34dd869d2, doing (ietf-drums-get-comment "random (comment) (string)") returns "string", whereas the docstring says it returns the content of the first comment. The documentation for both ietf-drums-get-comment and mail-header-get-comment say "last"; perusing the code (only ietf-drums-get-comment is actually called) also shows that the last one is what callers expect. -- Bob Rogers http://www.rgrjr.com/ >From d1c9098ddfe0a913f8c20606347e334ca06dd9d3 Mon Sep 17 00:00:00 2001 From: Bob Rogers Date: Sat, 5 Feb 2022 18:27:58 -0500 Subject: [PATCH] ; Correct the ietf-drums-get-comment docstring * lisp/mail/ietf-drums.el (ietf-drums-get-comment): We really return the last comment. --- lisp/mail/ietf-drums.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/mail/ietf-drums.el b/lisp/mail/ietf-drums.el index 952707226f..fd9cb6abb7 100644 --- a/lisp/mail/ietf-drums.el +++ b/lisp/mail/ietf-drums.el @@ -150,7 +150,7 @@ ietf-drums-remove-whitespace (buffer-string)))) (defun ietf-drums-get-comment (string) - "Return the first comment in STRING." + "Return the last comment in STRING." (with-temp-buffer (ietf-drums-init string) (let (result c) -- 2.34.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 05 19:08:25 2022 Received: (at 53810) by debbugs.gnu.org; 6 Feb 2022 00:08:25 +0000 Received: from localhost ([127.0.0.1]:35988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGV6O-0004Yf-Rp for submit@debbugs.gnu.org; Sat, 05 Feb 2022 19:08:25 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGV6K-0004YI-6q for 53810@debbugs.gnu.org; Sat, 05 Feb 2022 19:08:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OTfpEU9eJrSe29xI00JFjTD4i2002nAiWrP3b0zD398=; b=N9NQssoMX8qflCZAwZ3kOsTVRv TKvZkfhFonyvKEGcvyghA5RAyFDORNpNz9MXnYQSfXe1ggz3CJKyVF+13dgEj+A4j8M4wWueUGZD2 f5lAhRDBV7KQp8OvECRKKNHu1ieeIB4/Kil8Rl1osLX51xHs0JKd4hyol8fjjTeszGMs=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGV6B-0005QK-4U; Sun, 06 Feb 2022 01:08:13 +0100 From: Lars Ingebrigtsen To: Bob Rogers Subject: Re: bug#53810: 29.0.50; Incorrect docstring for ietf-drums-get-comment References: X-Now-Playing: Brian Eno's _Another Green World_: "Everything Merges with the Night" Date: Sun, 06 Feb 2022 01:08:09 +0100 In-Reply-To: (Bob Rogers's message of "Sat, 05 Feb 2022 18:51:45 -0500") Message-ID: <87leyo7t7a.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Bob Rogers writes: > * lisp/mail/ietf-drums.el (ietf-drums-get-comment): We really return > the last comment. Thanks; pushed to emacs-28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53810 Cc: 53810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Bob Rogers writes: > * lisp/mail/ietf-drums.el (ietf-drums-get-comment): We really return > the last comment. Thanks; pushed to emacs-28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 05 19:08:30 2022 Received: (at control) by debbugs.gnu.org; 6 Feb 2022 00:08:30 +0000 Received: from localhost ([127.0.0.1]:35991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGV6U-0004Yx-1C for submit@debbugs.gnu.org; Sat, 05 Feb 2022 19:08:30 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGV6S-0004YX-30 for control@debbugs.gnu.org; Sat, 05 Feb 2022 19:08:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N0fBWmDRVrAdjJT8X1ABbdMMwmT4fXDpk3ZcAy6qFVI=; b=b0UAYWRaGhaN5qq5jIa5J0Llxy NvdJya8ar7f1Vm2LGfD2NfqwnnlN265lwbzfV+ft7UnrZd5llGAnEcV9Sa0YTSIBPSdi1lwoPJ2pI bIXM21YnNLdJfcfLFcLXTt7iXKzUT3qYwo+6gnMGfgEILupkXwLPJSR7RLkJK9uSR2Ow=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGV6K-0005QW-9l for control@debbugs.gnu.org; Sun, 06 Feb 2022 01:08:22 +0100 Date: Sun, 06 Feb 2022 01:08:19 +0100 Message-Id: <87k0e87t70.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #53810 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 53810 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 53810 29.1 quit From unknown Fri Aug 15 21:25:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 06 Mar 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator