From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 03 14:31:49 2022 Received: (at submit) by debbugs.gnu.org; 3 Feb 2022 19:31:49 +0000 Received: from localhost ([127.0.0.1]:57852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFhpc-0005z9-PI for submit@debbugs.gnu.org; Thu, 03 Feb 2022 14:31:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:59664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFhpZ-0005yz-05 for submit@debbugs.gnu.org; Thu, 03 Feb 2022 14:31:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFhpX-0007EO-2Z for bug-gnu-emacs@gnu.org; Thu, 03 Feb 2022 14:31:43 -0500 Received: from mail-4319.protonmail.ch ([185.70.43.19]:52525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFhpQ-0004C9-B8 for bug-gnu-emacs@gnu.org; Thu, 03 Feb 2022 14:31:41 -0500 Date: Thu, 03 Feb 2022 19:30:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail2; t=1643916633; bh=ZMqapjVSlVuVnfp0HwJ/IpQ6n58XXGp7gYaQTek5l6k=; h=Date:To:From:Reply-To:Subject:Message-ID:From:To:Cc; b=T3msAt7A8zj2ngiJJmIO275tQKOyOdMqLW83YUTwAdkxiavP1Pob8q3VaP0CEWpLt bkGeaen0sXzSDpZWjs2c4thbaib44tjdPZUT0YpvfMeK7rbiGVGUgrzqu4nIDXvdve InhIqvq4gUQsB/ydlWHnIiWZq7NDDKD2GH1db3FPeMt8uTZN1gfZVqV3PLLvf7t67V CTxrAS8TRcK/4PlkYNDPCrL1ciksvLx0rYxjFF6WLHaCrvjD1lnSpHmD8UXy/ou7SS dFb0RZr48ZMl8qe+2LvDNdP67zyOVY9Y/yBE8ZkDXSaRABy4egodify9fouZRC7OPv 4Wg7MaPQ6uElA== To: "Bug reports for GNU Emacs, the Swiss army knife of text editors" From: emacsq Subject: Improve error message when during url retrieving network connection is lost Message-ID: <0alb06p4adi7DfKd_YPyh8NxSUppew_01ob8lx_aj8JtmGdl8TnKXWlLBxm8hqn4JNeGVK8uq97s-Y_46aFsR6ah16xHQGr7Wvbjq8Cp3HY=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.43.19; envelope-from=laszlomail@protonmail.com; helo=mail-4319.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: emacsq Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Sometimes when fetching an URL with url-retireve emacs returns the error "Process not running" This is the case when emacs tries to do an operation on the process and finds the process is not running anymore. In case of fetching an url it is presumably because of the network connection is unexpectedly lost, so for network processes returning an error message like "Network connection closed unexpectedly" or similar is more informative for the user than saying "Process X not running". From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 04 04:50:51 2022 Received: (at 53762) by debbugs.gnu.org; 4 Feb 2022 09:50:51 +0000 Received: from localhost ([127.0.0.1]:58792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFvEw-00064M-TM for submit@debbugs.gnu.org; Fri, 04 Feb 2022 04:50:51 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:46854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFvEv-000646-9O for 53762@debbugs.gnu.org; Fri, 04 Feb 2022 04:50:49 -0500 Received: by mail-wm1-f49.google.com with SMTP id l67-20020a1c2546000000b00353951c3f62so2898025wml.5 for <53762@debbugs.gnu.org>; Fri, 04 Feb 2022 01:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=gzxO4JI5Hs02hJg2k/6i9PLb15/KRc5/pDCS0pD1kmQ=; b=SloAHuXanQZ2WvrTIqQi7kLn2BmdnxzOdzO6QtHbj5asHFvrJcRc+XQhPcKReZwKxb h0JJCmVChxtXxO+xZnbHwLbdhkzaStuLkNKdA/4qyRCcF/8ZypqvvLJvRGu7iSGkmWn3 lLeBzE/tJXHud++q5oBAsWbhPhmblzo86k5SCaTPcgL8Fvgk2aG5FXtKWpm6IQ7+d01J LLCaedJDl/GnQgOI3sL9OiemKsGixqiJgw0QHMbQ2i8bnBm0h9VM+y/PkB/6XHHX5/8V WmjfMiDwT5iOkF4TziISPxEr1Jcfyjpxxv/CMUBv0kY/wOMgFcC4Zr6KDDj20EeKsQ9M XrAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=gzxO4JI5Hs02hJg2k/6i9PLb15/KRc5/pDCS0pD1kmQ=; b=jpS5Ucn/V2o+FwVY80WtPOQbj8ULEwZ/K0DZV3N3+YxjDr6nwmXxfvNy36pybTwLJk +HBWc+0tnqxLf/c9kGmg9P2mUmqOZc2Ur7gFUh7XJq2FY98axjhhyf1GI27fvNByuzLF QqIvNB+l+/phYJq3mRvD/vrFXETskFFp1FK5+5bDwmrV0qxmGkZMKETtcO8KJoMnSUcP rlAQWUdV2hU0EbUuu4pxlALauEHkGJUoC+z9ckcWCgm3RSfMpnuhO4sywWDGcW6Onaxg JeBT+i5oNiHICJYPFr8dSv/W17twBx23GnlvXGz0anKGRQHPubu5Z+5a+9nQ6aWydhFl dJlg== X-Gm-Message-State: AOAM530KrYKJkS93BAlOUUmfv/WcC9+QNKZIN0UHNWHFpoYqnHVKFOro tVSJMQ+GjaAjbsGWEKtIk8c= X-Google-Smtp-Source: ABdhPJzhqcKgfOI+sNBuryBbi1hrxaraJS4at4Z23gy+E2muhrkODSCPf6plWTCOlrR4qBnjaUHS1w== X-Received: by 2002:a05:600c:3aca:: with SMTP id d10mr1560948wms.64.1643968243075; Fri, 04 Feb 2022 01:50:43 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:1d59:aa04:d41c:740]) by smtp.gmail.com with ESMTPSA id l5sm1519724wrs.65.2022.02.04.01.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Feb 2022 01:50:42 -0800 (PST) From: Robert Pluim To: 53762@debbugs.gnu.org Subject: Re: bug#53762: Improve error message when during url retrieving network connection is lost References: <0alb06p4adi7DfKd_YPyh8NxSUppew_01ob8lx_aj8JtmGdl8TnKXWlLBxm8hqn4JNeGVK8uq97s-Y_46aFsR6ah16xHQGr7Wvbjq8Cp3HY=@protonmail.com> Date: Fri, 04 Feb 2022 10:50:41 +0100 In-Reply-To: <0alb06p4adi7DfKd_YPyh8NxSUppew_01ob8lx_aj8JtmGdl8TnKXWlLBxm8hqn4JNeGVK8uq97s-Y_46aFsR6ah16xHQGr7Wvbjq8Cp3HY=@protonmail.com> (emacsq via's message of "Thu, 03 Feb 2022 19:30:31 +0000") Message-ID: <87r18j7yfi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53762 Cc: emacsq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 03 Feb 2022 19:30:31 +0000, emacsq via "Bug reports for GNU E= macs, the Swiss army knife of text editors" said: emacsq> Sometimes when fetching an URL with url-retireve emacs emacsq> returns the error "Process not running" emacsq> This is the case when emacs tries to do an operation emacsq> on the process and finds the process is not running anymore. emacsq> In case of fetching an url it is presumably because of emacsq> the network connection is unexpectedly lost, so for network emacsq> processes returning an error message like "Network connection emacsq> closed unexpectedly" or similar is more informative for the emacsq> user than saying "Process X not running". Does something like this do the trick? I=CA=BCve not been able to get a reliable test case for it yet. diff --git a/src/process.c b/src/process.c index 7c7f608284..18d4579dba 100644 --- a/src/process.c +++ b/src/process.c @@ -6424,7 +6424,7 @@ send_process (Lisp_Object proc, const char *buf, ptrd= iff_t len, if (p->raw_status_new) update_status (p); if (! EQ (p->status, Qrun)) - error ("Process %s not running", SDATA (p->name)); + error ("Process %s %s", SDATA (p->name), SDATA (status_message (p))); if (p->outfd < 0) error ("Output file descriptor of %s is closed", SDATA (p->name)); =20 @@ -7129,7 +7129,7 @@ DEFUN ("process-send-eof", Fprocess_send_eof, Sproces= s_send_eof, 0, 1, 0, if (XPROCESS (proc)->raw_status_new) update_status (XPROCESS (proc)); if (! EQ (XPROCESS (proc)->status, Qrun)) - error ("Process %s not running", SDATA (XPROCESS (proc)->name)); + error ("Process %s %s", SDATA (XPROCESS (proc)->name), SDATA (status_m= essage (XPROCESS (proc)))); =20 if (coding && CODING_REQUIRE_FLUSHING (coding)) { From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 05 01:57:42 2022 Received: (at 53762) by debbugs.gnu.org; 5 Feb 2022 06:57:42 +0000 Received: from localhost ([127.0.0.1]:33585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGF0w-0000B7-Jx for submit@debbugs.gnu.org; Sat, 05 Feb 2022 01:57:42 -0500 Received: from quimby.gnus.org ([95.216.78.240]:42394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGF0v-0000Ar-Br for 53762@debbugs.gnu.org; Sat, 05 Feb 2022 01:57:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=euy8etB9tphFeRoLXnW/iyTMqCJc/DGKNuhQ6X+D84Y=; b=VXEv2IM3LTBQLEzVTcP2gqPvgK ujeBmOUn/FwgbHPlSE4yZ/faTw4+x1emm2ZtypKLSTbWlPW5Bs396Ca8/jJsQak1ix76AHx/IzbwL DmYl33oeNO8sMfQnz/jayd5XDKZs6uIb9Zs/5H6rxC45Z+GOpYLgVgPpU8iD/24GQc6E=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGF0m-0005Kq-3a; Sat, 05 Feb 2022 07:57:35 +0100 From: Lars Ingebrigtsen To: Robert Pluim Subject: Re: bug#53762: Improve error message when during url retrieving network connection is lost References: <0alb06p4adi7DfKd_YPyh8NxSUppew_01ob8lx_aj8JtmGdl8TnKXWlLBxm8hqn4JNeGVK8uq97s-Y_46aFsR6ah16xHQGr7Wvbjq8Cp3HY=@protonmail.com> <87r18j7yfi.fsf@gmail.com> X-Now-Playing: David Bowie's _Aladdin Sane_: "The Jean Genie" Date: Sat, 05 Feb 2022 07:57:31 +0100 In-Reply-To: <87r18j7yfi.fsf@gmail.com> (Robert Pluim's message of "Fri, 04 Feb 2022 10:50:41 +0100") Message-ID: <87pmo1dcmc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > Does something like this do the trick? Iʼve not been able to get a > reliable test case for it yet. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53762 Cc: 53762@debbugs.gnu.org, emacsq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: > Does something like this do the trick? I=CA=BCve not been able to get a > reliable test case for it yet. [...] > if (! EQ (p->status, Qrun)) > - error ("Process %s not running", SDATA (p->name)); > + error ("Process %s %s", SDATA (p->name), SDATA (status_message (p))); I think that's probably an improvement over what we have now, but I don't really have a good test case, either. But perhaps "not running" should be kept, and the status message just be appended? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 07 08:57:00 2022 Received: (at 53762) by debbugs.gnu.org; 7 Feb 2022 13:57:00 +0000 Received: from localhost ([127.0.0.1]:41293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nH4Vo-0006Wn-GP for submit@debbugs.gnu.org; Mon, 07 Feb 2022 08:57:00 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:38653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nH4Vm-0006Wa-Ky for 53762@debbugs.gnu.org; Mon, 07 Feb 2022 08:56:58 -0500 Received: by mail-wr1-f43.google.com with SMTP id s10so22369261wra.5 for <53762@debbugs.gnu.org>; Mon, 07 Feb 2022 05:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=32//tTs6zkn7wIdB7N5ZrVMGbcW+GGOiSnhchsA3dCg=; b=SBrF9+dBA8swzcIA1UocH27tjCC1Et/vc59UPUcPxFkGhDg2biWoqg0UY9eyqdbaKc U/4MXgWZCeq+6zfyJtun/Kn5zYCvt7cZqV6cp8hBlfpZC9Uj5lQvgJ0gqLCLI9le7XKI /jMlKnC+iZBD9N/m0/b4PsM/CMalP1cKBiB+BXYlVG4X/3UPzcdjEQ6UtmXBySh75pmK zJHtWcc/galaDt1aqHrcWJwic2EqnZWahCprwHJGHjGiMmze+MTm6D14P1ca1zVohTTl P4MeYyehLKyAt+7PsKcAYgAgsy3JvPVDIsTO7AQr7N7zO3GyF+RmGbRQ9obogFJAHEpT ZIPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=32//tTs6zkn7wIdB7N5ZrVMGbcW+GGOiSnhchsA3dCg=; b=c/HM36XQF5fW/9MTXX/NJifysmjJ9AEoHRw6CcNtE9EjMhBypzZxzByFI9d/8SjVpN LKYjTZuGP8yOgsiKkKqYq63OO19qeANOO7Of8wINT77j6r8EZ35DKRlatva2KlNkfZpO rFIeyR8IDJPAiy8d/VyLli0RTemhUmt4xwuDA+fPQWoOumuGJTbxaiiKwnSwQEug3Rtu st5sWMyy4WGspJeRuJSv/Qi6BE5iy+jflDeb48VX+rNjsG00CoCOuOCxAO2vKR+FEubX o5V1K8sb7Lu/qkPvsJ8Sbq62jblUHlpYWJCpLNA5JXUsf1xn62F0kJHI1DcOdX7S1UpU 4RhQ== X-Gm-Message-State: AOAM531eKcXZmH+LmUX2OKiVcyZoHstdR7T1nVzVXrSG27b0TCuURYg3 QaAJkQ426wnY87CELUCDU5o= X-Google-Smtp-Source: ABdhPJyh0Z3HWcZk97dXACmsP0GSv77hlUnKoZJXMpIgfzP5aRMrHhPk39NASasCHMNNbiKtyefTIA== X-Received: by 2002:adf:ce85:: with SMTP id r5mr5505273wrn.343.1644242212246; Mon, 07 Feb 2022 05:56:52 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:ae9c:f7e1:47ab:fed]) by smtp.gmail.com with ESMTPSA id u11sm4120833wrt.108.2022.02.07.05.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 05:56:51 -0800 (PST) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#53762: Improve error message when during url retrieving network connection is lost References: <0alb06p4adi7DfKd_YPyh8NxSUppew_01ob8lx_aj8JtmGdl8TnKXWlLBxm8hqn4JNeGVK8uq97s-Y_46aFsR6ah16xHQGr7Wvbjq8Cp3HY=@protonmail.com> <87r18j7yfi.fsf@gmail.com> <87pmo1dcmc.fsf@gnus.org> Date: Mon, 07 Feb 2022 14:56:50 +0100 In-Reply-To: <87pmo1dcmc.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 05 Feb 2022 07:57:31 +0100") Message-ID: <87bkzi93vh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53762 Cc: 53762@debbugs.gnu.org, emacsq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sat, 05 Feb 2022 07:57:31 +0100, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> Does something like this do the trick? I=CA=BCve not been able to ge= t a >> reliable test case for it yet. Lars> [...] >> if (! EQ (p->status, Qrun)) >> - error ("Process %s not running", SDATA (p->name)); >> + error ("Process %s %s", SDATA (p->name), SDATA (status_message = (p))); Lars> I think that's probably an improvement over what we have now, but= I Lars> don't really have a good test case, either. But perhaps "not run= ning" Lars> should be kept, and the status message just be appended? Sure, that can be done. Does the patch actually solve the problem, emacsq? Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 07 11:49:06 2022 Received: (at 53762) by debbugs.gnu.org; 7 Feb 2022 16:49:06 +0000 Received: from localhost ([127.0.0.1]:43573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nH7CM-0003J3-5P for submit@debbugs.gnu.org; Mon, 07 Feb 2022 11:49:06 -0500 Received: from mail-40130.protonmail.ch ([185.70.40.130]:41795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nH7CK-0003IR-EP for 53762@debbugs.gnu.org; Mon, 07 Feb 2022 11:49:05 -0500 Date: Mon, 07 Feb 2022 16:48:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail2; t=1644252538; bh=MsOIqbKoWQtKyVR5hYXH2I1NuJlttdAoKivDKoAH/VY=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=wTC+jAYEazrsjK0iyOvOfb08jM+/09FS9AbGgvsRwgPNijQhFjXI6a3xRQLInPro6 RVuI6hIPjc6yEVMQWkNDxxtXDmHW4T0wn/Zhk4hP3EhAe861+wsQRYAwICCgH7T5eE 6FVf9lFCwDqyZKWwmbtHJwCRJIUGN5Un+ND4XcJUvcG9JOds8O03Ho7gCj/aS8OwS9 jEDweaTcjGPf8PSecGVEWMiGJ2NXk/hKlqUN8bEbAF7xySODOzVlMiWU4zpWy7krmq AVRhZ6RFHuZ3WsPWCRMmziUEvVkaBdlSdKBm8MpEYrGg2Aq6jaOKTS+xuTn5dWJ5mp ggWtMis017T3w== To: Robert Pluim From: emacsq Subject: Re: bug#53762: Improve error message when during url retrieving network connection is lost Message-ID: In-Reply-To: <87bkzi93vh.fsf@gmail.com> References: <0alb06p4adi7DfKd_YPyh8NxSUppew_01ob8lx_aj8JtmGdl8TnKXWlLBxm8hqn4JNeGVK8uq97s-Y_46aFsR6ah16xHQGr7Wvbjq8Cp3HY=@protonmail.com> <87r18j7yfi.fsf@gmail.com> <87pmo1dcmc.fsf@gnus.org> <87bkzi93vh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53762 Cc: 53762@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: emacsq Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Sure, that can be done. Does the patch actually solve the problem, emacsq? We have information if it's a network connection: if (NETCONN_P (proc)) So using that we can improve the message. Something like: if (NETCONN_P (proc)) "Network error: " else "Process not running: " From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 08 03:41:02 2022 Received: (at 53762) by debbugs.gnu.org; 8 Feb 2022 08:41:02 +0000 Received: from localhost ([127.0.0.1]:45166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHM3a-0000ph-Da for submit@debbugs.gnu.org; Tue, 08 Feb 2022 03:41:02 -0500 Received: from mail-wr1-f42.google.com ([209.85.221.42]:33358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHM3Y-0000p6-Pa for 53762@debbugs.gnu.org; Tue, 08 Feb 2022 03:41:01 -0500 Received: by mail-wr1-f42.google.com with SMTP id e3so15362351wra.0 for <53762@debbugs.gnu.org>; Tue, 08 Feb 2022 00:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=ZhDaEV6kr5V3NQFLfgEPDnxhv1PfkVxZC1Yn6HDSgCE=; b=jgb8PlQ5m68knjP5VIb32SGcpTxGaXERDSGm92UeVxFbvIeG4OtQVW+XTdXVI28kcN haJi9ZnADqazHwlFxX+y9OtNV1RloM6bA26OwC22oIysfnMiZRpO9k/txWh3b0+y5vnS ykOcEHRFlHKE6V0sWm7Fd49qa5wF78dVWw47SI34RldCm0dGvwJ+ol8tdQf5ZCmuyNlg bUaVLPbvRpeYvDpYuAb/bUzowCmKuYAyrY45arLxOS6kMks58+UPifqqHWp2d7aiCaKk L01hJxW+lP/6nh3Ixm6CX3ckRGZawCSjJ4shpMpFa0JBnmGIhP2bJFMWgsQkJk8Z50Mk waVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=ZhDaEV6kr5V3NQFLfgEPDnxhv1PfkVxZC1Yn6HDSgCE=; b=v1mv31pydQClpoyyOVpSr5aqEGH3QhqPSdbNy99dfqUfyFl8tMklaMeURZ7l/4wQX8 KYEdSHpfyOE2cs/D8fXBXF93zDGe9X3YUjfS6ZJJp/BkE1TxyU7kqILlHJT0BZBwBzHG 9fJWnPMKdl3VfkIn1ejUSdyzcsVQ+5Noqlf60Zj/tgP7YBVUEe1NuNQpWjSwrnzK3p8/ JxPDgYi9f7lb3Zl+jU51hPgt89SMn1pblWpX8I5xf1L5T1cxJD0kJS/bH5dDq1vxG3Vk 4yyJu6Nx/Ga73WDC+L1EVAdzGkBKdwVj8l4UIgwUoqEk9zODQnk28fX+JgGxR2eHbeY5 uw4g== X-Gm-Message-State: AOAM531Gfvs0LsAzhAQAUTKejtDWsCri14VzS+3kfLju3wlc1bkiNH3B HW7te902bzFqf/p5WMQQeRE= X-Google-Smtp-Source: ABdhPJxBxdCz5oVBXlyZuX4271GiL4P+cgqmZf/pB/wzUme/Y7qOkx/EgtUhL5YXequpYqPHPFiDQg== X-Received: by 2002:a05:6000:1b8a:: with SMTP id r10mr2591279wru.665.1644309654980; Tue, 08 Feb 2022 00:40:54 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:ae9c:f7e1:47ab:fed]) by smtp.gmail.com with ESMTPSA id z1sm1412911wmk.32.2022.02.08.00.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 00:40:54 -0800 (PST) From: Robert Pluim To: emacsq Subject: Re: bug#53762: Improve error message when during url retrieving network connection is lost References: <0alb06p4adi7DfKd_YPyh8NxSUppew_01ob8lx_aj8JtmGdl8TnKXWlLBxm8hqn4JNeGVK8uq97s-Y_46aFsR6ah16xHQGr7Wvbjq8Cp3HY=@protonmail.com> <87r18j7yfi.fsf@gmail.com> <87pmo1dcmc.fsf@gnus.org> <87bkzi93vh.fsf@gmail.com> Date: Tue, 08 Feb 2022 09:40:53 +0100 In-Reply-To: (emacsq via's message of "Mon, 07 Feb 2022 16:48:57 +0000") Message-ID: <87a6f17nu2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53762 Cc: 53762@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 07 Feb 2022 16:48:57 +0000, emacsq via "Bug reports for GNU E= macs, the Swiss army knife of text editors" said: >> Sure, that can be done. Does the patch actually solve the problem, emacsq> emacsq? emacsq> We have information if it's a network connection: if (NETCONN_P= (proc)) emacsq> So using that we can improve the message. Something like: emacsq> if (NETCONN_P (proc)) emacsq> "Network error: " emacsq> else emacsq> "Process not running: " `status_message' already produces different messages based on whether it=CA=BCs a network connection, so I don=CA=BCt think that=CA=BCs necessary. Have you been able to try the original patch? I now realise that you=CA=BCre on windows, which explains why you were seeing problems originally. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 08 16:50:17 2022 Received: (at 53762) by debbugs.gnu.org; 8 Feb 2022 21:50:17 +0000 Received: from localhost ([127.0.0.1]:48937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHYNN-00057Y-D2 for submit@debbugs.gnu.org; Tue, 08 Feb 2022 16:50:17 -0500 Received: from mail-40138.protonmail.ch ([185.70.40.138]:40813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHYNL-000579-4n for 53762@debbugs.gnu.org; Tue, 08 Feb 2022 16:50:15 -0500 Date: Tue, 08 Feb 2022 21:50:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1644357008; bh=RN0YFcGafGUPiYSFLINWHXNQbsboRVrY//qzUMDLcbw=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=ENqQBSER/IgYLQAkP3PXi7dKtXQSz+Ch5v+h9PE4Ttt02Sa15074uy8LO+YClqFAp whTeH8KMhiXRe2q8l3TGhGuq7KPu60uIlYBSxJ2CTLU6S6rmQhDVCcY5IYCrhMGTHU v3RnIaU8O82lNAPBNPTU8aYG//vKKafcNw66S/cp2hklaomGZJtV+AtWUHpuaqARL5 cdGJ82vpqIKWsmm4CEY9oufgNVn5KbGTCR16MSEc3U6ER/B71JNfEQ4SbxgA5P3BzJ TzFivqfp5ZcYKvoCk3IRR0yptnvMKWicjLQOdNO2d13gyGQ/0J3RK5FzJ4w1+rD+cL 1tvr+cqDwOm3w== To: Robert Pluim From: emacsq Subject: Re: bug#53762: Improve error message when during url retrieving network connection is lost Message-ID: In-Reply-To: <87a6f17nu2.fsf@gmail.com> References: <0alb06p4adi7DfKd_YPyh8NxSUppew_01ob8lx_aj8JtmGdl8TnKXWlLBxm8hqn4JNeGVK8uq97s-Y_46aFsR6ah16xHQGr7Wvbjq8Cp3HY=@protonmail.com> <87r18j7yfi.fsf@gmail.com> <87pmo1dcmc.fsf@gnus.org> <87bkzi93vh.fsf@gmail.com> <87a6f17nu2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53762 Cc: 53762@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: emacsq Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > `status_message' already produces different messages based on whether it=CA=BCs a network connection, so I don=CA=BCt think that=CA=BCs necessary= . Sounds good. I don't have a C compilation environment set up on windows to try the patch, but it's an improvement over the current message, so AFAIC this bug can be closed with this fix. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 16 13:59:53 2022 Received: (at 53762) by debbugs.gnu.org; 16 Mar 2022 17:59:54 +0000 Received: from localhost ([127.0.0.1]:52264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUXw9-0006Pl-GY for submit@debbugs.gnu.org; Wed, 16 Mar 2022 13:59:53 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:39645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUXw7-0006PT-FY; Wed, 16 Mar 2022 13:59:52 -0400 Received: by mail-wr1-f46.google.com with SMTP id h15so4073564wrc.6; Wed, 16 Mar 2022 10:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=tT/4M1hqC7PROmoCx7IAyTeJblEd56rzCvprXF2F7K0=; b=XRoWjQGuIa2+MzaNCYJJLZKtfcBR1yXxwOWogdSUtVeYEvjsam8zA1iRC9CeAnikFj e/99gjGw9tOIYhrU/QtcbejD9t8GhVblHge9kQ3KwWnQwQz9BHDEt9Ph+JQ5+vSi9h0F TwsSc5jZmLwKP7MZne1r83zgV5ezMZuDNNQL4aVPar3WHxTEXzrN/LsGuY0DNNqSoLjK kYqxS3MuUA0vIkMTpK0IVaPMLL7GYqqWDMMaNfZOchBPbbLjR5gKuJv/JeQCNDLvC4J+ upzcQseTfXzt+FsbEDS3EKxolRfUr9Suiok0YuDpa3IzcS1TYHKlUUtO0+OEKNt6UipD cCfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=tT/4M1hqC7PROmoCx7IAyTeJblEd56rzCvprXF2F7K0=; b=TLl9d5urbeLrt70DFN4cc36dbjoichez5VCv6zDmlLYU9Hc+G1MeaYETrvBjMXqfZC xsKdVV4k1tcN8WNkwvKEmp4XTaNCazYvzHD/Isq+Yt+HiXY5Q7WRaxvEBRZaQI5gwVYe EYUfxW9z37tQRime16ERAqhjVrUJ9JOWDl3KG1hqLKIl0ingKb9ITfhQdWM+doxQ5BHf vINzo/haDkdNY+mjedxzFp5+EY6B6SxmgNdXMttEWqs4e7pGXVXdVRnD8TAjMD//1lQe lYyoEC0Bw64h15BPqITdOd5XxZAuNN4PMMS9WgmyJiMTkaQvmxvzM3eDqEfDnDo+1FVj 33og== X-Gm-Message-State: AOAM530M4I2jQDjm8DvA9nvhJ+ZTQi3UDXRRaAT0gHkDvsaTBI8y4cHe 3vO6qvu2t67OJzZlBQc+CooMS6aF4+s= X-Google-Smtp-Source: ABdhPJxiCQDon92ruKjYFPapIPrat/CQ2FF3x3PJo1IO8hTktHj5C/RDWw/6sYDwyaKv5wa5z+vvYQ== X-Received: by 2002:adf:f244:0:b0:203:d527:317d with SMTP id b4-20020adff244000000b00203d527317dmr837937wrp.672.1647453585030; Wed, 16 Mar 2022 10:59:45 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:3fdc:5468:a6c5:c9b4]) by smtp.gmail.com with ESMTPSA id l12-20020a05600012cc00b001f059bcbd7asm2104627wrx.31.2022.03.16.10.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 10:59:44 -0700 (PDT) From: Robert Pluim To: emacsq Subject: Re: bug#53762: Improve error message when during url retrieving network connection is lost References: <0alb06p4adi7DfKd_YPyh8NxSUppew_01ob8lx_aj8JtmGdl8TnKXWlLBxm8hqn4JNeGVK8uq97s-Y_46aFsR6ah16xHQGr7Wvbjq8Cp3HY=@protonmail.com> <87r18j7yfi.fsf@gmail.com> <87pmo1dcmc.fsf@gnus.org> <87bkzi93vh.fsf@gmail.com> <87a6f17nu2.fsf@gmail.com> Date: Wed, 16 Mar 2022 18:59:43 +0100 In-Reply-To: (emacsq's message of "Tue, 08 Feb 2022 21:50:07 +0000") Message-ID: <87ee31bwxc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53762 Cc: 53762@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 53762 fixed close 53762 29.1 quit >>>>> On Tue, 08 Feb 2022 21:50:07 +0000, emacsq said: >> `status_message' already produces different messages based on whether emacsq> it=CA=BCs a network connection, so I don=CA=BCt think that=CA= =BCs necessary. emacsq> Sounds good. I don't have a C compilation environment set up on emacsq> windows to try the patch, but it's an improvement over the curr= ent emacsq> message, so AFAIC this bug can be closed with this fix. Closing. Committed as fa8c93ad9a From unknown Sun Jun 22 07:49:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 14 Apr 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator