GNU bug report logs - #5374
vc-find-file-hook in batch?

Previous Next

Package: emacs;

Reported by: Lennart Borgman <lennart.borgman <at> gmail.com>

Date: Wed, 13 Jan 2010 10:30:03 UTC

Severity: minor

Tags: moreinfo

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5374 in the body.
You can then email your comments to 5374 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5374; Package emacs. (Wed, 13 Jan 2010 10:30:03 GMT) Full text and rfc822 format available.
Acknowledgement sent to Lennart Borgman <lennart.borgman <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 13 Jan 2010 10:30:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: vc-find-file-hook in batch?
Date: Wed, 13 Jan 2010 11:28:34 +0100

Should really vc-find-file-hook be in find-file-hook when Emacs is run
in batch? Could not that create problems?
Added tag(s) moreinfo. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Fri, 15 Jan 2010 02:35:02 GMT) Full text and rfc822 format available.
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5374; Package emacs. (Tue, 12 Jul 2011 00:16:02 GMT) Full text and rfc822 format available.

Message #10 received at 5374 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 5374 <at> debbugs.gnu.org
Subject: Re: bug#5374: vc-find-file-hook in batch?
Date: Mon, 11 Jul 2011 20:15:06 -0400

Lennart Borgman wrote:

> Should really vc-find-file-hook be in find-file-hook when Emacs is run
> in batch? Could not that create problems?

Can you give an example of a problem?
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5374; Package emacs. (Tue, 12 Jul 2011 11:10:02 GMT) Full text and rfc822 format available.

Message #13 received at 5374 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 5374 <at> debbugs.gnu.org
Subject: Re: bug#5374: vc-find-file-hook in batch?
Date: Tue, 12 Jul 2011 13:08:39 +0200

On Tue, Jul 12, 2011 at 02:15, Glenn Morris <rgm <at> gnu.org> wrote:
> Lennart Borgman wrote:
>
>> Should really vc-find-file-hook be in find-file-hook when Emacs is run
>> in batch? Could not that create problems?
>
> Can you give an example of a problem?

In some cases I run a lot of batch jobs from Emacs (to be sure about
what is loaded in Emacs).
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5374; Package emacs. (Tue, 12 Jul 2011 16:04:01 GMT) Full text and rfc822 format available.

Message #16 received at 5374 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 5374 <at> debbugs.gnu.org
Subject: Re: bug#5374: vc-find-file-hook in batch?
Date: Tue, 12 Jul 2011 12:03:48 -0400

Lennart Borgman <lennart.borgman <at> gmail.com> writes:

> On Tue, Jul 12, 2011 at 02:15, Glenn Morris <rgm <at> gnu.org> wrote:
>> Lennart Borgman wrote:
>>
>>> Should really vc-find-file-hook be in find-file-hook when Emacs is run
>>> in batch? Could not that create problems?
>>
>> Can you give an example of a problem?
>
> In some cases I run a lot of batch jobs from Emacs (to be sure about
> what is loaded in Emacs).

This is not an example of problem.  Can you give an example of a problem
that vc-find-file-hook causes?
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5374; Package emacs. (Tue, 12 Jul 2011 16:18:01 GMT) Full text and rfc822 format available.

Message #19 received at 5374 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 5374 <at> debbugs.gnu.org
Subject: Re: bug#5374: vc-find-file-hook in batch?
Date: Tue, 12 Jul 2011 18:17:07 +0200

On Tue, Jul 12, 2011 at 18:03, Chong Yidong <cyd <at> stupidchicken.com> wrote:
> Lennart Borgman <lennart.borgman <at> gmail.com> writes:
>
>> On Tue, Jul 12, 2011 at 02:15, Glenn Morris <rgm <at> gnu.org> wrote:
>>> Lennart Borgman wrote:
>>>
>>>> Should really vc-find-file-hook be in find-file-hook when Emacs is run
>>>> in batch? Could not that create problems?
>>>
>>> Can you give an example of a problem?
>>
>> In some cases I run a lot of batch jobs from Emacs (to be sure about
>> what is loaded in Emacs).
>
> This is not an example of problem.  Can you give an example of a problem
> that vc-find-file-hook causes?

It takes a lot of time to run the hook in this case, but other than
that I see no problem.
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Fri, 15 Jul 2011 22:06:01 GMT) Full text and rfc822 format available.
Notification sent to Lennart Borgman <lennart.borgman <at> gmail.com>:
bug acknowledged by developer. (Fri, 15 Jul 2011 22:06:02 GMT) Full text and rfc822 format available.

Message #24 received at 5374-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 5374-done <at> debbugs.gnu.org
Subject: Re: bug#5374: vc-find-file-hook in batch?
Date: Fri, 15 Jul 2011 18:05:19 -0400

Lennart Borgman wrote:

> It takes a lot of time to run the hook in this case, but other than
> that I see no problem.

OK. I don't think is reason enough to remove vc-find-file-hook in batch
mode though. You can always remove it in your own personal use if you
feel it necessary.
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5374; Package emacs. (Mon, 18 Jul 2011 14:45:02 GMT) Full text and rfc822 format available.

Message #27 received at 5374 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 5374 <at> debbugs.gnu.org
Cc: rgm <at> gnu.org
Subject: Re: bug#5374: vc-find-file-hook in batch?
Date: Mon, 18 Jul 2011 10:44:21 -0400

>> It takes a lot of time to run the hook in this case, but other than
>> that I see no problem.
> OK. I don't think is reason enough to remove vc-find-file-hook in batch
> mode though. You can always remove it in your own personal use if you
> feel it necessary.

If it's a performance problem, the right fix is to profile it, find the
culprit and fix it.  Disabling vc-find-file-hook would just workaround
the problem.


        Stefan
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 16 Aug 2011 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 25 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.