GNU bug report logs - #53738
[PATCH] gnu: nyxt: Add missing input.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Wed, 2 Feb 2022 22:07:02 UTC

Severity: normal

Tags: patch

Done: Guillaume Le Vaillant <glv <at> posteo.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53738 in the body.
You can then email your comments to 53738 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#53738; Package guix-patches. (Wed, 02 Feb 2022 22:07:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 02 Feb 2022 22:07:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: nyxt: Add missing input.
Date: Wed,  2 Feb 2022 17:05:16 -0500
* gnu/packages/web-browsers.scm (nyxt)[inputs]: Add sbcl-cl-gopher.
---
 gnu/packages/web-browsers.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index c49e3ceac5..1aec6d6adc 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -639,6 +639,7 @@ (define-public nyxt
        ("cl-containers" ,sbcl-cl-containers)
        ("cl-css" ,sbcl-cl-css)
        ("cl-custom-hash-table" ,sbcl-custom-hash-table)
+       ("cl-gopher" ,sbcl-cl-gopher)
        ("cl-html-diff" ,sbcl-cl-html-diff)
        ("cl-json" ,sbcl-cl-json)
        ("cl-ppcre" ,sbcl-cl-ppcre)
-- 
2.35.0





Information forwarded to guix-patches <at> gnu.org:
bug#53738; Package guix-patches. (Thu, 03 Feb 2022 10:02:01 GMT) Full text and rfc822 format available.

Message #8 received at 53738 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: jgart <jgart <at> dismail.de>
Cc: 53738 <at> debbugs.gnu.org
Subject: Re: [bug#53738] [PATCH] gnu: nyxt: Add missing input.
Date: Thu, 03 Feb 2022 09:49:26 +0000
[Message part 1 (text/plain, inline)]
jgart via Guix-patches via <guix-patches <at> gnu.org> skribis:

> * gnu/packages/web-browsers.scm (nyxt)[inputs]: Add sbcl-cl-gopher.
> ---
>  gnu/packages/web-browsers.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index c49e3ceac5..1aec6d6adc 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -639,6 +639,7 @@ (define-public nyxt
>         ("cl-containers" ,sbcl-cl-containers)
>         ("cl-css" ,sbcl-cl-css)
>         ("cl-custom-hash-table" ,sbcl-custom-hash-table)
> +       ("cl-gopher" ,sbcl-cl-gopher)
>         ("cl-html-diff" ,sbcl-cl-html-diff)
>         ("cl-json" ,sbcl-cl-json)
>         ("cl-ppcre" ,sbcl-cl-ppcre)

Hi,

What issue is solved by adding cl-gopher to inputs?

As far as I can see the source code for Nyxt 2.2.4 doesn't contain any
reference to cl-gopher, so just adding it to inputs will not change the
produced nyxt program.

According to the upstream repository, support for Gopher and Gemini will
be in Nyxt 3.0.0, which has not been released yet.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#53738; Package guix-patches. (Thu, 03 Feb 2022 21:39:01 GMT) Full text and rfc822 format available.

Message #11 received at 53738 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 53738 <at> debbugs.gnu.org
Subject: Re: [bug#53738] [PATCH] gnu: nyxt: Add missing input.
Date: Thu, 3 Feb 2022 16:37:54 -0500
On Thu, 03 Feb 2022 09:49:26 +0000 Guillaume Le Vaillant <glv <at> posteo.net> wrote:
> jgart via Guix-patches via <guix-patches <at> gnu.org> skribis:
> 
> > * gnu/packages/web-browsers.scm (nyxt)[inputs]: Add sbcl-cl-gopher.
> > ---
> >  gnu/packages/web-browsers.scm | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> > index c49e3ceac5..1aec6d6adc 100644
> > --- a/gnu/packages/web-browsers.scm
> > +++ b/gnu/packages/web-browsers.scm
> > @@ -639,6 +639,7 @@ (define-public nyxt
> >         ("cl-containers" ,sbcl-cl-containers)
> >         ("cl-css" ,sbcl-cl-css)
> >         ("cl-custom-hash-table" ,sbcl-custom-hash-table)
> > +       ("cl-gopher" ,sbcl-cl-gopher)
> >         ("cl-html-diff" ,sbcl-cl-html-diff)
> >         ("cl-json" ,sbcl-cl-json)
> >         ("cl-ppcre" ,sbcl-cl-ppcre)
> 
> Hi,
> 
> What issue is solved by adding cl-gopher to inputs?
> 
> As far as I can see the source code for Nyxt 2.2.4 doesn't contain any
> reference to cl-gopher, so just adding it to inputs will not change the
> produced nyxt program.
> 
> According to the upstream repository, support for Gopher and Gemini will
> be in Nyxt 3.0.0, which has not been released yet.

Ah ok. I was accidently reading the master branch latest commit instead
of version 2.2.4.

https://github.com/atlas-engineer/nyxt/blob/16a89132fdbf56c713033edcc2d4611f06199f3c/source/mode/small-web.lisp#L18

Sorry, yes, let's wait.

all best,

jgart




Reply sent to Guillaume Le Vaillant <glv <at> posteo.net>:
You have taken responsibility. (Thu, 03 Feb 2022 22:23:02 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Thu, 03 Feb 2022 22:23:02 GMT) Full text and rfc822 format available.

Message #16 received at 53738-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: jgart <jgart <at> dismail.de>
Cc: 53738-done <at> debbugs.gnu.org
Subject: Re: [bug#53738] [PATCH] gnu: nyxt: Add missing input.
Date: Thu, 03 Feb 2022 22:20:28 +0000
[Message part 1 (text/plain, inline)]
jgart <jgart <at> dismail.de> skribis:

> Ah ok. I was accidently reading the master branch latest commit instead
> of version 2.2.4.
>
> https://github.com/atlas-engineer/nyxt/blob/16a89132fdbf56c713033edcc2d4611f06199f3c/source/mode/small-web.lisp#L18
>
> Sorry, yes, let's wait.
>
> all best,
>
> jgart

Thanks for confirming.
Closing for now.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 04 Mar 2022 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 108 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.