From unknown Wed Aug 20 05:17:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#53725] [PATCH] gnu: mlt: Wrap LADSPA_PATH and FREI0R_PATH. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Feb 2022 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53725 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53725@debbugs.gnu.org Cc: Vinicius Monego X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164381716824059 (code B ref -1); Wed, 02 Feb 2022 15:53:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Feb 2022 15:52:48 +0000 Received: from localhost ([127.0.0.1]:53145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFHw8-0006Fz-CL for submit@debbugs.gnu.org; Wed, 02 Feb 2022 10:52:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:34918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFHw5-0006Fr-RP for submit@debbugs.gnu.org; Wed, 02 Feb 2022 10:52:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFHw4-0003dy-3g for guix-patches@gnu.org; Wed, 02 Feb 2022 10:52:44 -0500 Received: from mout02.posteo.de ([185.67.36.66]:44319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFHw0-00056J-OI for guix-patches@gnu.org; Wed, 02 Feb 2022 10:52:43 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id A1529240104 for ; Wed, 2 Feb 2022 16:52:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1643817157; bh=SufQsEkq5f5uCFoMJ7y+5zWoip+Kpsp+uHy2O/bORA4=; h=From:To:Cc:Subject:Date:From; b=Ubb9CYsQ9Qi0fawc0CoSC+XzvycmYgIOBOAR6kzwmwb7GeFC/E0mRQScxb6Ygbcut 3buW5nZ1OgwJctdCQWu6rRTlrrfujHs9LDvc568kaELBI771A92mXusSURhBNxC7DJ 0DXNfLDcHn3lnJmJjtZCGlrEBfsYPvnS1ltRDL+XETRkj6s0k2CfT0ic2ZxgnoK04G O8xGCikcaArbrPKNdeK6P0Cy2q2jof1jAcsv2lf3Qhyok543c47kB9tINAPP88iZzK DlNKQ30RGaFGGz3rlfkJFM1DnxP8uLE79w3/pvNE8DN9aIluoy4YO43rFDdq6gI64s xxFitollWz/6A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JpmXN5TcXz6tmX; Wed, 2 Feb 2022 16:52:36 +0100 (CET) From: Vinicius Monego Date: Wed, 2 Feb 2022 15:52:21 +0000 Message-Id: <20220202155221.289085-1-monego@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=monego@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/video.scm (mlt)[arguments]: Use gexps. Add 'wrap-executable phase. [inputs]: Add bash-minimal. --- Sending to list for comments about the symlink workaround. The linter also complains about alsa-plugins input, but I don't know what to do about it. gnu/packages/video.scm | 34 +++++++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 8a903f6fe1..68cd5d3f83 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -3208,18 +3208,34 @@ from sites like Twitch.tv and pipes them into a video player of choice.") (base32 "17d4gs46ca3n0qg6z69hl6mmllnqj2id8ccrv8fyz8c5zm55ghqm")))) (build-system cmake-build-system) (arguments - `(#:tests? #f ;requires "Kwalify" - #:phases - (modify-phases %standard-phases - (add-before 'configure 'override-LDFLAGS - (lambda* (#:key outputs #:allow-other-keys) - (setenv "LDFLAGS" - (string-append - "-Wl,-rpath=" - (assoc-ref outputs "out") "/lib"))))))) + (list + #:tests? #f ;requires "Kwalify" + #:phases + #~(modify-phases %standard-phases + (add-before 'configure 'override-LDFLAGS + (lambda _ + (setenv "LDFLAGS" + (string-append "-Wl,-rpath=" #$output "/lib")))) + (add-after 'install 'wrap-executable + (lambda _ + (let* ((frei0r #$(this-package-input "frei0r-plugins")) + (ladspa #$(this-package-input "ladspa")) + ;; In MLT 7, 'melt' symlinks to 'melt-7'. Try to keep + ;; compatibility with MLT 6 where it's only 'melt'. + (major #$(version-major version)) + (exec (if (file-exists? + (string-append #$output "/bin/melt-" major)) + (string-append "melt-" major) + "melt"))) + (wrap-program (string-append #$output "/bin/" exec) + `("FREI0R_PATH" ":" = + (,(string-append frei0r "/lib/frei0r-1"))) + `("LADSPA_PATH" ":" = + (,(string-append ladspa "/lib/ladspa")))))))))) (inputs (list alsa-lib `(,alsa-plugins "pulseaudio") + bash-minimal ffmpeg fftw frei0r-plugins -- 2.30.2 From unknown Wed Aug 20 05:17:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#53725] [PATCH] gnu: mlt: Wrap LADSPA_PATH and FREI0R_PATH. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 03 Mar 2022 22:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53725 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 53725@debbugs.gnu.org Received: via spool by 53725-submit@debbugs.gnu.org id=B53725.16463475982552 (code B ref 53725); Thu, 03 Mar 2022 22:47:02 +0000 Received: (at 53725) by debbugs.gnu.org; 3 Mar 2022 22:46:38 +0000 Received: from localhost ([127.0.0.1]:44086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPuDV-0000f5-R4 for submit@debbugs.gnu.org; Thu, 03 Mar 2022 17:46:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPuDT-0000eq-RZ for 53725@debbugs.gnu.org; Thu, 03 Mar 2022 17:46:36 -0500 Received: from [2001:470:142:3::e] (port=59998 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPuDO-0007sC-I1; Thu, 03 Mar 2022 17:46:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=EDezppC/gc2HCNNl582yTCiBtAn1ALaib1fJ2ZnRnTU=; b=pK7twwzrXCFjVoRVEIjq 6twAGFERxZ6T4JsQEGlxBhcyMgBziXwN4ua/cN2jsm/Ud6ASvp9IdQUZFeTu/PgdN+iNzKSkmfPob 2F1AcmCPBRef91cfgAbR0UGbDN5RdtUTG1ZVFUTtDmu5aMbnFVye+wRsAT1MF6z2Ye00o5q/36ABH fQqvM/GlTLx5v8H9wGqWqTg5a2kw6DACgcXtEJnYKHsdB+x2hNyFuwg9r0pold0h+f07FUkOMzYRg faHk/jNVDuOmIxMNfqdKc/jJyKNjJLmxRVqT1RzYccSHeJ/Py18BjfMyEUJbqrGu5rO8cRpxlEsLY EuMWaxkvgin5+g==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:50104 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPuDO-00014r-3y; Thu, 03 Mar 2022 17:46:30 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220202155221.289085-1-monego@posteo.net> Date: Thu, 03 Mar 2022 23:46:28 +0100 In-Reply-To: <20220202155221.289085-1-monego@posteo.net> (Vinicius Monego's message of "Wed, 2 Feb 2022 15:52:21 +0000") Message-ID: <87r17iu01n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Vinicius, Vinicius Monego skribis: > * gnu/packages/video.scm (mlt)[arguments]: Use gexps. Add 'wrap-executable > phase. > [inputs]: Add bash-minimal. LGTM, thanks! Ludo=E2=80=99. From unknown Wed Aug 20 05:17:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Vinicius Monego Subject: bug#53725: closed (Re: bug#53725: [PATCH] gnu: mlt: Wrap LADSPA_PATH and FREI0R_PATH.) Message-ID: References: <20220202155221.289085-1-monego@posteo.net> X-Gnu-PR-Message: they-closed 53725 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 53725@debbugs.gnu.org Date: Fri, 04 Mar 2022 01:35:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1646357701-18404-1" This is a multi-part message in MIME format... ------------=_1646357701-18404-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #53725: [PATCH] gnu: mlt: Wrap LADSPA_PATH and FREI0R_PATH. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 53725@debbugs.gnu.org. --=20 53725: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D53725 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1646357701-18404-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 53725-done) by debbugs.gnu.org; 4 Mar 2022 01:34:14 +0000 Received: from localhost ([127.0.0.1]:44238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPwpi-0004lp-AK for submit@debbugs.gnu.org; Thu, 03 Mar 2022 20:34:14 -0500 Received: from mout01.posteo.de ([185.67.36.65]:44183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPwpf-0004lb-SW for 53725-done@debbugs.gnu.org; Thu, 03 Mar 2022 20:34:12 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A655F24002B for <53725-done@debbugs.gnu.org>; Fri, 4 Mar 2022 02:34:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1646357645; bh=ySv4VMQGRjUhWsPkVTAERpsP3PfBtepqKDnnnPd3e2Q=; h=Date:Subject:To:Cc:From:From; b=PLhOJuS4lekwt7FS1LFX7sLUMiJyzJLB2JnnVNcQN4TDbv0QGg2bmi8bsVOElT4j3 hXQi3GyCB80kvKdvvixiHrEuiKpWvgYsRzIVFmNV23lCllnfdnEhTURTjW3rfKpo0M JIo5g+tv6h2ZvhmvL8TI+UI0SCjESdvt/PJ4s59S5HLcYgDMZlOilAuWDiaAll3C1I h6M2XU5HnHIa6Js1LL7nB8NA6COQlGCEFxUHMiwsJu8w79bG4STRPIlYTXnyJ2phoq mmNk9UAsuauHg/T5PjPs/p7JZ++Ner1SEJ2qVXBhmPyIwz0ha7dHCHwC1EIggli5Fe UM7u5usKBSsjg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4K8r3v6BZ4z9rxG; Fri, 4 Mar 2022 02:34:03 +0100 (CET) Message-ID: Date: Fri, 4 Mar 2022 01:34:02 +0000 MIME-Version: 1.0 Subject: Re: bug#53725: [PATCH] gnu: mlt: Wrap LADSPA_PATH and FREI0R_PATH. Content-Language: en-US To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20220202155221.289085-1-monego@posteo.net> <87r17iu01n.fsf@gnu.org> From: Vinicius Monego In-Reply-To: <87r17iu01n.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53725-done Cc: 53725-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 03/03/2022 7:46 PM, Ludovic Courtès wrote: > Hi Vinicius, > > Vinicius Monego skribis: > >> * gnu/packages/video.scm (mlt)[arguments]: Use gexps. Add 'wrap-executable >> phase. >> [inputs]: Add bash-minimal. > LGTM, thanks! > > Ludo’. Thanks! Pushed this followed by an update to mlt. ------------=_1646357701-18404-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Feb 2022 15:52:48 +0000 Received: from localhost ([127.0.0.1]:53145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFHw8-0006Fz-CL for submit@debbugs.gnu.org; Wed, 02 Feb 2022 10:52:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:34918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFHw5-0006Fr-RP for submit@debbugs.gnu.org; Wed, 02 Feb 2022 10:52:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFHw4-0003dy-3g for guix-patches@gnu.org; Wed, 02 Feb 2022 10:52:44 -0500 Received: from mout02.posteo.de ([185.67.36.66]:44319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFHw0-00056J-OI for guix-patches@gnu.org; Wed, 02 Feb 2022 10:52:43 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id A1529240104 for ; Wed, 2 Feb 2022 16:52:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1643817157; bh=SufQsEkq5f5uCFoMJ7y+5zWoip+Kpsp+uHy2O/bORA4=; h=From:To:Cc:Subject:Date:From; b=Ubb9CYsQ9Qi0fawc0CoSC+XzvycmYgIOBOAR6kzwmwb7GeFC/E0mRQScxb6Ygbcut 3buW5nZ1OgwJctdCQWu6rRTlrrfujHs9LDvc568kaELBI771A92mXusSURhBNxC7DJ 0DXNfLDcHn3lnJmJjtZCGlrEBfsYPvnS1ltRDL+XETRkj6s0k2CfT0ic2ZxgnoK04G O8xGCikcaArbrPKNdeK6P0Cy2q2jof1jAcsv2lf3Qhyok543c47kB9tINAPP88iZzK DlNKQ30RGaFGGz3rlfkJFM1DnxP8uLE79w3/pvNE8DN9aIluoy4YO43rFDdq6gI64s xxFitollWz/6A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JpmXN5TcXz6tmX; Wed, 2 Feb 2022 16:52:36 +0100 (CET) From: Vinicius Monego To: guix-patches@gnu.org Subject: [PATCH] gnu: mlt: Wrap LADSPA_PATH and FREI0R_PATH. Date: Wed, 2 Feb 2022 15:52:21 +0000 Message-Id: <20220202155221.289085-1-monego@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=monego@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Vinicius Monego X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/video.scm (mlt)[arguments]: Use gexps. Add 'wrap-executable phase. [inputs]: Add bash-minimal. --- Sending to list for comments about the symlink workaround. The linter also complains about alsa-plugins input, but I don't know what to do about it. gnu/packages/video.scm | 34 +++++++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 8a903f6fe1..68cd5d3f83 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -3208,18 +3208,34 @@ from sites like Twitch.tv and pipes them into a video player of choice.") (base32 "17d4gs46ca3n0qg6z69hl6mmllnqj2id8ccrv8fyz8c5zm55ghqm")))) (build-system cmake-build-system) (arguments - `(#:tests? #f ;requires "Kwalify" - #:phases - (modify-phases %standard-phases - (add-before 'configure 'override-LDFLAGS - (lambda* (#:key outputs #:allow-other-keys) - (setenv "LDFLAGS" - (string-append - "-Wl,-rpath=" - (assoc-ref outputs "out") "/lib"))))))) + (list + #:tests? #f ;requires "Kwalify" + #:phases + #~(modify-phases %standard-phases + (add-before 'configure 'override-LDFLAGS + (lambda _ + (setenv "LDFLAGS" + (string-append "-Wl,-rpath=" #$output "/lib")))) + (add-after 'install 'wrap-executable + (lambda _ + (let* ((frei0r #$(this-package-input "frei0r-plugins")) + (ladspa #$(this-package-input "ladspa")) + ;; In MLT 7, 'melt' symlinks to 'melt-7'. Try to keep + ;; compatibility with MLT 6 where it's only 'melt'. + (major #$(version-major version)) + (exec (if (file-exists? + (string-append #$output "/bin/melt-" major)) + (string-append "melt-" major) + "melt"))) + (wrap-program (string-append #$output "/bin/" exec) + `("FREI0R_PATH" ":" = + (,(string-append frei0r "/lib/frei0r-1"))) + `("LADSPA_PATH" ":" = + (,(string-append ladspa "/lib/ladspa")))))))))) (inputs (list alsa-lib `(,alsa-plugins "pulseaudio") + bash-minimal ffmpeg fftw frei0r-plugins -- 2.30.2 ------------=_1646357701-18404-1--