From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 02 09:41:14 2022 Received: (at submit) by debbugs.gnu.org; 2 Feb 2022 14:41:14 +0000 Received: from localhost ([127.0.0.1]:51939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFGor-0001dm-ST for submit@debbugs.gnu.org; Wed, 02 Feb 2022 09:41:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:44516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFGop-0001dI-97 for submit@debbugs.gnu.org; Wed, 02 Feb 2022 09:41:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFGop-0006Ek-2F for guix-patches@gnu.org; Wed, 02 Feb 2022 09:41:11 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:38700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFGok-0004Os-Bl for guix-patches@gnu.org; Wed, 02 Feb 2022 09:41:10 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id D974881284 for ; Wed, 2 Feb 2022 14:41:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo03-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2ruiEtuGHICp for ; Wed, 2 Feb 2022 14:41:03 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 9764B81014 for ; Wed, 2 Feb 2022 14:41:03 +0000 (UTC) From: Simon South To: guix-patches@gnu.org Subject: [PATCH staging 0/2] gnu: tbb: Fix build on AArch64; update to 2021.5.0. Date: Wed, 2 Feb 2022 09:41:00 -0500 Message-Id: X-Mailer: git-send-email 2.25.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) These patches - Allow the tbb package to build on AArch64 by backporting an upstream commit that prevents one of the test cases from failing on that platform[0], and - Update tbb itself to 2021.5.0. On x86-64 the updated package and its 320 dependents build for me without any new failures: only dealii-openmpi, python-dolfin-adjoint, python-vedo and shogun fail, as they all do presently on the staging branch. On AArch64 the updated package now builds fine and I'm in the (lengthy) process of checking its dependencies, though an unrelated build failure in ceres-solver and the lack of a Haskell compiler limit how far this will go anyway. [0] See https://github.com/oneapi-src/oneTBB/issues/687 -- Simon South simon@simonsouth.net Simon South (2): gnu: tbb: Fix test on AArch64. gnu: tbb: Update to 2021.5.0. gnu/local.mk | 1 + .../patches/tbb-fix-test-on-aarch64.patch | 35 +++++++++++++++++++ gnu/packages/tbb.scm | 8 +++-- 3 files changed, 42 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/tbb-fix-test-on-aarch64.patch base-commit: 1a5302435ff0d2822b823f5a6fe01faa7a85c629 -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 02 09:47:25 2022 Received: (at 53724) by debbugs.gnu.org; 2 Feb 2022 14:47:25 +0000 Received: from localhost ([127.0.0.1]:51949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFGuq-0001ow-Pv for submit@debbugs.gnu.org; Wed, 02 Feb 2022 09:47:24 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:44322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFGup-0001oX-1U for 53724@debbugs.gnu.org; Wed, 02 Feb 2022 09:47:23 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 66EB174533 for <53724@debbugs.gnu.org>; Wed, 2 Feb 2022 14:47:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nA6hHZvcvMBS for <53724@debbugs.gnu.org>; Wed, 2 Feb 2022 14:47:17 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 2D6EF741E0 for <53724@debbugs.gnu.org>; Wed, 2 Feb 2022 14:47:17 +0000 (UTC) From: Simon South To: 53724@debbugs.gnu.org Subject: [PATCH staging 2/2] gnu: tbb: Update to 2021.5.0. Date: Wed, 2 Feb 2022 09:47:06 -0500 Message-Id: X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53724 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/tbb.scm (tbb): Update to 2021.5.0. --- gnu/packages/tbb.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/tbb.scm b/gnu/packages/tbb.scm index ef92e6db69..e8fbc0f97e 100644 --- a/gnu/packages/tbb.scm +++ b/gnu/packages/tbb.scm @@ -31,7 +31,7 @@ (define-module (gnu packages tbb) (define-public tbb (package (name "tbb") - (version "2021.4.0") + (version "2021.5.0") (source (origin (method git-fetch) (uri (git-reference @@ -40,7 +40,7 @@ (define-public tbb (file-name (git-file-name name version)) (sha256 (base32 - "0ih727g802j9lvwkqhw021bk1wb7xlvfgd0vl1i6jng4am1wv7vq")))) + "1z0pqzfx63zrmyqdvvkk8vl5dc0i0n5cimdkrypd50ig4d4yi7sc")) (patches (list ;; Backport an upstream commit that prevents the ;; "test_eh_thread" test failing on AArch64. -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 02 09:47:25 2022 Received: (at 53724) by debbugs.gnu.org; 2 Feb 2022 14:47:25 +0000 Received: from localhost ([127.0.0.1]:51951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFGur-0001oy-0G for submit@debbugs.gnu.org; Wed, 02 Feb 2022 09:47:25 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:44320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFGup-0001oW-27 for 53724@debbugs.gnu.org; Wed, 02 Feb 2022 09:47:23 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 59E0274532 for <53724@debbugs.gnu.org>; Wed, 2 Feb 2022 14:47:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wgn5V4h71MFl for <53724@debbugs.gnu.org>; Wed, 2 Feb 2022 14:47:17 +0000 (UTC) Received: from laptop.simonsouth.net (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 135F97404C for <53724@debbugs.gnu.org>; Wed, 2 Feb 2022 14:47:17 +0000 (UTC) From: Simon South To: 53724@debbugs.gnu.org Subject: [PATCH staging 1/2] gnu: tbb: Fix test on AArch64. Date: Wed, 2 Feb 2022 09:47:05 -0500 Message-Id: <2b93c60ffb8c3ced234c023975a8e35f4bd3ba11.1643812145.git.simon@simonsouth.net> X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53724 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/patches/tbb-fix-test-on-aarch64.patch: New file. * gnu/local.mk: Add it. * gnu/packages/tbb.scm (tbb)[source]: Apply it. --- gnu/local.mk | 1 + .../patches/tbb-fix-test-on-aarch64.patch | 35 +++++++++++++++++++ gnu/packages/tbb.scm | 4 +++ 3 files changed, 40 insertions(+) create mode 100644 gnu/packages/patches/tbb-fix-test-on-aarch64.patch diff --git a/gnu/local.mk b/gnu/local.mk index dceaa53145..ab96d06a34 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1843,6 +1843,7 @@ dist_patch_DATA = \ %D%/packages/patches/tao-fix-parser-types.patch \ %D%/packages/patches/tar-remove-wholesparse-check.patch \ %D%/packages/patches/tar-skip-unreliable-tests.patch \ + %D%/packages/patches/tbb-fix-test-on-aarch64.patch \ %D%/packages/patches/tcc-boot-0.9.27.patch \ %D%/packages/patches/tclxml-3.2-install.patch \ %D%/packages/patches/tcsh-fix-autotest.patch \ diff --git a/gnu/packages/patches/tbb-fix-test-on-aarch64.patch b/gnu/packages/patches/tbb-fix-test-on-aarch64.patch new file mode 100644 index 0000000000..3a6003591e --- /dev/null +++ b/gnu/packages/patches/tbb-fix-test-on-aarch64.patch @@ -0,0 +1,35 @@ +From 013035b4e9af39f506e87ae6b755c3363e768d4d Mon Sep 17 00:00:00 2001 +From: Vladislav Shchapov +Date: Thu, 23 Dec 2021 19:17:24 +0500 +Subject: [PATCH] Fix issue #687 (test_eh_thread) (#697) + +Signed-off-by: Vladislav Shchapov +--- + test/tbb/test_eh_thread.cpp | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/test/tbb/test_eh_thread.cpp b/test/tbb/test_eh_thread.cpp +index aa6d764d..af291f48 100644 +--- a/test/tbb/test_eh_thread.cpp ++++ b/test/tbb/test_eh_thread.cpp +@@ -36,6 +36,7 @@ + // TODO: enable limitThreads with sanitizer under docker + #if TBB_USE_EXCEPTIONS && !_WIN32 && !__ANDROID__ + ++#include + #include + #include + #include +@@ -73,7 +74,8 @@ public: + mValid = false; + pthread_attr_t attr; + // Limit the stack size not to consume all virtual memory on 32 bit platforms. +- if (pthread_attr_init(&attr) == 0 && pthread_attr_setstacksize(&attr, 100*1024) == 0) { ++ std::size_t stacksize = utils::max(128*1024, PTHREAD_STACK_MIN); ++ if (pthread_attr_init(&attr) == 0 && pthread_attr_setstacksize(&attr, stacksize) == 0) { + mValid = pthread_create(&mHandle, &attr, thread_routine, /* arg = */ nullptr) == 0; + } + } +-- +2.34.0 + diff --git a/gnu/packages/tbb.scm b/gnu/packages/tbb.scm index e5d8394f5f..ef92e6db69 100644 --- a/gnu/packages/tbb.scm +++ b/gnu/packages/tbb.scm @@ -41,6 +41,10 @@ (define-public tbb (sha256 (base32 "0ih727g802j9lvwkqhw021bk1wb7xlvfgd0vl1i6jng4am1wv7vq")))) + (patches (list + ;; Backport an upstream commit that prevents the + ;; "test_eh_thread" test failing on AArch64. + (search-patch "tbb-fix-test-on-aarch64.patch"))))) (build-system cmake-build-system) (arguments `(#:configure-flags '("-DTBB_STRICT=OFF"))) ;; Don't fail on warnings -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 04 19:15:35 2022 Received: (at 53724-done) by debbugs.gnu.org; 5 Feb 2022 00:15:36 +0000 Received: from localhost ([127.0.0.1]:33259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nG8jn-0000Qz-Fw for submit@debbugs.gnu.org; Fri, 04 Feb 2022 19:15:35 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:46552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nG8jl-0000Ia-Ep for 53724-done@debbugs.gnu.org; Fri, 04 Feb 2022 19:15:33 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 0386C383; Sat, 5 Feb 2022 01:15:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VD6MsUq8iDED; Sat, 5 Feb 2022 01:15:26 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DF3E5193; Sat, 5 Feb 2022 01:15:25 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon South Subject: Re: bug#53724: [PATCH staging 0/2] gnu: tbb: Fix build on AArch64; update to 2021.5.0. References: Date: Sat, 05 Feb 2022 01:15:25 +0100 In-Reply-To: (Simon South's message of "Wed, 2 Feb 2022 09:41:00 -0500") Message-ID: <87h79ekw2q.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: 0386C383 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 53724-done Cc: 53724-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, Simon South skribis: > These patches > > - Allow the tbb package to build on AArch64 by backporting an upstream co= mmit > that prevents one of the test cases from failing on that platform[0], a= nd > > - Update tbb itself to 2021.5.0. > > On x86-64 the updated package and its 320 dependents build for me without= any > new failures: only dealii-openmpi, python-dolfin-adjoint, python-vedo and > shogun fail, as they all do presently on the staging branch. > > On AArch64 the updated package now builds fine and I'm in the (lengthy) > process of checking its dependencies, though an unrelated build failure in > ceres-solver and the lack of a Haskell compiler limit how far this will go > anyway. Perfect! > gnu: tbb: Fix test on AArch64. > gnu: tbb: Update to 2021.5.0. It=E2=80=99s slightly above the limit stated in the manual but I thought it would be reasonable to have it on =E2=80=98master=E2=80=99, so I did that. Thank you! Ludo=E2=80=99. From unknown Tue Aug 19 23:13:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 05 Mar 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator