From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 12 23:52:47 2010 Received: (at submit) by debbugs.gnu.org; 13 Jan 2010 04:52:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUvDr-0001ke-Ng for submit@debbugs.gnu.org; Tue, 12 Jan 2010 23:52:47 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUvDm-0001kW-Dr for submit@debbugs.gnu.org; Tue, 12 Jan 2010 23:52:47 -0500 Received: from mx10.gnu.org ([199.232.76.166]:53306) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUvDj-000241-5h for submit@debbugs.gnu.org; Tue, 12 Jan 2010 23:52:39 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NUvDh-00033V-U6 for submit@debbugs.gnu.org; Tue, 12 Jan 2010 23:52:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:34050) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NUvDh-00033L-Mg for submit@debbugs.gnu.org; Tue, 12 Jan 2010 23:52:37 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUvDh-00054o-Bz for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 23:52:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUvDd-00053E-Sr for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 23:52:37 -0500 Received: from [199.232.76.173] (port=47453 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUvDd-000537-NP for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 23:52:33 -0500 Received: from mail-fx0-f228.google.com ([209.85.220.228]:54655) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUvDd-00032T-8T for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 23:52:33 -0500 Received: by fxm28 with SMTP id 28so14617565fxm.26 for ; Tue, 12 Jan 2010 20:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=J2m7AMd/bGz7yWijYjzwAZ8hqgoh3li8Qkh04B36To4=; b=QE1QiUxyyXIkT+wA9bxMtI2crkcc1zh0c9VaU3xwzcC5zx3Ly/j9JRRFu8YhIOJaaG 03eJTaapt+e9Ezq0ouUFd59pa6aJaaRNMOZYpnzX6GTurIKcz712FQvAkYuyT05snNcB x3KJyfIDt/B0bxxert+As563b/dKHQ6QfZ4P8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=B+ckvEGrYvY+KQCwmQJiyApF6+yINKpF1ENNCWWCGbmxWJO+suUN7BfOfHkC1Re7o8 zB5upAEHo/nW/BQlkvuzeWlxsHDbXdW0GKNyhsqsnkUhSSc4BgTNEuZQ0ECsYo9J81XA ljLGKwIlX419Qt0MJTbTxbMmeIAkxp9ESpJZI= MIME-Version: 1.0 Received: by 10.239.151.74 with SMTP id q10mr2331799hbb.202.1263358352108; Tue, 12 Jan 2010 20:52:32 -0800 (PST) From: Juanma Barranquero Date: Wed, 13 Jan 2010 05:52:12 +0100 Message-ID: Subject: M-x hexl-mode M-x hexl-mode leaves unwanted ruler To: Bug-Gnu-Emacs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.4 (----) emacs -Q M-x hexl-mode y ; to the question about discarding undo M-x hexl-mode C-c C-c now *scratch* has a ruler, thanks to `header-line-format' containing (:eval (funcall ruler-mode-ruler-function)) while `ruler-mode' is nil (so M-x ruler-mode doesn't remove it). The second call to hexl-mode bypasses most of the hexl-mode initialization, but runs `hexl-mode-hook', which by default contains `hexl-activate-ruler', so the ruler is initialized again. `ruler-mode' already has code to save header-line-format, but it seems like it isn't dealing too well with reentering. So, I think the bug is in ruler-mode. But, what to do? Create a stack of previous header-line-format's? At some point the thing turns ridiculous. In the case above, however, it is a real bug (though harmless) because the unwary user will have a hard time removing the ruler. Still, shouldn't hexl-activate-ruler be a noop when the buffer is already in hexl-mode? It is certainly possible to do M-x hexl-mode ; you have a hexl ruler M-x ruler-mode ; to turn it off M-x hexl-mode ; you get it back but I can't really say whether the user would expect at that point to have a hexl ruler or not in the buffer :-) Juanma From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 30 18:46:58 2010 Received: (at 5370-done) by debbugs.gnu.org; 30 Jun 2010 22:46:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OU63W-0004fl-CK for submit@debbugs.gnu.org; Wed, 30 Jun 2010 18:46:58 -0400 Received: from pantheon-po44.its.yale.edu ([130.132.50.78]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OU63U-0004fg-FR for 5370-done@debbugs.gnu.org; Wed, 30 Jun 2010 18:46:57 -0400 Received: from furry (dhcp128036163215.central.yale.edu [128.36.163.215]) (authenticated bits=0) by pantheon-po44.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o5UMkqlS003242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 30 Jun 2010 18:46:52 -0400 Received: by furry (Postfix, from userid 1000) id 614DAC011; Wed, 30 Jun 2010 18:46:52 -0400 (EDT) From: Chong Yidong To: Juanma Barranquero Subject: Re: M-x hexl-mode M-x hexl-mode leaves unwanted ruler Date: Wed, 30 Jun 2010 18:46:52 -0400 Message-ID: <87mxuct9yb.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 5370-done Cc: 5370-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) > The second call to hexl-mode bypasses most of the hexl-mode > initialization, but runs `hexl-mode-hook', which by default contains > `hexl-activate-ruler', so the ruler is initialized again. `ruler-mode' > already has code to save header-line-format, but it seems like it > isn't dealing too well with reentering. > > So, I think the bug is in ruler-mode. But, what to do? Create a stack > of previous header-line-format's? The solution is to avoid saving the old header-line-format if Ruler mode is already on. I've checked in a fix. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 30 20:21:29 2010 Received: (at 5370) by debbugs.gnu.org; 1 Jul 2010 00:21:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OU7Wz-0005FV-BN for submit@debbugs.gnu.org; Wed, 30 Jun 2010 20:21:29 -0400 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OU7Wx-0005FP-Ht for 5370@debbugs.gnu.org; Wed, 30 Jun 2010 20:21:27 -0400 Received: by bwz7 with SMTP id 7so694252bwz.3 for <5370@debbugs.gnu.org>; Wed, 30 Jun 2010 17:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=qn2sEcPz22KFToCEzsCDcIZ4lvRJtUzOnRv8S3gy2RA=; b=VTqVrPEgu84N3tIrqqKOrzgioBtjn7VSu9LdNnNtw5u/Hd2BS+WoHuHO9pe/etQDMZ Qcoxs8FhOLPXP+GLguVdqtMj0qaPScxCK0ra2SDctqO+HPclK26VkWfnwMr827gFJxIG uRFu/quYg7K+zh6s7C0g8wzFusIYe2dGxkFvc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=P/ulEDA5gYTj8wh1iXLJTO4F3BhJuMrRsdXyj0KwjBjMqE2NTe9yyPnkOp63rNu7i1 R4eUzsHH9BoNXuDEyIVYvcWAlk0ES3PGXf6+sn3WRgFABSz8QOEPFmvbqx2KgdtLb7Cl T7M41f1BKV8q2/W/+SFrXkt9X0zOLYCZPjqkI= Received: by 10.204.162.202 with SMTP id w10mr3852122bkx.115.1277943683096; Wed, 30 Jun 2010 17:21:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.66.77 with HTTP; Wed, 30 Jun 2010 17:21:03 -0700 (PDT) In-Reply-To: <87mxuct9yb.fsf@stupidchicken.com> References: <87mxuct9yb.fsf@stupidchicken.com> From: Juanma Barranquero Date: Thu, 1 Jul 2010 02:21:03 +0200 Message-ID: Subject: Re: bug#5370: M-x hexl-mode M-x hexl-mode leaves unwanted ruler To: cyd@stupidchicken.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 5370 Cc: 5370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Thu, Jul 1, 2010 at 00:46, Chong Yidong wrote: > The solution is to avoid saving the old header-line-format if Ruler mode > is already on. =C2=A0I've checked in a fix. OK, thanks. A couple questions: Why do you need "(when enable" in ruler--save-header-line-format, which causes this warning ruler-mode.el:562:9:Warning: reference to free variable `enable' when ruler--save-header-line-format is only called once, like so (when enable (ruler--save-header-line-format)) ? Also, the docstring for r--s-h-l-f says "Install the header line format for Ruler mode. Unless if Ruler mode is already enabled, save the old header line format first." Shouldn't that be s/Unless if/Unless/? Juanma From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 01 01:32:02 2010 Received: (at 5370) by debbugs.gnu.org; 1 Jul 2010 05:32:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUCNW-0007iF-7e for submit@debbugs.gnu.org; Thu, 01 Jul 2010 01:32:02 -0400 Received: from pantheon-po41.its.yale.edu ([130.132.50.98]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUCNU-0007ht-Qx for 5370@debbugs.gnu.org; Thu, 01 Jul 2010 01:32:01 -0400 Received: from furry (adsl-99-69-53-86.dsl.wlfrct.sbcglobal.net [99.69.53.86]) (authenticated bits=0) by pantheon-po41.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o615VtmX008891 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 1 Jul 2010 01:31:57 -0400 Received: by furry (Postfix, from userid 1000) id DDCB4C011; Thu, 1 Jul 2010 01:31:53 -0400 (EDT) From: Chong Yidong To: Juanma Barranquero Subject: Re: bug#5370: M-x hexl-mode M-x hexl-mode leaves unwanted ruler References: <87mxuct9yb.fsf@stupidchicken.com> Date: Thu, 01 Jul 2010 01:31:53 -0400 In-Reply-To: (Juanma Barranquero's message of "Thu, 1 Jul 2010 02:21:03 +0200") Message-ID: <87lj9v22eu.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 5370 Cc: 5370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Juanma Barranquero writes: > Why do you need "(when enable" in ruler--save-header-line-format, > > Also, the docstring for r--s-h-l-f says > > "Install the header line format for Ruler mode. > Unless if Ruler mode is already enabled, save the old header line > format first." Typos, sorry. Fixed. Thanks for checking. From unknown Fri Sep 05 08:21:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 Jul 2010 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator