GNU bug report logs - #53676
[PATCH 0/5] *** PulseAudio service improvements ***

Previous Next

Full log

Message #32 received at 53676 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 53676 <at> debbugs.gnu.org
Subject: Re: [PATCH 2/5] services/sound: Normalize pulseaudio-configuration
 accessor names.
Date: Tue, 01 Feb 2022 20:48:57 +0100

Am Montag, dem 31.01.2022 um 23:19 -0500 schrieb Maxim Cournoyer:
> * gnu/services/sound.scm (<pulseaudio-configuration>): Adjust getter
> names to match convention.
> ---
>  gnu/services/sound.scm | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
> index 7beca35ffe..19eccfc860 100644
> --- a/gnu/services/sound.scm
> +++ b/gnu/services/sound.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright © 2018, 2020 Oleg Pykhalov <go.wigust <at> gmail.com>
>  ;;; Copyright © 2020 Liliana Marie Prikler
> <liliana.prikler <at> gmail.com>
>  ;;; Copyright © 2020 Marius Bakke <mbakke <at> fastmail.com>
> +;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -115,16 +116,16 @@ (define alsa-service-type
>  (define-record-type* <pulseaudio-configuration>
>    pulseaudio-configuration make-pulseaudio-configuration
>    pulseaudio-configuration?
> -  (client-conf pulseaudio-client-conf
> +  (client-conf pulseaudio-configuration-client-conf
>                 (default '()))
> -  (daemon-conf pulseaudio-daemon-conf
> +  (daemon-conf pulseaudio-configuration-daemon-conf
>                 ;; Flat volumes may cause unpleasant experiences to
> users
>                 ;; when applications inadvertently max out the system
> volume
>                 ;; (see e.g. <https://bugs.gnu.org/38172>).
>                 (default '((flat-volumes . no))))
> -  (script-file pulseaudio-script-file
> +  (script-file pulseaudio-configuration-script-file
>                 (default (file-append pulseaudio
> "/etc/pulse/default.pa")))
> -  (system-script-file pulseaudio-system-script-file
> +  (system-script-file pulseaudio-configuration-system-script-file
>                        (default
>                          (file-append pulseaudio
> "/etc/pulse/system.pa"))))
I don't see calling code adjusted anywhere.  Is this because we only
use match to access this records fields?

On a related note, would it make sense to port this over to (define-
configuration)?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.