GNU bug report logs - #53673
[PATCH] Add package: emacs-beacon-1.3.4

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Pierre-Henry Fröhring <contact <at> phfrohring.com>
Cc: 53673 <at> debbugs.gnu.org
Subject: [bug#53673] [PATCH] Add package: emacs-beacon-1.3.4
Date: Sun, 06 Feb 2022 21:39:51 +0100

Hello,

Pierre-Henry Fröhring <contact <at> phfrohring.com> writes:

> ---
> +(define-public emacs-beacon-1.3.4

Thank you. Some comments follow.

First, the variable should not include the version string. So, you
should write:

  (define-public emacs-beacon

Then, you need to provide a proper commit message. Such messages are
somewhat standardized in Guix. Here, this could be:

    gnu: Add emacs-beacon.

    * gnu/packages/emacs-xyz.scm (emacs-beacon): New variable.

> +  (package
> +    (name "emacs-beacon")
> +    (version "1.3.4")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/Malabarba/"
> +                                  (second (string-split name #\-))
> +                                  "/archive/refs/tags/" version ".tar.gz"))

This URL is not stable. Use git-fetch method, with version string as the tag.

> +    (synopsis "A light that follows your cursor around so you don't lose it!")

A synopsis may not start with an article. I suggest to use "guix lint"
on your package definition. I suggest:

  Emacs minor mode creating a light that follows your cursor around

> +    (description
> +     "This is a global minor-mode. Turn it on everywhere with: (beacon-mode 1).
> +Whenever the window scrolls a light will shine on top of your cursor so you know where it is.
> +That’s it.")

The part about "(beacon-mode 1)" belongs to the manual, not the
description. The last sentence can be dropped, too. Also, sentences
should be separated with two spaces in descriptions. I suggest:

Beacon is an Emacs minor-mode.  Whenever the ... where it is.


Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.