From unknown Mon Aug 18 08:27:05 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5367: 23.1; gnus -- Inconsistent mml-secure-message-sign method Mail-Followup-To: Tommi Vainikainen , 5367@debbugs.gnu.org Resent-From: Tommi Vainikainen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jan 2010 20:38:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: report 5367 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@debbugs.gnu.org id=B.126332862920746 (code B ref -1); Tue, 12 Jan 2010 20:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Jan 2010 20:37:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUnUD-0005OV-D9 for submit@debbugs.gnu.org; Tue, 12 Jan 2010 15:37:09 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUmo2-0004s4-VI for submit@debbugs.gnu.org; Tue, 12 Jan 2010 14:53:35 -0500 Received: from mx10.gnu.org ([199.232.76.166]:36636) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUmny-0001SU-Pq for submit@debbugs.gnu.org; Tue, 12 Jan 2010 14:53:30 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NUmnw-0000Z9-Mp for submit@debbugs.gnu.org; Tue, 12 Jan 2010 14:53:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:33725) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NUmnw-0000Ym-EY for submit@debbugs.gnu.org; Tue, 12 Jan 2010 14:53:28 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUmnv-0007KE-GY for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 14:53:27 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUmnq-0007Hv-LC for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 14:53:26 -0500 Received: from [199.232.76.173] (port=59399 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUmnq-0007He-Fn for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 14:53:22 -0500 Received: from mail-bw0-f215.google.com ([209.85.218.215]:64961) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUmnq-0000Wk-1e for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 14:53:22 -0500 Received: by bwz7 with SMTP id 7so16071866bwz.26 for ; Tue, 12 Jan 2010 11:53:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :message-id:user-agent:mime-version:content-type; bh=PKXoTtydtwN00D5eMg11ktbH5eoFCE9x6f2lIi574Uk=; b=IG0ifKwux1sRJ3xcBhiCgJFOxlOgK9IjTJAvLuwdGoIN+oHQ+uuT5AZ5rlOprE8bJB 0zfBgUbClCjrxPgx0nWc0IApPQtlEfOauuboFg4HdYqpdDKcfgAT3JDYMOuVCREOYtTM A2DxoXgFufKPxalCf3aTIVXg4KGYxvl4e8nQY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:message-id:user-agent:mime-version :content-type; b=HIu/wALUiHBgL6U29NBGKqptZCMe8inbi6hLwM2M73zjP5MECx3FQNOjntTHeIxZa6 IniR/5mjbZRuHSwF3O1Gk8u33iTmha57nHo6tfmpnPTnXXsEo/hvJuG2DHrYqEm2eS/a hCMY/rtEIkNr8ozcKuxpTXxITSZ13/3RUbchw= Received: by 10.204.154.68 with SMTP id n4mr4477383bkw.68.1263325999860; Tue, 12 Jan 2010 11:53:19 -0800 (PST) Received: from michelangelo (a91-152-169-252.elisa-laajakaista.fi [91.152.169.252]) by mx.google.com with ESMTPS id 15sm9558801bwz.12.2010.01.12.11.53.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 12 Jan 2010 11:53:19 -0800 (PST) From: Tommi Vainikainen To: bug-gnu-emacs@gnu.org Date: Tue, 12 Jan 2010 21:53:18 +0200 Message-ID: <87vdf7je1d.fsf@thv.iki.fi> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Mailman-Approved-At: Tue, 12 Jan 2010 15:36:55 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) --=-=-= Hi, currently gnus/lisp/mml-sec.el contains definitions for functions mml-secure-sign and mml-secure-message-sign which have equal bodies and description. However when comparing mml-secure-message-sign with mml-secure-message-* functions, one would expect that also mml-secure-message-sign would set signing to the entire message, not only current MML part. I believe that the current version is copy&paste error, which caused this inconsistency in the function declarations. Following patch fixes the problem: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=gnus-mml-secure-message-sign.patch Index: lisp/mml-sec.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/mml-sec.el,v retrieving revision 7.25 diff -u -r7.25 mml-sec.el --- lisp/mml-sec.el 22 Jan 2009 07:02:16 -0000 7.25 +++ lisp/mml-sec.el 16 Nov 2009 02:00:20 -0000 @@ -306,11 +306,11 @@ (defun mml-secure-message-sign (&optional method) - "Add MML tags to sign this MML part. + "Add MML tags to sign the entire message. Use METHOD if given. Else use `mml-secure-method' or `mml-default-sign-method'." (interactive) - (mml-secure-part + (mml-secure-message (or method mml-secure-method mml-default-sign-method) 'sign)) --=-=-= -- Tommi Vainikainen --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 13 12:39:30 2010 Received: (at control) by debbugs.gnu.org; 13 Jan 2010 17:39:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NV7Bq-0005Bi-2S for submit@debbugs.gnu.org; Wed, 13 Jan 2010 12:39:30 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NV7Bn-0005Bb-KB for control@debbugs.gnu.org; Wed, 13 Jan 2010 12:39:27 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NV7Bi-00008A-3m; Wed, 13 Jan 2010 12:39:22 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19278.1354.66161.232229@fencepost.gnu.org> Date: Wed, 13 Jan 2010 12:39:22 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: green X-Ran: Br14aVx1s"b%XZBACFejP="95+225[b<2X;?d6*Zi5tg3`Ay]KueFAKm`1I_ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) reassign 1184 emacs forcemerge 1184 5351 reassign 5367 emacs,gnus severity 5366 wishlist severity 5325 minor From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 18 10:30:14 2010 Received: (at control) by debbugs.gnu.org; 18 Jan 2010 15:30:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWtYT-0000aX-VZ for submit@debbugs.gnu.org; Mon, 18 Jan 2010 10:30:14 -0500 Received: from mail-bw0-f222.google.com ([209.85.218.222]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWtYF-0000Zm-A6 for control@debbugs.gnu.org; Mon, 18 Jan 2010 10:29:59 -0500 Received: by bwz22 with SMTP id 22so1117930bwz.5 for ; Mon, 18 Jan 2010 07:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=Is/ce3b5xSOTC3eMHKw+mF0ETCQ6SXGDpWvFD1VkQxo=; b=X6+wc2Yr8axUipc64z/cGYQsvdQv8ksHd1P+BzcsB8qMpEfSITnDxXfwO82i0eDfgZ 2r6UCYlXjTQ4JNc1zOyXcxaddsVCW0DbvSbiZDrjOPISRr+qbRe6fD0dQeQW7AMLgamv vOi390+iR3CpUqlTBZLRSqSFMqke3iwZxsWD0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=CFz5w2CXesVdFC1H2+8sP7qNj76gVqYjfwcjkWtNdZ7ozlUvdfudQ67u1lDfGJYHQ4 yALUqwZnpACjHusjW5nibF6R1MUlMeS7DjlFd9S0S3DuLn4frtEesfYtL0TjxFgulnlt s3XLSCDeDq4EQOKpysptsnFEiDbvxtAZtzuG0= MIME-Version: 1.0 Received: by 10.204.8.26 with SMTP id f26mr3543558bkf.66.1263828591110; Mon, 18 Jan 2010 07:29:51 -0800 (PST) From: Juanma Barranquero Date: Mon, 18 Jan 2010 16:29:31 +0100 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) tags 5394 + patch tags 5367 + patch tags 5376 + patch quit From unknown Mon Aug 18 08:27:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5367: 23.1; gnus -- Inconsistent mml-secure-message-sign method Resent-From: Andreas Seltenreich Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 06 May 2010 05:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5367 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch To: Tommi Vainikainen Cc: 5367@debbugs.gnu.org Received: via spool by 5367-submit@debbugs.gnu.org id=B5367.127312553524370 (code B ref 5367); Thu, 06 May 2010 05:59:01 +0000 Received: (at 5367) by debbugs.gnu.org; 6 May 2010 05:58:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9u6p-0006L1-7P for submit@debbugs.gnu.org; Thu, 06 May 2010 01:58:55 -0400 Received: from smtp2.rz.uni-karlsruhe.de ([129.13.185.218]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9tyg-0006FT-Fg for 5367@debbugs.gnu.org; Thu, 06 May 2010 01:50:31 -0400 Received: from rzstud2.stud.uni-karlsruhe.de (rzstud2.stud.uni-karlsruhe.de [193.196.41.42]) by smtp2.rz.uni-karlsruhe.de with esmtps (Exim 4.63 #1) id 1O9tyc-0002ia-Cv; Thu, 06 May 2010 07:50:26 +0200 Received: from uwi7 by rzstud2.stud.uni-karlsruhe.de with local (Exim 4.63) (envelope-from ) id 1O9tyc-0003FE-35; Thu, 06 May 2010 07:50:26 +0200 From: Andreas Seltenreich In-Reply-To: <87vdf7je1d.fsf@thv.iki.fi> (Tommi Vainikainen's message of "Tue, 12 Jan 2010 21:53:18 +0200") References: <87vdf7je1d.fsf@thv.iki.fi> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.96 (gnu/linux) X-Now-Playing: Anathema =?UTF-8?Q?=E2=99=AA?= diverse =?UTF-8?Q?=E2=99=AA?= angelswalkamongus X-Hashcash: 1:26:100506:thv@iki.fi::X9J8Gywurco/Lao1:35eT5 X-Hashcash: 1:26:100506:5367@debbugs.gnu.org::zP8nblQPBVltSgA7:00000000000003QTK4 Date: Thu, 06 May 2010 07:50:24 +0200 Message-ID: <871vdpk28v.fsf@gate450.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Mailman-Approved-At: Thu, 06 May 2010 01:58:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) Tommi Vainikainen writes: > currently gnus/lisp/mml-sec.el contains definitions for functions > mml-secure-sign and mml-secure-message-sign which have equal bodies and > description. However when comparing mml-secure-message-sign with > mml-secure-message-* functions, one would expect that also > mml-secure-message-sign would set signing to the entire message, not > only current MML part. I believe that the current version is copy&paste > error, which caused this inconsistency in the function declarations. > Following patch fixes the problem: Thanks - I committed your patch to the Gnus repository. I'll leave this bug open till the change is merged into emacs though. Thanks, andreas From debbugs-submit-bounces@debbugs.gnu.org Fri May 07 13:22:57 2010 Received: (at control) by debbugs.gnu.org; 7 May 2010 17:22:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OARGK-0000BL-P4 for submit@debbugs.gnu.org; Fri, 07 May 2010 13:22:56 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OARGJ-0000BG-RU for control@debbugs.gnu.org; Fri, 07 May 2010 13:22:55 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OARGI-0001K8-4p; Fri, 07 May 2010 13:22:54 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19428.19566.111683.131175@fencepost.gnu.org> Date: Fri, 7 May 2010 13:22:54 -0400 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: yellow X-Ran: |=kr5'nq=-,@H(f1dTv-L8U{GxwIlA}8~45$SzE{!@09;P-{T#OJA,=S}7]++3CC>aLoQS X-Debbugs-No-Ack: yes X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) close 5367 close 6107 merge 6123 6124