GNU bug report logs - #53656
[PATCH 0/2] 2 Julia packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53656 in the body.
You can then email your comments to 53656 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH 0/2] 2 Julia packages
Date: Mon, 31 Jan 2022 12:38:02 +0200

Two more julia packages, ready for upstreaming.

Efraim Flashner (2):
  gnu: Add julia-linesearches.
  gnu: Add julia-optim.

 gnu/packages/julia-xyz.scm | 93 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 92 insertions(+), 1 deletion(-)


base-commit: 43dd34c7777a212c99a97da7a2c237158faa9a1b
prerequisite-patch-id: 0db9d2565885888d76f51e5e9ab3287fdaa3877a
-- 
2.34.0

Message #8 received at 53656 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 53656 <at> debbugs.gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH 1/2] gnu: Add julia-linesearches.
Date: Mon, 31 Jan 2022 12:40:32 +0200

* gnu/packages/julia-xyz.scm (julia-linesearches): New variable.
---
 gnu/packages/julia-xyz.scm | 45 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm
index e30cf39dc9..7de0c32113 100644
--- a/gnu/packages/julia-xyz.scm
+++ b/gnu/packages/julia-xyz.scm
@@ -1,7 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2020, 2021 Nicolò Balzarotti <nicolo <at> nixo.xyz>
 ;;; Copyright © 2021, 2022 Simon Tournier <zimon.toutoune <at> gmail.com>
-;;; Copyright © 2021 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2021, 2022 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2021 Vinicius Monego <monego <at> posteo.net>
 ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
 ;;;
@@ -3104,6 +3104,49 @@ (define-public julia-lazyarrays
 implementation of matrix-free methods for iterative solvers.")
     (license license:expat)))
 
+(define-public julia-linesearches
+  (package
+    (name "julia-linesearches")
+    (version "7.1.1")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/JuliaNLSolvers/LineSearches.jl")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32 "1qc4la07w6s1xhcyd0hvbnpr31zc1a2ssgyybc8biv5m00g0dnr0"))))
+    (build-system julia-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'link-depot 'skip-optim-tests
+           (lambda _
+             (substitute* "test/examples.jl"
+               ;; Prevent a cycle with Optim.jl.
+               (("^    SKIPFILE.*") "")
+               (("^    #SKIPFILE") "    SKIPFILE"))))
+         (add-after 'link-depot 'skip-doublefloats-tests
+           (lambda _
+             (substitute* "test/runtests.jl"
+               (("using DoubleFloats.*") "")
+               ((".*arbitrary_precision\\.jl.*") "")))))))
+    (propagated-inputs
+     (list julia-nlsolversbase
+           julia-nanmath
+           julia-parameters))
+    (native-inputs
+     ;; DoubleFloats.jl transitively depends on TimeZones.jl, which is currently
+     ;; unpackageable due to its oversized Artifacts.toml.
+     (list ;julia-doublefloats
+           julia-optimtestproblems))
+    (home-page "https://github.com/JuliaNLSolvers/LineSearches.jl")
+    (synopsis "Line search methods for optimization and root-finding")
+    (description "This package provides an interface to line search algorithms
+implemented in Julia.")
+    (license license:expat)))
+
 (define-public julia-logexpfunctions
   (package
     (name "julia-logexpfunctions")
-- 
2.34.0

Message #11 received at 53656 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 53656 <at> debbugs.gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH 2/2] gnu: Add julia-optim.
Date: Mon, 31 Jan 2022 12:40:33 +0200

* gnu/packages/julia-xyz.scm (julia-optim): New variable.
---
 gnu/packages/julia-xyz.scm | 48 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm
index 7de0c32113..2fcc4cf83e 100644
--- a/gnu/packages/julia-xyz.scm
+++ b/gnu/packages/julia-xyz.scm
@@ -23,6 +23,7 @@
 (define-module (gnu packages julia-xyz)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages)
+  #:use-module (guix gexp)
   #:use-module (guix utils)
   #:use-module (guix packages)
   #:use-module (guix git-download)
@@ -3650,6 +3651,53 @@ (define-public julia-nnlib
 doesn't provide any other \"high-level\" functionality like layers or AD.")
     (license license:expat)))
 
+(define-public julia-optim
+  (package
+    (name "julia-optim")
+    (version "1.6.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/JuliaNLSolvers/Optim.jl")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32 "0nvl3xp9c6r80y9n7fic4zyq2443apfmbcpnx0wvgkv4vsy08x5j"))))
+    (build-system julia-build-system)
+    (arguments
+     (list
+       #:phases
+       #~(modify-phases %standard-phases
+           (add-after 'unpack 'adjust-tests
+             (lambda _
+               ;; TODO: Figure out why this test fails.
+               (substitute* "test/runtests.jl"
+                 ((".*l_bfgs.*") "")))))))
+    (propagated-inputs
+     (list julia-compat
+           julia-fillarrays
+           julia-forwarddiff
+           julia-linesearches
+           julia-nanmath
+           julia-nlsolversbase
+           julia-parameters
+           julia-positivefactorizations
+           julia-statsbase))
+    (native-inputs
+     (list julia-linesearches
+           julia-measurements
+           julia-nlsolversbase
+           julia-optimtestproblems
+           julia-positivefactorizations
+           julia-recursivearraytools
+           julia-stablerngs))
+    (home-page "https://github.com/JuliaNLSolvers/Optim.jl")
+    (synopsis "Optimization functions for Julia")
+    (description "@code{Optim.jl} is a package for univariate and multivariate
+optimization of functions.")
+    (license license:expat)))
+
 (define-public julia-optimtestproblems
   (package
     (name "julia-optimtestproblems")
-- 
2.34.0

Message #14 received at 53656 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 53656 <at> debbugs.gnu.org
Subject: Re: bug#53656: [PATCH 0/2] 2 Julia packages
Date: Thu, 10 Feb 2022 17:22:33 +0100

Hi Efraim,

Both patches look good to me.


I notice this warning:

--8<---------------cut here---------------start------------->8---
┌ Warning: Package OptimTestProblems does not have LinearAlgebra in its dependencies:
│ - If you have OptimTestProblems checked out for development and have
│   added LinearAlgebra as a dependency but haven't updated your primary
│   environment's manifest file, try `Pkg.resolve()`.
│ - Otherwise you may need to report an issue with OptimTestProblems
└ Loading LinearAlgebra into OptimTestProblems from project dependency, future warnings for OptimTestProblems are suppressed.
--8<---------------cut here---------------end--------------->8---

and...


On Mon, 31 Jan 2022 at 12:40, Efraim Flashner <efraim <at> flashner.co.il> wrote:

> * gnu/packages/julia-xyz.scm (julia-optim): New variable.

[...]

> +  #:use-module (guix gexp)

[...]

> +       #:phases
> +       #~(modify-phases %standard-phases
> +           (add-after 'unpack 'adjust-tests
> +             (lambda _
> +               ;; TODO: Figure out why this test fails.
> +               (substitute* "test/runtests.jl"
> +                 ((".*l_bfgs.*") "")))))))

...I am thinking loudly if this gexp is required.  There are other many
similar patter without a gexp.  Therefore, for consistency with the
rest, I would be in favor to switch to regular modification of phases.
Or let me know if this is becoming the new patter and I would adapt for
the others.


Cheers,
simom

Message #19 received at 53656-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 53656-done <at> debbugs.gnu.org
Subject: Re: bug#53656: [PATCH 0/2] 2 Julia packages
Date: Sun, 13 Feb 2022 12:23:19 +0200

[Message part 1 (text/plain, inline)]

On Thu, Feb 10, 2022 at 05:22:33PM +0100, zimoun wrote:
> Hi Efraim,
> 
> Both patches look good to me.
> 
> 
> I notice this warning:
> 
> --8<---------------cut here---------------start------------->8---
> ┌ Warning: Package OptimTestProblems does not have LinearAlgebra in its dependencies:
> │ - If you have OptimTestProblems checked out for development and have
> │   added LinearAlgebra as a dependency but haven't updated your primary
> │   environment's manifest file, try `Pkg.resolve()`.
> │ - Otherwise you may need to report an issue with OptimTestProblems
> └ Loading LinearAlgebra into OptimTestProblems from project dependency, future warnings for OptimTestProblems are suppressed.
> --8<---------------cut here---------------end--------------->8---

It ends up not being a problem, but I'm left wondering if we should
extend the #:julia-package-foo arguments to add more fields or if we
should just add a custom phase to build a Package.toml that includes all
the fields needed.

> and...
> 
> 
> On Mon, 31 Jan 2022 at 12:40, Efraim Flashner <efraim <at> flashner.co.il> wrote:
> 
> > * gnu/packages/julia-xyz.scm (julia-optim): New variable.
> 
> [...]
> 
> > +  #:use-module (guix gexp)
> 
> [...]
> 
> > +       #:phases
> > +       #~(modify-phases %standard-phases
> > +           (add-after 'unpack 'adjust-tests
> > +             (lambda _
> > +               ;; TODO: Figure out why this test fails.
> > +               (substitute* "test/runtests.jl"
> > +                 ((".*l_bfgs.*") "")))))))
> 
> ...I am thinking loudly if this gexp is required.  There are other many
> similar patter without a gexp.  Therefore, for consistency with the
> rest, I would be in favor to switch to regular modification of phases.
> Or let me know if this is becoming the new patter and I would adapt for
> the others.

It's definitely the new pattern we're using now. I suppose it's not
really necessary here, but having more instances of it throughout the
codebase also makes it easier to search for examples when others are
looking to use or modify gexps.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.