GNU bug report logs - #53648
[PATCH] gnu: fcitx5-gtk: Add GTK 4 support.

Previous Next

Package: guix-patches;

Reported by: Zhu Zihao <all_but_last <at> 163.com>

Date: Mon, 31 Jan 2022 06:55:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #44 received at 53648 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 53648 <at> debbugs.gnu.org
Subject: Re: [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support.
Date: Wed, 09 Feb 2022 21:33:48 +0100

[Message part 1 (text/plain, inline)]
users guix
usertags 53648 reviewed-looks-good
thanks

Zhu Zihao schreef op wo 09-02-2022 om 23:54 [+0800]:
> +                  (("¥¥$¥¥{CMAKE_INSTALL_LIBDIR¥¥}")
> +                   (string-append output "/lib"))))

Aside from the file encoding issue of the patch file (which the
committer might be in a better position to figure out), LGTM
(although I didn't personally test it.)

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 94 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.