GNU bug report logs - #53648
[PATCH] gnu: fcitx5-gtk: Add GTK 4 support.

Previous Next

Package: guix-patches;

Reported by: Zhu Zihao <all_but_last <at> 163.com>

Date: Mon, 31 Jan 2022 06:55:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #38 received at 53648 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 53648 <at> debbugs.gnu.org
Subject: Re: [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support.
Date: Wed, 09 Feb 2022 12:05:20 +0100

[Message part 1 (text/plain, inline)]
Zhu Zihao schreef op wo 09-02-2022 om 10:12 [+0800]:
> +            (lambda* (#:key outputs #:allow-other-keys)

Since you're doing #$output:FOO instead of (assoc-ref outputs "foo")
below now, 'outputs' is now unused, so this can be simplified to

(lambda _ ; <-- no (#:key outputs #:allow-other-keys) argument list needed
  ;; Take care of [...]
  (define (split-immodule gtk-version output)
    [...])
  [...])

> +    (description "Fcitx5-gtk provides following functionality in corresponding

As previously mentioned, a few definite articles would seem to be in place:
‘Fcitx5-gtk provides _the_ following functionality in _the_ corresponding
output:’ (emphasis mine).

Otherwise, LGTM, although I didn't test it.

Greetings,
Maxime.


[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 94 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.