GNU bug report logs - #53644
29.0.50; xref-search-program breaks if programm not installed on a remote host

Previous Next

Full log

View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Michael Albinus <michael.albinus <at> gmx.de>, 53644 <at> debbugs.gnu.org
Subject: bug#53644: 29.0.50; xref-search-program breaks if programm not installed on a remote host
Date: Mon, 14 Feb 2022 13:57:08 +0000

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 09.02.2022 11:17, Philip Kaludercic wrote:
>> In that case, I'd propose this patch:
>
> Thanks!
>
> Could you extract the detection logic to outside of the main function?
> I think the result would be easier to read. The diff, too.

Ok.

> And use a simpler test: (only when the host is remote) write some text
> to a file in the temp dir, then search through it. Only doing it once,
> of course, when the connection-local value is initialized.

I am afraid I don't understand what you mean here, specifically "some
text".

> I'd prefer an even simpler test than that, but I guess the current
> structure of xref-search-program-alist doesn't give us specific values
> to call 'executable-find' on. And that's probably fine.
>

-- 
	Philip Kaludercic

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.