GNU bug report logs - #53644
29.0.50; xref-search-program breaks if programm not installed on a remote host

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Sun, 30 Jan 2022 23:39:01 UTC

Severity: normal

Found in version 29.0.50

Full log


Message #50 received at 53644 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Philip Kaludercic <philipk <at> posteo.net>,
 Michael Albinus <michael.albinus <at> gmx.de>
Cc: 53644 <at> debbugs.gnu.org
Subject: Re: bug#53644: 29.0.50; xref-search-program breaks if programm not
 installed on a remote host
Date: Sat, 12 Feb 2022 03:04:02 +0200
On 09.02.2022 11:17, Philip Kaludercic wrote:
> In that case, I'd propose this patch:

Thanks!

Could you extract the detection logic to outside of the main function? I 
think the result would be easier to read. The diff, too.

And use a simpler test: (only when the host is remote) write some text 
to a file in the temp dir, then search through it. Only doing it once, 
of course, when the connection-local value is initialized.

I'd prefer an even simpler test than that, but I guess the current 
structure of xref-search-program-alist doesn't give us specific values 
to call 'executable-find' on. And that's probably fine.




This bug report was last modified 3 years and 121 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.