GNU bug report logs - #53626
28.0.91; project-find-regexp (C-x p g) twice results in searching different projects

Previous Next

Package: emacs;

Reported by: sbaugh <at> catern.com

Date: Sat, 29 Jan 2022 19:12:01 UTC

Severity: normal

Found in version 28.0.91

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


Message #56 received at 53626 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Sean Whitton <spwhitton <at> spwhitton.name>, sbaugh <at> catern.com,
 53626 <at> debbugs.gnu.org
Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results
 in searching different projects
Date: Wed, 23 Feb 2022 03:45:34 +0200
On 23.02.2022 01:09, Sean Whitton wrote:
>> The timer-based solution is hacky, but it affects only one place (the
>> xref buffer and the variable in it), so it's easier to verify that it
>> has the intended effect, and no external callers will need to bother
>> with additional knowledge (hopefully, of course).
> Is there no chance of any concurrency issues with this, btw?

Probably not, or not currently: the fetching of the list of xrefs is 
synchronous, and in all cases (so far) (I think) does not depend on the 
value of default-directory. It only affects the subsequent interaction 
with the buffer (jumping to locations), so deferring the assignment of 
the value of dd seems fine.

FETCHER is also called in the current buffer (before the 
with-current-buffer form), so even depending on the dynamic value of 
default-directory should be fine. At least until we get to 
asynchronous/chunked fetchers someday, but that's a bigger challenge 
with its own major changes.




This bug report was last modified 3 years and 92 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.