GNU bug report logs - #53626
28.0.91; project-find-regexp (C-x p g) twice results in searching different projects

Previous Next

Full log

Message #53 received at 53626 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Dmitry Gutov <dgutov <at> yandex.ru>, sbaugh <at> catern.com, 53626 <at> debbugs.gnu.org
Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results
 in searching different projects
Date: Tue, 22 Feb 2022 16:09:01 -0700

Hello,

On Tue 22 Feb 2022 at 01:14AM +02, Dmitry Gutov wrote:

> On 22.02.2022 01:00, Sean Whitton wrote:
>> I think I prefer my with-temp-buffer thing to this, to be honest --
>> adding a timer into the mix seems like it might make debugging harder.
>>
>> Assuming you're still okay with my initial idea, I'll come up with a
>> patch to do it with a macro, and apply it across project.el.
>
> I liked the simplicity of the with-temp-buffer solution, but it doesn't
> solve the conceptual problem: that any code trying to let-bind
> default-directory around the call for xref-show-xrefs will have
> rediscover and solve this problem (or, more likely, live with it for a
> few years until somebody notices).

Good point.

> The timer-based solution is hacky, but it affects only one place (the
> xref buffer and the variable in it), so it's easier to verify that it
> has the intended effect, and no external callers will need to bother
> with additional knowledge (hopefully, of course).

Is there no chance of any concurrency issues with this, btw?

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.