From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 29 14:11:41 2022 Received: (at submit) by debbugs.gnu.org; 29 Jan 2022 19:11:41 +0000 Received: from localhost ([127.0.0.1]:34827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDt8P-0005If-06 for submit@debbugs.gnu.org; Sat, 29 Jan 2022 14:11:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:42484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDt8N-0005IX-9Y for submit@debbugs.gnu.org; Sat, 29 Jan 2022 14:11:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDt8N-0006Ti-3S for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 14:11:39 -0500 Received: from pnkfpfxf.outbound-mail.sendgrid.net ([50.31.63.175]:47518) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDt8K-0006Mm-G1 for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 14:11:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:mime-version:to:content-type:content-transfer-encoding; s=s1; bh=jZgCf2lHXgVYPqiSu8a1gWh9mhb/TiaD88/24J2uxs4=; b=Lis61a1XeKxuh69FCCnL5msNGlMw5kd3+kc06oQ426gqxZBx7si0BNQRBpukJctYQzXy 4sBgipNiOFWxnJ3w+3CLoFsXvONrW2Zpoi7QvMUUSV5dChbMYu4zGeroIS/o8D3Juwap2v st2ym9w+ikIjoAFACdHdgWDJJLxYZn7sDqccKVhCKZ7/lAoljZdPWsqRVHqrLkkqCQFoc7 66qGLj2X+VV1aY/61KUPstbRzjY83+y0kGfT/BJzS9XJBeV9t19A/QEDvlJzIFafOq+hNb T+lq0kMvfUtiHDDRJbkXXdr0S6c4z+Kqy4udskEHy3fUDbqYYtn+JyjX4M0pi19A== Received: by filterdrecv-656998cfdd-ptszh with SMTP id filterdrecv-656998cfdd-ptszh-1-61F59167-1 2022-01-29 19:11:35.045567117 +0000 UTC m=+11216655.695494395 Received: from earth.catern.com (unknown) by geopod-ismtpd-6-2 (SG) with ESMTP id Yn2TnjS1QTi7q8hftTcYLQ for ; Sat, 29 Jan 2022 19:11:34.875 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver= Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 2BD136006B for ; Sat, 29 Jan 2022 14:11:34 -0500 (EST) From: sbaugh@catern.com Subject: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Date: Sat, 29 Jan 2022 19:11:35 +0000 (UTC) Message-ID: <87wnii73x5.fsf@catern.com> MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbJHqy9bWSg6S0ICkzFTGL?= =?us-ascii?Q?Ds2dzcm+mcWY=2FP6+5ZwkXBMax4O3bg1DQ1Nus5R?= =?us-ascii?Q?sox0uXLL0wOAqH3oddaYjJowbNc6vUi0C6fppXD?= =?us-ascii?Q?Dd1nhohEejrR5hVdLxjTpVQL=2F2RLiHEZaoQMiIo?= =?us-ascii?Q?17wtKNEWvc9XnK0vh+5bTG5eDuZ451YLhWw=3D=3D?= To: bug-gnu-emacs@gnu.org X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=50.31.63.175; envelope-from=bounces+21787432-3678-bug-gnu-emacs=gnu.org@em8926.catern.com; helo=pnkfpfxf.outbound-mail.sendgrid.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) An existing *xref* buffer doesn't have its default-directory changed when running project-find-regexp. Since project-find-regexp switches to *xref*, that means running project-find-regexp twice in a row may search two different projects, which is unexpected. Steps to reproduce: With buffers in two different projects as detected by project.el, do the following sequence: 1. Switch to a buffer in project A 2. project-find-regexp, which will search project A, and create and switch to an *xref* buffer with a default-directory pointing at the project root of A 3. project-find-regexp again, which will search project A again. (This is the desired behavior) 4. Switch to a buffer in project B 5. project-find-regexp, which will search project B and switch to the existing *xref* buffer (which is still pointing at project A) 6. project-find-regexp again, which will search project A instead of B. Suggested fix: Change project-find-regexp to reset the default-directory of the *xref* buffer used to the most recently used project root. In GNU Emacs 28.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0) Repository revision: 525dc6e5c428185b62c72d7958cd4fe17937f126 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: NixOS 21.05 (Okapi) Configured using: 'configure --prefix=/nix/store/023rdncicx7hz02dq986rnnpl12l1kas-emacs-git-20220115.0 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-xft --with-cairo' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $EMACSLOADPATH: value of $EMACSNATIVELOADPATH: /nix/store/fs7slsl0rz28h6dq8rnhgk4ddkk8dh0w-emacs-packages-deps/share/emacs/native-lisp:: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: notmuch-hello Minor modes in effect: windmove-mode: t envrc-global-mode: t envrc-mode: t global-git-commit-mode: t magit-auto-revert-mode: t shell-dirtrack-mode: t savehist-mode: t save-place-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/sbaugh/.nix-profile/share/emacs/site-lisp/site-start hides /nix/store/fs7slsl0rz28h6dq8rnhgk4ddkk8dh0w-emacs-packages-deps/share/emacs/site-lisp/site-start /home/sbaugh/.nix-profile/share/emacs/site-lisp/site-start hides /nix/store/023rdncicx7hz02dq986rnnpl12l1kas-emacs-git-20220115.0/share/emacs/site-lisp/site-start /nix/store/fs7slsl0rz28h6dq8rnhgk4ddkk8dh0w-emacs-packages-deps/share/emacs/site-lisp/elpa/transient-20220112.1305/transient hides /nix/store/023rdncicx7hz02dq986rnnpl12l1kas-emacs-git-20220115.0/share/emacs/28.0.91/lisp/transient /nix/store/fs7slsl0rz28h6dq8rnhgk4ddkk8dh0w-emacs-packages-deps/share/emacs/site-lisp/elpa/let-alist-1.0.6/let-alist hides /nix/store/023rdncicx7hz02dq986rnnpl12l1kas-emacs-git-20220115.0/share/emacs/28.0.91/lisp/emacs-lisp/let-alist Features: (shadow emacsbug ibuf-ext sh-script executable pulse qp sort tabify man git-rebase pcmpl-unix image-file image-converter korea-util novice timezone network-stream url-http url-gw nsm url-auth ggtags etags fileloop ewoc two-column skeleton dumb-jump popup s xref quail log-view magit-extras ibuffer ibuffer-loaddefs em-unix em-term term disp-table ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-cmpl em-dirs esh-var em-basic em-banner em-alias esh-mode eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util make-mode find-dired grep mhtml-mode css-mode js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs sgml-mode facemenu org-attach org-id warnings mail-extr nix-mode ffap smie nix-repl nix-shell nix-store nix-instantiate nix-shebang nix-format nix project reposition rect misc vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc bug-reference finder-inf deuglify gnus-async gnus-cite gnus-cus gnus-demon gnus-diary nndiary gnus-draft gnus-agent nnvirtual nntp gnus-cache nndraft nnmh gnus-dup gnus-fun gnus-html url-cache gnus-kill gnus-logic gnus-mh mh-comp mh-scan mh-gnus mh-e mh-compat mh-buffers mh-loaddefs gnus-registry registry eieio-base gnus-salt gnus-score score-mode gnus-srvr gnus-topic gnus-uu yenc gnus-vm gnus-msg sendmail cus-dep autoload lisp-mnt cus-theme cl-print shortdoc hippie-exp windmove help-fns radix-tree compile shr-color color mule-util cus-edit pp notmuch notmuch-tree notmuch-jump notmuch-hello notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-message notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser notmuch-wash coolj notmuch-query goto-addr icalendar diary-lib diary-loaddefs notmuch-tag notmuch-lib notmuch-compat pcase hl-line ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt speedbar ezimage dframe gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win gnus nnheader wid-edit ol-docview doc-view jka-compr image-mode exif ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi vc-git vc-dispatcher python tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat parse-time ls-lisp face-remap misearch multi-isearch cus-start cus-load dired-aux envrc inheritenv page-ext dired-x magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff git-commit log-edit message rmc dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor shell server magit-mode transient cl-extra magit-git magit-section magit-utils crm dash lui-autopaste circe diff-mode lui-irc-colors irc gnutls puny lcs lui-logging lui-format lui tracking shorten thingatpt help-mode flyspell ispell circe-compat ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda org-refile ox-html table ox-ascii ox-publish ox org-element avl-tree generator org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex iso8601 time-date ol rx org-keys oc org-compat advice org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs gdb-mi gud easy-mmode comint ansi-color ring cyberpunk-theme better-defaults savehist saveplace ido tex-site edmacro kmacro info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1076574 118416) (symbols 48 46869 2) (strings 32 222312 21193) (string-bytes 1 8226000) (vectors 16 108694) (vector-slots 8 1962697 150648) (floats 8 695 502) (intervals 56 63651 321) (buffers 992 195)) From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 30 01:28:43 2022 Received: (at 53626) by debbugs.gnu.org; 30 Jan 2022 06:28:43 +0000 Received: from localhost ([127.0.0.1]:35436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nE3hb-0006wZ-FQ for submit@debbugs.gnu.org; Sun, 30 Jan 2022 01:28:43 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nE3hZ-0006wM-BU for 53626@debbugs.gnu.org; Sun, 30 Jan 2022 01:28:42 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2AF775C00AD; Sun, 30 Jan 2022 01:28:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 30 Jan 2022 01:28:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=zlaQrBXinBXzDlhDnAs35hT/I2wZu40eiTHmXv UYMUY=; b=2C6S9maNJX5AwgdpQuFHCj1pmucCKj2/IzyjwGPU9Z/2ECLRxtc3+I jV5Js7CZPis+ETuMH16c7fAub6Z+VR5vvsgaonIITJHr3hFHMhnvBO97VLZaGHxk 7eKeC8rPp6cevws95cCqHCvkLd9+NQUStUiuMwrp0Y/SPQ2ZeybX6n8l3J1V2P2E t2fyX70RDxPw2stDuBu8K0XlI0zmC8Ize8nz0o8indH53Ch6n6nu3pRQH5yxvEvW wo23Phqv5IPu+0yTyKivd0cj6ByFbWHUUpEfr74tA2zfx2qlLxkNUqnbsV0HwOVb /ijdylD9iMXDnddBuWAnNc7/23YxVClw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=zlaQrBXinBXzDlhDn As35hT/I2wZu40eiTHmXvUYMUY=; b=LJ5yopAW4haHhOh2ZnHXdSHBW+E4u5A8o dyTWkBiLIXt0Zrj+TNRpXGP0/QuOSNwdQo8HK1s5aGPBwt70os/3YdA82/2D0Ke3 /iZ8sVwlNYLWUK3KtxiFxoAmvDorF/vkAJtHzp14yGhapmqrv0mtdIm583oKIOry vFbZcjx9KDL0AOvZQOYzdOtk5uYHeXcV+n7x1UB2JYzjOzfxskzo0NlLQu6uZlgm 8b1Tb76OtTjalBFNnqyZcX2HYPvyojiPQLUPREsNP9z55kTdfRKz2AChXo73Au/l YMZTqLiN1vVmaTpv5FjumiCS5G2PX9GJA+/V33k2HOwBLl+0PWTEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrfeekgdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehttddttd dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepleeggefgvdeijedvhf dugfegtefgkeekueeileejjeehudeggeefteeghfeuffeknecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih htthhonhdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Jan 2022 01:28:35 -0500 (EST) Received: by athena.silentflame.com (Postfix, from userid 1000) id 0C98C1B65FF; Sun, 30 Jan 2022 06:28:34 +0000 (UTC) From: Sean Whitton To: sbaugh@catern.com, 53626@debbugs.gnu.org Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects In-Reply-To: <87wnii73x5.fsf@catern.com> References: <87wnii73x5.fsf@catern.com> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Sat, 29 Jan 2022 23:28:33 -0700 Message-ID: <87a6fd68ku.fsf@athena.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sat 29 Jan 2022 at 07:11pm GMT, sbaugh@catern.com wrote: > An existing *xref* buffer doesn't have its default-directory changed > when running project-find-regexp. Since project-find-regexp switches to > *xref*, that means running project-find-regexp twice in a row may search > two different projects, which is unexpected. I think the problem is the let bindings for default-directory established by project-find-regexp and also project-switch-project, which latter I was using for testing. These bindings hide the buffer-local value for default-directory in *xref*, such that xref--show-xref-buffer is only able to set the binding's value, not the real buffer-local value, and so when the let forms unwind *xref*'s old default-directory is restored. Neither project-find-regexp nor project-switch-project should special-case *xref*, because it looks like xref-show-xrefs-function could be such as not to use that buffer. One possible fix is the following patch, plus something similar in project-find-regexp, but it feels whack-a-mole -- there are other similar bindings of default-directory in project.el. And it is not really correct because perhaps the command would like to set default-directory in whatever buffer the command was called in, without knowing its name as xref--show-xref-buffer does. > @@ -1605,9 +1605,12 @@ > (let ((command (if (symbolp project-switch-commands) > project-switch-commands > (project--switch-project-command)))) > - (let ((default-directory dir) > - (project-current-inhibit-prompt t)) > - (call-interactively command)))) > + ;; Switch to a temporary buffer to avoid shadowing a buffer-local value > + ;; for `default-directory' that command might want to set. > + (with-temp-buffer > + (let ((default-directory dir) > + (project-current-inhibit-prompt t)) > + (call-interactively command))))) > > (provide 'project) > ;;; project.el ends here -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 02 22:15:51 2022 Received: (at 53626) by debbugs.gnu.org; 3 Feb 2022 03:15:51 +0000 Received: from localhost ([127.0.0.1]:54100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFSb8-0003uP-Mb for submit@debbugs.gnu.org; Wed, 02 Feb 2022 22:15:50 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:39755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFSb6-0003uB-8V for 53626@debbugs.gnu.org; Wed, 02 Feb 2022 22:15:49 -0500 Received: by mail-wr1-f52.google.com with SMTP id g18so1876718wrb.6 for <53626@debbugs.gnu.org>; Wed, 02 Feb 2022 19:15:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=SBdkTt7DF60BXQLvHtnwar3gacRyj1/0iEXkKTwaJj0=; b=VzqZfnOehnrJGchMmWLn9ibp43ImM0wiRoeILEAbc8O4YX/jWz7Iu7j7Qg5POrFXJh Wi+3MLSWJZYw56adFtludMitl6KfDQJKoDfqc7RRQwkSte7bApmpvzKRECd3Sn233zXN UiNj4+6PCdky3T5TRHjN49aqZ7nJdrmrzsGLC5Z6gmukXeVoYw3DJoTbu7u8GmJmokUB lMMZ/tRixP3w/MCrLrfVjvD7b0z42L/2anXuaWsLjaYOtgXYKBLBfgyvnL1ZrJJ1hfhA i3m400+S/Kk4cJHKJxQ8sKUUYksYBBgg66Lr5KkzvIoqQziZVyk2ftwBKiXgu4MYVgI1 VYXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=SBdkTt7DF60BXQLvHtnwar3gacRyj1/0iEXkKTwaJj0=; b=cUlRA8a7pvPt0yOVkco3KHvuPwheszq6UFAS0rlBHKjkyLHgasPqUN+hhNvEkPT0y5 H+qzUfCNxk1eP+DCP8Yri9s7teEu2rh89BcSk3INcRv413Fi1ynucoSFt0AGUArVzCde 1Evfb06XSTA4C8nDyQLw7oWKcYZZlELP9ifJ8EJkCKEZPgYFpYbkOvhWMYGGIyNOC3Zj NKhjmmvShzYHfaOx27S12agUwr53/yn2RoWv+Lf3vQ19120fctOLNPtoNXxZMTPE/VfN j1i//6Kity5ALzmzTwwnc6oLlLsIwd+mFoSIIiJIu+khL5CuyVhDAbfkUu3GOXnRJ7v4 eAXg== X-Gm-Message-State: AOAM530vT92jjZ9/nFe1Xr8RVKSvVPGVkFxYLHG/h6/LbtBcHzqoVn8K /I7seWFLjoVbP4GJ0ix3uyg9kNoj17w= X-Google-Smtp-Source: ABdhPJw561aGWPV8sAundwy+FpoRX16BLdz2JKQL0Mwk/t4C9TBHYmhaa7+DLFy8B6mDiKSVdVyUSQ== X-Received: by 2002:adf:9d8b:: with SMTP id p11mr27159878wre.185.1643858142206; Wed, 02 Feb 2022 19:15:42 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n11sm812207wms.3.2022.02.02.19.15.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Feb 2022 19:15:41 -0800 (PST) Message-ID: Date: Thu, 3 Feb 2022 05:15:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US To: sbaugh@catern.com, 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> From: Dmitry Gutov In-Reply-To: <87wnii73x5.fsf@catern.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi! On 29.01.2022 21:11, sbaugh@catern.com wrote: > An existing*xref* buffer doesn't have its default-directory changed > when running project-find-regexp. Since project-find-regexp switches to > *xref*, that means running project-find-regexp twice in a row may search > two different projects, which is unexpected. > > Steps to reproduce: > > With buffers in two different projects as detected by project.el, do the > following sequence: > > 1. Switch to a buffer in project A > > 2. project-find-regexp, which will search project A, and create and > switch to an*xref* buffer with a default-directory pointing at the > project root of A > > 3. project-find-regexp again, which will search project A again. (This > is the desired behavior) > > 4. Switch to a buffer in project B > > 5. project-find-regexp, which will search project B and switch to the > existing*xref* buffer (which is still pointing at project A) > > 6. project-find-regexp again, which will search project A instead of B. > > Suggested fix: > > Change project-find-regexp to reset the default-directory of the*xref* > buffer used to the most recently used project root. This sounds like something that was fixed in commit b99848c72cb2570c (meaning, about a year ago). I have tried to quickly reproduce this in my build from master, and hadn't managed to. How recent is Emacs that you're trying this in? Do you perhaps have an older version of project.el or xref installed through ELPA? Or did you maybe use project-switch-project, doing a search from its menu, like Sean seems to be hinting? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 03 08:28:56 2022 Received: (at 53626) by debbugs.gnu.org; 3 Feb 2022 13:28:56 +0000 Received: from localhost ([127.0.0.1]:54851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFcAS-0001Ua-Ed for submit@debbugs.gnu.org; Thu, 03 Feb 2022 08:28:56 -0500 Received: from wrqvvpks.outbound-mail.sendgrid.net ([149.72.131.22]:63762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFcAO-0001UJ-8A for 53626@debbugs.gnu.org; Thu, 03 Feb 2022 08:28:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:content-type: content-transfer-encoding; s=s1; bh=lbFJjTtyaDv16gXjHt7URyC9PqHuNhjmBozHPVX+7rM=; b=kQUUHpMOOrZ//t8zDsi1keJ+Su9WOawS1w+tbYtGubc0aqfyEpw3yAnNInYfEP6YO/oR 286/q/hPnM7SPny+efF4wACxnSnUPnCjbAN6STCB23aTU+0JqHHCZ1nPVD7EgRwydeEhXB 9vcyDreqxDbDe8U/WJh3mXOWtvR3iB/8BRrTEhi3S53EDQjnxnYS5ibuGgHOtM9Hc2TyQj xx1c2CNVJDey0gNJ4+1mumegUuZBnTEzcw9CXhLIy0Q7RBBnw0tiFpjYAYuwSHo5rvG01A dRMMAD3luJgPjCvY2JQUqaCkwj8HbN//jwwUT8lcOvQNAj0NbAH5y8ydt3jhG1gw== Received: by filterdrecv-75ff7b5ffb-q2hvm with SMTP id filterdrecv-75ff7b5ffb-q2hvm-1-61FBD88E-14 2022-02-03 13:28:46.308970137 +0000 UTC m=+13360110.153078848 Received: from earth.catern.com (unknown) by geopod-ismtpd-5-3 (SG) with ESMTP id zIbaoEv_Q-qXBkX9dsHz9w Thu, 03 Feb 2022 13:28:46.013 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver= Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 4A25F6000F; Thu, 3 Feb 2022 08:28:45 -0500 (EST) From: Spencer Baugh Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects In-Reply-To: References: <87wnii73x5.fsf@catern.com> Date: Thu, 03 Feb 2022 13:28:46 +0000 (UTC) Message-ID: <87leys6pv6.fsf@catern.com> MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?GW3oCMoYnalRiojMOuLzE6x2H5kORXvlCdz1UwQVRMVT4fbh9ODEfCogOe74cO?= =?us-ascii?Q?rI4e0V+MFZgakz9Re5a6=2FCgkMThpMfj7XI=2FIDxA?= =?us-ascii?Q?5Gj=2FlM2ZFMchyt7MEuvloQLRYr1ROLOCWUkvdvC?= =?us-ascii?Q?ukQzkxVZOsLaUZ=2FOc6yNSmkiGwiiNxxhZQyMaun?= =?us-ascii?Q?TIdkad=2FJ1rdyhzKL2dBTjF2q6iAlv9z8dpDsrMm?= =?us-ascii?Q?PPvA=2F1IIwNLrhjrdo9KlhB0J1oaTVh9xvYDdDT?= To: Dmitry Gutov , 53626@debbugs.gnu.org X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > This sounds like something that was fixed in commit b99848c72cb2570c > (meaning, about a year ago). > > I have tried to quickly reproduce this in my build from master, and > hadn't managed to. > > How recent is Emacs that you're trying this in? Do you perhaps have an > older version of project.el or xref installed through ELPA? > > Or did you maybe use project-switch-project, doing a search from its > menu, like Sean seems to be hinting? You're exactly right, the bug is only on an old Emacs. I can't reproduce it on a recent version. My apologies, I thought I had repro'd it on recent Emacs before submitting this. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 03 08:59:02 2022 Received: (at 53626) by debbugs.gnu.org; 3 Feb 2022 13:59:02 +0000 Received: from localhost ([127.0.0.1]:54875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFcda-0002Gg-4Z for submit@debbugs.gnu.org; Thu, 03 Feb 2022 08:59:02 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:36855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFcdV-0002G5-MQ for 53626@debbugs.gnu.org; Thu, 03 Feb 2022 08:59:00 -0500 Received: by mail-wr1-f46.google.com with SMTP id u15so5250557wrt.3 for <53626@debbugs.gnu.org>; Thu, 03 Feb 2022 05:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ul0Upr86Pg/G6zFKRQEKibsHh8sh/xtFZ4ujxg0iaiE=; b=W1ow1eafn3vXgpLBxVJOC7R+bwUcCbg/Ybp+gQL48EzZgwfVcO80r7gKjtUmDWsXB2 WTbySdOvdS3uwQt4TktpNdMtGmC5A6w3KlFLJd7qv9e2KkdsbdCrDYBqMyC82g1cdCdm aTWYrOUbjXOWtFZMiAdsbdCEiJg+JRof93E1QMi/gs0NvyQQ9aluPfIqVAQYVjpsmZ4G LguBEf5QdD7wonsNJwGeFelNjBbkjJig9FNG1aErHeqdVApXXhJE38Kk5PsVyYSNBr1x GAVbqMDXq0nTGZ2VdCR5cBrUUkSYwv/fxyOGTj9XNzIqjje41hDO9NEL9lc8Te9GmRCJ 3Vig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ul0Upr86Pg/G6zFKRQEKibsHh8sh/xtFZ4ujxg0iaiE=; b=BlsNWqNhLe+eIwGL/ZKBMSf8JeD1SR1H0XDWdvmxyYmc2corEVr7xHzXcUQZ6/XWzf tZBNdvp5wQjA7c/5V8p0AeXatx7bAcQLLpG5lSnT1YCZlimxIXxe9WLZLmDA22DdYVPF qJS6YERw0bHcad0on2Da4ZOe5MJU2fTmzN8luxUaHkU5HfQlrUin2/tKc6osTIIG8H5W l0m9eBGr3xHL9av4ggXS4TGmA/BtvdVjjHN+uQQn2JRcSOyGHxlrJKw3944USlPP9dW8 9nMNen7op++zF44LK55/9I8yQDFzb2Eq71N7GACE9KXr6aL1PPdjBb4Skan0NAkzE5z7 4ltw== X-Gm-Message-State: AOAM530kn9oIpRP9X8kqaX0U16WOOyIqYU3YY6eAiQkX8FKbB4wInVPw 6E7dN2Im+A5iIRSTtF/gYfIvPmI5i8g= X-Google-Smtp-Source: ABdhPJytsX6sEGrKt6b7b6NGP/K0B2oi03i9QM9ktCjy5Ai3vJ6dQo7G/ryOtxnu33ZrYMucoznnVw== X-Received: by 2002:a5d:67d1:: with SMTP id n17mr29136850wrw.271.1643896730657; Thu, 03 Feb 2022 05:58:50 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m6sm23507155wrw.54.2022.02.03.05.58.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Feb 2022 05:58:49 -0800 (PST) Message-ID: Date: Thu, 3 Feb 2022 15:58:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US To: Spencer Baugh , 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87leys6pv6.fsf@catern.com> From: Dmitry Gutov In-Reply-To: <87leys6pv6.fsf@catern.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 03.02.2022 15:28, Spencer Baugh wrote: > Dmitry Gutov writes: >> This sounds like something that was fixed in commit b99848c72cb2570c >> (meaning, about a year ago). >> >> I have tried to quickly reproduce this in my build from master, and >> hadn't managed to. >> >> How recent is Emacs that you're trying this in? Do you perhaps have an >> older version of project.el or xref installed through ELPA? >> >> Or did you maybe use project-switch-project, doing a search from its >> menu, like Sean seems to be hinting? > > You're exactly right, the bug is only on an old Emacs. I can't > reproduce it on a recent version. My apologies, I thought I had repro'd > it on recent Emacs before submitting this. Thanks for checking. If you're running an older Emacs (27 or older), you should be able to install the latest versions of project.el and xref from GNU ELPA to avoid this problem. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 03 09:00:17 2022 Received: (at 53626) by debbugs.gnu.org; 3 Feb 2022 14:00:17 +0000 Received: from localhost ([127.0.0.1]:54886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFcen-0002Kd-EP for submit@debbugs.gnu.org; Thu, 03 Feb 2022 09:00:17 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:39867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFcel-0002KJ-8w for 53626@debbugs.gnu.org; Thu, 03 Feb 2022 09:00:15 -0500 Received: by mail-wr1-f46.google.com with SMTP id g18so4873228wrb.6 for <53626@debbugs.gnu.org>; Thu, 03 Feb 2022 06:00:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=GNCKtyicvo/wjcIEGdz2q8w/E1Bv0CNIB7iFDlL5cmU=; b=Iesc/iUPSvEfOI/gvija5cw7jNYcU07gCDVSPooX3/lRYkT8pOY221QjEw7KeYhqgD Km6Lpwf4vPdRSWj/gK7rqIWT8SBLGHOGt4EEScohjAhnOOwPI5qvcIo5tMH87MuDIi4I f/xEaVtYBl89ZmS1iCrnf5IqHN7FO0qWWcGj0k6l6DVA3Up5WsVliS9FEZ5h+bUus8v2 qDAxKOdviRAh/ltsq63/qQmsYGGbE2Bglr9pWoC5ml+wOdwRSzZOHPorc9+27tZWs0J6 HUhX+Iq8KvS8LVk5A37ZfuUyiQtzsHOUzthH9tsD/JpM4z5k1jEk5VlTZfYAtWMQaO8D nL6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=GNCKtyicvo/wjcIEGdz2q8w/E1Bv0CNIB7iFDlL5cmU=; b=Y055uOzYpDo+mkEak5q2VoNBWVa5r52GxBfClYDlOaggGOMgBOT1sqkzF+4mfPcAAN fLfdml2D2MV2ehPuXR16+nShbs8u3SbF0fKpjF0b5ZUkODx/480xY6Au1a6U2vvVrJQ6 Zr5c1E2w63LtaeWT5t1/PrDBRcFRtVsOgC+etcD6h5Jk0T42EYdQmS4ozW1skTRai6VT 6/9B0BWk4PtZIBbt+hUqIbYsDHAVJn5R8A2vswgh0fvxt1Yp9Fe0gCdib7HauUXa427v Sgt7gslsKeoGNWBdwHqcCAncBcPjw5pFfvwpZAlqh1UziO6guIurmIWEvuAvNm/tnjM/ J6Zg== X-Gm-Message-State: AOAM532VxDCq1yBRMxTDKwwbowJKFl7g+tQI83uS1fW8mVkUy9nlaA8D aELtW6qB6IDxZABZi8muFF8mUZBFm00= X-Google-Smtp-Source: ABdhPJwJ6JUbdM1RDMAoyda1zE23FxR533h8cq46LkVQIL9GGkLxhj+WAfO6pn12u/6pcynIkSXmkw== X-Received: by 2002:a05:6000:1a8e:: with SMTP id f14mr19783319wry.558.1643896809170; Thu, 03 Feb 2022 06:00:09 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id s17sm19691368wrm.62.2022.02.03.06.00.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Feb 2022 06:00:08 -0800 (PST) Message-ID: <1276b808-aa22-9ab2-78aa-65cf69a31a20@yandex.ru> Date: Thu, 3 Feb 2022 16:00:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US To: Sean Whitton , sbaugh@catern.com, 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> From: Dmitry Gutov In-Reply-To: <87a6fd68ku.fsf@athena.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Sean, On 30.01.2022 08:28, Sean Whitton wrote: > I think the problem is the let bindings for default-directory > established by project-find-regexp and also project-switch-project, > which latter I was using for testing. Could you also try your scenario with the master version of Emacs? Or with the latest project.el and xref, at least. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 03 10:19:22 2022 Received: (at 53626) by debbugs.gnu.org; 3 Feb 2022 15:19:22 +0000 Received: from localhost ([127.0.0.1]:57410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFdtK-0004v8-9w for submit@debbugs.gnu.org; Thu, 03 Feb 2022 10:19:22 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFdtI-0004uv-UB for 53626@debbugs.gnu.org; Thu, 03 Feb 2022 10:19:21 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 78C955C00CF; Thu, 3 Feb 2022 10:19:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 03 Feb 2022 10:19:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=24UcNMH6Dgz2R5j6sTosY0Izf/Mj0REF96lqSw VILK8=; b=pxm+J4IdTStmixBXSOwQvGLPZraDhH6bShC7HmUFeVJS9sFCBxHe/H on7F7kPb9dnAwcgS0R4fsKaYnFM0AKSa60pgUJ7kN5qdKHENGfAXWrKJX1tsZZyr /zu3v2/NAcv80kc3ga8HF67Ikr1xudASb7fTMLVjWygOPsQkke6HR7l904TpuX7l Y9moiT14aBQ9S434SDfYtZsCs5CCblBX0jf/mGjfgxmdyv4zKUGsI35Vc70qNoZH sU4fa2ZBCluxoij5O40LlRIJXWjQVIh3Egnm1i7vzseqVZyLWJV+bLDB89rdm3Of Y/f/4/VehoJ6HmolFqm476TX1Y2DaWZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=24UcNMH6Dgz2R5j6s TosY0Izf/Mj0REF96lqSwVILK8=; b=le14P8qbbSzYi5PIsdvqTouvv0gGFjAYv JhYbUUkAC5lALpzVqD50unxbE6escEp28EHMqtbi8NePASA+inGr9WURgAG28VPb PIqteuFaKvl0sKcs/OgKmWgU2tSi9WAVAn6yG8uJPuRwudO1MUtu8IFnec2I+gEL zimiGOkEtUP21+FRyY2BrYwAb6RWLIj5SawOIiDvtyR+BylMew98pVBc6cW7twBQ dVbkZQFbD1yHjQAaALNutfEDaznLkNcous/dwc7Pazga6h0ndwZRUPcK8SpfK6eJ x7ugDohfukOO+vZXwmdNmEQ1aFCpgdzWE7uMZoyqASAzeIvtlqebg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgeejgdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeelgeeggfdvieejvdfhudfggeetgfekkeeuieeljeejhedugeeg feetgefhueffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Feb 2022 10:19:15 -0500 (EST) Received: by athena.silentflame.com (Postfix, from userid 1000) id 821D41B664C; Thu, 3 Feb 2022 15:19:12 +0000 (UTC) From: Sean Whitton To: Dmitry Gutov , sbaugh@catern.com, 53626@debbugs.gnu.org Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects In-Reply-To: <1276b808-aa22-9ab2-78aa-65cf69a31a20@yandex.ru> References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <1276b808-aa22-9ab2-78aa-65cf69a31a20@yandex.ru> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Thu, 03 Feb 2022 08:19:12 -0700 Message-ID: <87o83ogeq7.fsf@athena.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Dmitry, On Thu 03 Feb 2022 at 04:00pm +02, Dmitry Gutov wrote: > Hi Sean, > > On 30.01.2022 08:28, Sean Whitton wrote: >> I think the problem is the let bindings for default-directory >> established by project-find-regexp and also project-switch-project, >> which latter I was using for testing. > > Could you also try your scenario with the master version of Emacs? > > Or with the latest project.el and xref, at least. I was using master as of one week ago to test and looking at the code as of the day I was writing. And it doesn't look like there were any relevant changes to project.el or xref.el in that time. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 03 10:42:10 2022 Received: (at 53626) by debbugs.gnu.org; 3 Feb 2022 15:42:10 +0000 Received: from localhost ([127.0.0.1]:57427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFeFN-0005U8-U7 for submit@debbugs.gnu.org; Thu, 03 Feb 2022 10:42:10 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:38709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFeFL-0005Ti-HA for 53626@debbugs.gnu.org; Thu, 03 Feb 2022 10:42:08 -0500 Received: by mail-wr1-f45.google.com with SMTP id s10so3256577wra.5 for <53626@debbugs.gnu.org>; Thu, 03 Feb 2022 07:42:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=fLExsb7YOcrNMYHnhaBmPWcmWxlrtQxzIE1CwA4pHYM=; b=eI5jDUcUk4CSHq/Mw9b3T3u0WEv+vf5/9zGjh+iDmn9/93ajzi0KYmOYXqcqLe8fnB QEsTwBRJQDebQ+7yKpTt0ePcqsyZLW/E4hWQVIOnFKEp7Pev6cuSIGnrRCmNzNR4V9hH UPTqtFrER1knxEzYcUGWLRWfyBsc5dcE0RTzD18AOx4mGi+O5kRo8x6U8MEaUzMsyNr0 FG9pazzq20QC3DIvW6OKaN7rJwcisDOeLIFTrU1e4D+ZOmX3Rb8MDMuLISdbwuLO+bZh MgJbSuuDaVmQJsbsPsiWlTgOH51AMR5tiEaI8YwPJqNoA4EQ8npJdjdqjoJdIH/c/Rtr T0iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=fLExsb7YOcrNMYHnhaBmPWcmWxlrtQxzIE1CwA4pHYM=; b=Q/2lHFJiC2j/80JPyEzfCKOsLEcNB4x3wavlQTChsskT1rriBnM9QG9mwpc4Cb2DWq 4cfIVPdvI1MHqwwtfduovR1CwkFtMzTWk7sptR/2OMWoF3ulwqY/2Qm9Tbojjdz6JpfN MIN/CK89xY/ZEEUV/S7yx8QgOo9lH9e+lHR/es7Z84v26OAtks4a4wcX+JKmmRKhXN3u JVLpuUqgimV+TBEwe25mMFUnsfV+iWGg3jPW1CyE31PzHi4LxSMpJxWf33jII6SMwNI6 sXACGJvfAxyUY9o6F8MsyLpw82bX3bBEeJ1GOdGBZp+9+NcxrLIw4ONbKLhE//5UnPKn A/uA== X-Gm-Message-State: AOAM532wKHQfpuPQd/+aXLJOkYivXTYM8LaszaJNATu69T0YSY1vF/jT 80MSCoZVSH1UCt2kjlYfrbA= X-Google-Smtp-Source: ABdhPJxbD2Qokh4r0f8+pismdrxGVlwNSBwNwPRYHo7IF4Hq/8hFGJuA3kERr9Ko6h0AcOdAVnSk8A== X-Received: by 2002:a5d:65cd:: with SMTP id e13mr30165761wrw.472.1643902921424; Thu, 03 Feb 2022 07:42:01 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id 1sm24948456wry.52.2022.02.03.07.41.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Feb 2022 07:42:00 -0800 (PST) Message-ID: <8c8c2201-0356-6934-cc6d-421e06eb2bfe@yandex.ru> Date: Thu, 3 Feb 2022 17:41:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US To: Sean Whitton , sbaugh@catern.com, 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <1276b808-aa22-9ab2-78aa-65cf69a31a20@yandex.ru> <87o83ogeq7.fsf@athena.silentflame.com> From: Dmitry Gutov In-Reply-To: <87o83ogeq7.fsf@athena.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 03.02.2022 17:19, Sean Whitton wrote: > Hello Dmitry, > > On Thu 03 Feb 2022 at 04:00pm +02, Dmitry Gutov wrote: > >> Hi Sean, >> >> On 30.01.2022 08:28, Sean Whitton wrote: >>> I think the problem is the let bindings for default-directory >>> established by project-find-regexp and also project-switch-project, >>> which latter I was using for testing. >> Could you also try your scenario with the master version of Emacs? >> >> Or with the latest project.el and xref, at least. > I was using master as of one week ago to test and looking at the code as > of the day I was writing. And it doesn't look like there were any > relevant changes to project.el or xref.el in that time. OK. Then could you write down your problem scenario step-by-step? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 03 18:16:28 2022 Received: (at 53626) by debbugs.gnu.org; 3 Feb 2022 23:16:28 +0000 Received: from localhost ([127.0.0.1]:58261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFlL2-00060F-0X for submit@debbugs.gnu.org; Thu, 03 Feb 2022 18:16:28 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:33847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFlKz-0005tW-8S for 53626@debbugs.gnu.org; Thu, 03 Feb 2022 18:16:26 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0FC2D5C0071; Thu, 3 Feb 2022 18:16:20 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 03 Feb 2022 18:16:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=hMdfPrDHs3DfWOejO6Z3EXY44OOnz+OLCR+esK +Cve4=; b=djRdDXAA/j8fDUvqcSAmRZT+fGAMD4vnbRFhD91kXr9kiTXM1/XCNO nQYt2ZDqAi48efS6JYgVLD2qKRhT7KAJqs2amTnKufK8+ZUXSJcerQROZO8Ew8bK cNv/19RwuDHfovxi6Rkk1pFhg3UDh1bLfQ/xn7GX1UI5Edab9jLcDimqa30a4pP9 Yp1Z+FE8TYmTfjr8nleQe4fpoh5zCkFHDyZYpExLFOb3hhCVmjkFYt418kkpvi9B KRjSB6amDlmkg1K5IYzXxRg/Wx/nWJPkUYqFTv9FjOQ+8QoI8dvRGuCHOXUDN5df 35Db5jruddZWMxS3SVS5Rh8amgqUTbTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=hMdfPrDHs3DfWOejO 6Z3EXY44OOnz+OLCR+esK+Cve4=; b=NkN0o+hV4QsHnbW52Be2v4O2U/+uZf4zK YchLOajbgXqjLbHceBUllTf0ibVXVXR1oasebPKWz8QfnvWanaPORJK1l8Ajyag8 5F/D9Z9pHgiWh4T0GukrbH6prFIZ6uBQjJrLjcwAWNVo76FcVmHoDrMekK5qymVr z4OM9SMjfo8ZVv+iWUgWB4O26p4OrKkW3y7U66+3UHJchCkfzKpFgOaaLExrUaGC W0kwGKlFQJ6qP0g4+hItXNZeNq6W3Y7wqycsyehtu0CFTERm2t++q4hpovdJi49c cuJyXdhyRKrR+U84m7ruZ6Tb6W5gl5dsN0PosMapbIZKv3EXL50Hg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgeekgddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeelgeeggfdvieejvdfhudfggeetgfekkeeuieeljeejhedugeeg feetgefhueffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Feb 2022 18:16:19 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 3CCCB7E704E; Thu, 3 Feb 2022 16:16:18 -0700 (MST) From: Sean Whitton To: Dmitry Gutov , sbaugh@catern.com, 53626@debbugs.gnu.org Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects In-Reply-To: <8c8c2201-0356-6934-cc6d-421e06eb2bfe@yandex.ru> References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <1276b808-aa22-9ab2-78aa-65cf69a31a20@yandex.ru> <87o83ogeq7.fsf@athena.silentflame.com> <8c8c2201-0356-6934-cc6d-421e06eb2bfe@yandex.ru> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Thu, 03 Feb 2022 16:16:18 -0700 Message-ID: <87pmo35ynx.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 03 Feb 2022 at 05:41PM +02, Dmitry Gutov wrote: > Then could you write down your problem scenario step-by-step? 1. C-x p g foo RET 2. C-x p p ~/src/emacs RET bar RET 3. Observe that default-directory != ~/src/emacs, but instead the root of whatever project you searched for 'foo' in. 4. Thus, C-x p g baz RET will search in the first project, not ~/src/emacs. Can test more if needed. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 03 21:07:38 2022 Received: (at 53626) by debbugs.gnu.org; 4 Feb 2022 02:07:38 +0000 Received: from localhost ([127.0.0.1]:58431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFo0g-0002fX-Dh for submit@debbugs.gnu.org; Thu, 03 Feb 2022 21:07:38 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:34671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFo0e-0002f5-Hr for 53626@debbugs.gnu.org; Thu, 03 Feb 2022 21:07:36 -0500 Received: by mail-wr1-f43.google.com with SMTP id f17so8586039wrx.1 for <53626@debbugs.gnu.org>; Thu, 03 Feb 2022 18:07:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=tzmlgW11Rhb5nQQNopl9ZztRb5frIZsdvlEQBRhKv1c=; b=eIXJcYjBvNr9RaFHCxnM0W36YVAUHIxZnZ8+y7nB0pjg+4qLOVD/Y9oUBF3OcGrMEw zYY+09QRhWPRdGCgs3axyM+dqPk0xU4lUwWqb2M4qLC5h/lS2spv4GoeW62kqUoLb9Kq +fUi6dttShNsQ4VKMmPbZTgNVwemHXnd/LjR1ZmGWbxITqgSVuRWbS7sVT3q/fIM1YZ4 tNDw+2vzZuKmdFK4qlIAmPYgiks+yoXtHR01AybsjUZUzZwyf3F5k/EXPeOPqZTf/iu2 oNIOfvJxYDi1A8VIYkvTwoAMBKzC8QSR9dAOQA1UQddKAM+UAYJO5M+RHkwSL+JgnA2k HCXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=tzmlgW11Rhb5nQQNopl9ZztRb5frIZsdvlEQBRhKv1c=; b=gPMJ/B8f5HS4WUInrQ6o/mgwGOgmSH3Kcec4P5VwKYZ8hnMkZ4QhEjGTatXNJw1tDV ZIzHapIOzZItgVIIoXsS6+HSmgMeFHRlwnpDhiZN4dqTgrtbgjKYhiytR6K6Tr+uGMu7 ext6bKu01GA4QJ/2rH8dbLiOQWMxnKRQnyI8RbRRnAf7DslhLbjrLU9n74Jsgle/56cy w+JFZQvrByeSSGconbkPXg77AKXk+lPYoY4fJWYLupuMqDCUUIDPk8NI8aEFICypoSzU w+vU8DVbYOgB9jcDzkMmYOqxzMqkXIVot1OMi2OYgzX8kRTpFXuqB+B0Uib2VMwWmfHX rz4A== X-Gm-Message-State: AOAM530hfiDQye4i1lM/Nvt78v8ZvtGPnherb7q4Pk24H7GXmj5Sykui l/ulvfv5ZLiN/8B+Uohjcw8Jpoil1VgRYw== X-Google-Smtp-Source: ABdhPJzS0Sqqc3zZhVBk3+lJyM0OErPczGi+i/TcwJR6eJDOa5qlauBJocu/H/vRjuFlvYQ3eiGocg== X-Received: by 2002:a5d:524e:: with SMTP id k14mr530623wrc.620.1643940450781; Thu, 03 Feb 2022 18:07:30 -0800 (PST) Received: from [10.111.251.39] ([194.36.25.24]) by smtp.googlemail.com with ESMTPSA id z13sm515408wrm.90.2022.02.03.18.07.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Feb 2022 18:07:30 -0800 (PST) Message-ID: <648ee2ee-83cb-03a6-d35b-d3e014e181fc@yandex.ru> Date: Fri, 4 Feb 2022 04:07:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US To: Sean Whitton , sbaugh@catern.com, 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <1276b808-aa22-9ab2-78aa-65cf69a31a20@yandex.ru> <87o83ogeq7.fsf@athena.silentflame.com> <8c8c2201-0356-6934-cc6d-421e06eb2bfe@yandex.ru> <87pmo35ynx.fsf@melete.silentflame.com> From: Dmitry Gutov In-Reply-To: <87pmo35ynx.fsf@melete.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04.02.2022 01:16, Sean Whitton wrote: > 2. C-x p p ~/src/emacs RET bar RET You probably mean RET g bar RET. And it seems the key is that the search is performed while the *xref* buffer is current. With that condition, I can repro, thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 03 21:32:55 2022 Received: (at 53626) by debbugs.gnu.org; 4 Feb 2022 02:32:56 +0000 Received: from localhost ([127.0.0.1]:58443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFoP9-0003H4-M0 for submit@debbugs.gnu.org; Thu, 03 Feb 2022 21:32:55 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:45821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFoP7-0003Gq-Ao for 53626@debbugs.gnu.org; Thu, 03 Feb 2022 21:32:53 -0500 Received: by mail-wr1-f49.google.com with SMTP id m14so8575587wrg.12 for <53626@debbugs.gnu.org>; Thu, 03 Feb 2022 18:32:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=DaseFAiRnapxQ8/wF34f0E9oJbtRWTUp6S/Ng4YQgDg=; b=dFxvIE9mVT7lGLayJ4iFFuPYdH54T73ndN5nVO8qLLj0EizFztXVS2Q4CNi9FCvl1f WqbChivHLqAUwT7ypb8qgho3B+QRxEz4qw+GLYYlMMfzWsPfLAoEf9qj2YuKEnnrF4EU BTT5l/Qs3c3+EMGprW75jlk5VixxKlksJZ0Y2QcINVNDzUswDYJg6c5GM5brjh5KeA5m ulJrbi6OeTb31sJl1vFySoCQUA86gTs2cYfynC88LOTTiLc0yur6KIeMyR5/AWIYcEJw DfYu/rWsh1TcAlsUJ4JkOvKnWRvkuHT9Hiah44hSMe5/6VQ3xWsFa0qP2pY5IFNu8e5v JYKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=DaseFAiRnapxQ8/wF34f0E9oJbtRWTUp6S/Ng4YQgDg=; b=QJ6XQLYf82Nz5youPCmlf7NDCGKx/gfB/FJ8H41sqk3KaQ6fKE2fCtTtdx+jrpan/O BHw9PPi+J96DQ2cKAXiA5KPqQpU+RnsPUDsqjfMxAK3Z3dUjPXGqSJwBIk9RtlELmd1v kGg+yWyyETpRrWQlY0NKBXcNLnj+EpRlKvhaiLWW7yDSwo3MeuM+98bw3kHATw4bMzl0 1qAOFNYxGi4YIzQenLZG+gmmJm//n+J3jLa7gig2e6ECT9dUlkEkEAaZrQh4t0sn2UrS oJFgxVbsJU4d3ToFWzkMKiKqOw4cFknUYv3N14GD2/mUrQNGHYbl5/I5rxQvsow76U5Z 4AQg== X-Gm-Message-State: AOAM533FWE8lONC8/ZwoxQa4+4lQZNuODr4WZaUHqU8GqjmOOUWzBYLu U9F4rc2iH2Cg83+dVm/sJIU= X-Google-Smtp-Source: ABdhPJziEylQNIB6NvXfEM0q5GyfjWJP9vk2HTEmZUEidLZWz9PcpYtrJfrO9gR1+rwsGpvsilG3rw== X-Received: by 2002:a5d:6e12:: with SMTP id h18mr578599wrz.674.1643941967348; Thu, 03 Feb 2022 18:32:47 -0800 (PST) Received: from [10.111.251.39] ([194.36.25.24]) by smtp.googlemail.com with ESMTPSA id q2sm471750wrw.14.2022.02.03.18.32.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Feb 2022 18:32:46 -0800 (PST) Message-ID: Date: Fri, 4 Feb 2022 04:32:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US To: Sean Whitton , sbaugh@catern.com, 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> From: Dmitry Gutov In-Reply-To: <87a6fd68ku.fsf@athena.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 30.01.2022 08:28, Sean Whitton wrote: > These bindings hide the > buffer-local value for default-directory in*xref*, such that > xref--show-xref-buffer is only able to set the binding's value, not the > real buffer-local value, and so when the let forms unwind*xref*'s old > default-directory is restored. I have to say I'm surprised by this mechanic: not even setq-local helps. Guess we could kill the xref buffer every time, instead of erasing and re-filling it, though. Like diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 4efa652084..bb08db726b 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -1111,6 +1111,7 @@ xref--show-xref-buffer (xref-alist (xref--analyze xrefs)) (dd default-directory) buf) + (ignore-errors (kill-buffer xref-buffer-name)) (with-current-buffer (get-buffer-create xref-buffer-name) (setq default-directory dd) (xref--xref-buffer-mode) It has the unfortunate side-effect of having that buffer displayed in a different window, though. Or at least the possibility (though it happens every time here). Maybe some kill-but-recreate-and-show-in-the-same-window-first kind of hack would do the trick. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 04 00:32:29 2022 Received: (at 53626) by debbugs.gnu.org; 4 Feb 2022 05:32:29 +0000 Received: from localhost ([127.0.0.1]:58627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFrCv-0007lh-B8 for submit@debbugs.gnu.org; Fri, 04 Feb 2022 00:32:29 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFrCs-0007lM-A8 for 53626@debbugs.gnu.org; Fri, 04 Feb 2022 00:32:27 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DA5A55C01C5; Fri, 4 Feb 2022 00:32:20 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 04 Feb 2022 00:32:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=vIcuQTT3crcEpyRM2PgV+EiTAnTUSzLqv6ccBD LrH24=; b=HV+XkqnQ7dWD2HP4rqxs7Vy9dRyQhJezWs32fZxFayTS7uyC8wpIS5 b5sqs14w1ekSmfyr31NhLY5XF0dSFVHK8vD+W5crFREUyZuazYxVJPeyvsjd1CdH cRJcRvxv/BCbY24DtgbBbbiqVdAYyIdiE2NSPZkzu4639ALkKIdJEotq16vlkjEy aDEcqGVM2SG4ZzXkPR73iUomC269ByqoC/44v/UpGrj8admem/S8VO/AkYVhGJl9 Cs+oNx8rI35k1kkZZIv+cC3nLySr5YICm1xt4qPalExMOQ276NfNQL2ROthYaXCZ /kAVPg7H7XFzE+/LhNEEc/Kg21hRiC2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=vIcuQTT3crcEpyRM2 PgV+EiTAnTUSzLqv6ccBDLrH24=; b=gqH0mGmbKCJuglcilmLIIPjqcxTRIxO+9 RCjRs8qk59CWTLu7ZOiJcoXzW8MBBsCRrI+TbyFkXxzcy2087q4I1wFoWLW1+LrU PZatqeYxK0opjDPBneNRqd/zz9TopSk1QRnax6ALPUo0aw+ZwCRS+oFPuIGT33Sk qdSGlKjf5j4HxASr4vPVi3fh10iFfnqDpK1jeL9Qw23IGzzwESnd3iTrLq0nw746 IvsDdnOOHgVuE6d/lXoEQoSyQdgSblDYatOWOBJ/l2mNORGi0Ib8374k6LeSfcm1 5FIG/Qp1vDcc7DnUTWQCBE3c3EqhlX7K9jzqmlB515xgHJcxHniqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgeekgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeelgeeggfdvieejvdfhudfggeetgfekkeeuieeljeejhedugeeg feetgefhueffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 4 Feb 2022 00:32:20 -0500 (EST) Received: by athena.silentflame.com (Postfix, from userid 1000) id BD0C81D25BD; Fri, 4 Feb 2022 05:32:18 +0000 (UTC) From: Sean Whitton To: Dmitry Gutov , sbaugh@catern.com, 53626@debbugs.gnu.org Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects In-Reply-To: References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Thu, 03 Feb 2022 22:32:18 -0700 Message-ID: <87leyrgpst.fsf@athena.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Fri 04 Feb 2022 at 04:32am +02, Dmitry Gutov wrote: > On 30.01.2022 08:28, Sean Whitton wrote: >> These bindings hide the >> buffer-local value for default-directory in*xref*, such that >> xref--show-xref-buffer is only able to set the binding's value, not the >> real buffer-local value, and so when the let forms unwind*xref*'s old >> default-directory is restored. > > I have to say I'm surprised by this mechanic: not even setq-local helps. I guess that's dynamic binding for you :) > Guess we could kill the xref buffer every time, instead of erasing and > re-filling it, though. > [...] > It has the unfortunate side-effect of having that buffer displayed in a > different window, though. Or at least the possibility (though it happens > every time here). > > Maybe some kill-but-recreate-and-show-in-the-same-window-first kind of > hack would do the trick. Maybe we could rename the old buffer to a temp name, then create and fill the new one, then set the old buffer's window's buffer to the new one, and finally kill the old one. But this is not nice at all. How necessary is it that project.el set up this binding? Is there something else it could do to achieve the same effect? At worst, it seems better to special-case *xref* over in project.el than in xref.el, but you have a better overall perspective of the two libraries than me. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 06 22:12:14 2022 Received: (at 53626) by debbugs.gnu.org; 7 Feb 2022 03:12:14 +0000 Received: from localhost ([127.0.0.1]:40582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGuRq-0001Uq-7S for submit@debbugs.gnu.org; Sun, 06 Feb 2022 22:12:14 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:37558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGuRo-0001Ud-Sd for 53626@debbugs.gnu.org; Sun, 06 Feb 2022 22:12:13 -0500 Received: by mail-wr1-f50.google.com with SMTP id w11so22271641wra.4 for <53626@debbugs.gnu.org>; Sun, 06 Feb 2022 19:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=db48dHpNJAi56Rsus2rQt9v+30DnBMyNd+RmD80AkMQ=; b=QFuX9Ax++AoMnG808HYYqa9wBlPATr8T2htSS7Jrb6gVYKHIP9I5TP09lK7n6pYeL7 GEWUI8FxrBMzw1Z9840jQD3ONR1yYotqW20XCtAQiTQU5NhAmCAzDMIQBP60trtvRdNN qujSFZHqatt+DHQAAZZrhE8nigA9gkCQi3OTozazyLWfT96fR1VCM9uqcDR7uUzQy9hK V8AoNII/gdie1eBWt0SCZb9I0HcS+z0kuiM0CSoYVC/h89UnYTLJIxlE4+0rHjL5/gC4 1NTvi3fZgvylHDPNWLps9AVcVydHsMQ3QD2gPasw0NPja8gRlcKAj89gkbc7+ix6a45z fhSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=db48dHpNJAi56Rsus2rQt9v+30DnBMyNd+RmD80AkMQ=; b=KxUfidpPKUkWmjeIk8DA3m74u8Z9ow8DwERGtosEig7Shc5fjcJoUpgGtU1mYa85Pz Qiex8w8IWeQmhaFiJeMl0HhKzxMpoOA74vHQSbx5zyGXZZo7i0reGG8zvy+wFzV0oZmq hjs/qozNqyuIG3i5B0jDKw//ZO8CdJqJDFIwb50IK479Tur3qQaSd3XbMlJPHVbqYhJ6 /89MLvMfbWStkJ+A92bSLIaxaxVkygcgbiqe9L5zgmBgF7EJn/JXVCDGyckiyYb9YQyI lJ68ncngaDUhIVxwoQaLrw9BJ8XLFh++FJh70gMp2hcxe3kwtg1gHfqbU782uYrqoE6l asxw== X-Gm-Message-State: AOAM533qaIAa4R4ypnJyvCiOW0KeVBbk7Sm5XdjzmKuvZ/tAfyjXjybo sdM0ghNSMTitgcQJQZCtA8M= X-Google-Smtp-Source: ABdhPJxAqpYQu1QF+XZDa+aOfhlNzB+8OqjVuNnGYC5yJ+KghOzrOrGESnny/ir0kpt18Rz5JcYbFA== X-Received: by 2002:a5d:6483:: with SMTP id o3mr7963684wri.67.1644203527134; Sun, 06 Feb 2022 19:12:07 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m12sm9757443wrp.61.2022.02.06.19.12.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Feb 2022 19:12:06 -0800 (PST) Message-ID: <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> Date: Mon, 7 Feb 2022 05:12:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US To: Sean Whitton , sbaugh@catern.com, 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <87leyrgpst.fsf@athena.silentflame.com> From: Dmitry Gutov In-Reply-To: <87leyrgpst.fsf@athena.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04.02.2022 07:32, Sean Whitton wrote: > Hello, > > On Fri 04 Feb 2022 at 04:32am +02, Dmitry Gutov wrote: > >> On 30.01.2022 08:28, Sean Whitton wrote: >>> These bindings hide the >>> buffer-local value for default-directory in*xref*, such that >>> xref--show-xref-buffer is only able to set the binding's value, not the >>> real buffer-local value, and so when the let forms unwind*xref*'s old >>> default-directory is restored. >> >> I have to say I'm surprised by this mechanic: not even setq-local helps. > > I guess that's dynamic binding for you :) > >> Guess we could kill the xref buffer every time, instead of erasing and >> re-filling it, though. >> [...] >> It has the unfortunate side-effect of having that buffer displayed in a >> different window, though. Or at least the possibility (though it happens >> every time here). >> >> Maybe some kill-but-recreate-and-show-in-the-same-window-first kind of >> hack would do the trick. > > Maybe we could rename the old buffer to a temp name, then create and > fill the new one, then set the old buffer's window's buffer to the new > one, and finally kill the old one. But this is not nice at all. Right. > How necessary is it that project.el set up this binding? Is there > something else it could do to achieve the same effect? > > At worst, it seems better to special-case *xref* over in project.el than > in xref.el, but you have a better overall perspective of the two > libraries than me. I suppose which is the better fix depends on whether we consider it to be important for third-party or simply new/future code to be able add a let-binding for default-directory to affect xref's behavior without having to worry about using a temp buffer. Until now, I've considered it to be a reasonable approach that shouldn't cause problems requiring the code author to travel down the call chain for investigation. But maybe that was a bad assumption, and the added complexity of the approach described above it too much. I like your first suggested fix well enough, FWIW. I wonder if we hit this problem in Emacs in some packages in the past, and how we chose to solve it. After all, default-directory is always buffer-local, and modifying its value is a common thing to do. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 20 20:56:05 2022 Received: (at 53626) by debbugs.gnu.org; 21 Feb 2022 01:56:05 +0000 Received: from localhost ([127.0.0.1]:34306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLxvp-0001bi-Cl for submit@debbugs.gnu.org; Sun, 20 Feb 2022 20:56:05 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:42995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLxvn-0001bE-8v for 53626@debbugs.gnu.org; Sun, 20 Feb 2022 20:56:03 -0500 Received: by mail-wr1-f46.google.com with SMTP id h6so24413135wrb.9 for <53626@debbugs.gnu.org>; Sun, 20 Feb 2022 17:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=gQ1EQ/+VDHPnwLlNSPgPmHVSz5htjqGfIIaaHRjg5B4=; b=hZc1/9bp4XSzgbeSwJiJyowR1UZbQgbldO8zysMaXKl6ogLQnDcqL5Hlph5NMXPaON 2tVKMCCkAbC/0J8nMrfCGA4DFk4GfwHh+fSdrp9UEAnLN+S+lFkdPDbtqJOIgYz0t4Yt ciEpEFeVeksNMdDA1O1KBK0GznJDfgZ4vbJtfWlpUwbGafcpx1KPktAjNICdvvM4PSr6 ep5/KvbdwJN6Lb48gIr4HZ28qIRaj/pyxoj2JHmEblbXpqp5sUucAPABO3E2RFDTmp7i cUC4jpPYpNkNjPwPyJdq/V/SIOv+IKXDrZ46t+Z5CwhSLQ9LteCkqHXZ4Ol2uclAmz0I 5+LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=gQ1EQ/+VDHPnwLlNSPgPmHVSz5htjqGfIIaaHRjg5B4=; b=nrZHLqD9lN3iw1AyvZSMdZUnPPV+Xw8Wxs5jOm0nfakOYMIGUvKRCWypUWgBiohUWU birAIHXe3WIYf6g/WIeqChqwlDBsassqQutn0A+IJW9Rx57W2yDkGsAp5/1f1y7rBtdb XDEONaeagvX7iLULiTwA6coBIjrNhhoerJU0Yusy++jYYPrK9NdbDbFfQp5/iLE679ZM kB2LoEE3/dGy6wnvhvhcofPwN79+ckKawBngoXzcONsDK9p98FijfWXLZsLyG0R+nnFo Xpr4LzIS+CXasdJ0N8DwuFXir5c04/4pzzxCzyMSd6OIIH9lUTY/v1ysOwZmcemMCzVW fsiw== X-Gm-Message-State: AOAM533ATCYOp7IeCKgwdwzY30EFPWxaswTctsQjpS77Q3OMWo3gy8bh gCTpd3uEjBrDYXoH5j4XLRMrNUdsA1g= X-Google-Smtp-Source: ABdhPJxWJdojSiNVJpLBOMc19wDbbya1nQEPifer0BjUSCBvIujreE8MhRb7r3E7TguebW9Q+43UOg== X-Received: by 2002:a5d:53cb:0:b0:1e7:5e87:9c6c with SMTP id a11-20020a5d53cb000000b001e75e879c6cmr14337175wrw.696.1645408557228; Sun, 20 Feb 2022 17:55:57 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p27sm13055655wms.1.2022.02.20.17.55.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Feb 2022 17:55:56 -0800 (PST) Message-ID: Date: Mon, 21 Feb 2022 03:55:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US From: Dmitry Gutov To: Sean Whitton , sbaugh@catern.com, 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <87leyrgpst.fsf@athena.silentflame.com> <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> In-Reply-To: <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 07.02.2022 05:12, Dmitry Gutov wrote: >> Maybe we could rename the old buffer to a temp name, then create and >> fill the new one, then set the old buffer's window's buffer to the new >> one, and finally kill the old one.  But this is not nice at all. > > Right. We can also try a lighter-weight hack like below. WDYT? diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 784c745477..082d64aaeb 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -1107,6 +1107,13 @@ xref--analyze (cdr pair))) alist))) +(defun xref--ensure-default-directory (dd buffer) + ;; We might be in a let-binding which will restore the current value + ;; to a previous one (bug#53626). So do this later. + (run-with-timer + 0 nil + (lambda () (with-current-buffer buffer (setq default-directory dd))))) + (defun xref--show-xref-buffer (fetcher alist) (cl-assert (functionp fetcher)) (let* ((xrefs @@ -1117,7 +1124,7 @@ xref--show-xref-buffer (dd default-directory) buf) (with-current-buffer (get-buffer-create xref-buffer-name) - (setq default-directory dd) + (xref--ensure-default-directory dd (current-buffer)) (xref--xref-buffer-mode) (xref--show-common-initialize xref-alist fetcher alist) (pop-to-buffer (current-buffer)) @@ -1216,7 +1223,7 @@ xref-show-definitions-buffer-at-bottom (assoc-default 'display-action alist))) (t (with-current-buffer (get-buffer-create xref-buffer-name) - (setq default-directory dd) + (xref--ensure-default-directory dd (current-buffer)) (xref--transient-buffer-mode) (xref--show-common-initialize (xref--analyze xrefs) fetcher alist) (pop-to-buffer (current-buffer) From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 21 18:01:11 2022 Received: (at 53626) by debbugs.gnu.org; 21 Feb 2022 23:01:11 +0000 Received: from localhost ([127.0.0.1]:39387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMHg7-00053J-Ld for submit@debbugs.gnu.org; Mon, 21 Feb 2022 18:01:11 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:52325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMHg3-00052r-LO for 53626@debbugs.gnu.org; Mon, 21 Feb 2022 18:01:10 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 63F833200D25; Mon, 21 Feb 2022 18:01:01 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 21 Feb 2022 18:01:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=36TGc2H9P1I/Ja 0qfGLCIhoOHjn/PLPpb/SDWIifIV4=; b=x7AD56j5XjNbbjcn6Uz44jqdnPptGy Ui4oh3VsDxoJ3IqyIi9CpW1m+qKilvtTYMAJCJF/t9a72WIfwh8SYJRXwqdhvjNi 1p5oBv4sGBT/k/8MTHZ64x4E56aNBTB6SXi8DLFeHTJST1Nfad4wNYm7CjYqPJOK KzSgFIFAgtCSMynEHOLOFXjr7khQ1yenjRs9001sRxESaF9I4v+1cVxnLKbGQdmB WR0uF9TisVa28WjnNuWOlFUNGDgHKRGGvAs+USdcW01CzpDk1nUJNTxEMXlgI+t4 bV41Du0joVMTGwfZIr6iqHGiTgTatm3mrBPKCM3nMjHzbjw4NeDw2Qiw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=36TGc2H9P1I/Ja0qfGLCIhoOHjn/PLPpb/SDWIifIV4=; b=Ng8G7I38 UoaoyoSHOcib+j/NOuib2rT/oNljjcY+XZF+gVHhbu7leypkJQWB0zHHtQUapWHn NgDrCS6iSxgAxJBzmUpWH5hXvTjkYYK3ax5bPhjwxwJesrjluUcUAFBd4ExylCYa 6xF28o28v+XAzZeq8xnsMOuk3ZnpMoipZM0Hod8C5eg0iEMpB0MN7UUws0eOI7bh ZcSCJyJ8ATvoykgVD94PrzGa3LyNigVZqHlrWe4Aj3+bOWe+wY+EB/dLO5PZGaDN 3tVyOVACSm2HJ/KlaqCRaTgzTEpBEtkkCkF/5jHy9DjQKf7STxRBWRlSng/2a5DV Xb8EdRH6NEHqaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeejgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgfgsehtqhdttddtreejnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnheplefgffejveelleehkeeuvdektddvudefffeujeegiefhkeej geefffdtgeehkeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Feb 2022 18:01:00 -0500 (EST) Received: by athena.silentflame.com (Postfix, from userid 1000) id 880541D2991; Mon, 21 Feb 2022 23:00:59 +0000 (UTC) From: Sean Whitton To: Dmitry Gutov , sbaugh@catern.com, 53626@debbugs.gnu.org Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects In-Reply-To: References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <87leyrgpst.fsf@athena.silentflame.com> <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Mon, 21 Feb 2022 16:00:59 -0700 Message-ID: <87bkyzvn84.fsf@athena.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Mon 21 Feb 2022 at 03:55am +02, Dmitry Gutov wrote: > On 07.02.2022 05:12, Dmitry Gutov wrote: >>> Maybe we could rename the old buffer to a temp name, then create and >>> fill the new one, then set the old buffer's window's buffer to the new >>> one, and finally kill the old one.=C2=A0 But this is not nice at all. >> >> Right. > > We can also try a lighter-weight hack like below. WDYT? I think I prefer my with-temp-buffer thing to this, to be honest -- adding a timer into the mix seems like it might make debugging harder. Assuming you're still okay with my initial idea, I'll come up with a patch to do it with a macro, and apply it across project.el. --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 21 18:14:19 2022 Received: (at 53626) by debbugs.gnu.org; 21 Feb 2022 23:14:19 +0000 Received: from localhost ([127.0.0.1]:39410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMHsp-0005Ml-0z for submit@debbugs.gnu.org; Mon, 21 Feb 2022 18:14:19 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:34426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMHsn-0005MY-4S for 53626@debbugs.gnu.org; Mon, 21 Feb 2022 18:14:18 -0500 Received: by mail-wr1-f45.google.com with SMTP id d3so13928876wrf.1 for <53626@debbugs.gnu.org>; Mon, 21 Feb 2022 15:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Ejx1ntwLwKqGJCXYzckFTtqhNzW14Rv+dNl9VuN0xf4=; b=XxZpJRSE50WR7olgt1bZ+sPdLKBwlEkx5SvI1X4C7AenIiT5p23oRHWIfbu3NaFVht LGHW9omHF0dx+zwwgU10WO7xGcnqYV4gy4dygQEIoNrVjiBaiw28MhvP49UgbUxBD2H/ iP9lZmVG7L98IkMrQDwAS+YRDdl+dxXJCemo07MXQOXBUfC/n1nirGFLfGAxfQES+laM o/taA7dOtZ2zk7eYUnANSIv8qb63hm84yHOqtj2Zo0h2CnD+9Lr1ucvu98WcwxEcByPo nsiaVseTFD2kR2NChc/9zwtrHlzKhA/2oYKEabixEgMONWrhqjdhkVK5Wmd/EQnryu2u xGBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Ejx1ntwLwKqGJCXYzckFTtqhNzW14Rv+dNl9VuN0xf4=; b=RhHG2aK2KJibgTfbkG5Q9MTI8UwtWgTWemtPwiF4ig2VG47KHzSTvgj/sWQ+jp5ZjF C4MggBKk+0Di6000B09EUJeiYXBTuV65sHFIjuLTh1ZAuUyR3fhBqtHPeFXGg3+EcBL7 6/orWhr4fHYxBraqKJmjj9rJaPcola6uFAhmUGYENuNY9pe5nZ/SMiRdA4UBgCM9PbBQ Y5mKKxejU4mk7C+FvMiXPjDv3zS72FCWAEQR4MdZb/6K/a8opDL4nai025spv6U+luSV QrTKDAgdHDyGUjRYig12W4G3aS4Q5Vw7D+/Y5kgkh0cxyEG1P+npDdC7xDf5VqsaMjxM 7XkQ== X-Gm-Message-State: AOAM530GWtvuwzQ1fvmot7jvGrLkp8iG5lRe3JvkS7iW+Y1gZh49iT9T YOMFVz+qN2VFmpFZXYLqQ8nERIvUWIg= X-Google-Smtp-Source: ABdhPJyp/xpw6w8w+VZZD9MuSUjCZa7mTY5cBcU5kzb6INta2XByTONRx55PzmLdAhg2FffRJV+DQw== X-Received: by 2002:adf:eac8:0:b0:1e4:a017:3d63 with SMTP id o8-20020adfeac8000000b001e4a0173d63mr17030183wrn.616.1645485251124; Mon, 21 Feb 2022 15:14:11 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l12sm48985608wrs.11.2022.02.21.15.14.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 15:14:10 -0800 (PST) Message-ID: <4cc2bbdb-7296-bada-8def-440cfcb18af1@yandex.ru> Date: Tue, 22 Feb 2022 01:14:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US To: Sean Whitton , sbaugh@catern.com, 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <87leyrgpst.fsf@athena.silentflame.com> <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> <87bkyzvn84.fsf@athena.silentflame.com> From: Dmitry Gutov In-Reply-To: <87bkyzvn84.fsf@athena.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 22.02.2022 01:00, Sean Whitton wrote: > I think I prefer my with-temp-buffer thing to this, to be honest -- > adding a timer into the mix seems like it might make debugging harder. > > Assuming you're still okay with my initial idea, I'll come up with a > patch to do it with a macro, and apply it across project.el. I liked the simplicity of the with-temp-buffer solution, but it doesn't solve the conceptual problem: that any code trying to let-bind default-directory around the call for xref-show-xrefs will have rediscover and solve this problem (or, more likely, live with it for a few years until somebody notices). The timer-based solution is hacky, but it affects only one place (the xref buffer and the variable in it), so it's easier to verify that it has the intended effect, and no external callers will need to bother with additional knowledge (hopefully, of course). From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 22 18:09:10 2022 Received: (at 53626) by debbugs.gnu.org; 22 Feb 2022 23:09:10 +0000 Received: from localhost ([127.0.0.1]:42828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMeHO-0002xg-B3 for submit@debbugs.gnu.org; Tue, 22 Feb 2022 18:09:10 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMeHM-0002xQ-CE for 53626@debbugs.gnu.org; Tue, 22 Feb 2022 18:09:09 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 07A865C0196; Tue, 22 Feb 2022 18:09:03 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 22 Feb 2022 18:09:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=FaJ6e9AmjgXll732LzBgzbWD+YVvibu9Xz9HtS 6Cans=; b=L4UdDXUzjnpUF+eB+r3IU8CvOjmBG20rkbWzCvG2vIAat+K/BPANK1 Wf8yzd88DApyUKbUXlxAeId3iFgs6R58hrg42rK9djeLXCfDRc2wCc33Dv1pMTMN HrcqUxWcH6U5qsM4WDxp72BpB895Myi+eHxk0lYI6fYeIk2Ud+ju92Kpiq2CfmcR 36nGyWjSvqDK68NXeASeIx5T+FM3KS/VmOlYF/ql4iChTdN3oSSE8ELWyWLUBsGl 7q0kIkfEksGjw2Xy4pNnWRVtkRBLy/bwOJS4uyiaphculqlgo2z/s8tZmRTWSm9U S1qVhDZtrWw9OshZFOhWVVB3AI8L0xRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=FaJ6e9AmjgXll732L zBgzbWD+YVvibu9Xz9HtS6Cans=; b=a3R67/4MFI4XtU1+T4LTObfnGFtY4STEp 8NmcuoprW2eaLK+nWwBJv4BBqHGTfy/jKYKLQ+4KOlj/Fgdd+jIftgdJ5O1t4ofI P9B7LCeg34/NBs0fdSwCqdGqVIlu+DPSomWbTfzPuTcvLVLRI+F+nkMlDMdlNKiW Yv2wyI0kZ9RsSgi2sUOM2ddyj1S1Q6wqTxMB1NR9Z2LnKWd6eqfuaB0j2grInj0F x4r87KpoYPWdHmd3mqnODW0xXA7M6bhM/Yq0lqrYQgtTdFoMkTWeFpCoBZda0qu/ Ir8JGkz1dJSIu2j1YnCJICmvRAglmLqdqGBj7ht85ruBDHoNz6vfQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeelgddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeelgeeggfdvieejvdfhudfggeetgfekkeeuieeljeejhedugeeg feetgefhueffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Feb 2022 18:09:02 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 537207E1A7C; Tue, 22 Feb 2022 16:09:01 -0700 (MST) From: Sean Whitton To: Dmitry Gutov , sbaugh@catern.com, 53626@debbugs.gnu.org Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects In-Reply-To: <4cc2bbdb-7296-bada-8def-440cfcb18af1@yandex.ru> References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <87leyrgpst.fsf@athena.silentflame.com> <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> <87bkyzvn84.fsf@athena.silentflame.com> <4cc2bbdb-7296-bada-8def-440cfcb18af1@yandex.ru> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Tue, 22 Feb 2022 16:09:01 -0700 Message-ID: <8735kawlbm.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 22 Feb 2022 at 01:14AM +02, Dmitry Gutov wrote: > On 22.02.2022 01:00, Sean Whitton wrote: >> I think I prefer my with-temp-buffer thing to this, to be honest -- >> adding a timer into the mix seems like it might make debugging harder. >> >> Assuming you're still okay with my initial idea, I'll come up with a >> patch to do it with a macro, and apply it across project.el. > > I liked the simplicity of the with-temp-buffer solution, but it doesn't > solve the conceptual problem: that any code trying to let-bind > default-directory around the call for xref-show-xrefs will have > rediscover and solve this problem (or, more likely, live with it for a > few years until somebody notices). Good point. > The timer-based solution is hacky, but it affects only one place (the > xref buffer and the variable in it), so it's easier to verify that it > has the intended effect, and no external callers will need to bother > with additional knowledge (hopefully, of course). Is there no chance of any concurrency issues with this, btw? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 22 20:45:46 2022 Received: (at 53626) by debbugs.gnu.org; 23 Feb 2022 01:45:46 +0000 Received: from localhost ([127.0.0.1]:43160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMgiw-0007L6-5e for submit@debbugs.gnu.org; Tue, 22 Feb 2022 20:45:46 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:40557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMgit-0007Kr-PG for 53626@debbugs.gnu.org; Tue, 22 Feb 2022 20:45:44 -0500 Received: by mail-wr1-f48.google.com with SMTP id f17so11978953wrh.7 for <53626@debbugs.gnu.org>; Tue, 22 Feb 2022 17:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Yz1kPHK4RETHpdIZxnhmAS4JQv/80RSdewAKTQ31o2g=; b=G/2L5fYWBEOJbAHQx8K75hHKBhiDYzBeL4E7jTn+m7bHdk3V2rb2mJHeoAXibaw3J7 2dw8IIcWRxKvvDYPRFBQvQfUWhunmhXN7JhuytxemEN/n45W6FFCrESJsfwTwttHVnFN Lz2q7f8zif+Qg/RQPqHChvtJpkNQQb8lka97b0Og1FjifKOsaeS4mo73DUrYplgMdITa nEprB1Dbd5u+iDpEF/ahWfWR5hPdN+oE+JYfi/Sk8SQIT/+2kvN43uORNp5eTpktODXb zOC4I6IT78SCdou69qeExnvC5fKmzUFgnlAhlj+DF4/Z2Jctw3yfW/DXb3+rR6FH7+Hu kyIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Yz1kPHK4RETHpdIZxnhmAS4JQv/80RSdewAKTQ31o2g=; b=5rgG7kSsnA7AityNp0/nLO0qOXvLCEphSperk0p0zpRd1XHgjgD7zFMD20prGdeGay BHduFy74M/NhLV2HqI0PXsms5xCcHpLrnvQYv7ikLGcP3SrAyCRiqaNq8T0jjZWmka2i 6ZrDy28S8nLo00mQHOYvtnwdvR9nT3zd5/K9eKbSKT6HBHjpQvreTjzAXCNFHUQP9WWv 5MZvufoYi9gbxdv2DnucUOwCnjcjoQkjhDlr6fj+aaprziuo5NR8hlMjebasVRpaswHY L0AR7hUyRThvqALAEPvMb4M7L/vq16ajoik2ySxO0MieueBa0S1yMjkf9nnDtcpb38pK 9Wfw== X-Gm-Message-State: AOAM533GBGpy90liFU4n+Av+2bH8deNhGVjBDkpUBEzohWFHtxPgnF37 CvID1QPfVFX6qlXXG5O2WDLtBhMohuE= X-Google-Smtp-Source: ABdhPJwS2pl3z6I4yy9l8KItEtGQKuFcw6/fRdyVJvhC603X7wffRagdjbo06HGCtNJ1ONfYsJKwjQ== X-Received: by 2002:a5d:47cc:0:b0:1ea:80f5:de90 with SMTP id o12-20020a5d47cc000000b001ea80f5de90mr5779777wrc.158.1645580737548; Tue, 22 Feb 2022 17:45:37 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id 1sm34686759wrz.75.2022.02.22.17.45.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 17:45:36 -0800 (PST) Message-ID: <96dded16-dda7-fa22-ba67-aea86fb3ebb0@yandex.ru> Date: Wed, 23 Feb 2022 03:45:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US To: Sean Whitton , sbaugh@catern.com, 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <87leyrgpst.fsf@athena.silentflame.com> <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> <87bkyzvn84.fsf@athena.silentflame.com> <4cc2bbdb-7296-bada-8def-440cfcb18af1@yandex.ru> <8735kawlbm.fsf@melete.silentflame.com> From: Dmitry Gutov In-Reply-To: <8735kawlbm.fsf@melete.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 23.02.2022 01:09, Sean Whitton wrote: >> The timer-based solution is hacky, but it affects only one place (the >> xref buffer and the variable in it), so it's easier to verify that it >> has the intended effect, and no external callers will need to bother >> with additional knowledge (hopefully, of course). > Is there no chance of any concurrency issues with this, btw? Probably not, or not currently: the fetching of the list of xrefs is synchronous, and in all cases (so far) (I think) does not depend on the value of default-directory. It only affects the subsequent interaction with the buffer (jumping to locations), so deferring the assignment of the value of dd seems fine. FETCHER is also called in the current buffer (before the with-current-buffer form), so even depending on the dynamic value of default-directory should be fine. At least until we get to asynchronous/chunked fetchers someday, but that's a bigger challenge with its own major changes. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 22 20:55:27 2022 Received: (at 53626) by debbugs.gnu.org; 23 Feb 2022 01:55:27 +0000 Received: from localhost ([127.0.0.1]:43164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMgsJ-0007cc-5H for submit@debbugs.gnu.org; Tue, 22 Feb 2022 20:55:27 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:37493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMgsH-0007cO-Td for 53626@debbugs.gnu.org; Tue, 22 Feb 2022 20:55:26 -0500 Received: by mail-wr1-f53.google.com with SMTP id d28so9109376wra.4 for <53626@debbugs.gnu.org>; Tue, 22 Feb 2022 17:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=Xuq8SgBYVZGsaKyXy3JGdJKMBbuEwzksEOt5gngHPKs=; b=UvfcXUsxGeag392s+WZcfLb80JqisEZSWK/ynSMYYLL2umax7ccr54iCnru8UREqXy +ImV7DZqAw7PUpxaDAmg7uiE1ggkqrwZ1se1hDqX4UeoIexIs+dNXDagTkY6z4oDjXlI nr/yN5LSI/jhFXsK72JekGtxpkVX09AvtU6cIuzZPusEf3Nie3bvOcglcjmgQF8EUcTj ioYcjEWsiWizFGMvVM+Sx0c6dsMZgKpxOcyduybDtwIOOGpeHEHr46CiCp9EqrDT8YMD nHjVlycyANOdPyxsQIz1l8l/1Z7G9h8ldDRQyhy81b+tH/ZqogdmSIpdQF4L3ViGTFGe p1Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=Xuq8SgBYVZGsaKyXy3JGdJKMBbuEwzksEOt5gngHPKs=; b=j/Yl/oRIn3+8XxhgwrsBY8wcNIgkQb1jt4G/NT6HiC2pgN6/solN53Wba4RJ7HdVR6 Gkojl87gkIEPjtklQtuUlJ5ltGk130wxciWn+vuQnWlgQYOfLXz4xDapdpOe2vNBggqh /f/4q2j1Vyu8ljcran8ncFsZ3RuL/z8zImQhUvsoI5mfFJfU2qeJ0/ZRp5NjzHJWESFi dZxPR/PEK7+S7TIvH15kj06OVwvYrYNMHCNL/4h09W2/bQaMyv4QYVljJAksMBhRu6bI znJK0TrQZaOKLC0uB4lGAAhOTfSyadoisHhzAZBeQ8vb+lxRTu6oSr8/IrlfmCw2p1yw xC2A== X-Gm-Message-State: AOAM530XE87LWm81UJ1RpeVk8QDeueafPs9aZjnLVwtaTzPD+4AgdBxQ OoWCRFCFErOiOLOfXby9AT4= X-Google-Smtp-Source: ABdhPJxxiI/BRoNw8cjap0diNnayk74P0ZhT16YNb0Sgfv6cVphkIqDUBEoDsH/1679jdNAeiWKLOQ== X-Received: by 2002:a5d:64a4:0:b0:1ea:7bb5:d103 with SMTP id m4-20020a5d64a4000000b001ea7bb5d103mr6166357wrp.564.1645581319992; Tue, 22 Feb 2022 17:55:19 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id bg20-20020a05600c3c9400b0037fa5c422c8sm4413277wmb.48.2022.02.22.17.55.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 17:55:19 -0800 (PST) Message-ID: Date: Wed, 23 Feb 2022 03:55:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US From: Dmitry Gutov To: Sean Whitton , sbaugh@catern.com, 53626@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <87leyrgpst.fsf@athena.silentflame.com> <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 21.02.2022 03:55, Dmitry Gutov wrote: > On 07.02.2022 05:12, Dmitry Gutov wrote: >>> Maybe we could rename the old buffer to a temp name, then create and >>> fill the new one, then set the old buffer's window's buffer to the new >>> one, and finally kill the old one.  But this is not nice at all. >> >> Right. > > We can also try a lighter-weight hack like below. WDYT? Long story short, I've pushed that change to master (in 0f67a3df0e). Let me know if you find any problems with it. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 23 00:36:18 2022 Received: (at 53626) by debbugs.gnu.org; 23 Feb 2022 05:36:18 +0000 Received: from localhost ([127.0.0.1]:43544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMkK1-0005RI-Vd for submit@debbugs.gnu.org; Wed, 23 Feb 2022 00:36:18 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:58929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMkJz-0005Qm-Kc for 53626@debbugs.gnu.org; Wed, 23 Feb 2022 00:36:16 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4BF083200D60; Wed, 23 Feb 2022 00:36:09 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 23 Feb 2022 00:36:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=d7Ngkm7MWEDQ0U o1yIk3iZaSNxY3SpwVTaydKe0C1Ko=; b=H5xfpc2UGBZfWzz+dmK9MaRuMmThPp pzNbeRdI1VEG0bLrie5FmUDLYY05bfkw2H1r6kdMvXw7J+Je4wF3yXuod4ZKFSVd B/h4CFbWsLNFl+Z7MGqoPNLkhtsGy3H6bSYHq/tZHHrnVVGpfRFC6JrpwZ+3tKXb urcvRsZPeO4yB/gQNU5vsO6G+PKhzPqMpljPMMl44AgSu0UJui6XwBI5T617etQc HTCCuPVQxHl7GqErStTdwHrce/MFPyXbmhmorXKXhuWRPQ8Do+jPm/4DeiIpVpVK hkMw94e1dR+piGWAuNqMcGfJSfFBmXJt+4D40Sr/LVn537GOQz5QtvKg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=d7Ngkm7MWEDQ0Uo1yIk3iZaSNxY3SpwVTaydKe0C1Ko=; b=Mbw5KlFu BTljDtIXsxGbVKkehvYcTMETQy2R2dEsZALvL/Iz1G4egXseXdb+GT+SSyLyPiVc 15zLsKkUy0UHuBEgyXp/lYWJvzvVGODe0iA04sl+fUptLNLzT48XdEqVK8NM0NwW irIAj5bWHScpbZsIr/6is8AogKksrXpf5IF3CbnyrXyvRzxDH0ofmVskGFr1gzNJ 28HS5jG8lxr/VngG3l+i4/3k5/6iJ/Y8Zf8w37xHN9R8oUfLMhGiq2LlMWvmibtf pJO7E2HXcjmIbx8Nn/3OGmVEmdgR0hKwYJ/XW62aXAXCsDfU8yourJXZ/2V5qnSK KttyAWcACRpIeQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeelgdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgfgsehtqhdttddtreejnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnheplefgffejveelleehkeeuvdektddvudefffeujeegiefhkeej geefffdtgeehkeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Feb 2022 00:36:08 -0500 (EST) Received: by athena.silentflame.com (Postfix, from userid 1000) id BA1661D29D7; Wed, 23 Feb 2022 05:36:06 +0000 (UTC) From: Sean Whitton To: Dmitry Gutov , sbaugh@catern.com, 53626@debbugs.gnu.org Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects In-Reply-To: References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <87leyrgpst.fsf@athena.silentflame.com> <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Tue, 22 Feb 2022 22:36:06 -0700 Message-ID: <874k4quou1.fsf@athena.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 23 Feb 2022 at 03:55am +02, Dmitry Gutov wrote: > On 21.02.2022 03:55, Dmitry Gutov wrote: >> On 07.02.2022 05:12, Dmitry Gutov wrote: >>>> Maybe we could rename the old buffer to a temp name, then create and >>>> fill the new one, then set the old buffer's window's buffer to the new >>>> one, and finally kill the old one.=C2=A0 But this is not nice at all. >>> >>> Right. >> >> We can also try a lighter-weight hack like below. WDYT? > > Long story short, I've pushed that change to master (in 0f67a3df0e). > > Let me know if you find any problems with it. Had a look and ran some tests. LGTM. Thanks! --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 23 06:42:09 2022 Received: (at 53626-done) by debbugs.gnu.org; 23 Feb 2022 11:42:09 +0000 Received: from localhost ([127.0.0.1]:44042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMq1x-0000nu-8c for submit@debbugs.gnu.org; Wed, 23 Feb 2022 06:42:09 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:36415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMq1u-0000ne-Rd for 53626-done@debbugs.gnu.org; Wed, 23 Feb 2022 06:41:59 -0500 Received: by mail-wm1-f49.google.com with SMTP id bg16-20020a05600c3c9000b00380f6f473b0so866640wmb.1 for <53626-done@debbugs.gnu.org>; Wed, 23 Feb 2022 03:41:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ff1jGtRwMAM6RCuZ3+yWKCMM/Wq+KC/Krs7UQpLQUVo=; b=Oxz26tJUci0bZo9G3qvtHgryWFxuCC/XbxAiQ4vgJsMs0ehvOhCdPZSB/mFt1srB1R OV1g4rQ+drbBRW2xDbgHJSndX47cDJzx2IHlMgv1E6QHvK/+UfdjrucTQUt+0eVlmije GzAkC8e0x3EWI2EI0ijX3EKtXukP50EmW0v6BxpvNECwHwtOjkm6IJy7uyqLb9K+mBaV lKv3eZjkV+ruoMdhPl1wsyeTRR7s/rJyoxsbQWbfpGT/YfpG8UNptAXMLgXr2+vYJegx zCjIlt1iN68/RLu8wixyq8N9ecJo+s180dZxj7knO1Wos8bk4vCVNlh8zzoiJLOyOp9d 50hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ff1jGtRwMAM6RCuZ3+yWKCMM/Wq+KC/Krs7UQpLQUVo=; b=kwU0zwiuSt17pJYpvoG7/p0sW7zW/r+bO6VPkQLGAQ0o2S9xMMpoAgh3ksKevL4q5g s9yEm1QqVpCMNfu4uGqkQr4xVtiM384jIZXv/+9aDIep/ujuUOwxj5eNFsKO8Lc1DCKH 1Cnjwa196iUsthlwyiNOVvWSw6clq+1m1ZHDWwzHHnGmgiXS7CkVq2NnN+Ek8b9fbeaz bwKZq0lCdf5PJhhLsunwhlOYQdcWE6Q4PzCI9ADVUEcr2NlWRvs9dwzT18L1Ym9qS7Wp mgdC8vhqjYEI9AlEy4IE/njPWaMbCk7W9vlMCLwDxlLn41o+jscN4RMFofv0rGFo27f6 tCAw== X-Gm-Message-State: AOAM532zQ3XDJ8VCZngBReTc5ntl03AuckaSxZIRzPF1qczCeChmrXd2 g04QMH2N6WZ8VNXVTebwP7t99zALkIQ= X-Google-Smtp-Source: ABdhPJxogIdw5lg5B8+GmefqrNwyniK9ps9zJtBlB54KKp7vnyKUNcjaGssR9Hl6Yu8MECyZhMXt8w== X-Received: by 2002:a05:600c:2e0c:b0:37c:3615:c52 with SMTP id o12-20020a05600c2e0c00b0037c36150c52mr6936911wmf.43.1645616512793; Wed, 23 Feb 2022 03:41:52 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id 1sm36493589wrz.75.2022.02.23.03.41.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Feb 2022 03:41:51 -0800 (PST) Message-ID: Date: Wed, 23 Feb 2022 13:41:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects Content-Language: en-US To: Sean Whitton , sbaugh@catern.com, 53626-done@debbugs.gnu.org References: <87wnii73x5.fsf@catern.com> <87a6fd68ku.fsf@athena.silentflame.com> <87leyrgpst.fsf@athena.silentflame.com> <1b884678-ed62-0b11-7fa9-88393a60d26d@yandex.ru> <874k4quou1.fsf@athena.silentflame.com> From: Dmitry Gutov In-Reply-To: <874k4quou1.fsf@athena.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53626-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 23.02.2022 07:36, Sean Whitton wrote: > Had a look and ran some tests. LGTM. Thanks! Thanks for checking! Closing. From unknown Mon Jun 23 18:33:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Mar 2022 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator