Package: guix-patches;
Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Date: Sat, 29 Jan 2022 02:32:01 UTC
Severity: normal
Tags: patch
Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Bug is archived. No further changes may be made.
View this message in rfc822 format
From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com> To: Leo Famulari <leo <at> famulari.name> Cc: 53619 <at> debbugs.gnu.org Subject: [bug#53619] [PATCH 0/3] gnu: linux-libre: Build the snd-emu10k1 module. Date: Sat, 29 Jan 2022 22:33:46 -0500
Hi Leo, Leo Famulari <leo <at> famulari.name> writes: > On Fri, Jan 28, 2022 at 09:30:34PM -0500, Maxim Cournoyer wrote: >> Hello Guix, >> >> If like me, you discovered a forgotten Sounblaster Live! from 2000 at the >> bottom of your desktop and wondered why there was no support for it in the >> Guix kernel config, this series is for you! ;-). >> >> The last patch is unrelated; I find it convenient to have the current Linux >> kernel's config exposed as /proc/config.gz, which makes it easy to consult, >> for example to grep for the CONFIG_SND_EMU10K1 option! >> >> Thank you, >> >> Maxim Cournoyer (3): >> linux-libre: Normalize the CONFIG_ZONE_DMA to 'y' in kernel configs. >> linux-libre: Build SND_EMU10K1 as a module for x86. >> gnu: linux-libre: Expose running kernel config as /proc/config.gz. > > The first and third patches LGTM. Thanks for having a look! > It seems that the 2nd patch brings a lot of unrelated changes. Can you > revise it to only add support for your old sound card? The unrelated changes appear just by running 'make oldconfig' on the master branch: --8<---------------cut here---------------start------------->8--- $ guix build linux-libre <at> 5.15 -S /gnu/store/429863zh1abhyj21kpnxkalsv5q5bhi4-linux-libre-5.15.16-guix.tar.xz maxim <at> hurd ~$ tar xf /gnu/store/429863zh1abhyj21kpnxkalsv5q5bhi4-linux-libre-5.15.16-guix.tar.xz -C /tmp maxim <at> hurd ~$ cd /tmp/linux-5.15.16/ maxim <at> hurd /tmp/linux-5.15.16$ cp ~/src/guix/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf .config maxim <at> hurd /tmp/linux-5.15.16$ guix shell -D linux-libre ncurses maxim <at> hurd /tmp/linux-5.15.16 [env]$ make oldconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/confdata.o HOSTCC scripts/kconfig/expr.o LEX scripts/kconfig/lexer.lex.c YACC scripts/kconfig/parser.tab.[ch] HOSTCC scripts/kconfig/lexer.lex.o HOSTCC scripts/kconfig/menu.o HOSTCC scripts/kconfig/parser.tab.o HOSTCC scripts/kconfig/preprocess.o HOSTCC scripts/kconfig/symbol.o HOSTCC scripts/kconfig/util.o HOSTLD scripts/kconfig/conf * * Restart config... * * * Bootup logo * Bootup logo (LOGO) [Y/n/?] y Standard black and white Linux logo (LOGO_LINUX_MONO) [N/y/?] n Standard 16-color Linux logo (LOGO_LINUX_VGA16) [N/y/?] n Standard 224-color Linux logo (LOGO_LINUX_CLUT224) [N/y/?] n 224-color Linux-libre logo (LOGO_LIBRE_CLUT224) [Y/n/?] (NEW) n # # configuration written to .config # maxim <at> hurd /tmp/linux-5.15.16 [env]$ make oldconfig^C (reverse-i-search)`diff': cp e796b33.^Cff ~/src/guix-master/gnu/packages/patches/jami-memory-usage.patch (reverse-i-search)`diff': __emacs_complete_pre_command; echo -n "^[^[pwd=${PWD}^[^[";__EMACS_COMPLETE_WRAPPER='COMP_LINE='\''cp f5e4619.diff'\''; COMP_POINT=$(( 1 + ${#COMP_LINE} )); COMP_CWORD=1; COMP_WORDS=( cp f5e4619.diff ); _longopt cp f5e4619.^Cff cp' compgen -F __emacs_complete_wrapper -- f5e4619.diff 2>/dev/null maxim <at> hurd /tmp/linux-5.15.16 [env]$ diff -u .config{.old,} --- .config.old 2022-01-29 22:21:49.011196075 -0500 +++ .config 2022-01-29 22:22:16.774374081 -0500 @@ -1,20 +1,19 @@ # # Automatically generated file; DO NOT EDIT. -# Linux/x86 5.15.5 Kernel Configuration +# Linux/x86 5.15.16-gnu Kernel Configuration # -CONFIG_CC_VERSION_TEXT="gcc (GCC) 11.2.0" +CONFIG_CC_VERSION_TEXT="gcc (GCC) 10.3.0" CONFIG_CC_IS_GCC=y -CONFIG_GCC_VERSION=110200 +CONFIG_GCC_VERSION=100300 CONFIG_CLANG_VERSION=0 CONFIG_AS_IS_GNU=y -CONFIG_AS_VERSION=23400 +CONFIG_AS_VERSION=23700 CONFIG_LD_IS_BFD=y -CONFIG_LD_VERSION=23400 +CONFIG_LD_VERSION=23700 CONFIG_LLD_VERSION=0 CONFIG_CC_CAN_LINK=y CONFIG_CC_CAN_LINK_STATIC=y CONFIG_CC_HAS_ASM_GOTO=y -CONFIG_CC_HAS_ASM_GOTO_OUTPUT=y CONFIG_CC_HAS_ASM_INLINE=y CONFIG_CC_HAS_NO_PROFILE_FN_ATTR=y CONFIG_IRQ_WORK=y @@ -6763,6 +6762,7 @@ # CONFIG_LOGO_LINUX_MONO is not set # CONFIG_LOGO_LINUX_VGA16 is not set # CONFIG_LOGO_LINUX_CLUT224 is not set +# CONFIG_LOGO_LIBRE_CLUT224 is not set # end of Graphics support CONFIG_SOUND=m @@ -8776,7 +8776,6 @@ CONFIG_THINKPAD_ACPI_VIDEO=y CONFIG_THINKPAD_ACPI_HOTKEY_POLL=y CONFIG_THINKPAD_LMI=m -CONFIG_X86_PLATFORM_DRIVERS_INTEL=y CONFIG_INTEL_ATOMISP2_PDX86=y CONFIG_INTEL_ATOMISP2_LED=m CONFIG_INTEL_SAR_INT1092=m @@ -10322,8 +10321,6 @@ CONFIG_STACKLEAK_RUNTIME_DISABLE=y CONFIG_INIT_ON_ALLOC_DEFAULT_ON=y # CONFIG_INIT_ON_FREE_DEFAULT_ON is not set -CONFIG_CC_HAS_ZERO_CALL_USED_REGS=y -# CONFIG_ZERO_CALL_USED_REGS is not set # end of Memory initialization # end of Kernel hardening options # end of Security options @@ -10806,8 +10803,6 @@ CONFIG_ARCH_HAS_UBSAN_SANITIZE_ALL=y # CONFIG_UBSAN is not set CONFIG_HAVE_ARCH_KCSAN=y -CONFIG_HAVE_KCSAN_COMPILER=y -# CONFIG_KCSAN is not set # end of Generic Kernel Debugging Instruments CONFIG_DEBUG_KERNEL=y --8<---------------cut here---------------end--------------->8--- They appear to me as KConfig changes in the newer releases that weren't propagated to the config files checked. I've currently running a reconfigure system on the kernel with an Soundblaster Audigy 2 sound card; works well :-). --8<---------------cut here---------------start------------->8--- $ zgrep EMU10K1 /proc/config.gz CONFIG_GAMEPORT_EMU10K1=m CONFIG_SND_EMU10K1=m CONFIG_SND_EMU10K1_SEQ=m # CONFIG_SND_EMU10K1X is not set --8<---------------cut here---------------end--------------->8--- Thanks, Maxim
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.