From unknown Tue Jun 17 20:21:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53617 <53617@debbugs.gnu.org> To: bug#53617 <53617@debbugs.gnu.org> Subject: Status: 28.0.90; duplicate checks in erc--switch-to-buffer Reply-To: bug#53617 <53617@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:21:01 +0000 retitle 53617 28.0.90; duplicate checks in erc--switch-to-buffer reassign 53617 emacs submitter 53617 Guy Gastineau severity 53617 normal tag 53617 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 28 19:10:23 2022 Received: (at submit) by debbugs.gnu.org; 29 Jan 2022 00:10:24 +0000 Received: from localhost ([127.0.0.1]:60737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDbJu-00081j-UK for submit@debbugs.gnu.org; Fri, 28 Jan 2022 19:10:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:51800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDbJt-00081a-57 for submit@debbugs.gnu.org; Fri, 28 Jan 2022 19:10:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDbJs-0006Az-EJ; Fri, 28 Jan 2022 19:10:20 -0500 Received: from [2a00:1450:4864:20::12d] (port=46949 helo=mail-lf1-x12d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDbJp-0007GG-0w; Fri, 28 Jan 2022 19:10:19 -0500 Received: by mail-lf1-x12d.google.com with SMTP id z19so14821903lfq.13; Fri, 28 Jan 2022 16:10:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to:cc; bh=KH+pVBejyVe8wfO9cbu+SyFOfiLC6A7uJQ1Z+b/pJAQ=; b=lPHpfS3S+UOlIyRgI5cZvK9ujZJU6NWwaCJ0ovolWCMCyvqJBK9hBM9NMcAmP++97D NKxkiHGLRWsD9xOUBDUxdUsxfqzLvjXY9CgLe7UAr+DU96vE37RuqV/gyVyJhIJbHCDD fPFAP9fDlH+vcbj0XBeh+inQTxqd18Xv5PGDFoWPclyQ1YttBaCqkS4j2Jrav3XxQZeE Y6Jmti1Iib4eGbM2Hkjl/pgyPBXVl02hR1Fj/7G82/DAFOJqGw4yHe/FTVulOR6lLC3K yIH/zK0jOnCUMeOvPedkMtUGZXqZWI8WFpJmywlOz5ukKnrzQhbGYxCkjq/+Lt3SZJd9 MRrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=KH+pVBejyVe8wfO9cbu+SyFOfiLC6A7uJQ1Z+b/pJAQ=; b=NT8OLnfm0Gxrmlb7c7fJ+PqgxTwrb01a/vhdqOMtmoekHmEWwQC8r3clfuZxeRM0YH uJgCbU+iIbTg8vM0n67h8MwG4bWzkaWwd9g8ie2ptgt+Hy5fDKe4IdFlJhfOf+MWmZ3S C2AhA8gUFiy6PVNYX2BFpf+pLwdPk4XQkCXTpDnqqeDo2bHrmgFYYQ58hJIIcjN7nFTA BGgUTAy0Wm6vADStOAmmxSnRcRPwVGZk0oWzvChvaZK2tEJzltb4GU6pG+MDOefPEnwU N+usqF43rTH4slDuNwLriptROcQKMf7hfotTARskFG1mVDwEsYOlE4QfwN2XdA97Ypc7 zArg== X-Gm-Message-State: AOAM531b0+g176VzPqmoW8FxeSeVNFuQ5BsPzPGWhcZOeczVmvk+ylFd qiZZlP5xX5oPWLs8HpF8QiOg4atSrR9WfgX++vuNe7mjZSs= X-Google-Smtp-Source: ABdhPJzIre7q+xJc6jSbep6+iieuw37QphpH7vHsh1DTRDGBOEAGfQPe8UDZxZTiamtw2vY7yiTwK1U/QWdpbHhbxdQ= X-Received: by 2002:a05:6512:3184:: with SMTP id i4mr7750528lfe.275.1643415011706; Fri, 28 Jan 2022 16:10:11 -0800 (PST) MIME-Version: 1.0 From: Guy Gastineau Date: Fri, 28 Jan 2022 19:10:00 -0500 Message-ID: Subject: 28.0.90; duplicate checks in erc--switch-to-buffer To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000fdcbd305d6ad5f02" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::12d (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=strings.stringsandstrings@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: submit Cc: emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000fdcbd305d6ad5f02 Content-Type: text/plain; charset="UTF-8" erc--switch-to-buffer has the following code at the end: ... (when buf (erc--buffer-p buf (lambda () t) proc) (with-current-buffer buf (and (derived-mode-p 'erc-mode) (or (null proc) (eq proc erc-server-process))))) ... but erc--buffer-p is already doing the checks with buf as current buffer: (defun erc--buffer-p (buf predicate proc) (with-current-buffer buf (and (derived-mode-p 'erc-mode) (or (not proc) (eq proc erc-server-process)) (funcall predicate) buf))) The entire sexp starting with `with-current-buffer ...` can be removed without changing the semantics of erc--switch-to-buffer. In GNU Emacs 28.0.90 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-12-14 built on medusa Repository revision: f88c1d222f17d3483bf6f387dc41be4366a047ab Repository branch: makepkg Windowing system distributor 'The X.Org Foundation', version 11.0.12101003 System Description: Arch Linux Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games --with-sound=alsa --with-modules --without-libotf --without-m17n-flt --without-gconf --without-gsettings --with-native-compilation --with-x-toolkit=gtk3 --without-xaw3d --with-sound=no --without-gpm --without-compress-install '--program-transform-name=s/\([ec]tags\)/\1.emacs/' 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection' LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t global-git-commit-mode: t magit-auto-revert-mode: t global-flycheck-mode: t flycheck-mode: t shell-dirtrack-mode: t global-ligature-mode: t ligature-mode: t paredit-mode: t rainbow-delimiters-mode: t global-company-mode: t company-mode: t counsel-projectile-mode: t counsel-mode: t projectile-mode: t save-place-mode: t electric-pair-mode: t recentf-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/guy/.emacs.d/elpa/transient-20211129.1146/transient hides /usr/share/emacs/28.0.90/lisp/transient Features: (shadow sort mail-extr emacsbug sendmail ivy-erc debug backtrace cl-print two-column misearch multi-isearch apropos erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-loaddefs eieio-opt speedbar ezimage dframe shortdoc tabify gnutls network-stream nsm rcirc magit-patch mule-util vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc bug-reference magit-extras magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func magit-diff smerge-mode diff git-commit log-edit message rmc rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor server magit-mode transient magit-git magit-section magit-utils crm mhtml-mode css-mode smie eww url-queue shr kinsoku svg xml puny mm-url gnus nnheader gnus-util rmail rmail-loaddefs mail-utils js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs sgml-mode facemenu dom ffap purescript-indentation purescript-mode purescript-font-lock purescript-string purescript-sort-imports purescript-align-imports haskell-doc inf-haskell haskell-decl-scan imenu haskell haskell-completions haskell-load haskell-commands highlight-uses-mode haskell-modules haskell-sandbox haskell-navigate-imports haskell-repl haskell-svg haskell-collapse hideshow haskell-debug haskell-interactive-mode haskell-presentation-mode haskell-compile haskell-hoogle haskell-process haskell-session vc-git diff-mode vc-dispatcher haskell-mode haskell-cabal haskell-utils haskell-font-lock haskell-indentation haskell-string haskell-sort-imports haskell-lexeme haskell-align-imports haskell-complete-module haskell-ghc-support noutline outline flymake-proc flymake dabbrev haskell-customize flycheck dash vterm bookmark pp tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat parse-time iso8601 time-date ls-lisp format-spec face-remap term shell pcomplete ehelp find-func vterm-module term/xterm xterm auto-complete popup ligature disp-table paredit rainbow-delimiters page-break-lines display-line-numbers linum whitespace time company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company pcase init exercism interactive counsel-projectile-ext counsel-projectile counsel xdg advice xref project dired dired-loaddefs swiper ivy delsel ivy-faces ivy-overlay colir color comp comp-cstr warnings projectile lisp-mnt mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr grep compile text-property-search comint ansi-color ibuf-ext ibuffer ibuffer-loaddefs thingatpt saveplace elec-pair dashboard dashboard-widgets recentf tree-widget wid-edit all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons modus-vivendi-theme modus-operandi-theme modus-themes cl-extra use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core finder-inf geiser-impl help-fns radix-tree help-mode geiser-custom geiser-base ring proof-site proof-autoloads edmacro kmacro rx info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 1092982 183001) (symbols 48 44207 0) (strings 32 236718 12429) (string-bytes 1 7415412) (vectors 16 95829) (vector-slots 8 2143178 190013) (floats 8 798 606) (intervals 56 55744 5618) (buffers 992 35)) --000000000000fdcbd305d6ad5f02 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

erc--switch-to-buffer has the following code at the en= d:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0...
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(when buf
=C2=A0 =C2=A0 =C2=A0 = (erc--buffer-p buf (lambda () t) proc)
=C2=A0 =C2=A0 =C2=A0 (with-cur= rent-buffer buf
(and (derived-mode-p 'erc-mode)
=C2=A0 = =C2=A0 =C2=A0(or (null proc)
=C2=A0(eq proc erc-server-process)))))=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0...

but erc--buf= fer-p is already doing the checks with buf as current
buffer:

(de= fun erc--buffer-p (buf predicate proc)
=C2=A0 (with-current-buffer buf=C2=A0 =C2=A0 (and (derived-mode-p 'erc-mode)
(or (not proc)
= =C2=A0 =C2=A0 (eq proc erc-server-process))
(funcall predicate)
= buf)))

The entire sexp starting with `with-current-buffer ...` can = be removed
without changing the semantics of erc--switch-to-buffer.
<= br>
In GNU Emacs 28.0.90 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.2= 4.30, cairo version 1.17.4)
=C2=A0of 2021-12-14 built on medusa
Repos= itory revision: f88c1d222f17d3483bf6f387dc41be4366a047ab
Repository bran= ch: makepkg
Windowing system distributor 'The X.Org Foundation',= version 11.0.12101003
System Description: Arch Linux

Configured = using:
=C2=A0'configure --prefix=3D/usr --sysconfdir=3D/etc --libexe= cdir=3D/usr/lib
=C2=A0--localstatedir=3D/var --mandir=3D/usr/share/man -= -with-gameuser=3D:games
=C2=A0--with-sound=3Dalsa --with-modules --witho= ut-libotf --without-m17n-flt
=C2=A0--without-gconf --without-gsettings -= -with-native-compilation
=C2=A0--with-x-toolkit=3Dgtk3 --without-xaw3d -= -with-sound=3Dno --without-gpm
=C2=A0--without-compress-install
=C2= =A0'--program-transform-name=3Ds/\([ec]tags\)/\1.emacs/'
=C2=A0&= #39;CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fno-plt -fexceptio= ns
=C2=A0-Wp,-D_FORTIFY_SOURCE=3D2 -Wformat -Werror=3Dformat-security=C2=A0-fstack-clash-protection -fcf-protection'
=C2=A0LDFLAGS=3D-Wl= ,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configured featu= res:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG JSON LCMS= 2
LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG=
SECCOMP THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB
=
Important settings:
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 loc= ale-coding-system: utf-8-unix

Major mode: ELisp/l

Minor modes= in effect:
=C2=A0 erc-list-mode: t
=C2=A0 erc-menu-mode: t
=C2=A0= erc-autojoin-mode: t
=C2=A0 erc-ring-mode: t
=C2=A0 erc-networks-mod= e: t
=C2=A0 erc-pcomplete-mode: t
=C2=A0 erc-track-mode: t
=C2=A0 = erc-track-minor-mode: t
=C2=A0 erc-match-mode: t
=C2=A0 erc-button-mo= de: t
=C2=A0 erc-fill-mode: t
=C2=A0 erc-stamp-mode: t
=C2=A0 erc-= netsplit-mode: t
=C2=A0 erc-irccontrols-mode: t
=C2=A0 erc-noncommand= s-mode: t
=C2=A0 erc-move-to-prompt-mode: t
=C2=A0 erc-readonly-mode:= t
=C2=A0 global-git-commit-mode: t
=C2=A0 magit-auto-revert-mode: t<= br>=C2=A0 global-flycheck-mode: t
=C2=A0 flycheck-mode: t
=C2=A0 shel= l-dirtrack-mode: t
=C2=A0 global-ligature-mode: t
=C2=A0 ligature-mod= e: t
=C2=A0 paredit-mode: t
=C2=A0 rainbow-delimiters-mode: t
=C2= =A0 global-company-mode: t
=C2=A0 company-mode: t
=C2=A0 counsel-proj= ectile-mode: t
=C2=A0 counsel-mode: t
=C2=A0 projectile-mode: t
= =C2=A0 save-place-mode: t
=C2=A0 electric-pair-mode: t
=C2=A0 recentf= -mode: t
=C2=A0 override-global-mode: t
=C2=A0 tooltip-mode: t
=C2= =A0 global-eldoc-mode: t
=C2=A0 eldoc-mode: t
=C2=A0 show-paren-mode:= t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2= =A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 f= ont-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-composition-= mode: t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compression-mode: = t
=C2=A0 column-number-mode: t
=C2=A0 line-number-mode: t
=C2=A0 t= ransient-mark-mode: t

Load-path shadows:
/home/guy/.emacs.d/elpa/= transient-20211129.1146/transient hides /usr/share/emacs/28.0.90/lisp/trans= ient

Features:
(shadow sort mail-extr emacsbug sendmail ivy-erc d= ebug backtrace
cl-print two-column misearch multi-isearch apropos erc-li= st erc-menu
erc-join erc-ring erc-networks erc-pcomplete erc-track erc-m= atch
erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc erc-back= end
erc-loaddefs eieio-opt speedbar ezimage dframe shortdoc tabify gnutl= s
network-stream nsm rcirc magit-patch mule-util vc-mtn vc-hg vc-bzr
= vc-src vc-sccs vc-svn vc-cvs vc-rcs vc bug-reference magit-extras
magit-= bookmark magit-submodule magit-obsolete magit-blame magit-stash
magit-re= flog magit-bisect magit-push magit-pull magit-fetch magit-clone
magit-re= mote magit-commit magit-sequence magit-notes magit-worktree
magit-tag ma= git-merge magit-branch magit-reset magit-files magit-refs
magit-status m= agit magit-repos magit-apply magit-wip magit-log
which-func magit-diff s= merge-mode diff git-commit log-edit message rmc
rfc822 mml mml-sec epa d= erived epg rfc6068 epg-config mm-decode
mm-bodies mm-encode mailabbrev g= mm-utils mailheader pcvs-util add-log
magit-core magit-autorevert autore= vert filenotify magit-margin
magit-transient magit-process with-editor s= erver magit-mode transient
magit-git magit-section magit-utils crm mhtml= -mode css-mode smie eww
url-queue shr kinsoku svg xml puny mm-url gnus n= nheader gnus-util rmail
rmail-loaddefs mail-utils js cc-mode cc-fonts cc= -guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs sgm= l-mode facemenu dom ffap
purescript-indentation purescript-mode purescri= pt-font-lock
purescript-string purescript-sort-imports purescript-align-= imports
haskell-doc inf-haskell haskell-decl-scan imenu haskell
haske= ll-completions haskell-load haskell-commands highlight-uses-mode
haskell= -modules haskell-sandbox haskell-navigate-imports haskell-repl
haskell-s= vg haskell-collapse hideshow haskell-debug
haskell-interactive-mode hask= ell-presentation-mode haskell-compile
haskell-hoogle haskell-process has= kell-session vc-git diff-mode
vc-dispatcher haskell-mode haskell-cabal h= askell-utils haskell-font-lock
haskell-indentation haskell-string haskel= l-sort-imports haskell-lexeme
haskell-align-imports haskell-complete-mod= ule haskell-ghc-support
noutline outline flymake-proc flymake dabbrev ha= skell-customize flycheck
dash vterm bookmark pp tramp tramp-loaddefs tra= mpver tramp-integration
files-x tramp-compat parse-time iso8601 time-dat= e ls-lisp format-spec
face-remap term shell pcomplete ehelp find-func vt= erm-module term/xterm
xterm auto-complete popup ligature disp-table pare= dit rainbow-delimiters
page-break-lines display-line-numbers linum white= space time
company-oddmuse company-keywords company-etags etags fileloop= generator
company-gtags company-dabbrev-code company-dabbrev company-fi= les
company-clang company-capf company-cmake company-semantic
company= -template company-bbdb company pcase init exercism interactive
counsel-p= rojectile-ext counsel-projectile counsel xdg advice xref
project dired d= ired-loaddefs swiper ivy delsel ivy-faces ivy-overlay
colir color comp c= omp-cstr warnings projectile lisp-mnt mail-parse
rfc2231 rfc2047 rfc2045= mm-util ietf-drums mail-prsvr grep compile
text-property-search comint = ansi-color ibuf-ext ibuffer ibuffer-loaddefs
thingatpt saveplace elec-pa= ir dashboard dashboard-widgets recentf
tree-widget wid-edit all-the-icon= s all-the-icons-faces data-material
data-weathericons data-octicons data= -fileicons data-faicons
data-alltheicons modus-vivendi-theme modus-opera= ndi-theme modus-themes
cl-extra use-package use-package-ensure use-packa= ge-delight
use-package-diminish use-package-bind-key bind-key easy-mmode=
use-package-core finder-inf geiser-impl help-fns radix-tree help-modegeiser-custom geiser-base ring proof-site proof-autoloads edmacro kmacro<= br>rx info package browse-url url url-proxy url-privacy url-expand
url-m= ethods url-history url-cookie url-domsuf url-util mailcap
url-handlers u= rl-parse auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs pass= word-cache json subr-x map url-vars seq byte-opt gv
bytecomp byte-compil= e cconv cl-loaddefs cl-lib iso-transl tooltip eldoc
paren electric uniqu= ify ediff-hook vc-hooks lisp-float-type elisp-mode
mwheel term/x-win x-w= in term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe ta= bulated-list replace newcomment text-mode lisp-mode
prog-mode register p= age tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-ba= r mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibu= ffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan th= ai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian s= lovak czech european ethiopic indian
cyrillic chinese composite emoji-zw= j charscript charprop case-table
epa-hook jka-cmpr-hook help simple abbr= ev obarray cl-preloaded nadvice
button loaddefs faces cus-face macroexp = files window text-properties
overlay sha1 md5 base64 format env code-pag= es mule custom widget
hashtable-print-readable backquote threads dbusbin= d inotify lcms2
dynamic-setting font-render-setting cairo move-toolbar g= tk x-toolkit x
multi-tty make-network-process native-compile emacs)
<= br>Memory information:
((conses 16 1092982 183001)
=C2=A0(symbols 48 = 44207 0)
=C2=A0(strings 32 236718 12429)
=C2=A0(string-bytes 1 741541= 2)
=C2=A0(vectors 16 95829)
=C2=A0(vector-slots 8 2143178 190013)
= =C2=A0(floats 8 798 606)
=C2=A0(intervals 56 55744 5618)
=C2=A0(buffe= rs 992 35))
--000000000000fdcbd305d6ad5f02-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 28 22:13:03 2022 Received: (at submit) by debbugs.gnu.org; 29 Jan 2022 03:13:03 +0000 Received: from localhost ([127.0.0.1]:60814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDeAh-0006Rt-GQ for submit@debbugs.gnu.org; Fri, 28 Jan 2022 22:13:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:58750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDeAf-0006Rd-Qh for submit@debbugs.gnu.org; Fri, 28 Jan 2022 22:13:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDeAf-0001EA-Mi for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 22:13:01 -0500 Received: from mail-108-mta252.mxroute.com ([136.175.108.252]:36791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDeAZ-0004Os-BN for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 22:12:57 -0500 Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta252.mxroute.com (ZoneMTA) with ESMTPSA id 17ea3cd960d0005a20.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 29 Jan 2022 03:07:46 +0000 X-Zone-Loop: adb907731018946dfcc99bf6714e53f84c3f948ec6e5 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aE64YxVnFXh1USbphdw2LCxxiJcv0tfg0imBmx0cfn8=; b=mhcch2wv5CViQMTwWOa0gj0jha cVfzxuCajMM31JI0KiwViqC34ioDZ7YVefjUtqiVd8Ci7/jvbR2RJJL27RviVA6z7ZpkqyvUwdqm5 xUkmKxWdt49XTlrvzlOGcDZd21OkujJpEwa+wwU+eebeIyRxR1abn+H1UPqIa0bz0E8miAZ7LuA9o cx6RR9Pq2Xj7/iTrsdQgGEunFHSWbFFiiMCs4XWmcl+GgG957g+4ftUJBg1ltaHrFrmqeSo4+6qdv HTQ+c11EhXdyVFFGPdja7McPS1y3rtOpfYUCPwCzbbjZkwWrxIZNnmZmVJpCaJcFAo9rxz/ZboCJJ Hzf/Jp3A==; From: "J.P." To: Guy Gastineau Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer References: Date: Fri, 28 Jan 2022 19:07:43 -0800 In-Reply-To: (Guy Gastineau's message of "Fri, 28 Jan 2022 19:10:00 -0500") Message-ID: <87ee4rutmo.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.252; envelope-from=jp@neverwas.me; helo=mail-108-mta252.mxroute.com X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi Guy, Thanks for following through with the report. Guy Gastineau writes: > The entire sexp starting with `with-current-buffer ...` can be removed > without changing the semantics of erc--switch-to-buffer. You're right, of course. In fact, the same commit that introduced `erc--buffer-p' added the redundancy as well [1]. It looks like they saw an opportunity to factor out that predicate and simply forgot to erase the last of what they'd just obsoleted. Are you sure you're not into cloning the repo and saving out a patch? No worries if not. This is great regardless. Thanks again, J.P. [1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f925fc93 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 28 22:14:11 2022 Received: (at submit) by debbugs.gnu.org; 29 Jan 2022 03:14:11 +0000 Received: from localhost ([127.0.0.1]:60818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDeBm-0006Tp-Rg for submit@debbugs.gnu.org; Fri, 28 Jan 2022 22:14:11 -0500 Received: from lists.gnu.org ([209.51.188.17]:58758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDeBk-0006Tg-Qy for submit@debbugs.gnu.org; Fri, 28 Jan 2022 22:14:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDeBh-0001GL-BS; Fri, 28 Jan 2022 22:14:06 -0500 Received: from [2a00:1450:4864:20::133] (port=40536 helo=mail-lf1-x133.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDeBc-0004Ri-9S; Fri, 28 Jan 2022 22:14:04 -0500 Received: by mail-lf1-x133.google.com with SMTP id a28so15466822lfl.7; Fri, 28 Jan 2022 19:13:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9gBNRNOiM2HDTLukerGHktsRPmRbCcc0p8rSehnyM4A=; b=aX81znCx8I4mSw5DX7xZUZYLuYcgbGV9pQsbls4X5czwQa28qWnZN5bXxn4UlQZsGn QxSjrUgVADAHc36NL1RQXAPds/MPwb0Iw7Yh3KvvfPbVRdCS1CSzSPNMwALrf1g4gVU8 hpCcQQoXUgBZQ7tl5SY4oJ2blrdunKVYNLTGZIOr2sVBMgFhbP4rEdZ1vNNt1If32Q4T cB0c5e/5rxboO93szLe+p/uTM6SI/f4SYfkysn1HYXy6FpLzHlPagZmhJ097QyFQjSpM iPJFVA/ZPAlPgydv0ZCxGj9ZR35fW1o1rvLeE329uJG2KLVQbP0cM+wZ5678SDx8HT4g slkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9gBNRNOiM2HDTLukerGHktsRPmRbCcc0p8rSehnyM4A=; b=GmoSf2kyXH4g1FnHhf5fz1GoUWe5Nl79kvKnlOlnHwJh9c1vbk6/Hy8utVYStCyucz ZE0d9RKOMlYda11rieD7kgT5MSMWjz4sLI52O0BBABImvGE7wuzuXfMkWRWM2ujPQ8rz Up7GDUrcerWOWcSwFopN2FWvoDTK9Grug+8yqEhLMBnCLHvKR0K9iBV2eJFJRhw/OG7C cwWmeab0q8NL6wQJ1RrfIJgFLXY21WnmKXzebv/qo+gBaU16xRFoXfeE1mU9XU6vkh4w 33iRIb3uHvCE16ZCWbytwtbpQUwjbsPvd1mYjV+MYvfnhoO+P0QRT/oqKnSaeB5BBDSM zZCg== X-Gm-Message-State: AOAM532ESrDSFE6wi3CJHRJYqey7KMU78MQh2rFmPqjDvWIfHzEi25Xp 4VbJ+drpqcTBnpnNv2lEdlGCw17E4CAHtgqiVGnISB1G X-Google-Smtp-Source: ABdhPJxgiNfylLm1mk/scgfIHCWc66IVD1/X0JTAa6z8aYTzIFd7XdiuEZTLkSkLSb2j06ok/TqW0uUzuqQ3B64Ojvg= X-Received: by 2002:a05:6512:1599:: with SMTP id bp25mr8020524lfb.678.1643426033060; Fri, 28 Jan 2022 19:13:53 -0800 (PST) MIME-Version: 1.0 References: <87ee4rutmo.fsf@neverwas.me> In-Reply-To: <87ee4rutmo.fsf@neverwas.me> From: Guy Gastineau Date: Fri, 28 Jan 2022 22:13:41 -0500 Message-ID: Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer To: "J.P." Content-Type: multipart/alternative; boundary="000000000000ea4e1c05d6aff051" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::133 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=strings.stringsandstrings@gmail.com; helo=mail-lf1-x133.google.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000ea4e1c05d6aff051 Content-Type: text/plain; charset="UTF-8" Sure. I will do it. The emacs bug report buffer provided access to a help page. It suggested I make a patch with `diff -u`. Is it preferable to provide a patch as made with git? On Fri, Jan 28, 2022, 10:07 PM J.P. wrote: > Hi Guy, > > Thanks for following through with the report. > > Guy Gastineau writes: > > > The entire sexp starting with `with-current-buffer ...` can be removed > > without changing the semantics of erc--switch-to-buffer. > > You're right, of course. In fact, the same commit that introduced > `erc--buffer-p' added the redundancy as well [1]. It looks like they saw > an opportunity to factor out that predicate and simply forgot to erase > the last of what they'd just obsoleted. > > Are you sure you're not into cloning the repo and saving out a patch? No > worries if not. This is great regardless. > > Thanks again, > J.P. > > > [1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f925fc93 > --000000000000ea4e1c05d6aff051 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sure. I will do it.=C2=A0 The emacs bug report buffer pro= vided access to a help page.=C2=A0 It suggested I make a patch with `diff -= u`.=C2=A0 Is it preferable to provide a patch as made with git?

On Fri, Jan = 28, 2022, 10:07 PM J.P. <jp@neverwas.m= e> wrote:
Hi Guy,

Thanks for following through with the report.

Guy Gastineau <strings.stringsandstrings@gmail.com&= gt; writes:

> The entire sexp starting with `with-current-buffer ...` can be removed=
> without changing the semantics of erc--switch-to-buffer.

You're right, of course. In fact, the same commit that introduced
`erc--buffer-p' added the redundancy as well [1]. It looks like they sa= w
an opportunity to factor out that predicate and simply forgot to erase
the last of what they'd just obsoleted.

Are you sure you're not into cloning the repo and saving out a patch? N= o
worries if not. This is great regardless.

Thanks again,
J.P.


[1] https://git.savannah= .gnu.org/cgit/emacs.git/commit/?id=3Df925fc93
--000000000000ea4e1c05d6aff051-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 28 22:30:38 2022 Received: (at submit) by debbugs.gnu.org; 29 Jan 2022 03:30:38 +0000 Received: from localhost ([127.0.0.1]:60824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDeRi-0006uD-D8 for submit@debbugs.gnu.org; Fri, 28 Jan 2022 22:30:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:60218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDeRg-0006u5-GC for submit@debbugs.gnu.org; Fri, 28 Jan 2022 22:30:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDeRf-0002zs-G0 for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 22:30:36 -0500 Received: from mail-108-mta16.mxroute.com ([136.175.108.16]:40153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDeRb-0006YM-Dd for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 22:30:33 -0500 Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta16.mxroute.com (ZoneMTA) with ESMTPSA id 17ea3e2316c0005a20.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 29 Jan 2022 03:30:17 +0000 X-Zone-Loop: 45fd8fab566a66f96fed6cc9c695087ced839a94937c X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nseOL7P0DiuWJ2p1m3X8R5SqDRfV1r7CwCVy9ch2l2M=; b=JfL+zK5EuAdC5r2mFKX3Jqi+xt 0RpssS3KqiXXXd2alGhXkRUdnKZE2kiNzHrA+wP8uZ1jVMc8F9WHHfLcy4PehVAEvBS+fZBLp/lIt 7+b/V20s7eJemvPfjit/5i78SLAEhFR62RtwtI/aePTt7iD32lc4tWUsG8xznlqmI44mEDveLKuIo VPqhDFJLjKo11ZGfGRnrpl2kfz8etK/9HUxTu/HUTPOv3CAoZfEPfqC2mZb2b/FTSwkE/XgpYHIdD uMPNwLU9JzD1Ka+zWE1S3anHF7GosnGMK/nbT2QXI02B07Lwl/QBZCWtQTEzMb7OwQnDLsH8F8cD9 fvpwMbXQ==; From: "J.P." To: Guy Gastineau Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer References: <87ee4rutmo.fsf@neverwas.me> Date: Fri, 28 Jan 2022 19:30:14 -0800 In-Reply-To: (Guy Gastineau's message of "Fri, 28 Jan 2022 22:13:41 -0500") Message-ID: <871r0rusl5.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.16; envelope-from=jp@neverwas.me; helo=mail-108-mta16.mxroute.com X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Guy Gastineau writes: > Sure. I will do it. Nice! > The emacs bug report buffer provided access to a help page. It > suggested I make a patch with `diff -u`. Is it preferable to provide a > patch as made with git? Definitely with git. The "Getting involved with development" section in CONTRIBUTE lays it out in full [1], but basically (after committing), you just run something like git-format-patch -M origin/master -o /tmp and look for a file named /tmp/0001-foo.patch and attach that in a reply. [1] https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE#n54 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 28 23:29:53 2022 Received: (at submit) by debbugs.gnu.org; 29 Jan 2022 04:29:53 +0000 Received: from localhost ([127.0.0.1]:60841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDfN3-0008MG-E8 for submit@debbugs.gnu.org; Fri, 28 Jan 2022 23:29:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:35596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDfN1-0008M9-O2 for submit@debbugs.gnu.org; Fri, 28 Jan 2022 23:29:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDfMz-0002gs-JS; Fri, 28 Jan 2022 23:29:49 -0500 Received: from [2a00:1450:4864:20::129] (port=40648 helo=mail-lf1-x129.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDfMx-0005Nm-1B; Fri, 28 Jan 2022 23:29:48 -0500 Received: by mail-lf1-x129.google.com with SMTP id a28so15692748lfl.7; Fri, 28 Jan 2022 20:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V9MAA9/bA5oZInpsJqAx7EkbBGbZJqCPI2ZTjAAauoo=; b=RpL6TKK+ezhi5y6PRTtKDuw7q4/XNjn6hOB0a9/hYJMHVeyEsSup65rHJLOCiLLMV8 SGnpK5qKZFIJY579KQUDIWSekH/stOBc/qEQuEmS8dhFcEifJctVAxqLwxGt3nldwfbe 29PtQexLcqqIfTyM2ZmU4ike31tw34y6RXW0vpCsixm99ed1oEKaA2PExxfpciP0WHs+ pYUbVtJ7bgxjDLfzn/n9PUA0kHGRRY3oNn8Vop0Y0bEHvy1t3LLPdyFrKhGFPRznhbK6 ef2ZlUaYD4p/8fTdfRkSgHEMTgBs9Wx76W/WHsc4ANq1be8pv/LrsvRPIEwe+PgWE7br 62LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V9MAA9/bA5oZInpsJqAx7EkbBGbZJqCPI2ZTjAAauoo=; b=t4IUXuyk9fek8iRLVyF+03p4FOLYm+Hbr4BANFvQlAz4qqpf/MzBUS9h9YmpPPxdrx jQXOiYZK/i+19tO7XjLHxUL9UrG0uQyQ4n6bz3Svlhgs4FGod1+XGsIHEVJ7gzf0rBP/ wfk0Gth1oUQjXsnCs0678GT+Et+/K9vd8EwtkjABliAllLQQm5P6HaJWqNHdYqCcA+BD MvGfYN5YFDLImJnDzRHzH7ciyFHrK7tvVRmZ0y2jW4RXarVXWOZidQC2qdB3eL8wyrfP NxRcw1RvcALuATACw8aQ4EPjo2fTCb7kIPQLI4MmOgUn2bwIfv+TqqjHaxNjHv6Xr/CV yFfw== X-Gm-Message-State: AOAM532Ky5egNcM9eN9bGWZ3AxeeJih0SRE+vupa6KVHWtFZD4pQtWx/ r/J5CGbK0poj1gJ+YmifnF/jz/oHwfLodlzAg3DXcAyV X-Google-Smtp-Source: ABdhPJzKfJ254QwzjHk12jnQqDe6TsuhlLrjLj3vVIlJ/0ZQeas08Yxdn9ROnhvbxemCiojwIGlnIi8Czkm3q5zg6X4= X-Received: by 2002:ac2:5542:: with SMTP id l2mr8194725lfk.252.1643430583442; Fri, 28 Jan 2022 20:29:43 -0800 (PST) MIME-Version: 1.0 References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> In-Reply-To: <871r0rusl5.fsf@neverwas.me> From: Guy Gastineau Date: Fri, 28 Jan 2022 23:29:31 -0500 Message-ID: Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer To: "J.P." Content-Type: multipart/mixed; boundary="00000000000024015f05d6b1004b" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::129 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=strings.stringsandstrings@gmail.com; helo=mail-lf1-x129.google.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --00000000000024015f05d6b1004b Content-Type: multipart/alternative; boundary="00000000000024015c05d6b10049" --00000000000024015c05d6b10049 Content-Type: text/plain; charset="UTF-8" Here it is. I don't think my pgp key is on any keyserver, but I signed it anyway. Thank you for the encouragement. On Fri, Jan 28, 2022 at 10:30 PM J.P. wrote: > Guy Gastineau writes: > > > Sure. I will do it. > > Nice! > > > The emacs bug report buffer provided access to a help page. It > > suggested I make a patch with `diff -u`. Is it preferable to provide a > > patch as made with git? > > Definitely with git. The "Getting involved with development" section in > CONTRIBUTE lays it out in full [1], but basically (after committing), > you just run something like > > git-format-patch -M origin/master -o /tmp > > and look for a file named /tmp/0001-foo.patch and attach that in a > reply. > > [1] https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE#n54 > --00000000000024015c05d6b10049 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here it is.=C2=A0 I don't think my pgp key is on any k= eyserver, but I signed it anyway.=C2=A0 Thank you for the encouragement.

On Fri, Jan 28, 2022 at 10:30 PM J.P. <jp@neverwas.me> wrote:
Guy Gastineau <strings.stringsandstrings@gmail.com>= writes:

> Sure. I will do it.

Nice!

> The emacs bug report buffer provided access to a help page. It
> suggested I make a patch with `diff -u`. Is it preferable to provide a=
> patch as made with git?

Definitely with git. The "Getting involved with development" sect= ion in
CONTRIBUTE lays it out in full [1], but basically (after committing),
you just run something like

=C2=A0 git-format-patch -M origin/master -o /tmp

and look for a file named /tmp/0001-foo.patch and attach that in a
reply.

[1] https://git.savannah.gnu.org/cgit= /emacs.git/tree/CONTRIBUTE#n54
--00000000000024015c05d6b10049-- --00000000000024015f05d6b1004b Content-Type: application/pgp-encrypted; name="0001-Remove-redundant-checks-in-erc-switch-to-buffer.patch.gpg" Content-Disposition: attachment; filename="0001-Remove-redundant-checks-in-erc-switch-to-buffer.patch.gpg" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kyzc3p1v0 owGNVHtsFEUcvmJBusgjCEWUx693IHvc7XV3730WUqy0hUYhpYGAkDi7O3u35W732EcPsEQImFgx VKogVRFUUIhBwtOIDQaQWDRBEku08moI/kF4JBxV5Bln70oh4B9OdrMz3/7m+37fzG/m3YFPOPoX tLWcfWb0xGxdwY7CNUKMZVmOqcUprQEzOpYsVUKqyYgJLC40GEVlsC4yRkYxxQRjaoxgyTLWfWlE xqj7cKJS11Igh/1+PhgNCWGW5wWZY3GQD4RQMIgEFMJBQZYEFBFDErysqTALp4ELA8vGcg/wRJ+y aWJQZS2BKmSYioqRBWWGqStq3PD1fJEq9fTK4ymkJH2ilppMvYRMHINKXfECH4HpSCWEPA+8P8bx sQAPDBtkWWqWJdRj0YzBqzOn1FVUL4C8Yeg1DHnDoKhgG37cMUXJUT4oi1G/gMQAJ4VDPC9xiIBh 7PcLLA77I7IcDAospLBNaGqEPSdiJhTDC4JlgmJSGWRAEssmCDihqJKPYhiGgqRipEuJsP36cBIa IQweJtco4EBWkphkiNQ4lrxkrKgG1k1FU2mP2wshkHAS20ODZtwUJSmyDAwTV0xApY8yC48iFMkC L4YoxhHJHxFY3ueLRlGE8wcEXgSOZUOBgJ3k41yUx+P5D77ycmC4cIjzcjx4cp0wEEwlO+akoKgI 6CRKCRICmiytilLYnUOB4NgE2kaBVsgrEkNpeDjIDqNFSe8FgY5js2eLekHSKCbHSKIzCazaf3oR guV2OD+JyQk8SMkNphvSuia6H55AiiHBiJauY/VhNTuE2CGFCbSEdaUBS0xKkzAhnWBr2H13PijP o+lAq1Yy+UAh5wgvygG5yiMb22CnRcbYMNy9jfLcd2TL5XL+XzZ6ZtsJyla+uB+tbaCf19J2+aAk ID1OggGcM8mJTJsgk5TJmZpaWwE9waSu8wSk56Ngjr2+itqgLcQS2OtEZLGsLLaZrBRZLy9YBgZE TD8gMXwAc0isZpmktIDiff6gj6WopoI9hY6C/o7RxSWF10OdrglvOrKJo86v799YffvYd46DKhpy HznvGXD3uVN/3qptdg2qv3opmt3yytOdZbu+PbvF9eHbW4f82u/M4Bb0xe291aV9xynvVxaHOwp/ XLfjyKlJE727p2x4Uvy4+wY64DpUebPW2Ti9vKXPqpFLR68XBw9tX3dg36iB2Wl7lvzsGqtw/dWN u0dlv5x77V74+HBP+Yxk8c6aeUsjYxpOt7d9M0p5YWvqTN3rfZeP/6H78Mlz1oV49eTvXtt/sbVp 3LZtl+avjNbt0g6xR/cuufzO76Wz5885X9dWNabCeadj72bpesmeIDvNeaSkvhGv3b70e9/UIdNG zHgr+1SLM9OldN67ntp07Og+esvJc380/b1r+5F/WlcOGzus+tZd+tOSMWn2GpTN3l90Y7N+sOZY ZWvzJ5d3Tuh670Wj4xd3W9eAEascn13568rg2Ss6aipuz/rIGlk2aPmO0mVoY2fx8NUH5y0Cy9VY M74y0549fcLzVfWdN5xX5t7MbB7atGbFwObjbc2Hhgl3uqKZg5suxEtcax3L6kf2a2dPtCdubfjg t0nrnw34P7968acF/wI= --00000000000024015f05d6b1004b-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 29 00:15:31 2022 Received: (at control) by debbugs.gnu.org; 29 Jan 2022 05:15:31 +0000 Received: from localhost ([127.0.0.1]:60856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDg5C-00018B-QG for submit@debbugs.gnu.org; Sat, 29 Jan 2022 00:15:30 -0500 Received: from mail-108-mta155.mxroute.com ([136.175.108.155]:36713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDg58-00017s-Ks for control@debbugs.gnu.org; Sat, 29 Jan 2022 00:15:29 -0500 Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta155.mxroute.com (ZoneMTA) with ESMTPSA id 17ea44255bd0005a20.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 29 Jan 2022 05:15:17 +0000 X-Zone-Loop: 4c3bb45b36a7e4dc1cb04117e2f85839473b303b4816 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=muXlsgxWnaDx5MI2qLywcJ2UmC4igK33Wk2FlPN2s0Y=; b=hxRjZwEr7djI83Xj83loPcBhip eZ5cXoSgdkw7HU9ISMkUBOqobVR8z+gbVovxbQiWFtRmYmpJ8Qfz4RBKYgjlcxAVQ5/l7WB9VoKv5 hlgzF8X1tAfJPOu5nzsNRz9xFbw2vIUQsIitKIyEXIbZwsmVyxFApj1LjNFEIoLo1CP4B7Sr4rX8T IidnMyoRuglcf7Hqo+KmMYCwP4Fd4LDvXBs3PX8ejXr2jHu0DrKLISdnuox9lKIFHBntDOPzMFiLP OveO0qgwzfstiY8wbtThr8Qyx24CRwkULO+3TBzazOG8MJah3wyd2IeuZ7vFYpP9pv/a0F/YuPeVO +zgLOVdw==; From: "J.P." To: control@debbugs.gnu.org Subject: control message for bug #53617 Date: Fri, 28 Jan 2022 21:15:14 -0800 Message-ID: <87y22zt95p.fsf@neverwas.me> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 53617 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 29 18:49:39 2022 Received: (at 53617) by debbugs.gnu.org; 29 Jan 2022 23:49:39 +0000 Received: from localhost ([127.0.0.1]:35158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDxTP-0002fa-9V for submit@debbugs.gnu.org; Sat, 29 Jan 2022 18:49:39 -0500 Received: from mail-108-mta220.mxroute.com ([136.175.108.220]:40201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDxTN-0002fN-1V for 53617@debbugs.gnu.org; Sat, 29 Jan 2022 18:49:37 -0500 Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta220.mxroute.com (ZoneMTA) with ESMTPSA id 17ea83e5f8d0005a20.001 for <53617@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 29 Jan 2022 23:49:27 +0000 X-Zone-Loop: 06ccf9c602fe726d1ee04c0b39c17bc4dcc148fc2f33 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HhilBh9CwE4yk+JxosI7Y7N4i1DJIS3t/sQVGgr9his=; b=KbdFBpMF52ZAeE7e/yo5gVIzbP crRr1Q4njnFoSCQo1jP/BYgLtiVgSUZamGA1PtVSZ8jSRf/KlaPwe75j6ZAWRKELUBEF6h9WYo1T6 vXEoX5W618eY60ZRIT3Te8anN44nUj5CjO3sP4yPrMdsgxGYfXdZUdkgcRgM/nMnKK60M4zEfEoxH I1RilUyzm9Reu7ZqnkGOUWvScxNd8Wg8RcC+D4wcX6xPnJavln+cQWL0/5W1Wswco5dyO/017wYJw gsCk12qtKJKaA4PeervLQSk/9ZDjrhA350deSHBy2tUOuYLqwztVX4ovIDpnRwzYKkFwQnTNv6Wnq D0jFmXhw==; From: "J.P." To: Guy Gastineau Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> Date: Sat, 29 Jan 2022 15:49:24 -0800 In-Reply-To: (Guy Gastineau's message of "Fri, 28 Jan 2022 23:29:31 -0500") Message-ID: <878ruyqf0b.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AuthUser: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53617 Cc: larsi@gnus.org, emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Guy Gastineau writes: > Here it is. I don't think my pgp key is on any keyserver, but I signed > it anyway. I'm not sure if Emacs has a policy regarding the signing of everyday contributions, but if your key isn't signed by anyone and not propagated among the keyservers, then I'd guess you can probably just skip further signing in the near term. > Thank you for the encouragement. My pleasure. This looks ready for Emacs 29. Thanks. . . . I've added the customary tweaks to the log message if someone wants to glance at it (cc. bandali, Lars). Also, question: is there formal recordkeeping going on re exempt lines accumulated per individual? And if not, is the recommended way to get a tally just `git log --author=`? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Remove-redundant-checks-in-erc-switch-to-buffer.patch >From 12352c00544c1916210dd15002ef4ffe0f5efdc8 Mon Sep 17 00:00:00 2001 From: Guy Gastineau Date: Fri, 28 Jan 2022 23:12:42 -0500 Subject: [PATCH] Remove redundant checks in erc--switch-to-buffer * lisp/erc/erc.el (erc--switch-to-buffer): Commit f925fc93bac41d7622d1af927e33b0e738ff55b0 "Add `predicate' arg to `read-buffer' and use it for erc-iswitchb" meant to remove this, but it was left behind. (Bug#53617). Copyright-paperwork-exempt: yes --- lisp/erc/erc.el | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 9ee8d38b02..52fe106f2d 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -1761,12 +1761,7 @@ erc--switch-to-buffer (lambda (bufname) (let ((buf (if (consp bufname) (cdr bufname) (get-buffer bufname)))) - (when buf - (erc--buffer-p buf (lambda () t) proc) - (with-current-buffer buf - (and (derived-mode-p 'erc-mode) - (or (null proc) - (eq proc erc-server-process)))))))))) + (and buf (erc--buffer-p buf (lambda () t) proc))))))) (defun erc-switch-to-buffer (&optional arg) "Prompt for an ERC buffer to switch to. When invoked with prefix argument, use all ERC buffers. Without -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 29 21:25:47 2022 Received: (at 53617) by debbugs.gnu.org; 30 Jan 2022 02:25:47 +0000 Received: from localhost ([127.0.0.1]:35267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDzuV-0000Vx-0U for submit@debbugs.gnu.org; Sat, 29 Jan 2022 21:25:47 -0500 Received: from mail-lj1-f173.google.com ([209.85.208.173]:43936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDzuT-0000Vj-En for 53617@debbugs.gnu.org; Sat, 29 Jan 2022 21:25:45 -0500 Received: by mail-lj1-f173.google.com with SMTP id t7so14536393ljc.10 for <53617@debbugs.gnu.org>; Sat, 29 Jan 2022 18:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JWc+G2jY8UK89eI4TFMgznA+BIMVACOxp47A+FLLxQI=; b=PGYfM5dbadZOjlM1jA878ECi0/JAiHLdLu0CW7fWHEuHAUDg+bFyvWwI9o8H2A2M3A f5wwgHwNdREiD09XrLYIWFQ/KZBImw6kNyaukOONzzyYulbZ6A8UlC8yK7jXUy0/OSE1 tNWdEcj1wB5cbHr2Km/u+TsEM6UfYqOzwwmjDQziRK5DwaipLJDI0WulERYLGsVXvcnb qWKmsi5bNaeQyimeAcO3HrLeqKJWcAdAXt3bVqHogMziw5TlBk99wCW+UvGLZK5jTwyO bqc6cadL5f0r0ZaUc2HDrZwcqzW/mSkTqldTOY4aU3os9ssEAt3RNeF63EDzpBPfwr5H Foxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JWc+G2jY8UK89eI4TFMgznA+BIMVACOxp47A+FLLxQI=; b=12DIbc/h7Q6v/rRvwoGnlU7qlK97mjDW6aBqP7TfeLTqJMpJ4Hk+mc63BrrYPbOGI/ VXTVV/oENtedV+jysezY7zDjtRdyc+pZTbMR0lw/QbwTN4QjDWgZh7weJxf8eMMxUxUZ XgsO+8eVmykM8iHa+vkR5Aw5++qNdcRPfJagCYnDElWQZhQ6N+yNiDml8Znznxi2kuJj nNhiE27IfdPRyoDV3FbSAM78rkHYRD3shUO88MalLNIHdZampkI/3dYs7rrTVIPkvKJC lz08NW8dnniAkXI5A3wvzF+uQZPbMhw1fSWU1Lh+ugsC4PMCjZYpM2NVTcsp4CUupjKs jLjA== X-Gm-Message-State: AOAM532TZUKmQNBIvaNCLsXD3/uTkxkGfAzRJVuCpnf1uiylqjEeccGj bywaToHNpCBEwGdTJgIZoW+kOm762wR7te0TWEs= X-Google-Smtp-Source: ABdhPJxTfz0/4HTOvrkD0MvUulbLMNaOyu29qtslmWrqePn2v9D6v7NIqjN/dzFHdDZNGd5+CaieF51fDf4T4XjUStA= X-Received: by 2002:a2e:b0c4:: with SMTP id g4mr9934524ljl.165.1643509539054; Sat, 29 Jan 2022 18:25:39 -0800 (PST) MIME-Version: 1.0 References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> In-Reply-To: <878ruyqf0b.fsf@neverwas.me> From: Guy Gastineau Date: Sat, 29 Jan 2022 21:25:28 -0500 Message-ID: Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer To: "J.P." Content-Type: multipart/alternative; boundary="00000000000042a7c505d6c3620a" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53617 Cc: larsi@gnus.org, emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000042a7c505d6c3620a Content-Type: text/plain; charset="UTF-8" Yeah, I should get my keys on some servers. I finally started signing all my commits, so I just felt weird about not signing the patch. It was my pleasure to contribute this miniscule addition to the wonderful emacs. On Sat, Jan 29, 2022, 6:49 PM J.P. wrote: > Guy Gastineau writes: > > > Here it is. I don't think my pgp key is on any keyserver, but I signed > > it anyway. > > I'm not sure if Emacs has a policy regarding the signing of everyday > contributions, but if your key isn't signed by anyone and not propagated > among the keyservers, then I'd guess you can probably just skip further > signing in the near term. > > > Thank you for the encouragement. > > My pleasure. This looks ready for Emacs 29. Thanks. > > . . . > > I've added the customary tweaks to the log message if someone wants to > glance at it (cc. bandali, Lars). Also, question: is there formal > recordkeeping going on re exempt lines accumulated per individual? And > if not, is the recommended way to get a tally just `git log --author=`? > > --00000000000042a7c505d6c3620a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yeah, I should get my keys on some servers.=C2=A0 I final= ly started signing all my commits, so I just felt weird about not signing t= he patch.=C2=A0 It was my pleasure to contribute this miniscule addition to= the wonderful emacs.

On Sat, Jan 29, 2022, 6:49 PM J.P. <jp@neverwas.me> wrote:
Guy Gastineau <strings.stringsandstrings@= gmail.com> writes:

> Here it is. I don't think my pgp key is on any keyserver, but I si= gned
> it anyway.

I'm not sure if Emacs has a policy regarding the signing of everyday contributions, but if your key isn't signed by anyone and not propagate= d
among the keyservers, then I'd guess you can probably just skip further=
signing in the near term.

> Thank you for the encouragement.

My pleasure. This looks ready for Emacs 29. Thanks.

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 . . .

I've added the customary tweaks to the log message if someone wants to<= br> glance at it (cc. bandali, Lars). Also, question: is there formal
recordkeeping going on re exempt lines accumulated per individual? And
if not, is the recommended way to get a tally just `git log --author=3D`?
--00000000000042a7c505d6c3620a-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 30 01:34:36 2022 Received: (at 53617) by debbugs.gnu.org; 30 Jan 2022 06:34:36 +0000 Received: from localhost ([127.0.0.1]:35450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nE3nI-0007D8-DX for submit@debbugs.gnu.org; Sun, 30 Jan 2022 01:34:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nE3nG-0007Cr-8O for 53617@debbugs.gnu.org; Sun, 30 Jan 2022 01:34:34 -0500 Received: from [2001:470:142:3::e] (port=42554 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nE3n4-0008NK-Dg; Sun, 30 Jan 2022 01:34:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qDObeA5y+3EP3MplY//YL2D42QmPL+9i8bBooEWZK74=; b=WzyP8qQk6JR7 bfzlOC7VKg0TCr06hV0Vhmvo//NoGbWxvIiE2xpZR+NSEhlf2F2B4nBaxkdeMJg0IfYJMhIqWNZH6 HOrUVMUYFshCkzCdUoPnx8Y5X6oldik3OBjL8mZxOT5oES50a/Wi1x0RKyJqjG9pXb7R/y7wJkBMJ W30aC8yXhMNyfJmc2/Ek+nH+l5esiSBf7fZ1B3VtuNW6hLFVNgSUBHPxzKkSOCk2OCNW5ZmZ/Ezom txB+v2Wrkh3OaUDggPZwHAYhCu6gN8PhW4F6UBlsx4OWrpQ2ceSmaLZBtHqKv66yTCthvlyduBSmW 6OQXqLOfCpl/clDS27RBtA==; Received: from [87.69.77.57] (port=3103 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nE3mx-0000dr-Fg; Sun, 30 Jan 2022 01:34:20 -0500 Date: Sun, 30 Jan 2022 08:34:08 +0200 Message-Id: <83a6fdbulb.fsf@gnu.org> From: Eli Zaretskii To: "J.P." In-Reply-To: <878ruyqf0b.fsf@neverwas.me> (jp@neverwas.me) Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53617 Cc: strings.stringsandstrings@gmail.com, larsi@gnus.org, emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "J.P." > Date: Sat, 29 Jan 2022 15:49:24 -0800 > Cc: larsi@gnus.org, emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org > > Guy Gastineau writes: > > > Here it is. I don't think my pgp key is on any keyserver, but I signed > > it anyway. > > I'm not sure if Emacs has a policy regarding the signing of everyday > contributions It does. From CONTRIBUTE: - Commit messages should not contain the "Signed-off-by:" lines that are used in some other projects. > I've added the customary tweaks to the log message if someone wants to > glance at it (cc. bandali, Lars). Also, question: is there formal > recordkeeping going on re exempt lines accumulated per individual? And > if not, is the recommended way to get a tally just `git log --author=`? I don't think I understand what you are asking here, please elaborate. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 30 10:43:55 2022 Received: (at 53617) by debbugs.gnu.org; 30 Jan 2022 15:43:55 +0000 Received: from localhost ([127.0.0.1]:37361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nECMt-0007nZ-0h for submit@debbugs.gnu.org; Sun, 30 Jan 2022 10:43:55 -0500 Received: from mail-108-mta102.mxroute.com ([136.175.108.102]:35443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nECMq-0007nM-4Y for 53617@debbugs.gnu.org; Sun, 30 Jan 2022 10:43:53 -0500 Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta102.mxroute.com (ZoneMTA) with ESMTPSA id 17eaba800da0005a20.001 for <53617@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sun, 30 Jan 2022 15:43:41 +0000 X-Zone-Loop: 315d338bc5cd3f52ada4eb175916d0a8fd889a039ac2 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nZ7a5qcfik6k4AJsy4JKLETX9J6ReejUX/JX0nQfw5E=; b=Tb08fwlyMeAtvL2g863ueEZFjR j2+LV+npOKkOudDlnM3LjLgvyvirZ/st/FtxfBld2XNKqt8uYHGm0LEuc7dDu4d9/J61xCQRjC6I8 qEknyenC3dr/Ic+ezIqtGpDduk8xjRcLks8AMBO0DT9g5n7Fle4SnUibeMUWAPZ31acoaFLPqGpjo d+XfBJI1hsu5CcjGCzfPeQSAt+2AxRqqb0ysqtNgpfQcmFZAM2YFRKA93EX7onJZX5G5w89ImNqp9 G1fmtyw0TlwIXs3J4iszkJKnPNVXpRAGmMCA/V2mpi6voMmHqd5L20da0PTLMB7DbXR8tKWXMm3hT scrrRexg==; From: "J.P." To: Eli Zaretskii Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> <83a6fdbulb.fsf@gnu.org> Date: Sun, 30 Jan 2022 07:43:37 -0800 In-Reply-To: <83a6fdbulb.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 Jan 2022 08:34:08 +0200") Message-ID: <878rux9ql2.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AuthUser: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53617 Cc: strings.stringsandstrings@gmail.com, larsi@gnus.org, emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> I'm not sure if Emacs has a policy regarding the signing of everyday >> contributions > > It does. From CONTRIBUTE: > > - Commit messages should not contain the "Signed-off-by:" lines that > are used in some other projects. Thanks. I could certainly use a good reread of CONTRIBUTE. I guess in this case, I was more confused about what role a PGP-signed patch (like the OP's) could ever play in workflows that incorporate PGP commit signing and whether Emacs had a stance on that sort of signing in general. The first part (I now realize) makes little sense because it's only committers who sign commits. And so a PGP-signed patch (like a PGP-signed email) can only get as far as the bug tracker. As for the second part, PGP-signed commits appear to be relatively rare in Emacs. Among the most recent 10K or so commits reachable from HEAD, it seems only around 1% have been signed (list attached). >> Also, question: is there formal recordkeeping going on re exempt >> lines accumulated per individual? And if not, is the recommended way >> to get a tally just `git log --author=`? > > I don't think I understand what you are asking here, please elaborate. Apologies for the unintelligible mumblage. Somehow (believe it or not), I was trying to ask whether there's a system in place for keeping track of the number of non-trivial changes a non-paperwork holder has made so far. By "system" I guess I mean a person in charge of recording such information or perhaps a table somewhere to consult. But if it's less formal than all that, I suppose I'll just rely on the git history and whatever an author self-reports. Thanks. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=recently-signed.log 477:11626f0c0c E Protesilaos Stavrou * admin/MAINTAINERS: Describe Modus themes as externally maintained package 754:f03d0de26f E Protesilaos Stavrou Update modus-themes to version 2.0.0 1519:030a5c5704 E Protesilaos Stavrou Remove problematic characters from modus-themes.org (bug#52126) 1520:ecf3bf66ba E Protesilaos Stavrou Remove problematic characters from modus-themes.org (bug#52126) 1810:ce33ad8bae E Protesilaos Stavrou Update modus-themes to version 1.7.0 2254:d96de23510 E Jonas Bernoulli * lisp/transient.el: Update to package version v0.3.7-11-g7f5520b3. 2577:3b5de7f991 E Jonas Bernoulli ; lisp/transient.el: Revert some misguided stylistic fixes. 2786:ca3d7234d3 E Amin Bandali Release ERC 5.4.1 2802:88bd6fccf1 E Amin Bandali * doc/misc/erc.texi: Add 'ERCVER' and 'ERCDIST'. 2885:ac06608878 E Amin Bandali Release ERC 5.4 2886:a1a589d07b E Amin Bandali * etc/ERC-NEWS: Announce ERC's addition to GNU ELPA. 2887:6c7947f0a1 E Amin Bandali * etc/ERC-NEWS: Fix outline level for the recent additions. 2888:c480b68644 E Amin Bandali Add ERC entries for 'customize-package-emacs-version-alist' 2890:36a485a1af E Stefan Kangas Obsolete XEmacs compat convention in 'erc-button-press-button' 2891:395273773c E Amin Bandali Revert "Obsolete XEmacs compat convention in erc-button-press-button" 2892:31d60488ac E F. Jason Park Backport: Add ERC version to protocol log 2983:1100fffcd3 E Amin Bandali * lisp/erc/erc.el: Don't error if 'erc-loaddefs' does not exist. 2984:8865fc02ab E Amin Bandali Add 'erc-bug' command for reporting ERC bugs 2985:5afa07919e E Amin Bandali Add 'erc-version' and use it to display ERC version consistently 2986:bc941846d9 E Amin Bandali Small tweaks and improvements to etc/ERC-NEWS 2987:30b5e0a514 E Amin Bandali Add NEWS items for changes to ERC since 5.3 to etc/ERC-NEWS 3091:595e506c82 E Stefan Kangas * lisp/erc/erc.el (erc-user-mode): Set "+i" by default. 3183:94c247d659 E Amin Bandali ; Oops, fix up last commit 3184:88378acbfc E Stefan Kangas Rename arguments of ERC's '/whois' and simplify doc string 3213:dc94ca7b2b E Amin Bandali Add new '/wii' convenience ERC command 3214:9fc1fdcbf3 E Amin Bandali Restore the previous order of ERC's '/whois' arguments 3239:081eb52e4d E Amin Bandali Switch the order of ERC's '/whois' arguments sent to the server 3241:cbb0b5d8d5 E Amin Bandali Unobsolete erc-compat.el 3525:0b98ea5fbe E Jonas Bernoulli No longer raise error when http authentication failed 3564:bc59c98f09 E Amin Bandali Add new '/opme' and '/deopme' convenience ERC commands 3597:62e870691d E Amin Bandali * lisp/erc/erc.el: Add Package-Requires and URL headers. 3598:931a898776 E Amin Bandali * etc/NEWS: Announce update of IRC-related references to point to Libera.Chat. 3631:c6eb114a42 E Olivier Certner ERC: NickServ: Prompt for password last, overall simplifications (bug#46777) 3632:f7ed946874 E Amin Bandali * lisp/erc/erc-button.el (erc-emacswiki-url): Update to shorter address. 3665:7a69fe3bc9 E Philip Kaludercic Merge branch 'feature/rcirc-update' 3689:5ebad79e62 E Philip Kaludercic Fix interactive forms for rcirc-define-command 3690:3405c85ae4 E Philip Kaludercic Unset mode-line-process for all buffers on reconnecting 3691:1e1378699c E Philip Kaludercic Restore rcirc-target if possible 3693:1c3bad8c2e E Philip Kaludercic Display server buffer after connecting 3694:8eb9eb0c41 E Philip Kaludercic Allow for multiple attempts when reconnecting 3695:ec50a368d5 E Philip Kaludercic * rcirc.texi (Hacking and Tweaking): Add missing section to menu 3696:767fa9761f E Philip Kaludercic * rcirc.el (rcirc-server-alist): Add #emacs to default server list 3758:85d0ed097e E Amin Bandali ERC: Use 'string-replace' only on Emacs 28 and later 3759:e20bae005e E Amin Bandali ERC: Use 'string-search' only on Emacs 28 and later 3779:291bcb5973 E Olivier Certner ERC: Track: Fix a perceived minor bug in mode line face selection 3780:3df279aae2 E Olivier Certner ERC: Track: Rewrite 'erc-track-find-face' as 'erc-track-select-mode-line-face' 3781:e4b7fa0500 E Amin Bandali Merge from origin/emacs-27 3782:d7f4cc0974 E Olivier Certner ERC: Track: Clarify documentation on tracked buffers and add references 3783:fb1f0dfec9 E Olivier Certner ERC: Track: Fix documentation of structure of 'erc-modified-channels-alist' 3786:0d350402d8 E Philip Kaludercic * NEWS: Remove empty entry 3787:0712e33588 E Philip Kaludercic * NEWS: Mention rcirc changes 3793:2e24b66079 E Philip Kaludercic * rcirc.texi: Replace defun-rcirc-command with rcirc-define-command 3794:251a9f5fe0 E Philip Kaludercic * rcirc.texi: Document rcirc-track-abbrevate-flag 3795:88b623772b E Philip Kaludercic * rcirc.texi: Document rcirc-nick-filter and rcirc-channel-filter 3796:0d08745806 E Philip Kaludercic * rcirc.texi: Document rcirc-track-ignore-server-buffer-flag 3797:550011ca58 E Philip Kaludercic * rcirc.texi: Document rcirc-omit-responses-after-join 3798:7a89e0f822 E Philip Kaludercic Rename rcirc-omit-after-reconnect to rcirc-omit-after-connect 3818:6d31d5b4b4 E Philip Kaludercic Merge branch 'master' into feature/rcirc-update 3819:a66fd7bb37 E Philip Kaludercic Fix double reconnection bug 3862:2ef6691602 E Philip Kaludercic Add rcirc-track-ignore-server-buffer-flag option 3878:ec0e46d66b E Philip Kaludercic Use fresh symbol for argument list 3879:4a0c0e5606 E Philip Kaludercic Allow /reconnect while connecting 3886:8275f0b117 E Philip Kaludercic Mention list of capabilities that should be implemented 3887:354929a85a E Philip Kaludercic Implement standard-replies capability 3888:659a77a0eb E Philip Kaludercic Connect to server asynchronously 3921:70d459914f E Philip Kaludercic Implement multi-prefix capability 3922:e37f3ce3b4 E Philip Kaludercic Fix rcirc-track-abbrevate-flag documentation 3923:0f1db3dc2b E Philip Kaludercic Store symbols in rcirc-acked-capabilities 3926:008a033bbb E Philip Kaludercic Print value on malformed input 3942:608b2ec9be E Philip Kaludercic Replace with-current-buffer with buffer-local-value where applicable 4011:8761d30da0 E Philip Kaludercic Avoid failing if vc backend doesn't implement ignore-completion-table 4384:c817a34edd E Philip Kaludercic Add new option rcirc-channel-filter 4385:ade9653108 E Philip Kaludercic Add new option rcirc-track-abbrevate-flag 4395:b77f6af24e E Olivier Certner ERC right stamps: also use latest buffer's window's width (Bug#44140) 4439:d50721bf02 E Amin Bandali Merge from origin/emacs-27 4440:72dc602459 E Amin Bandali ; Merge from origin/emacs-27 4441:75ecce4323 E Olivier Certner Unbreak ERC's Ibuffer filter (Bug#44100) 4516:190ea9cd3e E Philip Kaludercic Replace cl-c[ad]+r with regular c[ad]+r 4523:7e13bfd4a8 E Philip Kaludercic Remove removal of text properties from rcirc-buffer-alist keys 4525:fb27708f51 E Philip Kaludercic Fix checkdoc issues 4527:402385393a E Philip Kaludercic Update rcirc-buffer-alist after receiving NICK 4530:262fbe1a47 E Philip Kaludercic Fix TOPIC command 4571:47b5dcdcf5 E Philip Kaludercic Ensure that rcirc-buffer-alist has no text properties 4582:1967b9c474 E Philip Kaludercic Generate no message when activating rcirc-omit-mode 4606:55a19a1da2 E Philip Kaludercic Merge branch 'feature/rcirc-update' 4719:335a5fd173 E Protesilaos Stavrou Update modus-themes to version 1.5.0 4820:77631c2a77 E Philip Kaludercic Add query command removed in 4ff1f66b12 4821:1d73575681 E Philip Kaludercic Fix issues with argument parsing in rcirc-define-command 4842:7a13ddfda0 E Amin Bandali Update a few more IRC-related references to point to Libera.Chat 4843:8d957f2dd8 E Amin Bandali Merge from origin/emacs-27 4844:136b30b0c4 E Amin Bandali ; Merge from origin/emacs-27 4845:5d1cf01d53 E Amin Bandali Merge from origin/emacs-27 4846:348b2aed0c E Amin Bandali Update IRC-related references to point to Libera.Chat 4850:f222fe6163 E Philip Kaludercic * rcirc.el (rcirc-define-command): Mention name of malformed command 4865:124ba9db96 E Jonas Bernoulli * lisp/transient.el: Update to package version 0.3.6. 5266:5a762c946e E Protesilaos Stavrou Remove modus-themes.org build date (bug#48661) 5283:75604f882a E Jonas Bernoulli * lisp/transient.el: Update to package version 0.3.4. 5289:86e4d770a8 E Amin Bandali * lisp/erc/erc-services.el: Fix newly-added Libera.Chat entry (bug#48529). 5486:c38b4a9bef E Amin Bandali Tweak documentation relating to 'erc-tls' 5680:6a03e4cc4f E Amin Bandali * lisp/erc/erc.el: Add past maintainer Michael Olson to Contributors. 5743:87d37e279f E Amin Bandali Fix thinko introduced in the last ERC patch (bug#47788) 5757:344f769491 E Amin Bandali Add support for using a TLS client certificate with 'erc-tls' (bug#47788) 5795:afcdd4cab3 E Jonas Bernoulli Add new library transient.el 6205:f1f351def3 E Mark A. Hershberger Update rnc to use Open Document's Relax-NG schema to version 1.3 7285:42f45e52aa E Basil L. Contovounesios ; Improve defcustom :type in last change. 7298:f7b9b9a85e E Basil L. Contovounesios ; Use American spelling in etc/NEWS. 7415:e1902ac618 E Basil L. Contovounesios Fix recently uncovered 'make check' failures 7454:90bd6d8ba6 E Ted Zlatanov * test/infra/gitlab-ci.yml: Copy newer files to image to build less often. 7459:5d2ebcd896 E Ted Zlatanov * test/infra/gitlab-ci.yml: Revert to always building. 7491:849fe71de7 E Fabrice Bauzac Sort Ibuffer filename/process column as displayed 7505:1248c67484 E Ted Zlatanov * test/infra/gitlab-ci.yml: Bootstrap only from web, schedule, or C-related. 7528:8f4b3b812a E Basil L. Contovounesios Fix ibuffer-mark-by-file-name-regexp abbreviations 7529:bdb9889f78 E Basil L. Contovounesios Use format-prompt in read-regexp. 7542:372694e7c6 E Ted Zlatanov ; * test/infra/gitlab-ci.yml: Merge test-template script into job-template. 7543:1fe135a024 E Ted Zlatanov * test/infra/gitlab-ci.yml: Merge test-template into job-template. 7553:57ae3f29af E Ted Zlatanov test/infra/gitlab-ci.yml: run only for tags and some branches 7556:84e0749b8b E Ted Zlatanov EMBA container build improvements for Emacs build testing. 7564:f45be48ddb E Basil L. Contovounesios ; Remove recent spurious addition in window.el 7582:707ee6afe2 E Ted Zlatanov EMBA infrastructure improvements for Emacs build testing. 7627:25dadca0d1 E Basil L. Contovounesios Hyperlink symbol names without word syntax in Help 7629:5960e9cf57 E Basil L. Contovounesios ; * lisp/custom.el (defcustom): Fix last change. 7737:56556b5f4d E Basil L. Contovounesios Fix build for --enable-checking=structs 7901:c6d5555646 E Amin Bandali Display messages sent using ERC's /say 9107:ca3b199ad5 E Amin Bandali ; * etc/NEWS: Tweak the wording for the newly added entry 9108:ae9f234dd9 E Amin Bandali ; * etc/NEWS: Add entry for my last change 9109:694c82ab1a E Amin Bandali Replace irc.freenode.net with chat.freenode.net --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 30 11:00:37 2022 Received: (at 53617) by debbugs.gnu.org; 30 Jan 2022 16:00:37 +0000 Received: from localhost ([127.0.0.1]:37395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nECd2-0008Ie-Ve for submit@debbugs.gnu.org; Sun, 30 Jan 2022 11:00:37 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nECd1-0008IT-PL for 53617@debbugs.gnu.org; Sun, 30 Jan 2022 11:00:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7Lj9Qk6GpBQICJ6pQtVBSG3MRnurFgy79iqIkHwikp8=; b=is456p4vSPQV8A2+Pf7k3obByD 9L9mypEUFv6tgoF63/t7rjNoi4A8Id74znlc61MIdP4JNoifCIUXynSJNf1PmjgbZq88QvTnn3zC6 3CyoVcQliQyjje3e8oE2ncth5xoVozXgnYtxfL1vBUs/AY7puRFwWsxH9h6zvAlq0FvE=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nECcs-0007rl-KE; Sun, 30 Jan 2022 17:00:29 +0100 From: Lars Ingebrigtsen To: "J.P." Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> <83a6fdbulb.fsf@gnu.org> <878rux9ql2.fsf@neverwas.me> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXn6NJYRzsTEBSc bFr///+Q5a+sAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YBHg8pAiB74tkAAAF1SURBVDjLbZPZgYUw CEXjpAGBBh6xgRD6722ArL4ZflROWALXlIYhFjcmTW8r2/g+/Lmwh3BHB7kK4A45In4KuAe/AwYY Vs/a3EE8AtRR+yhxglYganS8gNpnAOQT5PhwMNMFUC3R0AC42rXELAOs+kw1EcACdDArzDMVEu5r JgDAWcMAHUBPcM+YxAwwACsh6TVAwQ4sTJWF80xlZ/v8AEStRFvApsAxJmiKN862UszNuwcqFXUu d4BIpZZ/z35HUDYAcgCIYfPTnuvRdoLeL7FeH97ArwEmQxCidt8HsLIPSrEpq/jLugdyY78F4bOO B4Chm7uRFN0gSvR95pqub2Do48KQNwC/yKeGvt7Al0EuyL8AwDWT8R9QtUvyG2i2kPo3lVRJWetq lydQpeQ7n/66UtGTVYbabdSaQGQFIZr4ArEm0hmDY2Xh190ukExg/hdQGBrx9w2QbJGxAt82HRH+ I/S/zpLSu8bQqtsBHsGRx0/9ArM5c6JvYejJAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTAxLTMw VDE1OjQxOjAyKzAwOjAw7hAvXgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wMS0zMFQxNTo0MTow MiswMDowMJ9Nl+IAAAAASUVORK5CYII= X-Now-Playing: Ida's _Ten Small Paces_: "Shoe-In" Date: Sun, 30 Jan 2022 17:00:25 +0100 In-Reply-To: <878rux9ql2.fsf@neverwas.me> (J. P.'s message of "Sun, 30 Jan 2022 07:43:37 -0800") Message-ID: <87bkztb4di.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "J.P." writes: > Apologies for the unintelligible mumblage. Somehow (believe it or not), > I was trying to ask whether there's a system in place for keeping track > of the number of non-trivial changes a non-paperwo [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53617 Cc: strings.stringsandstrings@gmail.com, Eli Zaretskii , emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "J.P." writes: > Apologies for the unintelligible mumblage. Somehow (believe it or not), > I was trying to ask whether there's a system in place for keeping track > of the number of non-trivial changes a non-paperwork holder has made so > far. By "system" I guess I mean a person in charge of recording such > information or perhaps a table somewhere to consult. But if it's less > formal than all that, I suppose I'll just rely on the git history and > whatever an author self-reports. Thanks. No, we don't have such a system, unfortunately. It's somewhat subjective what counts -- we try to count "lines of code", so whitespace changes don't count, of course, and other trivial transforms don't count either. So as you say -- you just have to look at the commit history and make a judgement call in these cases. (Or even better, ask for a copyright assignment form and then you don't have to count. =F0=9F=98=80) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 30 11:25:25 2022 Received: (at 53617) by debbugs.gnu.org; 30 Jan 2022 16:25:25 +0000 Received: from localhost ([127.0.0.1]:37464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nED13-0002nR-DT for submit@debbugs.gnu.org; Sun, 30 Jan 2022 11:25:25 -0500 Received: from mail-lj1-f182.google.com ([209.85.208.182]:40462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nED12-0002nE-3w for 53617@debbugs.gnu.org; Sun, 30 Jan 2022 11:25:24 -0500 Received: by mail-lj1-f182.google.com with SMTP id q22so16166220ljh.7 for <53617@debbugs.gnu.org>; Sun, 30 Jan 2022 08:25:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7wQR/SQhylOvaKZcpkmQXpt2ZebiYfWla0vBNFC7mdU=; b=PstEgUhhTEzIuY01LxqKutfQvia6Yht2V6igaVdl04A4gMNSMHaVEwIuMpvi8J3Ia9 msvuYMsJ/jbeDjrVydDJtu9bxr8FVKsv3bBH3WByOKL68J4d7HDSRGXbFmz489QoW2Km RfBad5/oTxgkeY6+wt/sXpQUaPwkOO9Um6EtRX+4KjF75u2jgqWrwN2q0yUrvhfxDpw1 qSVTPPyK2FTqqjWOyMHCFF4pBKC+1hHNNsVqo/hCe54wZABxenZE3xIPnCcTaKJbIefA za5E8DIwCSZaMcnL10ZsNsGnWfw5wjZ6IriDy7VsQ29DnAcc4E1qPX4GiXG/gVUwQAcv J8Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7wQR/SQhylOvaKZcpkmQXpt2ZebiYfWla0vBNFC7mdU=; b=OI2RUOs2LajCHXbh1flfpIcQmgeAQ16GiBWj4mwWjZli1nY1lTLpenSus/L3IfOhsw 18Fl8CWuG3lh05VqaWZx2UHciaKi+jzyBlFeIxHmG6O5sLp0b3FF3FQFfl3kO7gb9/jG bC72fOsL2Ww6OJ46vrGMvbB/aD9/4JHcHNQsnLaNRrWd6DYqeSS8bsmDaFkWPoDxRVi1 J94OH97hR8y4pjtzQIMc1dJAQfgAgPXG/9iwURIQH5OjeUXJesdEDNR4qCcrLHT7UoyP UabqSyQBsrl+hEs0MeT6xCqh9YWd9UlsnrK1Bve2t1AT9TmvjQ5s6+ImiakquHrepNsy 0Z9g== X-Gm-Message-State: AOAM532cAL+pqO22zQp/Zwem7U7ZJhzjSLcpXyz3tFipHnuRcxn+hBzT 2BhalI4zutX/xj3WEIRrTc2Z1DxyD4XciVZ+ewU= X-Google-Smtp-Source: ABdhPJw2QZE3Yn7steoCsVWD9AKg+Jt+s9GV3BuWJ+RX2rYjt81AlLe3O8X4jszYN8ColNRKVNTW3JHeQf0/jzWyKqw= X-Received: by 2002:a2e:94c5:: with SMTP id r5mr5734951ljh.17.1643559917220; Sun, 30 Jan 2022 08:25:17 -0800 (PST) MIME-Version: 1.0 References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> <83a6fdbulb.fsf@gnu.org> <878rux9ql2.fsf@neverwas.me> <87bkztb4di.fsf@gnus.org> In-Reply-To: <87bkztb4di.fsf@gnus.org> From: Guy Gastineau Date: Sun, 30 Jan 2022 11:25:05 -0500 Message-ID: Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="0000000000000876c505d6cf1d99" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53617 Cc: Eli Zaretskii , emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org, "J.P." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000876c505d6cf1d99 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yeah, I have no problem with the copyright assignment. I will look in the docs to see what I need to give you all for it. On Sun, Jan 30, 2022 at 11:00 AM Lars Ingebrigtsen wrote: > "J.P." writes: > > > Apologies for the unintelligible mumblage. Somehow (believe it or not), > > I was trying to ask whether there's a system in place for keeping track > > of the number of non-trivial changes a non-paperwork holder has made so > > far. By "system" I guess I mean a person in charge of recording such > > information or perhaps a table somewhere to consult. But if it's less > > formal than all that, I suppose I'll just rely on the git history and > > whatever an author self-reports. Thanks. > > No, we don't have such a system, unfortunately. It's somewhat > subjective what counts -- we try to count "lines of code", so whitespace > changes don't count, of course, and other trivial transforms don't count > either. > > So as you say -- you just have to look at the commit history and make a > judgement call in these cases. (Or even better, ask for a copyright > assignment form and then you don't have to count. =F0=9F=98=80) > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --0000000000000876c505d6cf1d99 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yeah, I have no problem with the copyright assignment.=C2= =A0 I will look in the docs to see what I need to give you all for it.
<= /div>
O= n Sun, Jan 30, 2022 at 11:00 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
"J.P." <jp@neverwas.me> writes:

> Apologies for the unintelligible mumblage. Somehow (believe it or not)= ,
> I was trying to ask whether there's a system in place for keeping = track
> of the number of non-trivial changes a non-paperwork holder has made s= o
> far. By "system" I guess I mean a person in charge of record= ing such
> information or perhaps a table somewhere to consult. But if it's l= ess
> formal than all that, I suppose I'll just rely on the git history = and
> whatever an author self-reports. Thanks.

No, we don't have such a system, unfortunately.=C2=A0 It's somewhat=
subjective what counts -- we try to count "lines of code", so whi= tespace
changes don't count, of course, and other trivial transforms don't = count
either.

So as you say -- you just have to look at the commit history and make a
judgement call in these cases.=C2=A0 (Or even better, ask for a copyright assignment form and then you don't have to count. =F0=9F=98=80)

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no
--0000000000000876c505d6cf1d99-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 30 22:22:24 2022 Received: (at 53617) by debbugs.gnu.org; 31 Jan 2022 03:22:24 +0000 Received: from localhost ([127.0.0.1]:38102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nENGq-0006nZ-Fl for submit@debbugs.gnu.org; Sun, 30 Jan 2022 22:22:24 -0500 Received: from mail-ej1-f42.google.com ([209.85.218.42]:45722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nENGo-0006nJ-Mf for 53617@debbugs.gnu.org; Sun, 30 Jan 2022 22:22:23 -0500 Received: by mail-ej1-f42.google.com with SMTP id me13so38448690ejb.12 for <53617@debbugs.gnu.org>; Sun, 30 Jan 2022 19:22:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FgNzkWXK1mJA9+hfq9uAevMYt83xXOGrO55M9LMZlpo=; b=rR6ZdP+05zZ4DYMCQbX1OCzqkY9n31uyGl4uMdO9eYWIEZPwxSRzvzsNQ9d4k23yvr VfMKtiw6fJwW9+0dN/HplhmNyfjZKSntwINmUPK5ir5S2tp2ZyXh36pY2UYk7XBHX+UP SQP3Jc00CRGuq+7Ggal124lQGPu9yiWhWTXdYJ95rl5fVa7e8fJD59TdSK/za3yp1Vj7 ZaB1GGfd/JXxWZpWzW7BhbPqP6LiVdLmnXDiQZtFiUH7W+gETFQUEnMjSifACN4q7U+T qXtQ5H56ilkimvkaC3fA1XG0HsdsKkeVWYkmM2JbkQsu28rNvfcmEbfR8bZSnGQ/2bN8 ErOg== X-Gm-Message-State: AOAM532qPIbxGJlDyZ/KMfwzReve3j1v+DcGuy24zuOHIutn9saynVxJ enAe5WDN5AV8O1f1da9ECpYTYzLyagRg4yaBtvIsAw== X-Google-Smtp-Source: ABdhPJy0OH7vLNSwgbraTNP0AYg596rUH7VEklctePm9g0qMnXFJTPmHtJZsY+OwosRJfShEzpqS12tLuNgUQN085yg= X-Received: by 2002:a17:907:7289:: with SMTP id dt9mr16290052ejc.62.1643599336942; Sun, 30 Jan 2022 19:22:16 -0800 (PST) MIME-Version: 1.0 References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> <83a6fdbulb.fsf@gnu.org> <878rux9ql2.fsf@neverwas.me> <87bkztb4di.fsf@gnus.org> In-Reply-To: <87bkztb4di.fsf@gnus.org> From: Michael Olson Date: Sun, 30 Jan 2022 22:22:05 -0500 Message-ID: Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="000000000000a1c10d05d6d84ada" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 53617 Cc: emacs-erc@gnu.org, bandali@gnu.org, "J.P." , 53617@debbugs.gnu.org, strings.stringsandstrings@gmail.com, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000a1c10d05d6d84ada Content-Type: text/plain; charset="UTF-8" On Sun, Jan 30, 2022 at 11:00 AM Lars Ingebrigtsen wrote: > "J.P." writes: > > > Apologies for the unintelligible mumblage. Somehow (believe it or not), > > I was trying to ask whether there's a system in place for keeping track > > of the number of non-trivial changes a non-paperwork holder has made so > > far. By "system" I guess I mean a person in charge of recording such > > information or perhaps a table somewhere to consult. But if it's less > > formal than all that, I suppose I'll just rely on the git history and > > whatever an author self-reports. Thanks. > > No, we don't have such a system, unfortunately. It's somewhat > subjective what counts -- we try to count "lines of code", so whitespace > changes don't count, of course, and other trivial transforms don't count > either. What I'd sometimes do 10+ years ago is keep an AUTHORS file with a list of who contributed, which files, and (in the case of unassigned contributors) how many lines so I knew if they were getting close to the limit. I'm not sure if that would map well to the Emacs repo, maybe a side file like ERC-AUTHORS, or just kept outside of the repo. --000000000000a1c10d05d6d84ada Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Jan 30, 2022 at 11:00 AM Lars Ing= ebrigtsen <larsi@gnus.org> wrot= e:
"J.P." <jp@neverwas.me> writes:

> Apologies for the unintelligible mumblage. Somehow (believe it or not)= ,
> I was trying to ask whether there's a system in place for keeping = track
> of the number of non-trivial changes a non-paperwork holder has made s= o
> far. By "system" I guess I mean a person in charge of record= ing such
> information or perhaps a table somewhere to consult. But if it's l= ess
> formal than all that, I suppose I'll just rely on the git history = and
> whatever an author self-reports. Thanks.

No, we don't have such a system, unfortunately.=C2=A0 It's somewhat=
subjective what counts -- we try to count "lines of code", so whi= tespace
changes don't count, of course, and other trivial transforms don't = count
either.

What I'd sometimes do 10+ years= ago is keep an AUTHORS file with a list of who contributed, which files, a= nd (in the case of unassigned contributors) how many lines so I knew if the= y were getting close to the limit. I'm not sure if that would map well = to the Emacs repo, maybe a side file like ERC-AUTHORS, or just kept outside= of the repo.
--000000000000a1c10d05d6d84ada-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 30 22:40:11 2022 Received: (at submit) by debbugs.gnu.org; 31 Jan 2022 03:40:11 +0000 Received: from localhost ([127.0.0.1]:38107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nENY3-0007Fh-5l for submit@debbugs.gnu.org; Sun, 30 Jan 2022 22:40:11 -0500 Received: from lists.gnu.org ([209.51.188.17]:53906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nENXz-0007FU-J5 for submit@debbugs.gnu.org; Sun, 30 Jan 2022 22:40:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nENXy-0002pF-Vt for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 22:40:07 -0500 Received: from ciao.gmane.io ([116.202.254.214]:50294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nENXx-0000fb-BY for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 22:40:06 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nENXu-0005Fo-Hm for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 04:40:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org To: bug-gnu-emacs@gnu.org From: Emanuel Berg Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer Followup-To: gmane.emacs.erc.general,gmane.emacs.bugs Date: Mon, 31 Jan 2022 04:38:00 +0100 Message-ID: <87mtjca82v.fsf@zoho.eu> References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> <83a6fdbulb.fsf@gnu.org> <878rux9ql2.fsf@neverwas.me> <87bkztb4di.fsf@gnus.org> <87r18oa8fd.fsf@zoho.eu> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cancel-Lock: sha1:MBJhkw7JY0k7u4V8iYq5RLsN6PQ= Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit Cc: emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) >>> No, we don't have such a system, unfortunately. >>> It's somewhat subjective what counts -- we try to count >>> "lines of code", so whitespace changes don't count, of >>> course, and other trivial transforms don't count either. >> >> What I'd sometimes do 10+ years ago is keep an AUTHORS file >> with a list of who contributed, which files, and (in the >> case of unassigned contributors) how many lines so I knew if >> they were getting close to the limit. I'm not sure if that >> would map well to the Emacs repo, maybe a side file like >> ERC-AUTHORS, or just kept outside of the repo. > > I've seen a git command do something similar for the Emacs > source ... posted on gmane.emacs.help not so long ago. Didn't find it, but I think it was this: $ git shortlog -s --all | sort -n -r | head -n 10 20708 Richard M. Stallman 12586 Glenn Morris 11454 Eli Zaretskii 9153 Stefan Monnier 6786 Kenichi Handa 6601 Paul Eggert 6056 Chong Yidong 5019 Gerd Moellmann 4703 Juanma Barranquero 4049 Lars Ingebrigtsen -- underground experts united https://dataswamp.org/~incal From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 30 22:50:22 2022 Received: (at submit) by debbugs.gnu.org; 31 Jan 2022 03:50:22 +0000 Received: from localhost ([127.0.0.1]:38112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nENhu-0007Y4-7K for submit@debbugs.gnu.org; Sun, 30 Jan 2022 22:50:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:57242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nENhs-0007Xx-Rk for submit@debbugs.gnu.org; Sun, 30 Jan 2022 22:50:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nENhq-0005gn-At for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 22:50:18 -0500 Received: from ciao.gmane.io ([116.202.254.214]:55124) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nENho-0001sr-IR for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 22:50:18 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nENha-0006IW-FP for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 04:50:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org To: bug-gnu-emacs@gnu.org From: Emanuel Berg Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer Followup-To: gmane.emacs.bugs,gmane.emacs.erc.general Date: Mon, 31 Jan 2022 04:30:30 +0100 Message-ID: <87r18oa8fd.fsf@zoho.eu> References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> <83a6fdbulb.fsf@gnu.org> <878rux9ql2.fsf@neverwas.me> <87bkztb4di.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cancel-Lock: sha1:ayeGVTvpvtBu0TSu4OaR6Z2QGow= Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit Cc: emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Michael Olson wrote: >>> Apologies for the unintelligible mumblage. >>> Somehow (believe it or not), I was trying to ask whether >>> there's a system in place for keeping track of the number >>> of non-trivial changes a non-paperwork holder has made so >>> far. By "system" I guess I mean a person in charge of >>> recording such information or perhaps a table somewhere to >>> consult. But if it's less formal than all that, I suppose >>> I'll just rely on the git history and whatever an author >>> self-reports. Thanks. >> >> No, we don't have such a system, unfortunately. >> It's somewhat subjective what counts -- we try to count >> "lines of code", so whitespace changes don't count, of >> course, and other trivial transforms don't count either. > > What I'd sometimes do 10+ years ago is keep an AUTHORS file > with a list of who contributed, which files, and (in the > case of unassigned contributors) how many lines so I knew if > they were getting close to the limit. I'm not sure if that > would map well to the Emacs repo, maybe a side file like > ERC-AUTHORS, or just kept outside of the repo. I've seen a git command do something similar for the Emacs source ... posted on gmane.emacs.help not so long ago. -- underground experts united https://dataswamp.org/~incal From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 31 00:35:23 2022 Received: (at 53617) by debbugs.gnu.org; 31 Jan 2022 05:35:24 +0000 Received: from localhost ([127.0.0.1]:38158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEPLX-0004F4-Kz for submit@debbugs.gnu.org; Mon, 31 Jan 2022 00:35:23 -0500 Received: from mail-108-mta162.mxroute.com ([136.175.108.162]:35851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEPLT-0004Eo-E1 for 53617@debbugs.gnu.org; Mon, 31 Jan 2022 00:35:22 -0500 Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta162.mxroute.com (ZoneMTA) with ESMTPSA id 17eaea144e60005a20.001 for <53617@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 31 Jan 2022 05:35:11 +0000 X-Zone-Loop: c7c2b23815026cb4e740980649c49b582076267a3495 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qqhpATyfgK7Mwp1aX70sb2+d/3PaQCCnVYvdEkhuLvM=; b=SsR/7XNUYnAYjxXj70W36UwOhG LrWn0wFA2YoAVPPidre/2729z2pN7p87wM7YHNmr8js5FqzOa18GRzxB/wlkme8gLupbF2s8YSfo5 e+tRkjW07vzYlqEWj0lx5GhO/++P77YD4FnbFqA/NbK1TkOyEXc72nQ+JH+Ndu2uO/H0yRnyXedTl h7DpMxUi1Vqwie7DqMLnDBww9+FKeVymD1r8u5rRIghC7WOKXEZdtINmpox06MLUI6J6O9cLHcNql EwRLopnjYWlVfDWGm8OELCkPcic2uQGbhxFja6hxZA7/JaiM2Ev93F4RreYsEFp0wcSLzWxn6kgGH BJHRiACA==; From: "J.P." To: Michael Olson Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> <83a6fdbulb.fsf@gnu.org> <878rux9ql2.fsf@neverwas.me> <87bkztb4di.fsf@gnus.org> Date: Sun, 30 Jan 2022 21:35:08 -0800 In-Reply-To: (Michael Olson's message of "Sun, 30 Jan 2022 22:22:05 -0500") Message-ID: <87wnigpiwj.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53617 Cc: emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org, strings.stringsandstrings@gmail.com, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Olson writes: > What I'd sometimes do 10+ years ago is keep an AUTHORS file with a > list of who contributed, which files, and (in the case of unassigned > contributors) how many lines so I knew if they were getting close to > the limit. I'm not sure if that would map well to the Emacs repo, > maybe a side file like ERC-AUTHORS, or just kept outside of the repo. Hi Michael (such an honor to hear from a true ERC OG!), In the case of an unassigned contributor (a term I'm stealing BTW because it's vastly superior to my unpronounceable "non-paperwork holder"), I guess we'd still have to keep tabs on contributions across *all* of Emacs. But as a starting point for a more intensive inquiry, it's a fine solution. And I guess we'd likely just leave that sort of thing outside the repo, for now. Anyway, thanks so much for your insights and for all your work back in the day! (And also to Lars for the low down/lay of the land.) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 31 07:31:18 2022 Received: (at 53617) by debbugs.gnu.org; 31 Jan 2022 12:31:18 +0000 Received: from localhost ([127.0.0.1]:38514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEVq1-0000VK-Su for submit@debbugs.gnu.org; Mon, 31 Jan 2022 07:31:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEVq0-0000PT-K1 for 53617@debbugs.gnu.org; Mon, 31 Jan 2022 07:31:17 -0500 Received: from [2001:470:142:3::e] (port=43172 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEVpu-0001Yv-IC; Mon, 31 Jan 2022 07:31:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=77/2Rn13tite0fZL61ZvDspIvkZoA205osUMy582ino=; b=VxsPAOHUdnTl A84bBpFopQatw3thRreNqu56SjAIq1Z97RPB50I1Zpc5egguEk4DtXVOi1o9YG4QC6V5SyP/5lS4W exDqd6VtpjOPqD1TowbCKdfHan5CxkE+6t3N5jJXCez4/SzHygJ4/LEglJxUraF7Madyu/ecYDT/S ol/mANo6+l+BbckbySB4ZxOb5sgE9PExgqZBKOUHIebWiHIYprUoikbGaMMuPtqvCyZhT1KhrH70U BmAnSfM7rqxNa24JkXkA7QL02dOnDoC5uq8M8G4o3AdewoVw/a9IqfQMxlg5qrBSZo4uEm8Ydluh3 levO2BcEeOScQYTFKZx2FQ==; Received: from [87.69.77.57] (port=1898 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEVpt-0007l2-L2; Mon, 31 Jan 2022 07:31:10 -0500 Date: Mon, 31 Jan 2022 14:31:06 +0200 Message-Id: <83wnig84tx.fsf@gnu.org> From: Eli Zaretskii To: Michael Olson In-Reply-To: (message from Michael Olson on Sun, 30 Jan 2022 22:22:05 -0500) Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> <83a6fdbulb.fsf@gnu.org> <878rux9ql2.fsf@neverwas.me> <87bkztb4di.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53617 Cc: emacs-erc@gnu.org, bandali@gnu.org, jp@neverwas.me, 53617@debbugs.gnu.org, strings.stringsandstrings@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Olson > Date: Sun, 30 Jan 2022 22:22:05 -0500 > Cc: "J.P." , strings.stringsandstrings@gmail.com, > Eli Zaretskii , emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org > > What I'd sometimes do 10+ years ago is keep an AUTHORS file with a list of who contributed, which files, > and (in the case of unassigned contributors) how many lines so I knew if they were getting close to the limit. > I'm not sure if that would map well to the Emacs repo, maybe a side file like ERC-AUTHORS, or just kept > outside of the repo. This is very tedious, and moreover, ephemeral: the threshold of a dozen or so non-trivial lines is crossed only once and usually very quickly; once it is crossed, it can never be crossed back (well, except in the rare case that a person changes employers and is again without an assignment). So this kind of bookkeeping requires a lot of clerical work for little or no gain. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 14 09:34:04 2022 Received: (at 53617) by debbugs.gnu.org; 14 Mar 2022 13:34:04 +0000 Received: from localhost ([127.0.0.1]:44383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTkpo-00012L-GB for submit@debbugs.gnu.org; Mon, 14 Mar 2022 09:34:04 -0400 Received: from mail-108-mta218.mxroute.com ([136.175.108.218]:42641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTkpl-000113-Q6 for 53617@debbugs.gnu.org; Mon, 14 Mar 2022 09:34:02 -0400 Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta218.mxroute.com (ZoneMTA) with ESMTPSA id 17f88a295c2000763e.001 for <53617@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 14 Mar 2022 13:33:50 +0000 X-Zone-Loop: 8f90c8da09d0aec2c6cc5e47cca54413b57babfef79a X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UhjTrk+qBrk8RsIPf9Qx/BKrgLjpoRb/ltQpKSqQQuw=; b=btoSxsNyFEvZs8Rf1UsiVrgHJY TTkCBLkl0jUTtOdNZtZiZ93YDuGB3CLGJyxDGBWBayXjHtPqRCgvs2F5Xfd+M5YR87GFo14wJ1Yxd JFuDPfKHO+J45US7AGPaJu8eNFGC3q9KJGsG6sSx1LBWvdQD32rx9pfG48CRbo2MT4Q+EQYtylUPn lgApVF5WJOvwd4d6ZG7p6zJHXU2jCRhIkWa+DOJPLEzFdLksUrEO8NIQ0+Fbm5LRXWO6GBd2GD28f ZwxUkLUMibD7dzcI1cjsdPCaNqGguDjcWVNUCfzeIoIhiVXyM3Xt7k8auEgEpdeXtRhDJx3FL2J1t jKpxxNMg==; From: "J.P." To: Guy Gastineau Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> Date: Mon, 14 Mar 2022 06:33:48 -0700 In-Reply-To: <878ruyqf0b.fsf@neverwas.me> (J. P.'s message of "Sat, 29 Jan 2022 15:49:24 -0800") Message-ID: <874k40r743.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AuthUser: masked@neverwas.me X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53617 Cc: larsi@gnus.org, emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain "J.P." writes: > I've added the customary tweaks to the log message if someone wants to > glance at it (cc. bandali, Lars). This now includes a unit test. Unless anyone objects or I'm preempted, I'll add this to 29 on or around March 19th (~5 days from now), and leave ERC's version number unchanged at 5.4.1. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Remove-redundant-checks-in-erc-switch-to-buffer.patch >From 751e93d57ac00399dfb528b270fe753a3e8cfc91 Mon Sep 17 00:00:00 2001 From: Guy Gastineau Date: Fri, 28 Jan 2022 23:12:42 -0500 Subject: [PATCH 1/2] Remove redundant checks in erc--switch-to-buffer * lisp/erc/erc.el (erc--switch-to-buffer): Commit f925fc93bac41d7622d1af927e33b0e738ff55b0 "Add `predicate' arg to `read-buffer' and use it for erc-iswitchb" meant to remove this, but it was left behind. (Bug#53617). Copyright-paperwork-exempt: yes --- lisp/erc/erc.el | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 9ee8d38b02..52fe106f2d 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -1761,12 +1761,7 @@ erc--switch-to-buffer (lambda (bufname) (let ((buf (if (consp bufname) (cdr bufname) (get-buffer bufname)))) - (when buf - (erc--buffer-p buf (lambda () t) proc) - (with-current-buffer buf - (and (derived-mode-p 'erc-mode) - (or (null proc) - (eq proc erc-server-process)))))))))) + (and buf (erc--buffer-p buf (lambda () t) proc))))))) (defun erc-switch-to-buffer (&optional arg) "Prompt for an ERC buffer to switch to. When invoked with prefix argument, use all ERC buffers. Without -- 2.35.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-DROP-ME-Add-eventual-unit-test-for-erc-switch-to-buf.patch >From d0c6ef217a18c98e18e4c29e2cba2e9ab63af970 Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Sun, 13 Mar 2022 22:39:36 -0700 Subject: [PATCH 2/2] [DROP ME] Add eventual unit test for erc--switch-to-buffer * test/lisp/erc/erc-tests.el (erc--switch-to-buffer): Add regression test for Bug#53617. Prefer postponing addition until after #48598. --- test/lisp/erc/erc-tests.el | 73 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/test/lisp/erc/erc-tests.el b/test/lisp/erc/erc-tests.el index 5603e76454..a14c4c0460 100644 --- a/test/lisp/erc/erc-tests.el +++ b/test/lisp/erc/erc-tests.el @@ -114,6 +114,79 @@ erc-with-all-buffers-of-server (should (get-buffer "#spam")) (kill-buffer "#spam"))) +;; DELETE ME BEG (just a demo, for now) +(require 'ert-x) +(defvar erc-modified-channels-alist) + +(ert-deftest erc--switch-to-buffer () + (unless (version< "28" emacs-version) + (ert-skip "Depends on symbol `minibuffer-quit'")) + + (let ((proc (start-process "aNet" (current-buffer) "true")) + (erc-modified-channels-alist `(("fake") (,(messages-buffer)))) + ;; + erc-kill-channel-hook erc-kill-server-hook erc-kill-buffer-hook) + + (with-current-buffer (get-buffer-create "server") + (erc-mode) + (set-process-buffer (setq erc-server-process proc) (current-buffer)) + (with-current-buffer (get-buffer-create "#chan") + (erc-mode) + (setq erc-server-process proc)) + (with-current-buffer (get-buffer-create "#foo") + (erc-mode) + (setq erc-server-process proc)) + + (ert-info ("Channel #chan selectable from server buffer") + (ert-simulate-keys (list ?# ?c ?h ?a ?n ?\C-m) + (should (string= "#chan" (erc--switch-to-buffer)))))) + + (ert-info ("Channel #foo selectable from non-ERC buffer") + (ert-simulate-keys (list ?# ?f ?o ?o ?\C-m) + (should (string= "#foo" (erc--switch-to-buffer))))) + + (ert-info ("Default selectable") + (ert-simulate-keys (list ?\C-m) + (should (string= "*Messages*" (erc--switch-to-buffer))))) + + ;; Can't use `should-error' here because `minibuffer-quit' derives + ;; from `quit' instead of `error', and only the latter is trapped. + (ert-info ("Extant but non-ERC buffer not selectable") + (get-buffer-create "#fake") ; not ours + (let (ran) + (condition-case s + (ert-simulate-keys (list ?# ?f ?a ?k ?e ?\C-m) + (erc--switch-to-buffer)) + (minibuffer-quit (setq ran s))) + (should (equal ran '(minibuffer-quit))))) + + (with-current-buffer (get-buffer-create "other") + (erc-mode) + (setq erc-server-process + (start-process "bNet" (current-buffer) "true"))) + + (ert-info ("Foreign ERC buffer not selectable") + (let (ran) + (condition-case s + (ert-simulate-keys (list ?o ?t ?h ?e ?r ?\C-m) + (with-current-buffer "server" + (erc--switch-to-buffer))) + (minibuffer-quit (setq ran s))) + (should (equal ran '(minibuffer-quit))))) + + (ert-info ("Any ERC-buffer selectable from non-ERC buffer") + (should-not (eq major-mode 'erc-mode)) + (ert-simulate-keys (list ?o ?t ?h ?e ?r ?\C-m) + (should (string= "other" (erc--switch-to-buffer))))) + + (kill-buffer "server") + (kill-buffer "other") + (kill-buffer "#chan") + (kill-buffer "#foo") + (kill-buffer "#fake"))) + +;; DELETE ME END (just a demo, for now) + (ert-deftest erc-lurker-maybe-trim () (let (erc-lurker-trim-nicks (erc-lurker-ignore-chars "_`")) -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 19 06:09:06 2022 Received: (at 53617) by debbugs.gnu.org; 19 Mar 2022 10:09:06 +0000 Received: from localhost ([127.0.0.1]:59049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVW1C-0002uJ-3F for submit@debbugs.gnu.org; Sat, 19 Mar 2022 06:09:06 -0400 Received: from mail-108-mta6.mxroute.com ([136.175.108.6]:43259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVW1A-0002to-IB for 53617@debbugs.gnu.org; Sat, 19 Mar 2022 06:09:05 -0400 Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta6.mxroute.com (ZoneMTA) with ESMTPSA id 17fa1a6cda20004b83.001 for <53617@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 19 Mar 2022 10:08:57 +0000 X-Zone-Loop: a201e6b42d348605539afbb67fa0f9cf1a6c2f0f5759 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fjdFZ5L+eZenw7maiwnehk/HW1Q3JvFFg4uHaL+/Jkk=; b=KoLsAitYeFopYO+NkkrezEDOqn Y7PITmXxGD1/wNfGPx4/8FYadXHrn+5z9W521QGpuQS+iNbE3vlifQ/SKmDc4B/pnWX5RL3Q+64Ai f0cy+tGVqNes+bFKb8hKjP7Dd/tbFl5SoY3t6nt+3jGVIY/p0ItSV3zXi1o5UZI0gFw77i5S0Zv6w GLrN/WOkTUu0IIn1mr+lXlHRXczep/wYboEUm+S8q2K+CSMBAnbdqFGsYXKUkrhNp3Rv/cp6N/L7i erVhzinHa2hnQ28s5Pw4Qkpz9gT/vaHysqHHSz9v98qO+uRdZ93aFC4o1HWKp1UN8KD5Ocj+22BwH D7Q8BVxA==; From: "J.P." To: Guy Gastineau Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> <878ruyqf0b.fsf@neverwas.me> <874k40r743.fsf@neverwas.me> Date: Sat, 19 Mar 2022 03:08:54 -0700 In-Reply-To: <874k40r743.fsf@neverwas.me> (J. P.'s message of "Mon, 14 Mar 2022 06:33:48 -0700") Message-ID: <87o822tft5.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: masked@neverwas.me X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53617 Cc: larsi@gnus.org, emacs-erc@gnu.org, bandali@gnu.org, 53617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "J.P." writes: > This now includes a unit test. Sorry about the test failure, people. Fixed now (^_^;) [1]. > Unless anyone objects or I'm preempted, I'll add this to 29 on or > around March 19th Done. Thanks. Closing. P.S. Guy, when you get your paperwork sorted, don't forget about ERC! [1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2f1fbf20 https://emba.gnu.org/emacs/emacs/-/jobs/41710 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 19 06:09:51 2022 Received: (at control) by debbugs.gnu.org; 19 Mar 2022 10:09:51 +0000 Received: from localhost ([127.0.0.1]:59052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVW1v-0002vO-Cj for submit@debbugs.gnu.org; Sat, 19 Mar 2022 06:09:51 -0400 Received: from mail-108-mta80.mxroute.com ([136.175.108.80]:34747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVW1t-0002vB-UC for control@debbugs.gnu.org; Sat, 19 Mar 2022 06:09:50 -0400 Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta80.mxroute.com (ZoneMTA) with ESMTPSA id 17fa1a77add0004b83.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 19 Mar 2022 10:09:42 +0000 X-Zone-Loop: a01028ae496e3c2cc851c1824cf338330a3fb95da29d X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vIYE9IcqMX3CKknqqdyGGMb9Ze2zDaYBwJBWmKDuruk=; b=edH2SA3CrBCW4/KCTAp81TbgsE zl6HfgnX78ibNuTn5TgSJcIFzVCEHitcXWp7YEroDsrskpt9UXm1Js5XtpsB4mLh0FtlXKURdvkAW hG+l+r8Q6wJptucJOktj0u9fRz3UPdvYR/WtR7mDwnZlngYah7NocHOczVHETtuav6zAplaXdoD2m ueZ32nF1X8fzr7p2iB6ElGQDgKZqUYHJiCvSakbeKmLdQzN8kymLOXsGRvRPowrPLY7vxaJsIwZ6F J/lc0lD8SdfLU0uv/2SmyByvLqlGAVvet3E7AeuFs7XC0bYXLobzma41Zz9d2dx6JrpcG6Tyevv7A QtFWqRbA==; From: "J.P." To: control@debbugs.gnu.org Subject: control message for bug #53617 Date: Sat, 19 Mar 2022 03:09:39 -0700 Message-ID: <87lex6tfrw.fsf@neverwas.me> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: masked@neverwas.me X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 53617 29.1 quit From unknown Tue Jun 17 20:21:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 16 Apr 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator