GNU bug report logs - #53601
[PATCH 1/2] gnu: Add mimalloc.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: phodina <phodina <at> protonmail.com>
Subject: bug#53601: closed (Re: bug#60754: [PATCH 1/2] gnu: Add mold.)
Date: Sun, 12 Feb 2023 00:48:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#53601: [PATCH 1/2] gnu: Add mimalloc.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 53601 <at> debbugs.gnu.org.

-- 
53601: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53601
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 60754-done <at> debbugs.gnu.org, 53601-done <at> debbugs.gnu.org,
 53327-done <at> debbugs.gnu.org
Subject: Re: bug#60754: [PATCH 1/2] gnu: Add mold.
Date: Sun, 12 Feb 2023 01:47:18 +0100

[Message part 3 (text/plain, inline)]

Hi,

Zhu Zihao <all_but_last <at> 163.com> skribis:

> * gnu/local.mk (GNU_SYSTEM_MODULES): Add new file.
> * gnu/packages/mold.scm: New file.
> * gnu/packages/mold.scm (mold): New variable.

[...]

> * gnu/packages/mold.scm(make-mold-wrapper): New variable.
> (mold-wrapper): New variable.
> (mold-as-ld-wrapper): New variable.

Applied both with minor changes (see below), thanks.

I’m also closing the two other issues you mentioned that were adding
mold.  Please let us know if there’s something to borrow from them!

Ludo’.

[Message part 4 (text/x-patch, inline)]

diff --git a/gnu/packages/mold.scm b/gnu/packages/mold.scm
index 6514bd3b90..dfc452a329 100644
--- a/gnu/packages/mold.scm
+++ b/gnu/packages/mold.scm
@@ -77,12 +77,12 @@ (define-public mold
               (delete-file "test/elf/rpath.sh"))))))
     (inputs (list mimalloc openssl tbb xxhash zlib `(,zstd "lib")))
     (home-page "https://github.com/rui314/mold")
-    (synopsis "Faster drop-in replacement for Unix linkers")
+    (synopsis "Fast linker")
     (description
-     "Mold is a faster drop-in replacement for existing Unix linkers.
+     "Mold is a faster drop-in replacement for existing linkers.
 It is designed to increase developer productivity by reducing build time,
 especially in rapid debug-edit-rebuild cycles.")
-    (license license:agpl3+)))
+    (license license:agpl3)))
 
 (define* (make-mold-wrapper mold #:key mold-as-ld?)
   "Return a MOLD wrapper.  When MOLD-AS-LD? is true, create a 'ld' symlink that

[Message part 5 (message/rfc822, inline)]

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 1/2] gnu: Add mimalloc.
Date: Fri, 28 Jan 2022 10:50:17 +0000

[Message part 6 (text/plain, inline)]

Hi,

here is a patch set to add mold linker.

I've temporarily put the package definition into gnu/packages/raspberry-pi.scm as I'm unsure if it should go to gnu/packages/commencement.scm or somewhere else.

It would be be interesting to test it as a new default linker on such a large scale project.

Also there is currently one test failing so I've disabled the tests for now:

Testing mold-wrapper ... execl: No such file or directory
make[1]: *** [Makefile.linux:6: elf/mold-wrapper.sh] Error 1
make[1]: *** Waiting for unfinished jobs....

----
Petr

[Message part 7 (text/html, inline)]

[0001-gnu-Add-mimalloc.patch (text/x-patch, attachment)]

[0002-gnu-Add-mold.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.