From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 28 04:47:34 2022 Received: (at submit) by debbugs.gnu.org; 28 Jan 2022 09:47:34 +0000 Received: from localhost ([127.0.0.1]:57426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDNqv-0002Lq-Q8 for submit@debbugs.gnu.org; Fri, 28 Jan 2022 04:47:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:49090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDNqu-0002Le-U6 for submit@debbugs.gnu.org; Fri, 28 Jan 2022 04:47:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDNqu-0007y7-D2 for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 04:47:32 -0500 Received: from server.a16n.net ([178.33.238.77]:34432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDNqs-0001pB-Dp for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 04:47:32 -0500 Received: from ws.localdomain (arennes-651-1-218-252.w90-32.abo.wanadoo.fr [90.32.93.252]) by server.a16n.net (Postfix) with ESMTPSA id 8E50F43E0507 for ; Fri, 28 Jan 2022 10:47:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n; t=1643363241; bh=VkEilWcbE7N113AigAAVZlJ9YvYYXb9PlGtmHny3kHI=; h=From:To:Subject:Date; b=hCIpaiAUsaZp3X4iIPofkFFvxQKhiXpz8Dgrj6tdkwIhSvxBTbGVuKcpAOpb5ClUk DC8YMOanSGBguw/yx5KwIdziBltjQ8xKRwOUzFQj7rbmy2ijLdeRPIB3OSSNrV6IaN P6Aa/p8hGHydc5C3qzm5dPWXHcpw9Id9fzLG9giX5mJFPljt9+xY6DGi5/Tw9W5tK2 GUVHwou/x1+m+KRvzIIN1fapkEo1P8Yj+8tCycopO+H7MM84C7vkdwlbqJxNEcg1ep r2hou69xnPs+8WJP+DWZpo92C0GiseNAZ5jOI+nJVo2Or/FbpmOMymPwy6QAboFByu wAZSO34pKtt4Q== Received: by ws.localdomain (Postfix, from userid 1000) id 2709E20596; Fri, 28 Jan 2022 10:47:20 +0100 (CET) From: =?utf-8?Q?Peter_M=C3=BCnster?= To: Emacs Bugs Subject: 29.0.50; image-dired-mouse-toggle-mark very slow Date: Fri, 28 Jan 2022 10:47:19 +0100 Message-ID: <87r18sfazc.fsf@a16n.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Received-SPF: pass client-ip=178.33.238.77; envelope-from=pm@a16n.net; helo=server.a16n.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, When using a buffer with about 5000 images, image-dired-mouse-toggle-mark takes about 1-2 seconds for one image. This is not a big problem. But when using this function on a region with about 200 images, then you need to wait several minutes for completion. That's because image-dired-thumb-update-marks is called in the macro image-dired--on-file-in-dired-buffer and therefore unnecessarily for each image in the region. What could be a good way to avoid the repeated calls to image-dired-thumb-update-marks please? TIA for any help, =2D-=20 Peter --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iGoEARECACoWIQS/5hHRBUjla4uZVXU6jitvQ7HLaAUCYfO7pwwccG1AYTE2bi5u ZXQACgkQOo4rb0Oxy2gn5gCfYWeKZhkJUl/8oOW1IN5e49bf4MYAnAnZrghFUXH8 ctLMfJz5KlN2mNf4 =zNPS -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 31 04:02:16 2022 Received: (at 53599) by debbugs.gnu.org; 31 Jan 2022 09:02:16 +0000 Received: from localhost ([127.0.0.1]:38324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nESZk-0001nj-Gq for submit@debbugs.gnu.org; Mon, 31 Jan 2022 04:02:16 -0500 Received: from server.a16n.net ([178.33.238.77]:46516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nESZe-0001nN-Oz for 53599@debbugs.gnu.org; Mon, 31 Jan 2022 04:02:15 -0500 Received: from ws.localdomain (arennes-657-1-259-127.w2-14.abo.wanadoo.fr [2.14.213.127]) by server.a16n.net (Postfix) with ESMTPSA id C85C643E054D for <53599@debbugs.gnu.org>; Mon, 31 Jan 2022 10:02:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n; t=1643619723; bh=R5cuRCYzJXJTZVC1Y0ux5b28aTES6SqG5TdpFjrvHDU=; h=From:To:Subject:References:Date:In-Reply-To; b=g0BkfDeV75Tozjogt8BxiVegbIjgDyX0SuadT+DeIDkzACXXWa6W1dZa02LmtdO6S h6A1BrTEgypV7P2UdAf13aK/lWCEnZu+3DY4SlPQ4PRtIzZCkO2bJbuyc92/Nw1vGV Cwv8qqwXx6v8LqxVnExCn2Rz/AtVEfyeSWjo/ZFTYPQbPq70Di91whyfcm5TI4N06I ilB5bYAMKsKCFZFx0zoM4M02r0HAu511DkvrKcQXe8c58NGeDa/LojS8pIJlEiXw+n VwQotxbd7cnaWTMyG0VMgkPEflGghOdmgJZytckwuYgMgtplkWMP0X/fOhYl5En73Z KQCBNIBLZQvuQ== Received: by ws.localdomain (Postfix, from userid 1000) id 4334B20599; Mon, 31 Jan 2022 10:02:03 +0100 (CET) From: =?utf-8?Q?Peter_M=C3=BCnster?= To: 53599@debbugs.gnu.org Subject: Re: bug#53599: 29.0.50; image-dired-mouse-toggle-mark very slow References: <87r18sfazc.fsf@a16n.net> Date: Mon, 31 Jan 2022 10:02:03 +0100 In-Reply-To: <87r18sfazc.fsf@a16n.net> ("Peter =?utf-8?Q?M=C3=BCnster=22's?= message of "Fri, 28 Jan 2022 10:47:19 +0100") Message-ID: <87mtjc5ldg.fsf@a16n.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53599 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Jan 28 2022, Peter M=C3=BCnster wrote: > What could be a good way to avoid the repeated calls to > image-dired-thumb-update-marks please? This works, but I don't know if it's not too hackish: diff --git a/lisp/image-dired.el b/lisp/image-dired.el index 9b0bbb70df..e5ccc17154 100644 =2D-- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -2392,17 +2390,20 @@ image-dired-mouse-toggle-mark Track this in associated Dired buffer if `image-dired-track-movement' is non-nil." (interactive "e") =2D (if (use-region-p) =2D (let ((end (region-end))) =2D (save-excursion =2D (goto-char (region-beginning)) =2D (while (<=3D (point) end) =2D (when (image-dired-image-at-point-p) =2D (image-dired-mouse-toggle-mark-1)) =2D (forward-char)))) =2D (mouse-set-point event) =2D (goto-char (posn-point (event-end event))) =2D (image-dired-mouse-toggle-mark-1)) + (let ((idtum-orig (symbol-function 'image-dired-thumb-update-marks))) + (defun image-dired-thumb-update-marks ()) + (if (use-region-p) + (let ((end (region-end))) + (save-excursion + (goto-char (region-beginning)) + (while (<=3D (point) end) + (when (image-dired-image-at-point-p) + (image-dired-mouse-toggle-mark-1)) + (forward-char)))) + (mouse-set-point event) + (goto-char (posn-point (event-end event))) + (image-dired-mouse-toggle-mark-1)) + (fset 'image-dired-thumb-update-marks idtum-orig)) (image-dired-thumb-update-marks)) =20 (defun image-dired-dired-display-properties () What do you think? =2D-=20 Peter --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iGoEARECACoWIQS/5hHRBUjla4uZVXU6jitvQ7HLaAUCYfeliwwccG1AYTE2bi5u ZXQACgkQOo4rb0Oxy2ijAwCgsr/XDto7SFxbHyySYjf+7+DRnmEAoIgwfxe4+sR8 LyNaQBi+nNIKdFG0 =yCqA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 13:57:52 2022 Received: (at 53599) by debbugs.gnu.org; 15 Sep 2022 17:57:52 +0000 Received: from localhost ([127.0.0.1]:59130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYt7X-0000kk-Az for submit@debbugs.gnu.org; Thu, 15 Sep 2022 13:57:52 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:51370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYt7J-0000kM-Ct for 53599@debbugs.gnu.org; Thu, 15 Sep 2022 13:57:49 -0400 Received: from server.a16n.net (unknown [82.65.98.121]) by smtp2-g21.free.fr (Postfix) with ESMTPS id D14112003CC for <53599@debbugs.gnu.org>; Thu, 15 Sep 2022 19:57:35 +0200 (CEST) Received: from ws.localdomain (unknown [192.168.13.254]) by server.a16n.net (Postfix) with ESMTPSA id 559BA8004AE for <53599@debbugs.gnu.org>; Thu, 15 Sep 2022 19:57:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n; t=1663264655; bh=gg5UqZLrH2iaBKaLCiO2WOIrdYYZeSeDTG27AXr0nGA=; h=From:To:Subject:In-Reply-To:References:Date; b=BKOljAzFEB8o8YHlhM4Ro4N+QTujRQqWkKWs3U3FDx3nHMl886gfQHK6NUbakQv51 9n34yfBiv5kzEA8gsKc6GbKjPMgyLcIs+YjPA9b9xbfKjGhpthUmdAXaJZDkJrXteF Qrd+Llxuapfy5VUh5+yD4+YGc9Rpeu0XSJ050no9IGTuhS0pZalKgIpHUnFNKvFDyC XNodBOOPLR5I6rHLypzYmbtTcMdMRjoHTTiEeHyNazWM4SfiH94oCo6xftVyyhgkmM O+EUsooLYRNPvQZ7+u3C3eSqCBP1bmhQe3ovbP2eIETwLkSCJdT16WZXHmIxhE5hVi FDXFQGGoHcYiw== Received: by ws.localdomain (Postfix, from userid 1000) id 2E1C220624; Thu, 15 Sep 2022 19:57:35 +0200 (CEST) From: =?utf-8?Q?Peter_M=C3=BCnster?= To: 53599@debbugs.gnu.org Subject: Re: bug#53599: 29.0.50; image-dired-mouse-toggle-mark very slow In-Reply-To: <87mtjc5ldg.fsf@a16n.net> ("Peter =?utf-8?Q?M=C3=BCnster=22's?= message of "Mon, 31 Jan 2022 10:02:03 +0100") References: <87r18sfazc.fsf@a16n.net> <87mtjc5ldg.fsf@a16n.net> Date: Thu, 15 Sep 2022 19:57:34 +0200 Message-ID: <87illoikq9.fsf@a16n.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53599 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Jan 31 2022, Peter M=C3=BCnster wrote: > This works, but I don't know if it's not too hackish: And here for the latest master: diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 75dcdd8cbc..0218cd4038 100644 =2D-- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -1269,15 +1269,18 @@ image-dired-mouse-toggle-mark Track this in associated Dired buffer if `image-dired-track-movement' is non-nil." (interactive "e") =2D (if (use-region-p) =2D (let ((end (region-end))) =2D (save-excursion =2D (goto-char (region-beginning)) =2D (while (<=3D (point) end) =2D (when (image-dired-image-at-point-p) =2D (image-dired-mouse-toggle-mark-1)) =2D (forward-char)))) =2D (mouse-set-point event) =2D (goto-char (posn-point (event-end event))) =2D (image-dired-mouse-toggle-mark-1)) + (let ((idtum-orig (symbol-function 'image-dired-thumb-update-marks))) + (defun image-dired-thumb-update-marks ()) + (if (use-region-p) + (let ((end (region-end))) + (save-excursion + (goto-char (region-beginning)) + (while (<=3D (point) end) + (when (image-dired-image-at-point-p) + (image-dired-mouse-toggle-mark-1)) + (forward-char)))) + (mouse-set-point event) + (goto-char (posn-point (event-end event))) + (image-dired-mouse-toggle-mark-1)) + (fset 'image-dired-thumb-update-marks idtum-orig)) (image-dired-thumb-update-marks)) What do you think? =2D-=20 Peter --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iGoEARECACoWIQS/5hHRBUjla4uZVXU6jitvQ7HLaAUCYyNnjgwccG1AYTE2bi5u ZXQACgkQOo4rb0Oxy2jiuwCfQmgNXHxPh4NNU4mSebqOIBUQ2J0Anik9YbqXJ6Gb ugrbUd0f68Qfs5D8 =FgXO -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 16:39:39 2022 Received: (at 53599) by debbugs.gnu.org; 15 Sep 2022 20:39:39 +0000 Received: from localhost ([127.0.0.1]:59345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYve6-0004w4-Vm for submit@debbugs.gnu.org; Thu, 15 Sep 2022 16:39:39 -0400 Received: from mail-oi1-f171.google.com ([209.85.167.171]:46039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYve4-0004vi-Ei for 53599@debbugs.gnu.org; Thu, 15 Sep 2022 16:39:36 -0400 Received: by mail-oi1-f171.google.com with SMTP id o204so3704420oia.12 for <53599@debbugs.gnu.org>; Thu, 15 Sep 2022 13:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date; bh=VBmLS+X8tqgSd02RVKd2LIdvFmCJv4Q273MT4j3TwMs=; b=GG+28pdunlHIZ6Y+TkECme54nla0xMHjdbgmvKVyG4IgmgZprTWSh48m3kE8Epv9SZ MafI+Arm/gaDJM2T//Y4NUr5XUlJlqUq4x0kcYeCPEu4PnAGiQ5KTfp0xQtFDo6TnsrZ /1ltaE6ju5dWVck5HE62Wq3eZGRUjD5vRPcHPGzfEgumHtP4pHiZO72N87xLr+VEGtbE 7hjR4HqSEdhciNFmgQQtF52ozHMqBDdGxLHmXCIvSjVD6xlrIN+70yCycbuH6n0++g7C DXiB2Zh+Vq+wdaX4Zwv8MuQ/N4W0CfjQSU9ktkoKtzJ+FJIpQjj659vmvh2Z5rFaHlyZ UqYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date; bh=VBmLS+X8tqgSd02RVKd2LIdvFmCJv4Q273MT4j3TwMs=; b=BZeeDfz1XWWco4PA6aERmCnTbOIE02g5ZcovC5IbLkJCByjBcwdLwwuyCW2t6mJVVt xe9EzGlLIxn23MAzY+REhM+BUKeHU7SCLOnxFZ3M/EPK2QFfxgP0qhJzFhTEmlaa99mz +1zO1fQiaCqH9ZMeK6Q45MNqrhBWax4zzOdzt5JRKALr1IcbxLBIZxeFFnC5gOiIAUeW C54aCPdXmw0gaVcDsRHbk3P8XoLp3qwzkz76GOfeYm0tmFCvfPtqurBIn2HJJ6Fz3xEF TrqRzOtklyfUK4UiiyejBcNtetMiMz3J+sfxp34pfTkoo1g+JVBN6skY/PhNOzz4YuoS QfOQ== X-Gm-Message-State: ACgBeo2xTM6UCewuFv/qv9FRVoNT9EeZbgcMRSb6sxPN6fhLfpM53nLt StkMMltpM/S46Rp6uZ69jc898U62ub8Cvw43UK9QH/Ub X-Google-Smtp-Source: AA6agR699qpI4+zAJEOz+89X+jHVdjLyCkCqVbv/eGFikcoEvI2xoRhVlRthQHhG8t4v64ysYeFZpDDNLZZUG6SofdU= X-Received: by 2002:a05:6808:1688:b0:345:ea9a:2954 with SMTP id bb8-20020a056808168800b00345ea9a2954mr5119606oib.199.1663274370530; Thu, 15 Sep 2022 13:39:30 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 15 Sep 2022 13:39:30 -0700 From: Stefan Kangas In-Reply-To: <87illoikq9.fsf@a16n.net> References: <87r18sfazc.fsf@a16n.net> <87mtjc5ldg.fsf@a16n.net> <87illoikq9.fsf@a16n.net> X-Hashcash: 1:20:220915:pm@a16n.net::/o8tvI81N4i2hys4:6AqL MIME-Version: 1.0 Date: Thu, 15 Sep 2022 13:39:30 -0700 Message-ID: Subject: Re: bug#53599: 29.0.50; image-dired-mouse-toggle-mark very slow To: =?UTF-8?Q?Peter_M=C3=BCnster?= , 53599@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53599 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 53599 + pending thanks Peter M=C3=BCnster writes: > And here for the latest master: Thanks for the updated patch, as well as the very good bug report that indicated clearly not just how to reproduce it but also the root cause. However, I think we should avoid mocking out that function, so I attempted to solve this in a more clean way on master. Could you please rebuild latest master, and verify that the bug is fixed for you too? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 01:09:22 2022 Received: (at 53599) by debbugs.gnu.org; 16 Sep 2022 05:09:22 +0000 Received: from localhost ([127.0.0.1]:41181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ3bN-00082S-D1 for submit@debbugs.gnu.org; Fri, 16 Sep 2022 01:09:21 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:10198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ3bH-00082F-QT for 53599@debbugs.gnu.org; Fri, 16 Sep 2022 01:09:19 -0400 Received: from server.a16n.net (unknown [82.65.98.121]) by smtp2-g21.free.fr (Postfix) with ESMTPS id 782612003CE; Fri, 16 Sep 2022 07:09:13 +0200 (CEST) Received: from ws.localdomain (unknown [192.168.13.254]) by server.a16n.net (Postfix) with ESMTPSA id F1A44800538; Fri, 16 Sep 2022 07:09:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n; t=1663304952; bh=GzAZzSXSzOT6MgIGNz+179TiuJUEulEAKXxKHNj629U=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=NV/a8OSpCQXb8timhso4KwU9JaTdnj77OA9i5+ZQYAKbQMFtugQh0B+/UclblYfn3 hVIPTephN/uDdVvobao6aiBejnSBjx1OPoS7QKtgYnvZzxAozoig+NS1267k5wV4WC JgymOjGSf5vyiCrNqXgg6yT/5+40ujlmz3PYFZuIGpQaEVZhRGKf3fMSwEpZaCvTgt z5o9a6raaIji0kQmZM4X8XlCJnY/GxFI1/cWqTRVTMb39eiHtkZEDkQthn+ciJ2wIH YPJWyXjhZ+7DsjtQTCGEJVTf6f54B+Rh3XNV1OVG43uZhEWRTL6abzaUKV+kqEhe83 5uTCXlCYKC1WA== Received: by ws.localdomain (Postfix, from userid 1000) id C0AFC20627; Fri, 16 Sep 2022 07:09:12 +0200 (CEST) From: =?utf-8?Q?Peter_M=C3=BCnster?= To: Stefan Kangas Subject: Re: bug#53599: 29.0.50; image-dired-mouse-toggle-mark very slow In-Reply-To: (Stefan Kangas's message of "Thu, 15 Sep 2022 13:39:30 -0700") References: <87r18sfazc.fsf@a16n.net> <87mtjc5ldg.fsf@a16n.net> <87illoikq9.fsf@a16n.net> Date: Fri, 16 Sep 2022 07:09:12 +0200 Message-ID: <875yhnc3d3.fsf@a16n.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53599 Cc: 53599@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, Sep 15 2022, Stefan Kangas wrote: > However, I think we should avoid mocking out that function, so I > attempted to solve this in a more clean way on master. Could you please > rebuild latest master, and verify that the bug is fixed for you too? Yes, it works well. Thanks! =2D-=20 Peter --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iGoEARECACoWIQS/5hHRBUjla4uZVXU6jitvQ7HLaAUCYyQE+AwccG1AYTE2bi5u ZXQACgkQOo4rb0Oxy2hrsgCfTWFMuI7sNxx1WlvcLluViomHAvIAoKtyHbNydlHr 2IS2T93v57TETB4A =TEFR -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 05:54:26 2022 Received: (at 53599) by debbugs.gnu.org; 16 Sep 2022 09:54:26 +0000 Received: from localhost ([127.0.0.1]:41707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ83G-0000zO-EB for submit@debbugs.gnu.org; Fri, 16 Sep 2022 05:54:26 -0400 Received: from mail-oi1-f173.google.com ([209.85.167.173]:42597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ83E-0000z6-SO for 53599@debbugs.gnu.org; Fri, 16 Sep 2022 05:54:25 -0400 Received: by mail-oi1-f173.google.com with SMTP id p187so5536138oia.9 for <53599@debbugs.gnu.org>; Fri, 16 Sep 2022 02:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date; bh=cF8DnvCn2P35SkVH9KnBwJjdVFFs41ruhDkftuPWxV0=; b=YgpcRUOEHcfdfJo0sA1dL5xo0esl1BxMcnLVn3tPW5eIz2usikBF7IthhgN4nqT2rB qSnyGwDLveIgVMTVo+amGR7IpR+XBYfh5ovMo0p5RDeLmOdy6dEvNVG2haWUPpCV/7s+ jYdWDpaMDjIxIJPgDF9yrOW3fq2ooaQv4b674QQVwtLL8BzWAj/AEKMcT6/h5q/CsQC6 VvX9vb7Bjit4aH98E9WZsYGJ808M+AR2Ss/1NDWfn+zZP4F+6/FYcw2+ZQir4gyQI9DV uxSaPT/xxWZMdyD3sF+fz7+RoZ3/7/ZlfDCwC9qyRIRtERkVzNG8HQ1EdrUeUNwKV0+Z wSgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date; bh=cF8DnvCn2P35SkVH9KnBwJjdVFFs41ruhDkftuPWxV0=; b=xnCZVH6ukCFaYq52c6QpnrVxWxMOaHBXeOmSEzuyj4po1VXxqP23UZkIpnDFz/kWqb XD4zUnQ2rko3siXyHz5H1sfO2xs7YI/Gj2YB9oAEQB18MVyrCmZFrMN2LAfJszMdAVE2 jf2/1+yYLJA7c/1fwR/nFcr4M0udiW5cCw9Rs0U/nxU2QqqyafM3QPiMUSuBkWe5OpCb sC346eJJWg32xSEN0PZG0ZOflGsDJTh7tCyeLtX6Xqf/yb+1OYrKeuzj2v7TV9klV+H7 J2nyNPE3v5xXcIacYtgsx3eO1MvAzbBqlHVBvDjciUcyOEVGANQd1IGQCpoaVV1TTRHw KFLw== X-Gm-Message-State: ACgBeo0z6XSDQT0AzEAsyublmNTdd113qQr2D5+bJhR/tf2YNZImwcqG 3rVUwl4pCY4AdLtSuEoacZPM/NTDbry5ZPiXId4Dr9Ar X-Google-Smtp-Source: AA6agR43BKNNafk4k8lx0IXqQl5DYalSdJT+TO2TjhNRVIv8LeixjGfJ/96BrD1Mpq1UKfkeZJJ1Xdrdmx9AP1PkF7Q= X-Received: by 2002:a05:6808:1688:b0:345:ea9a:2954 with SMTP id bb8-20020a056808168800b00345ea9a2954mr6262377oib.199.1663322059161; Fri, 16 Sep 2022 02:54:19 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 16 Sep 2022 02:54:18 -0700 From: Stefan Kangas In-Reply-To: <875yhnc3d3.fsf@a16n.net> References: <87r18sfazc.fsf@a16n.net> <87mtjc5ldg.fsf@a16n.net> <87illoikq9.fsf@a16n.net> <875yhnc3d3.fsf@a16n.net> X-Hashcash: 1:20:220916:53599@debbugs.gnu.org::9J8BxULEnTQ59kqz:8p5H MIME-Version: 1.0 Date: Fri, 16 Sep 2022 02:54:18 -0700 Message-ID: Subject: Re: bug#53599: 29.0.50; image-dired-mouse-toggle-mark very slow To: =?UTF-8?Q?Peter_M=C3=BCnster?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53599 Cc: 53599@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 53599 29.1 thanks Peter M=C3=BCnster writes: > Yes, it works well. Thanks! Thanks for testing! I'm therefore closing this bug report. From unknown Sun Aug 17 22:09:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 Oct 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator