GNU bug report logs - #53584
guix: Use 'gexp->derivation' instead of 'build-expression->derivation'.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53584 in the body.
You can then email your comments to 53584 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: guix: Use 'gexp->derivation' instead of
 'build-expression->derivation'.
Date: Thu, 27 Jan 2022 14:38:13 +0000

[Message part 1 (text/plain, inline)]

Hi,

I've noticed in the output of bootstraping the guix package some warnings about deprecated expression.

----
Petr

[Message part 2 (text/html, inline)]

[0001-guix-Use-gexp-derivation-instead-of-build-expression.patch (text/x-patch, attachment)]

Message #8 received at 53584 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: 53584 <at> debbugs.gnu.org
Subject: Re: bug#53584: guix: Use 'gexp->derivation' instead of
 'build-expression->derivation'.
Date: Sat, 29 Jan 2022 23:58:25 +0100

Hi,

phodina <phodina <at> protonmail.com> skribis:

> From e128b9d35060187b04ebd36cabd152f0e968dc87 Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Thu, 27 Jan 2022 15:32:35 +0100
> Subject: [PATCH] guix: Use 'gexp->derivation' instead of
>  'build-expression->derivation'.
>
> * guix/derivations.scm: Update deprecated expression.
> * guix/grafts.scm: Same as above.
>
> diff --git a/guix/derivations.scm b/guix/derivations.scm
> index f77ea179f4..615bb161d1 100644
> --- a/guix/derivations.scm
> +++ b/guix/derivations.scm
> @@ -1218,7 +1218,7 @@ (define builder
>                                      #:opts %auto-compilation-options)))))
>                  files)))
>  
> -    (build-expression->derivation store name builder
> +    (gexp->derivation store name builder
>                                    #:inputs `(("modules" ,module-dir))
>                                    #:system system
>                                    #:guile-for-build guile
> diff --git a/guix/grafts.scm b/guix/grafts.scm
> index 0ffda8f9aa..e0a97e895b 100644
> --- a/guix/grafts.scm
> +++ b/guix/grafts.scm
> @@ -134,7 +134,7 @@ (define properties
>      ((($ <graft> sources source-outputs targets target-outputs) ...)
>       (let ((sources (zip sources source-outputs))
>             (targets (zip targets target-outputs)))
> -       (build-expression->derivation store name build
> +       (gexp->derivation store name build
>                                       #:system system
>                                       #:guile-for-build guile
>                                       #:modules '((guix build graft)

It’s unfortunately not that simple: the above code doesn’t work, notably
because ‘gexp->derivation’ is a monadic procedure, unlike
‘build-expression->derivation’.

Also, the first hunk is unnecessary since it’s in an internal procedure
that’s used by ‘build-expression->derivation’ itself.

I’m closing it for now but this is something we should address
eventually!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.