From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 11 14:41:52 2010 Received: (at submit) by debbugs.gnu.org; 11 Jan 2010 19:41:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUQ99-0003P3-Ot for submit@debbugs.gnu.org; Mon, 11 Jan 2010 14:41:52 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUQ98-0003Oy-5z for submit@debbugs.gnu.org; Mon, 11 Jan 2010 14:41:50 -0500 Received: from mx10.gnu.org ([199.232.76.166]:41037) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUQ93-0002vv-TG for submit@debbugs.gnu.org; Mon, 11 Jan 2010 14:41:46 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NUQ91-0000ok-II for submit@debbugs.gnu.org; Mon, 11 Jan 2010 14:41:45 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO,UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:53098) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NUQ91-0000oU-AJ for submit@debbugs.gnu.org; Mon, 11 Jan 2010 14:41:43 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUQ90-0000yZ-UU for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 14:41:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUQ8x-0000wj-1c for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 14:41:42 -0500 Received: from [199.232.76.173] (port=50253 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUQ8w-0000wd-MJ for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 14:41:38 -0500 Received: from boost-consulting.com ([64.156.193.20]:54090) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUQ8w-0000lt-1M for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 14:41:38 -0500 Received: from zreba.local (207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com [207.172.223.249]) (Authenticated sender: dave) by boost-consulting.com (Postfix) with ESMTPSA id 0B19C1CC24; Mon, 11 Jan 2010 11:42:41 -0800 (PST) Received: from zreba.local (localhost [127.0.0.1]) by zreba.local (Postfix) with ESMTP id 424DD18D6FF3; Mon, 11 Jan 2010 14:41:35 -0500 (EST) Date: Mon, 11 Jan 2010 14:41:34 -0500 Message-ID: From: David Abrahams To: bug-gnu-emacs@gnu.org Subject: 23.1; Adding comment loses customizations in progress User-Agent: Wanderlust/2.15.7 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (i386-apple-darwin9.8.0) MULE/6.0 (HANACHIRUSATO) Organization: BoostPro Computing MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by monty-python.gnu.org: FreeBSD 6.x (1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Using the customization interface, I can make a change to a variable, then try to add a comment before saving. When I do that, the changes I've already made are lost. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /Applications/Emacs.app/Contents/Resources/etc/DEBUG for instructions. In GNU Emacs 23.1.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54) of 2009-08-16 on black.local Windowing system distributor `Apple', version 10.3.1038 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Custom Minor modes in effect: diff-auto-refine-mode: t shell-dirtrack-mode: t show-paren-mode: t server-mode: t global-auto-revert-mode: t delete-selection-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-n C-n C-p C-p C-. C-. C-. C-b C-b C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-e 0 C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-a C-p C-. C-. C-, 7 C-n C-n C-n C-e M-< C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-e C-p C-e 0 C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-x C-s C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-q C-j I SPC r e a l l y SPC d o n ' t SPC w a n t SPC t o SPC s e t e e SPC H T M L S-SPC u n l e s s SPC i t h a t ' s SPC a l l SPC t h e r e SPC i s . C-c C-c C-x C-s C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p M-x r e p o r b Recent messages: Mark set [2 times] Saving file /Users/dave/src/elisp.repo/elisp/custom.el... Wrote /Users/dave/src/elisp.repo/elisp/custom.el Compiling /Users/dave/src/elisp.repo/elisp/custom.el...done Wrote /Users/dave/src/elisp.repo/elisp/custom.elc Saving file /Users/dave/src/elisp.repo/elisp/custom.el... Wrote /Users/dave/src/elisp.repo/elisp/custom.el Compiling /Users/dave/src/elisp.repo/elisp/custom.el...done Wrote /Users/dave/src/elisp.repo/elisp/custom.elc Making completion list... -- Dave Abrahams Meet me at BoostCon: http://www.boostcon.com BoostPro Computing http://www.boostpro.com From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 16 22:48:43 2016 Received: (at 5358) by debbugs.gnu.org; 17 Feb 2016 03:48:44 +0000 Received: from localhost ([127.0.0.1]:38742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVt6Z-0004V1-Kt for submit@debbugs.gnu.org; Tue, 16 Feb 2016 22:48:43 -0500 Received: from mail-qg0-f42.google.com ([209.85.192.42]:34058) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVt6Y-0004Up-MV for 5358@debbugs.gnu.org; Tue, 16 Feb 2016 22:48:43 -0500 Received: by mail-qg0-f42.google.com with SMTP id b67so3414253qgb.1 for <5358@debbugs.gnu.org>; Tue, 16 Feb 2016 19:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=JadvfsPnAh/Q9iGEIB6gr7uMuG0HuPDypcv689vkmnk=; b=zRkSu6xrlzsepES8XsEpcFomc3bwtlgYWPhDs+765l7l7vC3JgtUSMoRK3HmpCeJMO 3yRNh9Q5HZ8SUgVuXUeG8bEFKiElsf2qABK3KJp4Zn85kHosux0iFOrDLAeJTXY7gDgm 0Uf8mp9DvtsIGKh+EmyWL8+oOtexnqfSdexQ5IAfmsZd3bgPXJvogMv7Uy56uimif7ju kDpaXgCPF7Px4Em5smo5Ur3rFozVHUSxE3vQxY3OXfhKdPfe5XEFZ3bhSt/BlZ6RxZEH i8SYGaTe7aPpjGaJpgAF5/QbLspE13n44DZNvFMue5yH0O2ltbPrTiBk5rY2QLG2vOSP AZ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=JadvfsPnAh/Q9iGEIB6gr7uMuG0HuPDypcv689vkmnk=; b=BcWL4x1X01xW2IbdSz1o8sOIz8dCTf6am1FiFTrVVrDWbfqdFtiebofxEkKHu57yPa vh7czFkpm85g7eu6wbACwPBhPTOMG+2zSUiEoaixk8FHB5s6Qm03rRRKvgU+Dv94Xymx /KqbYgI1Vjgs+3TCIu4MRRIr9raphHcnQoUB5BpIBGh8GV1DUXT8OQfik6SQ4TN5Z8wI HZwXW8HWFegX4/mCdlep3WNFINyfP8hSncwxZxYFeXT7zqhBvTE+XDzUvL/9c1jMfcqV /w7GlvWljUUAQ2tCUZa2Wb6q37k8ujaWMmla2yX8pKZPcx1TyH7bb/RQzQVT3bL8yPK6 6+0A== X-Gm-Message-State: AG10YOQl8ZV9+wbdGnPYsJ/4Q82/Vj4f9sl+mbUQXzwNJOyFNLxiBkSmMSuotkGoaEikpg== X-Received: by 10.140.100.141 with SMTP id s13mr31194371qge.25.1455680917415; Tue, 16 Feb 2016 19:48:37 -0800 (PST) Received: from Andrews-MacBook-Pro.local.ahyatt-laptop (cpe-74-73-128-199.nyc.res.rr.com. [74.73.128.199]) by smtp.gmail.com with ESMTPSA id y127sm14668751qky.4.2016.02.16.19.48.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Feb 2016 19:48:35 -0800 (PST) From: Andrew Hyatt To: David Abrahams Subject: Re: bug#5358: 23.1; Adding comment loses customizations in progress References: Date: Tue, 16 Feb 2016 22:48:33 -0500 In-Reply-To: (David Abrahams's message of "Mon, 11 Jan 2010 14:41:34 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 5358 Cc: 5358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Sorry, I don't understand this bug report. What do you mean by adding comments? David Abrahams writes: > Please write in English if possible, because the Emacs maintainers > usually do not have translators to read other languages for them. > > Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, > and to the gnu.emacs.bug news group. > > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: > > Using the customization interface, I can make a change to a variable, > then try to add a comment before saving. When I do that, the changes > I've already made are lost. > > If Emacs crashed, and you have the Emacs process in the gdb debugger, > please include the output from the following gdb commands: > `bt full' and `xbacktrace'. > If you would like to further debug the crash, please read the file > /Applications/Emacs.app/Contents/Resources/etc/DEBUG for instructions. > > > In GNU Emacs 23.1.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54) > of 2009-08-16 on black.local > Windowing system distributor `Apple', version 10.3.1038 > configured using `configure '--with-ns'' > > Important settings: > value of $LC_ALL: nil > value of $LC_COLLATE: nil > value of $LC_CTYPE: nil > value of $LC_MESSAGES: nil > value of $LC_MONETARY: nil > value of $LC_NUMERIC: nil > value of $LC_TIME: nil > value of $LANG: nil > value of $XMODIFIERS: nil > locale-coding-system: nil > default-enable-multibyte-characters: t > > Major mode: Custom > > Minor modes in effect: > diff-auto-refine-mode: t > shell-dirtrack-mode: t > show-paren-mode: t > server-mode: t > global-auto-revert-mode: t > delete-selection-mode: t > tooltip-mode: t > mouse-wheel-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > global-auto-composition-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > line-number-mode: t > transient-mark-mode: t > > Recent input: > C-n C-n C-p C-p C-. C-. C-. C-b C-b C-n C-n > C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n > C-e 0 C-n C-n C-n C-n C-n C-n C-n C-n C-n > C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n > C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p > C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p > C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p > C-p C-p C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-n > C-n C-n C-n C-n C-n C-n C-n C-n C-p C-n C-n C-n C-n > C-n C-n C-n C-n C-n C-n C-n C-a C-p C-. C-. C-, > 7 C-n C-n C-n C-e M-< C-n C-n C-n C-n C-n C-n C-n C-n > C-n C-n C-n C-n C-n C-n C-n C-n C-e C-p C-e > 0 C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p > C-p C-p C-p C-p C-p C-p C-p C-x C-s C-n C-n C-n C-n > C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n > C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p > C-q C-j I SPC r e a l l y SPC d o n ' t > SPC w a n t SPC t o SPC s e t e > e SPC H T M L S-SPC u n l e s s SPC i t > h a t ' s SPC a l l SPC t h e r e SPC i s . > C-c C-c C-x C-s C-p C-p C-p C-p C-p C-p C-p C-p C-p > C-p C-p M-x r e p o r b > > Recent messages: > Mark set [2 times] > Saving file /Users/dave/src/elisp.repo/elisp/custom.el... > Wrote /Users/dave/src/elisp.repo/elisp/custom.el > Compiling /Users/dave/src/elisp.repo/elisp/custom.el...done > Wrote /Users/dave/src/elisp.repo/elisp/custom.elc > Saving file /Users/dave/src/elisp.repo/elisp/custom.el... > Wrote /Users/dave/src/elisp.repo/elisp/custom.el > Compiling /Users/dave/src/elisp.repo/elisp/custom.el...done > Wrote /Users/dave/src/elisp.repo/elisp/custom.elc > Making completion list... From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 18 10:30:06 2016 Received: (at 5358) by debbugs.gnu.org; 18 Feb 2016 15:30:06 +0000 Received: from localhost ([127.0.0.1]:33102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWQWr-0004Cr-Gg for submit@debbugs.gnu.org; Thu, 18 Feb 2016 10:30:06 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36199) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWQWp-0004Bi-LY for 5358@debbugs.gnu.org; Thu, 18 Feb 2016 10:30:04 -0500 Received: by mail-pa0-f54.google.com with SMTP id yy13so32571243pab.3 for <5358@debbugs.gnu.org>; Thu, 18 Feb 2016 07:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boostpro-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=gyhPPhqpxivO0hWM8sBVH2iZxhSvbiLsXwHH0WXnTxQ=; b=0h3mn3QuMCqLAyLZ5QdcGIa0AvSTBwwGSBABeYTXPkq4Np32WAI1fN3wFLjOwl2nmd ibFLtyTBCbxaCDO8f/YQtTqSQKQB5g2tOhcmVsfhcrHvQODywTjCNuV7ViiUVw6DFDxI Jv0w0MSFKsRNTGUjAaDmIO8YPs4xafByT9kweDdw2U+8jePWUMM5yeeX9h0vp8BStUhO MrpRs3m3gU0/oJe+/GU7GW7g5liCnn66HQPCVPUu/Tir91f7V88NBpSoPuURqq22p+5P D8AU0STo3s+ve6sPU05CoANojgqg1Q2yYv+xIe95BLTc9NQBiCQgKRhRhtfabRrJEqzH CC5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=gyhPPhqpxivO0hWM8sBVH2iZxhSvbiLsXwHH0WXnTxQ=; b=G8OKKZ8MerzrelpwCZfA7dibWQDHsKokYkpx+DJEcKXinHIilcdnTbAFUVDuS/aNV5 m3HvLZOyE+teu4MzWQMR7Ol6MK12i1ThXVnWD+YqcpUC0V5qSt4iaHJJzstscJrLgXDq KcP6hU56jGQ/nfCCDFMWUK9xdQnvVi8+czxzuWHQCkiUj3nZK1SjMPjLOvwIPV5gyK7n 09jkyk5d0XnU4sZhajeWOSa7U2Ac6KVjAnaKFjkO/qOA+ioBDGNQ8GNihmamr2jA+0bR nv2j21Bq+rz2/QulQFlj6xqGMLUOy0XK0mKVbD5PgHlJ0crElwqP9oyAQmqCl6M/xg9H 4p8A== X-Gm-Message-State: AG10YOT84S1nxrgJBWqdlFzRj0BhJhnwq3mDZsfdXFt6tej0dQVd07IUg/WK10dG4JyaqQ== X-Received: by 10.66.145.105 with SMTP id st9mr10906077pab.32.1455809397955; Thu, 18 Feb 2016 07:29:57 -0800 (PST) Received: from eno.apple.com ([17.212.145.127]) by smtp.gmail.com with ESMTPSA id u84sm11124530pfa.57.2016.02.18.07.29.56 (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 18 Feb 2016 07:29:56 -0800 (PST) Received: by eno.apple.com (Postfix, from userid 501) id 5027096642B1; Thu, 18 Feb 2016 07:29:56 -0800 (PST) From: Dave Abrahams To: Andrew Hyatt Subject: Re: bug#5358: 23.1; Adding comment loses customizations in progress References: Date: Thu, 18 Feb 2016 07:29:56 -0800 In-Reply-To: (Andrew Hyatt's message of "Tue, 16 Feb 2016 22:48:33 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 5358 Cc: 5358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) There's an choice in the customization UI on emacsen < 24.5 that lets you add a comment to any customization, but now I don't see it. Apparently that feature was dropped :( on Tue Feb 16 2016, Andrew Hyatt wrote: > Sorry, I don't understand this bug report. What do you mean by adding > comments? > > David Abrahams writes: > >> Please write in English if possible, because the Emacs maintainers >> usually do not have translators to read other languages for them. >> >> Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, >> and to the gnu.emacs.bug news group. >> >> Please describe exactly what actions triggered the bug >> and the precise symptoms of the bug: >> >> Using the customization interface, I can make a change to a variable, >> then try to add a comment before saving. When I do that, the changes >> I've already made are lost. >> >> If Emacs crashed, and you have the Emacs process in the gdb debugger, >> please include the output from the following gdb commands: >> `bt full' and `xbacktrace'. >> If you would like to further debug the crash, please read the file >> /Applications/Emacs.app/Contents/Resources/etc/DEBUG for instructions. >> >> >> In GNU Emacs 23.1.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54) >> of 2009-08-16 on black.local >> Windowing system distributor `Apple', version 10.3.1038 >> configured using `configure '--with-ns'' >> >> Important settings: >> value of $LC_ALL: nil >> value of $LC_COLLATE: nil >> value of $LC_CTYPE: nil >> value of $LC_MESSAGES: nil >> value of $LC_MONETARY: nil >> value of $LC_NUMERIC: nil >> value of $LC_TIME: nil >> value of $LANG: nil >> value of $XMODIFIERS: nil >> locale-coding-system: nil >> default-enable-multibyte-characters: t >> >> Major mode: Custom >> >> Minor modes in effect: >> diff-auto-refine-mode: t >> shell-dirtrack-mode: t >> show-paren-mode: t >> server-mode: t >> global-auto-revert-mode: t >> delete-selection-mode: t >> tooltip-mode: t >> mouse-wheel-mode: t >> menu-bar-mode: t >> file-name-shadow-mode: t >> global-font-lock-mode: t >> font-lock-mode: t >> global-auto-composition-mode: t >> auto-composition-mode: t >> auto-encryption-mode: t >> auto-compression-mode: t >> line-number-mode: t >> transient-mark-mode: t >> >> Recent input: >> C-n C-n C-p C-p C-. C-. C-. C-b C-b C-n C-n >> C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n >> C-e 0 C-n C-n C-n C-n C-n C-n C-n C-n C-n >> C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n >> C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p >> C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p >> C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p >> C-p C-p C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-n >> C-n C-n C-n C-n C-n C-n C-n C-n C-p C-n C-n C-n C-n >> C-n C-n C-n C-n C-n C-n C-n C-a C-p C-. C-. C-, >> 7 C-n C-n C-n C-e M-< C-n C-n C-n C-n C-n C-n C-n C-n >> C-n C-n C-n C-n C-n C-n C-n C-n C-e C-p C-e >> 0 C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p >> C-p C-p C-p C-p C-p C-p C-p C-x C-s C-n C-n C-n C-n >> C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n >> C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p >> C-q C-j I SPC r e a l l y SPC d o n ' t >> SPC w a n t SPC t o SPC s e t e >> e SPC H T M L S-SPC u n l e s s SPC i t >> h a t ' s SPC a l l SPC t h e r e SPC i s . >> C-c C-c C-x C-s C-p C-p C-p C-p C-p C-p C-p C-p C-p >> C-p C-p M-x r e p o r b >> >> Recent messages: >> Mark set [2 times] >> Saving file /Users/dave/src/elisp.repo/elisp/custom.el... >> Wrote /Users/dave/src/elisp.repo/elisp/custom.el >> Compiling /Users/dave/src/elisp.repo/elisp/custom.el...done >> Wrote /Users/dave/src/elisp.repo/elisp/custom.elc >> Saving file /Users/dave/src/elisp.repo/elisp/custom.el... >> Wrote /Users/dave/src/elisp.repo/elisp/custom.el >> Compiling /Users/dave/src/elisp.repo/elisp/custom.el...done >> Wrote /Users/dave/src/elisp.repo/elisp/custom.elc >> Making completion list... -- -Dave From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 18 11:48:15 2016 Received: (at 5358) by debbugs.gnu.org; 18 Feb 2016 16:48:15 +0000 Received: from localhost ([127.0.0.1]:33130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWRkV-00066f-Me for submit@debbugs.gnu.org; Thu, 18 Feb 2016 11:48:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38796) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWRkU-00066S-GI for 5358@debbugs.gnu.org; Thu, 18 Feb 2016 11:48:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWRkO-0005EF-4Z for 5358@debbugs.gnu.org; Thu, 18 Feb 2016 11:48:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWRkH-0005DV-IZ; Thu, 18 Feb 2016 11:48:01 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aWRkF-00005T-3a; Thu, 18 Feb 2016 11:47:59 -0500 From: Glenn Morris To: Dave Abrahams Subject: Re: bug#5358: 23.1; Adding comment loses customizations in progress References: X-Spook: SBI STARLAN morse Nationalist Drug Administration gamma S X-Ran: ^e~d''R20#<7 (Dave Abrahams's message of "Thu, 18 Feb 2016 07:29:56 -0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 5358 Cc: Andrew Hyatt , 5358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) ? M-x customize-variable RET fill-column RET Click "State", see "Add Comment". (Current master.) From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 11:18:22 2016 Received: (at 5358) by debbugs.gnu.org; 19 Feb 2016 16:18:22 +0000 Received: from localhost ([127.0.0.1]:34203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWnl8-00049m-8V for submit@debbugs.gnu.org; Fri, 19 Feb 2016 11:18:22 -0500 Received: from mail-qg0-f46.google.com ([209.85.192.46]:36671) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWnl6-00049Y-4X for 5358@debbugs.gnu.org; Fri, 19 Feb 2016 11:18:20 -0500 Received: by mail-qg0-f46.google.com with SMTP id y9so65815870qgd.3 for <5358@debbugs.gnu.org>; Fri, 19 Feb 2016 08:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=t++xewuscy6oCMi+Oh6R+VC+wAKGDdg6hFzgL8nMkUY=; b=AblYe0pLxI4k+gszAIOq8NkXK9m9qIxAo44M7wDu2g3dmg8xcXCmqamJdu5kMKdEcD lPoN7IulUT+zsucmS2QPLMjl3IlK/DDvSAbIUQaU8fCe58ix2NxpQnsrEAlOHnT5ZRgN 8CQqXryYX5IP5jbso8egh1oyvk59zaVj74DUpXyWbV/+9T0hMUYQ4/yzrASsKJYuF+2B SGbJsBe3+pF2+yWvgNGf2j6YSaHJd48jDuUIuTCeYRrzUDlxAtjP46/xS2KtpVbS0OL9 hhp+cWw4mmR7q+/TBjfImyJnnvXJnD6MmP+Jwl+2KGqoCDRRhUAAXYvP9jpK0pmwR5Jt xlwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=t++xewuscy6oCMi+Oh6R+VC+wAKGDdg6hFzgL8nMkUY=; b=b/IPcKiEenS2ReimxTlQrembbDUMjvTTMgZ91iNW3aNSKVVurWk4r1X/k8iC2eE0KR N5qhryh6u+X5u70YG/udiMRu+Kq32aWWgkEXse420m2Py472bHwpFBW41o+efbylmfUA OG2nSxDAqmMl7YiWaiQsRDzUmaHQ/pS6/tdBfuYR4xorBaANG6ipuh4SBNp0ey272qYP Os79Uzyr7c6KbeuKJnzPuiY2DhQ1d3WY1aE7fuR/H9iPtd+MheutiQjJ4Wgw901jHD3R H/ggN1pjOnwI/ykD0H4AdSpO9opJVBaempLxExMbEn3ezvJnIg0lF5yhD8qcfjmIs46h P+Zw== X-Gm-Message-State: AG10YOReZz0puNp6T+JukyLXW25B+x6e4WPyUuizUDg01FlMRY3udX6UnfUM9oWhhd2OGw== X-Received: by 10.140.160.130 with SMTP id g124mr17683833qhg.88.1455898694750; Fri, 19 Feb 2016 08:18:14 -0800 (PST) Received: from Andrews-MacBook-Pro.local.ahyatt-laptop (cpe-74-73-128-199.nyc.res.rr.com. [74.73.128.199]) by smtp.gmail.com with ESMTPSA id n203sm4915010qhc.43.2016.02.19.08.18.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Feb 2016 08:18:12 -0800 (PST) From: Andrew Hyatt To: Glenn Morris Subject: Re: bug#5358: 23.1; Adding comment loses customizations in progress References: Date: Fri, 19 Feb 2016 11:18:11 -0500 In-Reply-To: (Glenn Morris's message of "Thu, 18 Feb 2016 11:47:58 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 5358 Cc: Dave Abrahams , 5358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Thanks, now I see it. Now that I see it, I was able to reproduce this bug on Emacs 25. Glenn Morris writes: > ? > > M-x customize-variable RET fill-column RET > Click "State", see "Add Comment". > > (Current master.) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 21:13:22 2016 Received: (at control) by debbugs.gnu.org; 8 Jul 2016 01:13:22 +0000 Received: from localhost ([127.0.0.1]:41649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLKM6-0002uu-2F for submit@debbugs.gnu.org; Thu, 07 Jul 2016 21:13:22 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:34989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLKM5-0002uh-0j for control@debbugs.gnu.org; Thu, 07 Jul 2016 21:13:21 -0400 Received: by mail-it0-f53.google.com with SMTP id u186so1769643ita.0 for ; Thu, 07 Jul 2016 18:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version; bh=Pda6yA4dFLIGq0MVQ9+wzn76pQ2PasLSdkMogTg0AeY=; b=FVaQkbD6Fjjd9gHQasm10TwmeOW1Iz3b4g43w9gI1lYWqs9CQ8rohGcfaS3IoD/V8M zSh4jSfXOGkbIIk2CQ7/a2tcY8B9yN2VYgUU28VupPTuy5tc8m65HOSn7zDIVXEkjU2C MobqskbmCV4aB9iGFw7gjbpk4mRQ1nWN5oUB9htXdaUN3dWqKFB/DYDx3SzSu3uZDfx6 Bk2PbSWcZMiYdrZRY3IQjau4BPnnidRH8tGzvR9M4f/clO/oWD0R8+W1YSPCNv+UpRk5 2R9P5hzd9tbmEljf6jGyCpaabKPOmu5/WmvTN8gg04khb3cbYOi2L+HEkI9ECDai1Frf otwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=Pda6yA4dFLIGq0MVQ9+wzn76pQ2PasLSdkMogTg0AeY=; b=jFTqM/ceZ/H6U15yRqiyFR4u5Cblp79KcQ8vdNU9/kl0HZ6qmsW1el1nShsRzYaPbQ IPvLTXWI7ku0DcemOBHuY+vugJo2Uzg1tVZY89Pb5Jao2kYCy3CCjGc9bRXbzjaTM07g tPsJe0jZQB5/O2L8coEAV1MPufIthx3zTkCytX2is9Jgojqdten6EFpnoA8RwZ+3EBIS 7JpUemOoO6obbZv8W1M3kWVrbf49ot5KsgTWZLkj2azacUcrwCZ5YvLEgPxKhHNfnPY/ qM+/V+9jkwl7WuDpm9N7QInz/WzzVhcnLc9AzRJ2MNN9Ep+ng5cHGnYCshsLFd80fEzF ZyBg== X-Gm-Message-State: ALyK8tJc05TlIYg/9qrNY/j0PTjMHZyRd5+IfdvejfA2LkXaLT85biBujBL+XAPfkKEt1g== X-Received: by 10.36.13.19 with SMTP id 19mr705455itx.76.1467940395421; Thu, 07 Jul 2016 18:13:15 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id m133sm2626308ioa.23.2016.07.07.18.13.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jul 2016 18:13:14 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #5358 Date: Thu, 07 Jul 2016 21:13:23 -0400 Message-ID: <871t35c4p8.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 5358 confirmed found 5358 25.0.95 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 10:48:18 2019 Received: (at 5358) by debbugs.gnu.org; 6 Sep 2019 14:48:18 +0000 Received: from localhost ([127.0.0.1]:37256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6FX7-0002a0-I0 for submit@debbugs.gnu.org; Fri, 06 Sep 2019 10:48:17 -0400 Received: from mail-lj1-f181.google.com ([209.85.208.181]:40554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6FX5-0002Zm-Rt for 5358@debbugs.gnu.org; Fri, 06 Sep 2019 10:48:16 -0400 Received: by mail-lj1-f181.google.com with SMTP id 7so6236127ljw.7 for <5358@debbugs.gnu.org>; Fri, 06 Sep 2019 07:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=VVFQd42L/X9H8T3XB8nxpQRX7vpPVP1f9uoop+cOpUA=; b=c2yqrOq7sMfUb6QHQIK4ZY9ZcVKpz/Ns8Yck6V9OVbFuO5UMSeiuOXU7ZjvggORKt/ JMZb7S45gRaFxcbrowmfzoEJplGOEefjVCOHJ6AAgR2ysm0uu536HunRROvjwLM7p6Jr Km9IB6pSFTpAa6H7CK/iTsJITrOSvriUcv7J11qgP9sTdBkqFVrC02Ri3Fb6RMg5EIwU XVwqFhLu1tsWUIAdBRGvZKtxTDlTSNRGSMkq0KQsKtK/Byxja2E2V5xFRNRznEEalhZd c5ZB9R2jDtmMH/wWoKjqwR+5k374jheTtC1dcKG2hrAZ1gETJP0nPagicYRwmxUSNkT7 PPLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=VVFQd42L/X9H8T3XB8nxpQRX7vpPVP1f9uoop+cOpUA=; b=Da025jckoUpghMFcOxR8QTCW/InUAhvDIyO9J7av72s7SwcVssMTBqj/DHAeIxuRxh CfQx3EPehWWPVRGGvJfbV3LRyWVA3lSaCiCkBhEv/IWXZwyYdhfFdeg34AtUy96CreA+ DLRdfDzpaVDUvISoP2rsJKuKXucaw642B+Gu5B9ublTQJxM1NvItzBW1GTrdJZmp7uQQ gbPsS2aERJwd137M2PcU9d2dQTE6pUPOW4IXyuIObEIVHyENbiu1RbC1gqoaP/SXJ3f/ 6G9sBSVln2wPDXjIxUrSo+jlrjPqM4k9yEXPK3A7Nxj/ho6rN6c6hVKTm7JNEb28/pG7 7h/A== X-Gm-Message-State: APjAAAWl66hWYiYwAfk12rv0tgQ0IDecR5rL4tP95TYtYfeiULf/iqPe Frjkwesc7o+Mw/2GUKmLFxE+eyTBJTDBuYzAwkM8ZvYm X-Google-Smtp-Source: APXvYqy8l51P0AalZAPcMDV0P2Vh1m4lOeXJR9N4N1OYUJHtx/Hap7e016aT5kWXqp03xp0f3Y0suZk11NMHV7nB0vw= X-Received: by 2002:a2e:9586:: with SMTP id w6mr5692833ljh.47.1567781289553; Fri, 06 Sep 2019 07:48:09 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Fri, 6 Sep 2019 11:47:57 -0300 Message-ID: Subject: Re: bug#5358: 23.1; Adding comment loses customizations in progress To: 5358@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000d990990591e38626" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5358 Cc: dave@boostpro.com, Glenn Morris , ahyatt@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000d990990591e38626 Content-Type: multipart/alternative; boundary="000000000000d990960591e38624" --000000000000d990960591e38624 Content-Type: text/plain; charset="UTF-8" The possibility to preserve the customizations in progress is already present in the customize machinery, but for some reason it wasn't used in this case. I propose a patch that makes use of the :shown-value property of the custom-variable and custom-face widgets, thus allowing to preserve the customizations in progress when redrawing a widget. Since after redrawing customize recomputes the state of the widget, it is necessary to check if the widget was modified. That isn't possible with `custom-variable-state' or `custom-face-state', because they are pretty "widget unaware". So I added a check in `custom-variable-state-set' and `custom-face-state-set' to catch this situation. Finally, to be able to use the value of the widget in `custom-face-state-set', it is necessary to rearrange the final part of `custom-face-value-create'. Namely, add the children to the :children property, before calling `custom-face-state-set'. Best regards, Mauro. --000000000000d990960591e38624 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The possibility to preserve the customizations in progress= is already
present in the customize machinery, but for some reason it w= asn't used
in this case.

I propose a patch that makes use of = the :shown-value property of the
custom-variable and custom-face widgets= , thus allowing to preserve the
customizations in progress when redrawin= g a widget.

Since after redrawing customize recomputes the state of = the widget, it
is necessary to check if the widget was modified.=C2=A0 T= hat isn't
possible with `custom-variable-state' or `custom-face-= state',
because they are pretty "widget unaware".=C2=A0 So= I added a check in
`custom-variable-state-set' and `custom-face-sta= te-set' to catch this
situation.

Finally, to be able to use t= he value of the widget in
`custom-face-state-set', it is necessary t= o rearrange the final part of
`custom-face-value-create'.=C2=A0 Name= ly, add the children to the :children
property, before calling `custom-f= ace-state-set'.

Best regards,
Mauro.
--000000000000d990960591e38624-- --000000000000d990990591e38626 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-discard-customizations-in-progress-when-adding.patch" Content-Disposition: attachment; filename="0001-Don-t-discard-customizations-in-progress-when-adding.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k087cpb80 RnJvbSBkMjY1NmM3ZGE5N2FjZjY4OWVjMTJmMWZkZTQ5NmU2MDhkOGU5MGZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IEZyaSwgNiBTZXAgMjAxOSAwOTo1NTozOSAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIERv bid0IGRpc2NhcmQgY3VzdG9taXphdGlvbnMgaW4gcHJvZ3Jlc3Mgd2hlbiBhZGRpbmcgY29tbWVu dHMKIChCdWcjNTM1OCkKCiogbGlzcC9jdXMtZWRpdC5lbCAoY3VzdG9tLWNvbW1lbnQtc2hvdyk6 IEFkZCBkb2NzdHJpbmcuICBTYXZlIHRoZQp3aWRnZXQgdmFsdWUgaW4gdGhlIDpzaG93bi12YWx1 ZSBwcm9wZXJ0eSwgYmVmb3JlIHJlZHJhd2luZy4KKGN1c3RvbS12YXJpYWJsZS1tb2RpZmllZC1w KTogTmV3IGZ1bmN0aW9uLCB0byBjb21wbGVtZW50IHRoZSByZXR1cm4KdmFsdWVzIG9mIGN1c3Rv bS12YXJpYWJsZS1zdGF0ZS4KKGN1c3RvbS12YXJpYWJsZS1zdGF0ZS1zZXQpOiBVc2UgaXQuCihj dXN0b20tZmFjZS12YWx1ZS1jcmVhdGUpOiBBZGQgY2hpbGRyZW4gdG8gdGhlIGN1c3RvbS1mYWNl IHdpZGdldApiZWZvcmUgc2V0dGluZyB0aGUgc3RhdGUsIHRvIGJlIGFibGUgdG8gY2hlY2sgZm9y IHVzZXIgZWRpdHMuCihjdXN0b20tZmFjZS1zdGF0ZS1zZXQpOiBDaGVjayBmb3IgdXNlciBlZGl0 cyBiZWZvcmUgY2FsbGluZwpjdXN0b20tZmFjZS1zdGF0ZS4KLS0tCiBsaXNwL2N1cy1lZGl0LmVs IHwgNjMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9saXNwL2N1cy1lZGl0LmVsIGIvbGlzcC9jdXMtZWRpdC5lbAppbmRleCA4 YThiYWQ5Li42MGU2OTk2IDEwMDY0NAotLS0gYS9saXNwL2N1cy1lZGl0LmVsCisrKyBiL2xpc3Av Y3VzLWVkaXQuZWwKQEAgLTI0MTEsOSArMjQxMSwyMSBAQCBjdXN0b20tY29tbWVudC1oaWRlCiA7 OyBUaG9zZSBmdW5jdGlvbnMgYXJlIGZvciB0aGUgbWVudS4gV0lER0VUIGlzIE5PVCB0aGUgY29t bWVudCB3aWRnZXQuIEl0J3MKIDs7IHRoZSBnbG9iYWwgY3VzdG9tIG9uZQogKGRlZnVuIGN1c3Rv bS1jb21tZW50LXNob3cgKHdpZGdldCkKLSAgKHdpZGdldC1wdXQgd2lkZ2V0IDpjb21tZW50LXNo b3duIHQpCi0gIChjdXN0b20tcmVkcmF3IHdpZGdldCkKLSAgKHdpZGdldC1zZXR1cCkpCisgICJT aG93IHRoZSBjb21tZW50IGVkaXRhYmxlIGZpZWxkIHRoYXQgYmVsb25ncyB0byBXSURHRVQuIgor ICAobGV0ICgoY2hpbGQgKGNhciAod2lkZ2V0LWdldCB3aWRnZXQgOmNoaWxkcmVuKSkpCisgICAg ICAgIDs7IEp1c3QgdG8gYmUgc2FmZSwgd2Ugd2lsbCByZXN0b3JlIHRoaXMgdmFsdWUgYWZ0ZXIg cmVkcmF3aW5nLgorICAgICAgICAob2xkLXNob3duLXZhbHVlICh3aWRnZXQtZ2V0IHdpZGdldCA6 c2hvd24tdmFsdWUpKSkKKyAgICAod2lkZ2V0LXB1dCB3aWRnZXQgOmNvbW1lbnQtc2hvd24gdCkK KyAgICA7OyBTYXZlIHRoZSBjaGFuZ2VzIG1hZGUgYnkgdGhlIHVzZXIgYmVmb3JlIHJlZHJhd2lu ZywgdG8gYXZvaWQKKyAgICA7OyBsb3NpbmcgY3VzdG9taXphdGlvbnMgaW4gcHJvZ3Jlc3MuICAo QnVnIzUzNTgpCisgICAgKGlmIChlcSAod2lkZ2V0LXR5cGUgd2lkZ2V0KSAnY3VzdG9tLWZhY2Up CisgICAgICAgIChpZiAoZXEgKHdpZGdldC10eXBlIGNoaWxkKSAnY3VzdG9tLWZhY2UtZWRpdCkK KyAgICAgICAgICAgICh3aWRnZXQtcHV0IHdpZGdldCA6c2hvd24tdmFsdWUgYCgodCAsKHdpZGdl dC12YWx1ZSBjaGlsZCkpKSkKKyAgICAgICAgICAod2lkZ2V0LXB1dCB3aWRnZXQgOnNob3duLXZh bHVlICh3aWRnZXQtdmFsdWUgY2hpbGQpKSkKKyAgICAgICh3aWRnZXQtcHV0IHdpZGdldCA6c2hv d24tdmFsdWUgKGxpc3QgKHdpZGdldC12YWx1ZSBjaGlsZCkpKSkKKyAgICAoY3VzdG9tLXJlZHJh dyB3aWRnZXQpCisgICAgKHdpZGdldC1wdXQgd2lkZ2V0IDpzaG93bi12YWx1ZSBvbGQtc2hvd24t dmFsdWUpCisgICAgKHdpZGdldC1zZXR1cCkpKQogCiAoZGVmdW4gY3VzdG9tLWNvbW1lbnQtaW52 aXNpYmxlLXAgKHdpZGdldCkKICAgKGxldCAoKHZhbCAod2lkZ2V0LXZhbHVlICh3aWRnZXQtZ2V0 IHdpZGdldCA6Y29tbWVudC13aWRnZXQpKSkpCkBAIC0yODA1LDEyICsyODE3LDM0IEBAIGN1c3Rv bS12YXJpYWJsZS1zdGF0ZQogCSAgICAgJ2NoYW5nZWQpKQogCSAgKHQgJ3JvZ3VlKSkpKQogCiso ZGVmdW4gY3VzdG9tLXZhcmlhYmxlLW1vZGlmaWVkLXAgKHdpZGdldCkKKyAgIk5vbi1uaWwgaWYg dGhlIHZhcmlhYmxlIHZhbHVlIG9mIFdJREdFVCBoYXMgYmVlbiBtb2RpZmllZC4KK1dJREdFVCBz aG91bGQgYmUgYSBjdXN0b20tdmFyaWFibGUgd2lkZ2V0LCB3aG9zZSBmaXJzdCBjaGlsZCBpcyB0 aGUgd2lkZ2V0Cit0aGF0IGhvbGRzIHRoZSB2YWx1ZS4KK01vZGlmaWVkIG1lYW5zIHRoYXQgdGhl IHdpZGdldCB0aGF0IGhvbGRzIHRoZSB2YWx1ZSBoYXMgYmVlbiBlZGl0ZWQgYnkgdGhlIHVzZXIK K2luIGEgY3VzdG9taXplIGJ1ZmZlci4KK1RvIGNoZWNrIGZvciBvdGhlciBzdGF0ZXMsIGNhbGwg YGN1c3RvbS12YXJpYWJsZS1zdGF0ZScuIgorICAoY29uZGl0aW9uLWNhc2UgbmlsCisgICAgICAo bGV0KiAoKHN5bWJvbCAod2lkZ2V0LWdldCB3aWRnZXQgOnZhbHVlKSkKKyAgICAgICAgICAgICAo Z2V0IChvciAoZ2V0IHN5bWJvbCAnY3VzdG9tLWdldCkgJ2RlZmF1bHQtdmFsdWUpKQorICAgICAg ICAgICAgICh2YWx1ZSAoaWYgKGRlZmF1bHQtYm91bmRwIHN5bWJvbCkKKyAgICAgICAgICAgICAg ICAgICAgICAgIChmdW5jYWxsIGdldCBzeW1ib2wpCisgICAgICAgICAgICAgICAgICAgICAgKHN5 bWJvbC12YWx1ZSBzeW1ib2wpKSkpCisgICAgICAgIChub3QgKGVxdWFsIHZhbHVlICh3aWRnZXQt dmFsdWUgKGNhciAod2lkZ2V0LWdldCB3aWRnZXQgOmNoaWxkcmVuKSkpKSkpCisgICAgKGVycm9y IHQpKSkKKwogKGRlZnVuIGN1c3RvbS12YXJpYWJsZS1zdGF0ZS1zZXQgKHdpZGdldCAmb3B0aW9u YWwgc3RhdGUpCiAgICJTZXQgdGhlIHN0YXRlIG9mIFdJREdFVCB0byBTVEFURS4KLUlmIFNUQVRF IGlzIG5pbCwgdGhlIHZhbHVlIGlzIGNvbXB1dGVkIGJ5IGBjdXN0b20tdmFyaWFibGUtc3RhdGUn LiIKK0lmIFNUQVRFIGlzIG5pbCwgdGhlIG5ldyBzdGF0ZSBpcyBjb21wdXRlZCBieSBgY3VzdG9t LXZhcmlhYmxlLW1vZGlmaWVkLXAnIGlmCitXSURHRVQgaGFzIGJlZW4gZWRpdGVkIGluIHRoZSBD dXN0b20gYnVmZmVyLCBvciBieSBgY3VzdG9tLXZhcmlhYmxlLXN0YXRlJworb3RoZXJ3aXNlLiIK ICAgKHdpZGdldC1wdXQgd2lkZ2V0IDpjdXN0b20tc3RhdGUKLQkgICAgICAob3Igc3RhdGUgKGN1 c3RvbS12YXJpYWJsZS1zdGF0ZSAod2lkZ2V0LXZhbHVlIHdpZGdldCkKLQkJCQkJICAgICAgICh3 aWRnZXQtZ2V0IHdpZGdldCA6dmFsdWUpKSkpKQorCSAgICAgIChvciBzdGF0ZQorICAgICAgICAg ICAgICAgICAgKGFuZCAoY3VzdG9tLXZhcmlhYmxlLW1vZGlmaWVkLXAgd2lkZ2V0KSAnbW9kaWZp ZWQpCisgICAgICAgICAgICAgICAgICAoY3VzdG9tLXZhcmlhYmxlLXN0YXRlICh3aWRnZXQtdmFs dWUgd2lkZ2V0KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAod2lk Z2V0LXZhbHVlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2Fy CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1nZXQg d2lkZ2V0IDpjaGlsZHJlbikpKSkpKSkKIAogKGRlZnVuIGN1c3RvbS12YXJpYWJsZS1zdGFuZGFy ZC12YWx1ZSAod2lkZ2V0KQogICAoZ2V0ICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSAnc3RhbmRhcmQt dmFsdWUpKQpAQCAtMzYzMCw5ICszNjY0LDkgQEAgY3VzdG9tLWZhY2UtdmFsdWUtY3JlYXRlCiAJ CSAgICAoaW5zZXJ0LWNoYXIgP1xzIGluZGVudCkpCiAJCSAgKHdpZGdldC1jcmVhdGUtY2hpbGQt YW5kLWNvbnZlcnQKIAkJICAgd2lkZ2V0ICdzZXhwIDp2YWx1ZSBzcGVjKSkpKQotCSAgKGN1c3Rv bS1mYWNlLXN0YXRlLXNldCB3aWRnZXQpCi0JICAocHVzaCBlZGl0b3IgY2hpbGRyZW4pCi0JICAo d2lkZ2V0LXB1dCB3aWRnZXQgOmNoaWxkcmVuIGNoaWxkcmVuKSkpKSkpCisgICAgICAgICAgKHB1 c2ggZWRpdG9yIGNoaWxkcmVuKQorICAgICAgICAgICh3aWRnZXQtcHV0IHdpZGdldCA6Y2hpbGRy ZW4gY2hpbGRyZW4pCisJICAoY3VzdG9tLWZhY2Utc3RhdGUtc2V0IHdpZGdldCkpKSkpKQogCiAo ZGVmdmFyIGN1c3RvbS1mYWNlLW1lbnUKICAgYCgoIlNldCBmb3IgQ3VycmVudCBTZXNzaW9uIiBj dXN0b20tZmFjZS1zZXQpCkBAIC0zNzE4LDkgKzM3NTIsMTQgQEAgY3VzdG9tLWZhY2Utc3RhdGUK ICAgICAgIHN0YXRlKSkpCiAKIChkZWZ1biBjdXN0b20tZmFjZS1zdGF0ZS1zZXQgKHdpZGdldCkK LSAgIlNldCB0aGUgc3RhdGUgb2YgV0lER0VULiIKLSAgKHdpZGdldC1wdXQgd2lkZ2V0IDpjdXN0 b20tc3RhdGUKLQkgICAgICAoY3VzdG9tLWZhY2Utc3RhdGUgKHdpZGdldC12YWx1ZSB3aWRnZXQp KSkpCisgICJTZXQgdGhlIHN0YXRlIG9mIFdJREdFVCwgYSBjdXN0b20tZmFjZSB3aWRnZXQuCitJ ZiB0aGUgdXNlciBlZGl0ZWQgdGhlIHdpZGdldCwgc2V0IHRoZSBzdGF0ZSB0byBtb2RpZmllZC4g IElmIG5vdCwgdGhlIG5ldworc3RhdGUgaXMgb25lIG9mIHRoZSByZXR1cm4gdmFsdWVzIG9mIGBj dXN0b20tZmFjZS1zdGF0ZScuIgorICAobGV0ICgoZmFjZSAod2lkZ2V0LXZhbHVlIHdpZGdldCkp KQorICAgICh3aWRnZXQtcHV0IHdpZGdldCA6Y3VzdG9tLXN0YXRlCisgICAgICAgICAgICAgICAg KGlmIChmYWNlLXNwZWMtbWF0Y2gtcCBmYWNlIChjdXN0b20tZmFjZS13aWRnZXQtdG8tc3BlYyB3 aWRnZXQpKQorICAgICAgICAgICAgICAgICAgICAoY3VzdG9tLWZhY2Utc3RhdGUgZmFjZSkKKyAg ICAgICAgICAgICAgICAgICdtb2RpZmllZCkpKSkKIAogKGRlZnVuIGN1c3RvbS1mYWNlLWFjdGlv biAod2lkZ2V0ICZvcHRpb25hbCBldmVudCkKICAgIlNob3cgdGhlIG1lbnUgZm9yIGBjdXN0b20t ZmFjZScgV0lER0VULgotLSAKMi43LjQKCg== --000000000000d990990591e38626-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 27 08:31:53 2019 Received: (at 5358) by debbugs.gnu.org; 27 Sep 2019 12:31:53 +0000 Received: from localhost ([127.0.0.1]:45940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDpPc-0003OS-Jq for submit@debbugs.gnu.org; Fri, 27 Sep 2019 08:31:53 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:37726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDpPa-0003OG-JB for 5358@debbugs.gnu.org; Fri, 27 Sep 2019 08:31:51 -0400 Received: by mail-lf1-f47.google.com with SMTP id w67so1791003lff.4 for <5358@debbugs.gnu.org>; Fri, 27 Sep 2019 05:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lQdZAXWrT6oDTO+g5tCLgdkRVob5W6saU4vHTWT0ZWg=; b=hMLNjRRoh8YjVlxWx4QxOFi38CrtBZvy9njTJ92OsQ7WrRd8L2AHSswxWo3Ztf9KdL tEfyyi2kkpuQ6VWlk+Tit2KifFWDvRawG25bFs/LPrblaIaxZ86tF1rhfdn1n73OwBc+ iqhIyci5PISpJ6DLI5GIBFWMSw5sd8oz3JvDnkawu7/DKzhye5asQA26FnnzM2Op19w3 W1gsKVNMCCZNtqwEj1rSklGwKyP46zxsK4ohujRdt27XiKJQAxOLakVZV6t96fp0BkvR q8YAvNcW/miND/GlowTg9GRzZKjXkvb88/oLXTdGAEu2RpjibtHfE4UB2wJ8o69Yj67V UznQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lQdZAXWrT6oDTO+g5tCLgdkRVob5W6saU4vHTWT0ZWg=; b=kagI1+IibTpN0kBPIYBp8NeReod8fipYrEKZ1BUIpDqhF2Rtk5H8ky2HZzTTEFpWxU 5WlEkkeyQA7azNPM/NuZxUnvCoJ7TYFV+y3ULC4ZLGnNYTxZJlz8D+/dEtNjbI47bgjx OI+nQ8KaZr2Rnrk6wyOZc01OfwylAp2k1V6N//YpLNO2jJrUcvt8EqzZ77wFuId8rZ8p y7mfeEkJ5y7PdallEGojcBZbeT1NR65wd1nISzUUiWaFfg40z/HNpqdukaIyBtbMjT5+ HiNecQ4825Sl54N+/urCD/RupFL55H8PawM3CDpc9I+sviiuRdrC9P7yGJ2mUHYxsyxY oV5g== X-Gm-Message-State: APjAAAWEGjkOYuhyWnI1EX7ZUAjLbRC6kKwNzpAaadXOYz17Y8YqqWQz G6Koey1jaKcUs2YFgNpq1yighkDfEof2XY6w37xMAMBO X-Google-Smtp-Source: APXvYqyI1BaFkDQ4azcLlBUzU420C+cZOt4L+d6gnJQaOtTPcluLoTEEXtthcz9v48dLTILTZ7Dniik/pEBPzWWt5Qc= X-Received: by 2002:ac2:4253:: with SMTP id m19mr2710916lfl.34.1569587504071; Fri, 27 Sep 2019 05:31:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mauro Aranda Date: Fri, 27 Sep 2019 09:31:31 -0300 Message-ID: Subject: Re: bug#5358: 23.1; Adding comment loses customizations in progress To: 5358@debbugs.gnu.org Content-Type: multipart/mixed; boundary="0000000000009fdc310593881171" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5358 Cc: Dave Abrahams , Glenn Morris , ahyatt@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000009fdc310593881171 Content-Type: multipart/alternative; boundary="0000000000009fdc2f059388116f" --0000000000009fdc2f059388116f Content-Type: text/plain; charset="UTF-8" I added a test for this change. Best regards, Mauro. --0000000000009fdc2f059388116f Content-Type: text/html; charset="UTF-8"
I added a test for this change.

Best regards,
Mauro.
--0000000000009fdc2f059388116f-- --0000000000009fdc310593881171 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-discard-customizations-in-progress-when-adding.patch" Content-Disposition: attachment; filename="0001-Don-t-discard-customizations-in-progress-when-adding.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k123uvxt0 RnJvbSA2OWVjNDA2YTY3YjExZDIzOThjZTc5NWIzMWRiN2EwYWU0Y2I0NzljIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IEZyaSwgNiBTZXAgMjAxOSAwOTo1NTozOSAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIERv bid0IGRpc2NhcmQgY3VzdG9taXphdGlvbnMgaW4gcHJvZ3Jlc3Mgd2hlbiBhZGRpbmcgY29tbWVu dHMKIChCdWcjNTM1OCkKCiogbGlzcC9jdXMtZWRpdC5lbCAoY3VzdG9tLWNvbW1lbnQtc2hvdyk6 IEFkZCBkb2NzdHJpbmcuICBTYXZlIHRoZQp3aWRnZXQgdmFsdWUgaW4gdGhlIDpzaG93bi12YWx1 ZSBwcm9wZXJ0eSwgYmVmb3JlIHJlZHJhd2luZy4KKGN1c3RvbS12YXJpYWJsZS1tb2RpZmllZC1w KTogTmV3IGZ1bmN0aW9uLCB0byBjb21wbGVtZW50IHRoZSByZXR1cm4KdmFsdWVzIG9mIGN1c3Rv bS12YXJpYWJsZS1zdGF0ZS4KKGN1c3RvbS12YXJpYWJsZS1zdGF0ZS1zZXQpOiBVc2UgaXQuCihj dXN0b20tZmFjZS12YWx1ZS1jcmVhdGUpOiBBZGQgY2hpbGRyZW4gdG8gdGhlIGN1c3RvbS1mYWNl IHdpZGdldApiZWZvcmUgc2V0dGluZyB0aGUgc3RhdGUsIHRvIGJlIGFibGUgdG8gY2hlY2sgZm9y IHVzZXIgZWRpdHMuCihjdXN0b20tZmFjZS1zdGF0ZS1zZXQpOiBDaGVjayBmb3IgdXNlciBlZGl0 cyBiZWZvcmUgY2FsbGluZwpjdXN0b20tZmFjZS1zdGF0ZS4KCiogdGVzdC9saXNwL2N1c3RvbS10 ZXN0cy5lbCAoY3VzdG9tLXRlc3Qtc2hvdy1jb21tZW50LXByZXNlcnZlcy1jaGFuZ2VzKToKTmV3 IHRlc3QuCi0tLQogbGlzcC9jdXMtZWRpdC5lbCAgICAgICAgICB8IDYzICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCiB0ZXN0L2xpc3AvY3VzdG9tLXRlc3Rz LmVsIHwgMjggKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDc5IGluc2Vy dGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwg Yi9saXNwL2N1cy1lZGl0LmVsCmluZGV4IDI0OTY5NjMuLmYzNDQ1YzYgMTAwNjQ0Ci0tLSBhL2xp c3AvY3VzLWVkaXQuZWwKKysrIGIvbGlzcC9jdXMtZWRpdC5lbApAQCAtMjQxNiw5ICsyNDE2LDIx IEBAIGN1c3RvbS1jb21tZW50LWhpZGUKIDs7IFRob3NlIGZ1bmN0aW9ucyBhcmUgZm9yIHRoZSBt ZW51LiBXSURHRVQgaXMgTk9UIHRoZSBjb21tZW50IHdpZGdldC4gSXQncwogOzsgdGhlIGdsb2Jh bCBjdXN0b20gb25lCiAoZGVmdW4gY3VzdG9tLWNvbW1lbnQtc2hvdyAod2lkZ2V0KQotICAod2lk Z2V0LXB1dCB3aWRnZXQgOmNvbW1lbnQtc2hvd24gdCkKLSAgKGN1c3RvbS1yZWRyYXcgd2lkZ2V0 KQotICAod2lkZ2V0LXNldHVwKSkKKyAgIlNob3cgdGhlIGNvbW1lbnQgZWRpdGFibGUgZmllbGQg dGhhdCBiZWxvbmdzIHRvIFdJREdFVC4iCisgIChsZXQgKChjaGlsZCAoY2FyICh3aWRnZXQtZ2V0 IHdpZGdldCA6Y2hpbGRyZW4pKSkKKyAgICAgICAgOzsgSnVzdCB0byBiZSBzYWZlLCB3ZSB3aWxs IHJlc3RvcmUgdGhpcyB2YWx1ZSBhZnRlciByZWRyYXdpbmcuCisgICAgICAgIChvbGQtc2hvd24t dmFsdWUgKHdpZGdldC1nZXQgd2lkZ2V0IDpzaG93bi12YWx1ZSkpKQorICAgICh3aWRnZXQtcHV0 IHdpZGdldCA6Y29tbWVudC1zaG93biB0KQorICAgIDs7IFNhdmUgdGhlIGNoYW5nZXMgbWFkZSBi eSB0aGUgdXNlciBiZWZvcmUgcmVkcmF3aW5nLCB0byBhdm9pZAorICAgIDs7IGxvc2luZyBjdXN0 b21pemF0aW9ucyBpbiBwcm9ncmVzcy4gIChCdWcjNTM1OCkKKyAgICAoaWYgKGVxICh3aWRnZXQt dHlwZSB3aWRnZXQpICdjdXN0b20tZmFjZSkKKyAgICAgICAgKGlmIChlcSAod2lkZ2V0LXR5cGUg Y2hpbGQpICdjdXN0b20tZmFjZS1lZGl0KQorICAgICAgICAgICAgKHdpZGdldC1wdXQgd2lkZ2V0 IDpzaG93bi12YWx1ZSBgKCh0ICwod2lkZ2V0LXZhbHVlIGNoaWxkKSkpKQorICAgICAgICAgICh3 aWRnZXQtcHV0IHdpZGdldCA6c2hvd24tdmFsdWUgKHdpZGdldC12YWx1ZSBjaGlsZCkpKQorICAg ICAgKHdpZGdldC1wdXQgd2lkZ2V0IDpzaG93bi12YWx1ZSAobGlzdCAod2lkZ2V0LXZhbHVlIGNo aWxkKSkpKQorICAgIChjdXN0b20tcmVkcmF3IHdpZGdldCkKKyAgICAod2lkZ2V0LXB1dCB3aWRn ZXQgOnNob3duLXZhbHVlIG9sZC1zaG93bi12YWx1ZSkKKyAgICAod2lkZ2V0LXNldHVwKSkpCiAK IChkZWZ1biBjdXN0b20tY29tbWVudC1pbnZpc2libGUtcCAod2lkZ2V0KQogICAobGV0ICgodmFs ICh3aWRnZXQtdmFsdWUgKHdpZGdldC1nZXQgd2lkZ2V0IDpjb21tZW50LXdpZGdldCkpKSkKQEAg LTI4MTAsMTIgKzI4MjIsMzQgQEAgY3VzdG9tLXZhcmlhYmxlLXN0YXRlCiAJICAgICAnY2hhbmdl ZCkpCiAJICAodCAncm9ndWUpKSkpCiAKKyhkZWZ1biBjdXN0b20tdmFyaWFibGUtbW9kaWZpZWQt cCAod2lkZ2V0KQorICAiTm9uLW5pbCBpZiB0aGUgdmFyaWFibGUgdmFsdWUgb2YgV0lER0VUIGhh cyBiZWVuIG1vZGlmaWVkLgorV0lER0VUIHNob3VsZCBiZSBhIGN1c3RvbS12YXJpYWJsZSB3aWRn ZXQsIHdob3NlIGZpcnN0IGNoaWxkIGlzIHRoZSB3aWRnZXQKK3RoYXQgaG9sZHMgdGhlIHZhbHVl LgorTW9kaWZpZWQgbWVhbnMgdGhhdCB0aGUgd2lkZ2V0IHRoYXQgaG9sZHMgdGhlIHZhbHVlIGhh cyBiZWVuIGVkaXRlZCBieSB0aGUgdXNlcgoraW4gYSBjdXN0b21pemUgYnVmZmVyLgorVG8gY2hl Y2sgZm9yIG90aGVyIHN0YXRlcywgY2FsbCBgY3VzdG9tLXZhcmlhYmxlLXN0YXRlJy4iCisgIChj b25kaXRpb24tY2FzZSBuaWwKKyAgICAgIChsZXQqICgoc3ltYm9sICh3aWRnZXQtZ2V0IHdpZGdl dCA6dmFsdWUpKQorICAgICAgICAgICAgIChnZXQgKG9yIChnZXQgc3ltYm9sICdjdXN0b20tZ2V0 KSAnZGVmYXVsdC12YWx1ZSkpCisgICAgICAgICAgICAgKHZhbHVlIChpZiAoZGVmYXVsdC1ib3Vu ZHAgc3ltYm9sKQorICAgICAgICAgICAgICAgICAgICAgICAgKGZ1bmNhbGwgZ2V0IHN5bWJvbCkK KyAgICAgICAgICAgICAgICAgICAgICAoc3ltYm9sLXZhbHVlIHN5bWJvbCkpKSkKKyAgICAgICAg KG5vdCAoZXF1YWwgdmFsdWUgKHdpZGdldC12YWx1ZSAoY2FyICh3aWRnZXQtZ2V0IHdpZGdldCA6 Y2hpbGRyZW4pKSkpKSkKKyAgICAoZXJyb3IgdCkpKQorCiAoZGVmdW4gY3VzdG9tLXZhcmlhYmxl LXN0YXRlLXNldCAod2lkZ2V0ICZvcHRpb25hbCBzdGF0ZSkKICAgIlNldCB0aGUgc3RhdGUgb2Yg V0lER0VUIHRvIFNUQVRFLgotSWYgU1RBVEUgaXMgbmlsLCB0aGUgdmFsdWUgaXMgY29tcHV0ZWQg YnkgYGN1c3RvbS12YXJpYWJsZS1zdGF0ZScuIgorSWYgU1RBVEUgaXMgbmlsLCB0aGUgbmV3IHN0 YXRlIGlzIGNvbXB1dGVkIGJ5IGBjdXN0b20tdmFyaWFibGUtbW9kaWZpZWQtcCcgaWYKK1dJREdF VCBoYXMgYmVlbiBlZGl0ZWQgaW4gdGhlIEN1c3RvbSBidWZmZXIsIG9yIGJ5IGBjdXN0b20tdmFy aWFibGUtc3RhdGUnCitvdGhlcndpc2UuIgogICAod2lkZ2V0LXB1dCB3aWRnZXQgOmN1c3RvbS1z dGF0ZQotCSAgICAgIChvciBzdGF0ZSAoY3VzdG9tLXZhcmlhYmxlLXN0YXRlICh3aWRnZXQtdmFs dWUgd2lkZ2V0KQotCQkJCQkgICAgICAgKHdpZGdldC1nZXQgd2lkZ2V0IDp2YWx1ZSkpKSkpCisJ ICAgICAgKG9yIHN0YXRlCisgICAgICAgICAgICAgICAgICAoYW5kIChjdXN0b20tdmFyaWFibGUt bW9kaWZpZWQtcCB3aWRnZXQpICdtb2RpZmllZCkKKyAgICAgICAgICAgICAgICAgIChjdXN0b20t dmFyaWFibGUtc3RhdGUgKHdpZGdldC12YWx1ZSB3aWRnZXQpCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICh3aWRnZXQtdmFsdWUKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChjYXIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAod2lkZ2V0LWdldCB3aWRnZXQgOmNoaWxkcmVuKSkpKSkpKQogCiAoZGVm dW4gY3VzdG9tLXZhcmlhYmxlLXN0YW5kYXJkLXZhbHVlICh3aWRnZXQpCiAgIChnZXQgKHdpZGdl dC12YWx1ZSB3aWRnZXQpICdzdGFuZGFyZC12YWx1ZSkpCkBAIC0zNjM1LDkgKzM2NjksOSBAQCBj dXN0b20tZmFjZS12YWx1ZS1jcmVhdGUKIAkJICAgIChpbnNlcnQtY2hhciA/XHMgaW5kZW50KSkK IAkJICAod2lkZ2V0LWNyZWF0ZS1jaGlsZC1hbmQtY29udmVydAogCQkgICB3aWRnZXQgJ3NleHAg OnZhbHVlIHNwZWMpKSkpCi0JICAoY3VzdG9tLWZhY2Utc3RhdGUtc2V0IHdpZGdldCkKLQkgIChw dXNoIGVkaXRvciBjaGlsZHJlbikKLQkgICh3aWRnZXQtcHV0IHdpZGdldCA6Y2hpbGRyZW4gY2hp bGRyZW4pKSkpKSkKKyAgICAgICAgICAocHVzaCBlZGl0b3IgY2hpbGRyZW4pCisgICAgICAgICAg KHdpZGdldC1wdXQgd2lkZ2V0IDpjaGlsZHJlbiBjaGlsZHJlbikKKwkgIChjdXN0b20tZmFjZS1z dGF0ZS1zZXQgd2lkZ2V0KSkpKSkpCiAKIChkZWZ2YXIgY3VzdG9tLWZhY2UtbWVudQogICBgKCgi U2V0IGZvciBDdXJyZW50IFNlc3Npb24iIGN1c3RvbS1mYWNlLXNldCkKQEAgLTM3MjMsOSArMzc1 NywxNCBAQCBjdXN0b20tZmFjZS1zdGF0ZQogICAgICAgc3RhdGUpKSkKIAogKGRlZnVuIGN1c3Rv bS1mYWNlLXN0YXRlLXNldCAod2lkZ2V0KQotICAiU2V0IHRoZSBzdGF0ZSBvZiBXSURHRVQuIgot ICAod2lkZ2V0LXB1dCB3aWRnZXQgOmN1c3RvbS1zdGF0ZQotCSAgICAgIChjdXN0b20tZmFjZS1z dGF0ZSAod2lkZ2V0LXZhbHVlIHdpZGdldCkpKSkKKyAgIlNldCB0aGUgc3RhdGUgb2YgV0lER0VU LCBhIGN1c3RvbS1mYWNlIHdpZGdldC4KK0lmIHRoZSB1c2VyIGVkaXRlZCB0aGUgd2lkZ2V0LCBz ZXQgdGhlIHN0YXRlIHRvIG1vZGlmaWVkLiAgSWYgbm90LCB0aGUgbmV3CitzdGF0ZSBpcyBvbmUg b2YgdGhlIHJldHVybiB2YWx1ZXMgb2YgYGN1c3RvbS1mYWNlLXN0YXRlJy4iCisgIChsZXQgKChm YWNlICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSkpCisgICAgKHdpZGdldC1wdXQgd2lkZ2V0IDpjdXN0 b20tc3RhdGUKKyAgICAgICAgICAgICAgICAoaWYgKGZhY2Utc3BlYy1tYXRjaC1wIGZhY2UgKGN1 c3RvbS1mYWNlLXdpZGdldC10by1zcGVjIHdpZGdldCkpCisgICAgICAgICAgICAgICAgICAgIChj dXN0b20tZmFjZS1zdGF0ZSBmYWNlKQorICAgICAgICAgICAgICAgICAgJ21vZGlmaWVkKSkpKQog CiAoZGVmdW4gY3VzdG9tLWZhY2UtYWN0aW9uICh3aWRnZXQgJm9wdGlvbmFsIGV2ZW50KQogICAi U2hvdyB0aGUgbWVudSBmb3IgYGN1c3RvbS1mYWNlJyBXSURHRVQuCmRpZmYgLS1naXQgYS90ZXN0 L2xpc3AvY3VzdG9tLXRlc3RzLmVsIGIvdGVzdC9saXNwL2N1c3RvbS10ZXN0cy5lbAppbmRleCAw YzQ5ZGI2Li4yNzBhY2RhIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvY3VzdG9tLXRlc3RzLmVsCisr KyBiL3Rlc3QvbGlzcC9jdXN0b20tdGVzdHMuZWwKQEAgLTIxLDYgKzIxLDEwIEBACiAKIChyZXF1 aXJlICdlcnQpCiAKKyhyZXF1aXJlICd3aWQtZWRpdCkKKyhyZXF1aXJlICdjdXMtZWRpdCkKKyhy ZXF1aXJlICdzZXEpIDsgRm9yIGBzZXEtZmluZCcuCisKIChlcnQtZGVmdGVzdCBjdXN0b20tdGhl bWUtLWxvYWQtcGF0aCAoKQogICAiVGVzdCBgY3VzdG9tLXRoZW1lLS1sb2FkLXBhdGgnIGJlaGF2 aW9yLiIKICAgKGxldCAoKHRtcGRpciAoZmlsZS1uYW1lLWFzLWRpcmVjdG9yeSAobWFrZS10ZW1w LWZpbGUgImN1c3RvbS10ZXN0cy0iIHQpKSkpCkBAIC0xMjMsNCArMTI3LDI4IEBAIGN1c3RvbS0t dGVzdC12YXJpYWJsZQogICAgIChzaG91bGQgKGVxdWFsIGN1c3RvbS0tdGVzdC11c2VyLW9wdGlv biAnYmF6KSkKICAgICAoc2hvdWxkIChlcXVhbCBjdXN0b20tLXRlc3QtdmFyaWFibGUgJ2Jheikp KSkKIAorOzsgVGhpcyB0ZXN0cyBCdWcjNTM1OC4KKyhlcnQtZGVmdGVzdCBjdXN0b20tdGVzdC1z aG93LWNvbW1lbnQtcHJlc2VydmVzLWNoYW5nZXMgKCkKKyAgIlRlc3QgdGhhdCBhZGRpbmcgYSBj b21tZW50IGRvZXNuJ3QgZGlzY2FyZCBtb2RpZmljYXRpb25zIGluIHByb2dyZXNzLiIKKyAgKGN1 c3RvbWl6ZS1vcHRpb24gJ2N1c3RvbS0tdGVzdC11c2VyLW9wdGlvbikKKyAgKGxldCogKChmaWVs ZCAoc2VxLWZpbmQgKGxhbWJkYSAod2lkZ2V0KQorICAgICAgICAgICAgICAgICAgICAgICAgICAg IChlcSBjdXN0b20tLXRlc3QtdXNlci1vcHRpb24gKHdpZGdldC12YWx1ZSB3aWRnZXQpKSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgd2lkZ2V0LWZpZWxkLWxpc3QpKQorICAgICAgICAgKHBh cmVudCAod2lkZ2V0LWdldCBmaWVsZCA6cGFyZW50KSkKKwkgKG9yaWd2YWx1ZSAod2lkZ2V0LXZh bHVlIGZpZWxkKSkpCisgICAgOzsgTW92ZSB0byB0aGUgZW5kIG9mIHRoZSB0ZXh0IG9mIHRoZSB3 aWRnZXQsIGFuZCBtb2RpZnkgaXQuICBUaGlzCisgICAgOzsgbW9kaWZpY2F0aW9uIHNob3VsZCBi ZSBwcmVzZXJ2ZWQgYWZ0ZXIgc2hvd2luZyB0aGUgY29tbWVudCBmaWVsZC4KKyAgICAoZ290by1j aGFyICh3aWRnZXQtZmllbGQtdGV4dC1lbmQgZmllbGQpKQorICAgIChpbnNlcnQgImJhciIpCisg ICAgKGN1c3RvbS1jb21tZW50LXNob3cgcGFyZW50KQorICAgIDs7IEZyb20gbm93IG9uLCBtdXN0 IHVzZSBgd2lkZ2V0LWF0JyB0byBnZXQgdGhlIHZhbHVlIG9mIHRoZSB3aWRnZXQuCisgICAgKHNo b3VsZC1ub3QgKGVxIG9yaWd2YWx1ZSAod2lkZ2V0LXZhbHVlICh3aWRnZXQtYXQpKSkpCisgICAg KHNob3VsZCAoZXEgKHdpZGdldC1nZXQgcGFyZW50IDpjdXN0b20tc3RhdGUpICdtb2RpZmllZCkp CisgICAgKHNob3VsZCAoZXEgKHdpZGdldC12YWx1ZSAod2lkZ2V0LWF0KSkKKyAgICAgICAgICAg ICAgICAod2lkZ2V0LWFwcGx5IGZpZWxkCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6 dmFsdWUtdG8tZXh0ZXJuYWwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjb25jYXQK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAod2lkZ2V0LWFwcGx5IGZpZWxkIDp2YWx1 ZS10by1pbnRlcm5hbCBvcmlndmFsdWUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ImJhciIpKSkpKSkKKwogOzs7IGN1c3RvbS10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuNy40Cgo= --0000000000009fdc310593881171-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 27 10:09:47 2019 Received: (at 5358) by debbugs.gnu.org; 27 Sep 2019 14:09:48 +0000 Received: from localhost ([127.0.0.1]:48241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDqwN-0008Rn-Jm for submit@debbugs.gnu.org; Fri, 27 Sep 2019 10:09:47 -0400 Received: from quimby.gnus.org ([80.91.231.51]:60160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDqwM-0008Re-3M for 5358@debbugs.gnu.org; Fri, 27 Sep 2019 10:09:46 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDqwH-0002Fj-18; Fri, 27 Sep 2019 16:09:44 +0200 From: Lars Ingebrigtsen To: Mauro Aranda Subject: Re: bug#5358: 23.1; Adding comment loses customizations in progress References: Date: Fri, 27 Sep 2019 16:09:40 +0200 In-Reply-To: (Mauro Aranda's message of "Fri, 27 Sep 2019 09:31:31 -0300") Message-ID: <87r241omor.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > Subject: [PATCH] Don't discard customizations in progress when adding comments > (Bug#5358) Looks good to me. Just one tiny comment: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5358 Cc: Dave Abrahams , ahyatt@gmail.com, 5358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > Subject: [PATCH] Don't discard customizations in progress when adding comments > (Bug#5358) Looks good to me. Just one tiny comment: > + (condition-case nil > + (let* ((symbol (widget-get widget :value)) > + (get (or (get symbol 'custom-get) 'default-value)) > + (value (if (default-boundp symbol) > + (funcall get symbol) > + (symbol-value symbol)))) > + (not (equal value (widget-value (car (widget-get widget :children)))))) > + (error t))) If it's just the funcall you expect that might fail, then moving the condition-case down there might be a better choice. Having a condition-case around code that shouldn't fail can hide errors you don't want to hide. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 27 11:04:59 2019 Received: (at 5358) by debbugs.gnu.org; 27 Sep 2019 15:04:59 +0000 Received: from localhost ([127.0.0.1]:48398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDrnn-0008Tx-0k for submit@debbugs.gnu.org; Fri, 27 Sep 2019 11:04:59 -0400 Received: from mail-lf1-f53.google.com ([209.85.167.53]:37988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDrnk-0008Td-IN for 5358@debbugs.gnu.org; Fri, 27 Sep 2019 11:04:57 -0400 Received: by mail-lf1-f53.google.com with SMTP id u28so2183849lfc.5 for <5358@debbugs.gnu.org>; Fri, 27 Sep 2019 08:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oqe68eRGKY2CP7wlmB1MHJM9VdAotXWx9XyUgTZvr9A=; b=T2EsvUotxxziCI8LBrknxS4J6Xk9Ne7pQreHWv9mOTUyq9GcCbnyO2uqel7Md44WqH Ci7BO3DS7cauq7960NraeiFW+OKFLee0D50XiZRDjWcE92ScIwu7Gyv7tmzpUS3g+ICV Jysvatz2dtV81D3uAdBXhPvl+k2gdGf3ERtQ92QVYCusWrmzpVXFl+9b/nemF0Wn+CFi 14Kf/aJkpWydAnDUTFe9tG/lVfFB+3RIMyaa3BxFUySe25DELN4fSa1rzVHL5/7Q4bpS eOxwVxdPO3CnJDNcUAD7eq5Ft00iILycGrowW2VxZ8P+lUeIFIfCDe9zc8xLv1HGwnLG eGDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oqe68eRGKY2CP7wlmB1MHJM9VdAotXWx9XyUgTZvr9A=; b=NidToeZeL5MFhnrGI2csqrvqCBjaQGc19x2a3gjoHStjR8Zsjdyh6wWqWRuac4TF5I cLBsTssysVSINQ4XnN/bjdCwDqBzn6jqlauCBSTMhpGLdMlotZrHx7LPPu/4V1XW40n4 WzN+mW61D8Zr3QtmOegNb98i6GEaugZ9Vhh4nynXDjR4q3zJ8zh26wcznQ9jINz42jrv 7xyzWeH+HOHRtulNe3aiDy3Y7QQLk6B2oHnQLR2jpqa2Hi5bscNvRn5wVWpCY2MIoGv2 bKVyiGRSuv8yyFQvJ3QyM3l2By1EPNOhU3g/ZPAkgEwv9wyDU3s3/XvnTcdjB5/HnXwz 4cWA== X-Gm-Message-State: APjAAAV1izvzJJu3NU8XaKXUi4ZaPJWxH+oz8Jdl6SJoL8BP4UG2g5A9 emnyrNbr6LxZbPVF4oFSbQmxWlnH2Bp2e3D8iXc= X-Google-Smtp-Source: APXvYqyaXj216eFBzDOR1a9k+IrjKZIhBlUA/WxkErorbRsIrhbjKx3Q2ahWItoC3ITQiNoIGL/8ZGwtvKXj4KcJUTs= X-Received: by 2002:a19:f711:: with SMTP id z17mr3107065lfe.58.1569596690613; Fri, 27 Sep 2019 08:04:50 -0700 (PDT) MIME-Version: 1.0 References: <87r241omor.fsf@gnus.org> In-Reply-To: <87r241omor.fsf@gnus.org> From: Mauro Aranda Date: Fri, 27 Sep 2019 12:04:37 -0300 Message-ID: Subject: Re: bug#5358: 23.1; Adding comment loses customizations in progress To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="0000000000002f629505938a3589" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5358 Cc: Dave Abrahams , ahyatt@gmail.com, 5358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002f629505938a3589 Content-Type: multipart/alternative; boundary="0000000000002f629405938a3587" --0000000000002f629405938a3587 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> Subject: [PATCH] Don't discard customizations in progress when adding comments >> (Bug#5358) > > Looks good to me. Just one tiny comment: > >> + (condition-case nil >> + (let* ((symbol (widget-get widget :value)) >> + (get (or (get symbol 'custom-get) 'default-value)) >> + (value (if (default-boundp symbol) >> + (funcall get symbol) >> + (symbol-value symbol)))) >> + (not (equal value (widget-value (car (widget-get widget :children)))))) >> + (error t))) > > If it's just the funcall you expect that might fail, then moving the > condition-case down there might be a better choice. Having a > condition-case around code that shouldn't fail can hide errors you don't > want to hide. Right, thanks for noticing that. I've moved down the condition-case, and I've added an outer catch, to avoid the comparison in case of an error. I think that's OK, but if you see something wrong, please let me know. --0000000000002f629405938a3587 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>
= >> Subject: [PATCH] Don't discard customizations in progress when= adding comments
>> =C2=A0(Bug#5358)
>
> Looks good to= me.=C2=A0 Just one tiny comment:
>
>> + =C2=A0(condition-ca= se nil
>> + =C2=A0 =C2=A0 =C2=A0(let* ((symbol (widget-get widget = :value))
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (get (or (= get symbol 'custom-get) 'default-value))
>> + =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (value (if (default-boundp symbol)
>&= gt; + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0(funcall get symbol)
>> + =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(symbol-value symbol)))= )
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (equal value (widget-value = (car (widget-get widget :children))))))
>> + =C2=A0 =C2=A0(error t= )))
>
> If it's just the funcall you expect that might fail= , then moving the
> condition-case down there might be a better choic= e.=C2=A0 Having a
> condition-case around code that shouldn't fai= l can hide errors you don't
> want to hide.

Right, thanks = for noticing that.

I've moved down the condition-case, and I'= ;ve added an outer catch, to
avoid the comparison in case of an error.= =C2=A0 I think that's OK, but if you
see something wrong, please let= me know.
--0000000000002f629405938a3587-- --0000000000002f629505938a3589 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-discard-customizations-in-progress-when-adding.patch" Content-Disposition: attachment; filename="0001-Don-t-discard-customizations-in-progress-when-adding.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k129atyx0 RnJvbSAzOTMzNGI1NmQ3MWFlMzA5ZTlkZWJhMTU2OGMyYjIxMzQ3YzUxOWUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IEZyaSwgNiBTZXAgMjAxOSAwOTo1NTozOSAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIERv bid0IGRpc2NhcmQgY3VzdG9taXphdGlvbnMgaW4gcHJvZ3Jlc3Mgd2hlbiBhZGRpbmcgY29tbWVu dHMKIChCdWcjNTM1OCkKCiogbGlzcC9jdXMtZWRpdC5lbCAoY3VzdG9tLWNvbW1lbnQtc2hvdyk6 IEFkZCBkb2NzdHJpbmcuICBTYXZlIHRoZQp3aWRnZXQgdmFsdWUgaW4gdGhlIDpzaG93bi12YWx1 ZSBwcm9wZXJ0eSwgYmVmb3JlIHJlZHJhd2luZy4KKGN1c3RvbS12YXJpYWJsZS1tb2RpZmllZC1w KTogTmV3IGZ1bmN0aW9uLCB0byBjb21wbGVtZW50IHRoZSByZXR1cm4KdmFsdWVzIG9mIGN1c3Rv bS12YXJpYWJsZS1zdGF0ZS4KKGN1c3RvbS12YXJpYWJsZS1zdGF0ZS1zZXQpOiBVc2UgaXQuCihj dXN0b20tZmFjZS12YWx1ZS1jcmVhdGUpOiBBZGQgY2hpbGRyZW4gdG8gdGhlIGN1c3RvbS1mYWNl IHdpZGdldApiZWZvcmUgc2V0dGluZyB0aGUgc3RhdGUsIHRvIGJlIGFibGUgdG8gY2hlY2sgZm9y IHVzZXIgZWRpdHMuCihjdXN0b20tZmFjZS1zdGF0ZS1zZXQpOiBDaGVjayBmb3IgdXNlciBlZGl0 cyBiZWZvcmUgY2FsbGluZwpjdXN0b20tZmFjZS1zdGF0ZS4KCiogdGVzdC9saXNwL2N1c3RvbS10 ZXN0cy5lbCAoY3VzdG9tLXRlc3Qtc2hvdy1jb21tZW50LXByZXNlcnZlcy1jaGFuZ2VzKToKTmV3 IHRlc3QuCi0tLQogbGlzcC9jdXMtZWRpdC5lbCAgICAgICAgICB8IDY0ICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCiB0ZXN0L2xpc3AvY3VzdG9tLXRlc3Rz LmVsIHwgMjggKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDgwIGluc2Vy dGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwg Yi9saXNwL2N1cy1lZGl0LmVsCmluZGV4IDI0OTY5NjMuLmI5ZmQzZTAgMTAwNjQ0Ci0tLSBhL2xp c3AvY3VzLWVkaXQuZWwKKysrIGIvbGlzcC9jdXMtZWRpdC5lbApAQCAtMjQxNiw5ICsyNDE2LDIx IEBAIGN1c3RvbS1jb21tZW50LWhpZGUKIDs7IFRob3NlIGZ1bmN0aW9ucyBhcmUgZm9yIHRoZSBt ZW51LiBXSURHRVQgaXMgTk9UIHRoZSBjb21tZW50IHdpZGdldC4gSXQncwogOzsgdGhlIGdsb2Jh bCBjdXN0b20gb25lCiAoZGVmdW4gY3VzdG9tLWNvbW1lbnQtc2hvdyAod2lkZ2V0KQotICAod2lk Z2V0LXB1dCB3aWRnZXQgOmNvbW1lbnQtc2hvd24gdCkKLSAgKGN1c3RvbS1yZWRyYXcgd2lkZ2V0 KQotICAod2lkZ2V0LXNldHVwKSkKKyAgIlNob3cgdGhlIGNvbW1lbnQgZWRpdGFibGUgZmllbGQg dGhhdCBiZWxvbmdzIHRvIFdJREdFVC4iCisgIChsZXQgKChjaGlsZCAoY2FyICh3aWRnZXQtZ2V0 IHdpZGdldCA6Y2hpbGRyZW4pKSkKKyAgICAgICAgOzsgSnVzdCB0byBiZSBzYWZlLCB3ZSB3aWxs IHJlc3RvcmUgdGhpcyB2YWx1ZSBhZnRlciByZWRyYXdpbmcuCisgICAgICAgIChvbGQtc2hvd24t dmFsdWUgKHdpZGdldC1nZXQgd2lkZ2V0IDpzaG93bi12YWx1ZSkpKQorICAgICh3aWRnZXQtcHV0 IHdpZGdldCA6Y29tbWVudC1zaG93biB0KQorICAgIDs7IFNhdmUgdGhlIGNoYW5nZXMgbWFkZSBi eSB0aGUgdXNlciBiZWZvcmUgcmVkcmF3aW5nLCB0byBhdm9pZAorICAgIDs7IGxvc2luZyBjdXN0 b21pemF0aW9ucyBpbiBwcm9ncmVzcy4gIChCdWcjNTM1OCkKKyAgICAoaWYgKGVxICh3aWRnZXQt dHlwZSB3aWRnZXQpICdjdXN0b20tZmFjZSkKKyAgICAgICAgKGlmIChlcSAod2lkZ2V0LXR5cGUg Y2hpbGQpICdjdXN0b20tZmFjZS1lZGl0KQorICAgICAgICAgICAgKHdpZGdldC1wdXQgd2lkZ2V0 IDpzaG93bi12YWx1ZSBgKCh0ICwod2lkZ2V0LXZhbHVlIGNoaWxkKSkpKQorICAgICAgICAgICh3 aWRnZXQtcHV0IHdpZGdldCA6c2hvd24tdmFsdWUgKHdpZGdldC12YWx1ZSBjaGlsZCkpKQorICAg ICAgKHdpZGdldC1wdXQgd2lkZ2V0IDpzaG93bi12YWx1ZSAobGlzdCAod2lkZ2V0LXZhbHVlIGNo aWxkKSkpKQorICAgIChjdXN0b20tcmVkcmF3IHdpZGdldCkKKyAgICAod2lkZ2V0LXB1dCB3aWRn ZXQgOnNob3duLXZhbHVlIG9sZC1zaG93bi12YWx1ZSkKKyAgICAod2lkZ2V0LXNldHVwKSkpCiAK IChkZWZ1biBjdXN0b20tY29tbWVudC1pbnZpc2libGUtcCAod2lkZ2V0KQogICAobGV0ICgodmFs ICh3aWRnZXQtdmFsdWUgKHdpZGdldC1nZXQgd2lkZ2V0IDpjb21tZW50LXdpZGdldCkpKSkKQEAg LTI4MTAsMTIgKzI4MjIsMzUgQEAgY3VzdG9tLXZhcmlhYmxlLXN0YXRlCiAJICAgICAnY2hhbmdl ZCkpCiAJICAodCAncm9ndWUpKSkpCiAKKyhkZWZ1biBjdXN0b20tdmFyaWFibGUtbW9kaWZpZWQt cCAod2lkZ2V0KQorICAiTm9uLW5pbCBpZiB0aGUgdmFyaWFibGUgdmFsdWUgb2YgV0lER0VUIGhh cyBiZWVuIG1vZGlmaWVkLgorV0lER0VUIHNob3VsZCBiZSBhIGN1c3RvbS12YXJpYWJsZSB3aWRn ZXQsIHdob3NlIGZpcnN0IGNoaWxkIGlzIHRoZSB3aWRnZXQKK3RoYXQgaG9sZHMgdGhlIHZhbHVl LgorTW9kaWZpZWQgbWVhbnMgdGhhdCB0aGUgd2lkZ2V0IHRoYXQgaG9sZHMgdGhlIHZhbHVlIGhh cyBiZWVuIGVkaXRlZCBieSB0aGUgdXNlcgoraW4gYSBjdXN0b21pemUgYnVmZmVyLgorVG8gY2hl Y2sgZm9yIG90aGVyIHN0YXRlcywgY2FsbCBgY3VzdG9tLXZhcmlhYmxlLXN0YXRlJy4iCisgIChj YXRjaCAnZ2V0LWVycm9yCisgICAgKGxldCogKChzeW1ib2wgKHdpZGdldC1nZXQgd2lkZ2V0IDp2 YWx1ZSkpCisgICAgICAgICAgIChnZXQgKG9yIChnZXQgc3ltYm9sICdjdXN0b20tZ2V0KSAnZGVm YXVsdC12YWx1ZSkpCisgICAgICAgICAgICh2YWx1ZSAoaWYgKGRlZmF1bHQtYm91bmRwIHN5bWJv bCkKKyAgICAgICAgICAgICAgICAgICAgICAoY29uZGl0aW9uLWNhc2UgbmlsCisgICAgICAgICAg ICAgICAgICAgICAgICAgIChmdW5jYWxsIGdldCBzeW1ib2wpCisgICAgICAgICAgICAgICAgICAg ICAgICAoZXJyb3IgKHRocm93ICdnZXQtZXJyb3IgdCkpKQorICAgICAgICAgICAgICAgICAgICAo c3ltYm9sLXZhbHVlIHN5bWJvbCkpKSkKKyAgICAgIChub3QgKGVxdWFsIHZhbHVlICh3aWRnZXQt dmFsdWUgKGNhciAod2lkZ2V0LWdldCB3aWRnZXQgOmNoaWxkcmVuKSkpKSkpKSkKKwogKGRlZnVu IGN1c3RvbS12YXJpYWJsZS1zdGF0ZS1zZXQgKHdpZGdldCAmb3B0aW9uYWwgc3RhdGUpCiAgICJT ZXQgdGhlIHN0YXRlIG9mIFdJREdFVCB0byBTVEFURS4KLUlmIFNUQVRFIGlzIG5pbCwgdGhlIHZh bHVlIGlzIGNvbXB1dGVkIGJ5IGBjdXN0b20tdmFyaWFibGUtc3RhdGUnLiIKK0lmIFNUQVRFIGlz IG5pbCwgdGhlIG5ldyBzdGF0ZSBpcyBjb21wdXRlZCBieSBgY3VzdG9tLXZhcmlhYmxlLW1vZGlm aWVkLXAnIGlmCitXSURHRVQgaGFzIGJlZW4gZWRpdGVkIGluIHRoZSBDdXN0b20gYnVmZmVyLCBv ciBieSBgY3VzdG9tLXZhcmlhYmxlLXN0YXRlJworb3RoZXJ3aXNlLiIKICAgKHdpZGdldC1wdXQg d2lkZ2V0IDpjdXN0b20tc3RhdGUKLQkgICAgICAob3Igc3RhdGUgKGN1c3RvbS12YXJpYWJsZS1z dGF0ZSAod2lkZ2V0LXZhbHVlIHdpZGdldCkKLQkJCQkJICAgICAgICh3aWRnZXQtZ2V0IHdpZGdl dCA6dmFsdWUpKSkpKQorCSAgICAgIChvciBzdGF0ZQorICAgICAgICAgICAgICAgICAgKGFuZCAo Y3VzdG9tLXZhcmlhYmxlLW1vZGlmaWVkLXAgd2lkZ2V0KSAnbW9kaWZpZWQpCisgICAgICAgICAg ICAgICAgICAoY3VzdG9tLXZhcmlhYmxlLXN0YXRlICh3aWRnZXQtdmFsdWUgd2lkZ2V0KQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAod2lkZ2V0LXZhbHVlCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2FyCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1nZXQgd2lkZ2V0IDpjaGlsZHJl bikpKSkpKSkKIAogKGRlZnVuIGN1c3RvbS12YXJpYWJsZS1zdGFuZGFyZC12YWx1ZSAod2lkZ2V0 KQogICAoZ2V0ICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSAnc3RhbmRhcmQtdmFsdWUpKQpAQCAtMzYz NSw5ICszNjcwLDkgQEAgY3VzdG9tLWZhY2UtdmFsdWUtY3JlYXRlCiAJCSAgICAoaW5zZXJ0LWNo YXIgP1xzIGluZGVudCkpCiAJCSAgKHdpZGdldC1jcmVhdGUtY2hpbGQtYW5kLWNvbnZlcnQKIAkJ ICAgd2lkZ2V0ICdzZXhwIDp2YWx1ZSBzcGVjKSkpKQotCSAgKGN1c3RvbS1mYWNlLXN0YXRlLXNl dCB3aWRnZXQpCi0JICAocHVzaCBlZGl0b3IgY2hpbGRyZW4pCi0JICAod2lkZ2V0LXB1dCB3aWRn ZXQgOmNoaWxkcmVuIGNoaWxkcmVuKSkpKSkpCisgICAgICAgICAgKHB1c2ggZWRpdG9yIGNoaWxk cmVuKQorICAgICAgICAgICh3aWRnZXQtcHV0IHdpZGdldCA6Y2hpbGRyZW4gY2hpbGRyZW4pCisJ ICAoY3VzdG9tLWZhY2Utc3RhdGUtc2V0IHdpZGdldCkpKSkpKQogCiAoZGVmdmFyIGN1c3RvbS1m YWNlLW1lbnUKICAgYCgoIlNldCBmb3IgQ3VycmVudCBTZXNzaW9uIiBjdXN0b20tZmFjZS1zZXQp CkBAIC0zNzIzLDkgKzM3NTgsMTQgQEAgY3VzdG9tLWZhY2Utc3RhdGUKICAgICAgIHN0YXRlKSkp CiAKIChkZWZ1biBjdXN0b20tZmFjZS1zdGF0ZS1zZXQgKHdpZGdldCkKLSAgIlNldCB0aGUgc3Rh dGUgb2YgV0lER0VULiIKLSAgKHdpZGdldC1wdXQgd2lkZ2V0IDpjdXN0b20tc3RhdGUKLQkgICAg ICAoY3VzdG9tLWZhY2Utc3RhdGUgKHdpZGdldC12YWx1ZSB3aWRnZXQpKSkpCisgICJTZXQgdGhl IHN0YXRlIG9mIFdJREdFVCwgYSBjdXN0b20tZmFjZSB3aWRnZXQuCitJZiB0aGUgdXNlciBlZGl0 ZWQgdGhlIHdpZGdldCwgc2V0IHRoZSBzdGF0ZSB0byBtb2RpZmllZC4gIElmIG5vdCwgdGhlIG5l dworc3RhdGUgaXMgb25lIG9mIHRoZSByZXR1cm4gdmFsdWVzIG9mIGBjdXN0b20tZmFjZS1zdGF0 ZScuIgorICAobGV0ICgoZmFjZSAod2lkZ2V0LXZhbHVlIHdpZGdldCkpKQorICAgICh3aWRnZXQt cHV0IHdpZGdldCA6Y3VzdG9tLXN0YXRlCisgICAgICAgICAgICAgICAgKGlmIChmYWNlLXNwZWMt bWF0Y2gtcCBmYWNlIChjdXN0b20tZmFjZS13aWRnZXQtdG8tc3BlYyB3aWRnZXQpKQorICAgICAg ICAgICAgICAgICAgICAoY3VzdG9tLWZhY2Utc3RhdGUgZmFjZSkKKyAgICAgICAgICAgICAgICAg ICdtb2RpZmllZCkpKSkKIAogKGRlZnVuIGN1c3RvbS1mYWNlLWFjdGlvbiAod2lkZ2V0ICZvcHRp b25hbCBldmVudCkKICAgIlNob3cgdGhlIG1lbnUgZm9yIGBjdXN0b20tZmFjZScgV0lER0VULgpk aWZmIC0tZ2l0IGEvdGVzdC9saXNwL2N1c3RvbS10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9jdXN0b20t dGVzdHMuZWwKaW5kZXggMGM0OWRiNi4uMjcwYWNkYSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2N1 c3RvbS10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvY3VzdG9tLXRlc3RzLmVsCkBAIC0yMSw2ICsy MSwxMCBAQAogCiAocmVxdWlyZSAnZXJ0KQogCisocmVxdWlyZSAnd2lkLWVkaXQpCisocmVxdWly ZSAnY3VzLWVkaXQpCisocmVxdWlyZSAnc2VxKSA7IEZvciBgc2VxLWZpbmQnLgorCiAoZXJ0LWRl ZnRlc3QgY3VzdG9tLXRoZW1lLS1sb2FkLXBhdGggKCkKICAgIlRlc3QgYGN1c3RvbS10aGVtZS0t bG9hZC1wYXRoJyBiZWhhdmlvci4iCiAgIChsZXQgKCh0bXBkaXIgKGZpbGUtbmFtZS1hcy1kaXJl Y3RvcnkgKG1ha2UtdGVtcC1maWxlICJjdXN0b20tdGVzdHMtIiB0KSkpKQpAQCAtMTIzLDQgKzEy NywyOCBAQCBjdXN0b20tLXRlc3QtdmFyaWFibGUKICAgICAoc2hvdWxkIChlcXVhbCBjdXN0b20t LXRlc3QtdXNlci1vcHRpb24gJ2JheikpCiAgICAgKHNob3VsZCAoZXF1YWwgY3VzdG9tLS10ZXN0 LXZhcmlhYmxlICdiYXopKSkpCiAKKzs7IFRoaXMgdGVzdHMgQnVnIzUzNTguCisoZXJ0LWRlZnRl c3QgY3VzdG9tLXRlc3Qtc2hvdy1jb21tZW50LXByZXNlcnZlcy1jaGFuZ2VzICgpCisgICJUZXN0 IHRoYXQgYWRkaW5nIGEgY29tbWVudCBkb2Vzbid0IGRpc2NhcmQgbW9kaWZpY2F0aW9ucyBpbiBw cm9ncmVzcy4iCisgIChjdXN0b21pemUtb3B0aW9uICdjdXN0b20tLXRlc3QtdXNlci1vcHRpb24p CisgIChsZXQqICgoZmllbGQgKHNlcS1maW5kIChsYW1iZGEgKHdpZGdldCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoZXEgY3VzdG9tLS10ZXN0LXVzZXItb3B0aW9uICh3aWRnZXQtdmFs dWUgd2lkZ2V0KSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgIHdpZGdldC1maWVsZC1saXN0 KSkKKyAgICAgICAgIChwYXJlbnQgKHdpZGdldC1nZXQgZmllbGQgOnBhcmVudCkpCisJIChvcmln dmFsdWUgKHdpZGdldC12YWx1ZSBmaWVsZCkpKQorICAgIDs7IE1vdmUgdG8gdGhlIGVuZCBvZiB0 aGUgdGV4dCBvZiB0aGUgd2lkZ2V0LCBhbmQgbW9kaWZ5IGl0LiAgVGhpcworICAgIDs7IG1vZGlm aWNhdGlvbiBzaG91bGQgYmUgcHJlc2VydmVkIGFmdGVyIHNob3dpbmcgdGhlIGNvbW1lbnQgZmll bGQuCisgICAgKGdvdG8tY2hhciAod2lkZ2V0LWZpZWxkLXRleHQtZW5kIGZpZWxkKSkKKyAgICAo aW5zZXJ0ICJiYXIiKQorICAgIChjdXN0b20tY29tbWVudC1zaG93IHBhcmVudCkKKyAgICA7OyBG cm9tIG5vdyBvbiwgbXVzdCB1c2UgYHdpZGdldC1hdCcgdG8gZ2V0IHRoZSB2YWx1ZSBvZiB0aGUg d2lkZ2V0LgorICAgIChzaG91bGQtbm90IChlcSBvcmlndmFsdWUgKHdpZGdldC12YWx1ZSAod2lk Z2V0LWF0KSkpKQorICAgIChzaG91bGQgKGVxICh3aWRnZXQtZ2V0IHBhcmVudCA6Y3VzdG9tLXN0 YXRlKSAnbW9kaWZpZWQpKQorICAgIChzaG91bGQgKGVxICh3aWRnZXQtdmFsdWUgKHdpZGdldC1h dCkpCisgICAgICAgICAgICAgICAgKHdpZGdldC1hcHBseSBmaWVsZAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgOnZhbHVlLXRvLWV4dGVybmFsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoY29uY2F0CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1h cHBseSBmaWVsZCA6dmFsdWUtdG8taW50ZXJuYWwgb3JpZ3ZhbHVlKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICJiYXIiKSkpKSkpCisKIDs7OyBjdXN0b20tdGVzdHMuZWwgZW5kcyBo ZXJlCi0tIAoyLjcuNAoK --0000000000002f629505938a3589-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 27 12:07:09 2019 Received: (at 5358) by debbugs.gnu.org; 27 Sep 2019 16:07:09 +0000 Received: from localhost ([127.0.0.1]:48514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDslx-0002bO-1J for submit@debbugs.gnu.org; Fri, 27 Sep 2019 12:07:09 -0400 Received: from quimby.gnus.org ([80.91.231.51]:34706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDslu-0002bF-VG for 5358@debbugs.gnu.org; Fri, 27 Sep 2019 12:07:07 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDsls-0003Yk-0Q; Fri, 27 Sep 2019 18:07:06 +0200 From: Lars Ingebrigtsen To: Mauro Aranda Subject: Re: bug#5358: 23.1; Adding comment loses customizations in progress References: <87r241omor.fsf@gnus.org> Date: Fri, 27 Sep 2019 18:07:03 +0200 In-Reply-To: (Mauro Aranda's message of "Fri, 27 Sep 2019 12:04:37 -0300") Message-ID: <87v9tdiuzc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > I've moved down the condition-case, and I've added an outer catch, to > avoid the comparison in case of an error. I think that's OK, but if you > see something wrong, please let me know. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5358 Cc: Dave Abrahams , ahyatt@gmail.com, 5358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > I've moved down the condition-case, and I've added an outer catch, to > avoid the comparison in case of an error. I think that's OK, but if you > see something wrong, please let me know. Looks good to me, so I've applied it to the trunk now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 27 12:07:19 2019 Received: (at control) by debbugs.gnu.org; 27 Sep 2019 16:07:19 +0000 Received: from localhost ([127.0.0.1]:48517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDsm7-0002bz-DX for submit@debbugs.gnu.org; Fri, 27 Sep 2019 12:07:19 -0400 Received: from quimby.gnus.org ([80.91.231.51]:34726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDsm3-0002bj-3z for control@debbugs.gnu.org; Fri, 27 Sep 2019 12:07:17 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDsly-0003Yw-Sp for control@debbugs.gnu.org; Fri, 27 Sep 2019 18:07:12 +0200 Date: Fri, 27 Sep 2019 18:07:10 +0200 Message-Id: <87tv8xiuz5.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #5358 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 5358 fixed close 5358 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 5358 fixed close 5358 27.1 quit From unknown Sat Jun 21 03:28:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 26 Oct 2019 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator