Subject: bug#53559: Mutter test-suite is flaky

From: Maxim Cournoyer <[email-masked]>
Date: Mon, 31 Jan 2022 00:27:28 -0500

Hello Liliana,

Liliana Marie Prikler <[email-masked]> writes:

> * gnu/packages/gnome.scm (mutter)[disable-problematic-tests]: Also disable
> timeline tests.
> ---
>  gnu/packages/gnome.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index e3fac534c4..b341fb4c97 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -7477,7 +7477,11 @@ (define-public mutter
>               ;; expression paragraph.  For an explanation, see: info '(sed)
>               ;; Multiline techniques'.
>               (invoke "sed" "/./{H;$!d} ; x ; s/^.*native-headless.*$//"
> -                     "-i" "src/tests/meson.build")))
> +                     "-i" "src/tests/meson.build")
> +             ;; Timeline tests may unexpectedly fail on missed frames, so
> +             ;; let's disable them as well.
> +             (substitute* "src/tests/clutter/conform/meson.build"
> +               (("'timeline.*',") ""))))
>           (replace 'check
>             (lambda* (#:key tests? test-options parallel-tests?
>                       #:allow-other-keys)

You'd want to let upstream know about these flaky tests, and add the
reference to the upstream issue in a comment so we can track progress.

Otherwise, LGTM.

Thanks,

Maxim