GNU bug report logs - #53556
[PATCH 1/2] gnu: Remove luminance-hdr.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53556 in the body.
You can then email your comments to 53556 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] gnu: Remove luminance-hdr.
Date: Wed, 26 Jan 2022 13:25:47 -0500

This package doesn't build anymore:

https://ci.guix.gnu.org/search?query=spec%3Amaster+system%3Ax86_64-linux+luminance-hdr

* gnu/packages/image-viewers.scm (luminance-hdr): Remove variable.
---
 gnu/packages/image-viewers.scm | 63 ----------------------------------
 1 file changed, 63 deletions(-)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index b61a79370d..68d9e53bf2 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -588,69 +588,6 @@ (define-public catimg
 It supports JPEG, PNG and GIF formats.")
     (license license:expat)))
 
-(define-public luminance-hdr
-  (package
-    (name "luminance-hdr")
-    (version "2.6.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "mirror://sourceforge/qtpfsgui/luminance/"
-                    version "/luminance-hdr-" version ".tar.bz2"))
-              (sha256
-               (base32
-                "188q0l63nfasqfvwbq4mwx2vh7wsfi2bq9n5nksddspl1qz01lnp"))))
-    (build-system cmake-build-system)
-    (native-inputs
-     (list pkg-config qttools))
-    (inputs
-     `(("qtbase" ,qtbase-5)
-       ("qtdeclarative" ,qtdeclarative)
-       ("qtsvg" ,qtsvg)
-       ("qtwebkit" ,qtwebkit)
-       ("boost" ,boost)
-       ("eigen" ,eigen)
-       ;; ("gtest" ,gtest)
-       ("libraw" ,libraw)
-       ("zlib" ,zlib)
-       ("exiv2" ,exiv2)
-       ("libpng" ,libpng)
-       ("libjpeg" ,libjpeg-turbo)
-       ("lcms" ,lcms)
-       ("openexr" ,openexr-2)
-       ("fftw" ,fftwf)
-       ("gsl" ,gsl)
-       ("libtiff" ,libtiff)))
-    (arguments
-     '(#:tests? #f  ;XXX: some tests fail to compile
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'set-paths 'add-ilmbase-include-path
-           (lambda* (#:key inputs #:allow-other-keys)
-             ;; 'OpenEXR.pc' has a -I for IlmBase but 'FindOpenEXR.cmake' does
-             ;; not use 'OpenEXR.pc'.  Thus, we need to add
-             ;; "$ilmbase/include/OpenEXR/" to the CPATH.
-             (setenv "CPATH"
-                     (string-append
-                      (search-input-directory inputs "include/OpenEXR")
-                      ":" (or (getenv "CPATH") ""))))))))
-    (home-page "http://qtpfsgui.sourceforge.net")
-    (synopsis "High dynamic range (HDR) imaging application")
-    (description
-     "Luminance HDR (formerly QtPFSGui) is a graphical user interface
-application that aims to provide a workflow for high dynamic range (HDR)
-imaging.  It supports several HDR and LDR image formats, and it can:
-
-@itemize
-@item Create an HDR file from a set of images (formats: JPEG, TIFF 8bit and
-16bit, RAW) of the same scene taken at different exposure setting;
-@item Save load HDR images;
-@item Rotate, resize and crop HDR images;
-@item Tone-map HDR images;
-@item Copy EXIF data between sets of images.
-@end itemize\n")
-    (license license:gpl2+)))
-
 ;; CBR and RAR are currently unsupported, due to non-free dependencies.
 (define-public mcomix
   ;; Official mcomix hasn't been updated since 2016, it's broken with
-- 
2.34.0

Message #10 received at 53556 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 53556 <at> debbugs.gnu.org
Subject: Re: [bug#53556] [PATCH 1/2] gnu: Remove luminance-hdr.
Date: Wed, 26 Jan 2022 23:32:57 -0500

Hello Leo,

Leo Famulari <leo <at> famulari.name> writes:

> This package doesn't build anymore:
>
> https://ci.guix.gnu.org/search?query=spec%3Amaster+system%3Ax86_64-linux+luminance-hdr
>
> * gnu/packages/image-viewers.scm (luminance-hdr): Remove variable.
> ---
>  gnu/packages/image-viewers.scm | 63 ----------------------------------
>  1 file changed, 63 deletions(-)

As I mentioned on #guix, I don't think removing broken but still
actively developed packages is the way to go.  Have you opened an issue
with upstream about the build failure?  I've searched but haven't seen
it.  Development now happens here:
https://github.com/LuminanceHDR/LuminanceHDR/

Other distributions are offering the package; we should check how they
do it.

At any rate, I don't think we should remove broken packages just because
they happen to be broken now.  It seems your concern was to advertise
broken packages to our users?  If so the way to do that would be to plug
the CI results in the generated package list on our site (they could be
shown in red or something).

Thanks,

Maxim

Message #13 received at 53556 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 53556 <at> debbugs.gnu.org
Subject: Re: [bug#53556] [PATCH 1/2] gnu: Remove luminance-hdr.
Date: Thu, 27 Jan 2022 01:10:28 -0500

On Wed, Jan 26, 2022 at 11:32:57PM -0500, Maxim Cournoyer wrote:
> As I mentioned on #guix, I don't think removing broken but still
> actively developed packages is the way to go.  Have you opened an issue
> with upstream about the build failure?  I've searched but haven't seen
> it.  Development now happens here:
> https://github.com/LuminanceHDR/LuminanceHDR/

I think that asking upstream is something that can be done by people who
aim to use this package. The packages have to sustain themselves with
user contributions: this work can't be done by just a handful of us.

Since this package hasn't built in a couple months (at least; that's as
far back as ci.guix.gnu.org shows us), one could guess it has no users.
A question of the chicken and the egg, perhaps, but we need a whole
henhouse regardless.

Additionally, this package depends on QtWebKit, which I am working to
remove from the distro:

https://issues.guix.gnu.org/53289

I respectfully insist that we wait 2 weeks for patches to fix this
package or else remove it from Guix.

Message #16 received at 53556 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: Leo Famulari <leo <at> famulari.name>, Maxim Cournoyer
 <maxim.cournoyer <at> gmail.com>
Cc: 53556 <at> debbugs.gnu.org
Subject: Re: [bug#53556] [PATCH 1/2] gnu: Remove luminance-hdr.
Date: Thu, 27 Jan 2022 08:14:32 +0100

Hi Leo,

Am Donnerstag, dem 27.01.2022 um 01:10 -0500 schrieb Leo Famulari:
> Additionally, this package depends on QtWebKit, which I am working to
> remove from the distro:
> 
> https://issues.guix.gnu.org/53289
The package can optionally build against QtWebEngine as of version
2.6.1 [1] (which for some odd reason is not advertised as latest on
either Github or Sourceforge).  Sourceforge has a tarball for both that
[2] and 2.6.1.1 [3].  So rather than dropping it, we should version-
bump it.  Other distros already ship it, including Debian experimental
and Fedora 33+ [4].

Cheers

[1] 
https://github.com/LuminanceHDR/LuminanceHDR/blob/v.2.6.1/CMakeLists.txt
[2] https://sourceforge.net/projects/qtpfsgui/files/luminance/2.6.1/
[3] https://sourceforge.net/projects/qtpfsgui/files/luminance/2.6.1.1/
[4] https://repology.org/project/luminance-hdr/versions

Message #19 received at 53556 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Cc: 53556 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#53556] [PATCH 1/2] gnu: Remove luminance-hdr.
Date: Thu, 27 Jan 2022 14:12:23 -0500

On Thu, Jan 27, 2022 at 08:14:32AM +0100, Liliana Marie Prikler wrote:
> The package can optionally build against QtWebEngine as of version
> 2.6.1 [1] (which for some odd reason is not advertised as latest on
> either Github or Sourceforge).  Sourceforge has a tarball for both that
> [2] and 2.6.1.1 [3].  So rather than dropping it, we should version-
> bump it.  Other distros already ship it, including Debian experimental
> and Fedora 33+ [4].

Sure, somebody can upgrade it and change the dependencies if they want.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.