GNU bug report logs - #53540
29.0.50; Completion support for the NAME field of cl-defmethod

Previous Next

Full log

View this message in rfc822 format

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: 53540 <at> debbugs.gnu.org
Subject: bug#53540: 29.0.50; Completion support for the NAME field of cl-defmethod
Date: Sat, 29 Jan 2022 01:17:32 +0100

[Message part 1 (text/plain, inline)]

Michael Heerdegen <michael_heerdegen <at> web.de> writes:


>   (cl-defmethod foo|
>
> and try completion at point (M-TAB) at the position indicated with the
> "|" meta marker.

Is this ok?

[0001-Elisp-mode-Fix-completion-of-cl-defmethod-NAME-arg.patch (text/x-diff, inline)]

From 826cf267ba8d65110ef6d338e30033f6cb79d66f Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen <at> web.de>
Date: Thu, 27 Jan 2022 02:56:17 +0100
Subject: [PATCH] Elisp-mode: Fix completion of cl-defmethod NAME arg

Fixes Bug#53540.

* lisp/progmodes/elisp-mode.el (elisp--expect-function-p):
Add "defmethod" to recognized parent expression types.
---
 lisp/progmodes/elisp-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index 0dfff32f20..914e4e3836 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -449,7 +449,7 @@ elisp--expect-function-p
                               (regexp-opt '("declare-function"
                                             "function" "defadvice"
                                             "callf" "callf2"
-                                            "defsetf"))
+                                            "defsetf" "defmethod"))
                               "[ \t\r\n]+"))
           (eq (match-end 0) pos)))))))

--
2.30.2

[Message part 3 (text/plain, inline)]

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.