From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 11 11:42:59 2010 Received: (at submit) by debbugs.gnu.org; 11 Jan 2010 16:42:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUNM2-0000lw-V0 for submit@debbugs.gnu.org; Mon, 11 Jan 2010 11:42:59 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUNM0-0000lp-TM for submit@debbugs.gnu.org; Mon, 11 Jan 2010 11:42:57 -0500 Received: from mail.gnu.org ([199.232.76.166]:34088 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUNLw-00050h-8m for emacs-pretest-bug@gnu.org; Mon, 11 Jan 2010 11:42:52 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NUNLs-0006Tm-Gm for emacs-pretest-bug@gnu.org; Mon, 11 Jan 2010 11:42:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.0 Received: from mail-fx0-f215.google.com ([209.85.220.215]:33879) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUNLr-0006T6-LS for emacs-pretest-bug@gnu.org; Mon, 11 Jan 2010 11:42:47 -0500 Received: by fxm7 with SMTP id 7so38743fxm.8 for ; Mon, 11 Jan 2010 08:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=5CdCNHYQd5sOsb7+oWLsS7DGWFF2Ap4YVm9Pq4XCzcs=; b=RVmDlsvINuIBO80WgkWx5/G+v4zg4BKxUmkHI1o8lC0rGPortf3gGVuQM0nT8uQdU/ xJ2LUeYmsEW3KWvM9NOWjtH3Z8jGHOMA8oD4sJijeBY64yN7M4Q2u7ZYF5gVbGRsf3Rx ki1QUzQYKK/+N+AjC/lNjaLkPeMr77VK4XPww= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=rJ3AulHMyL/ZBqI5kmagXUwq8I6fupZwUF8QInGLxWZ5l9avL8R/WH2jQr4WqAHa4Q XV1YM0NpyHGTptmJ8bDvJ209hCZQsF9HMwpnPL2xzhRbhtV+B5F+RS7CQiVTAbQqPMgB zlBhpUG8g/qzT2mUlU0yopUvfzWhrqJ1XTHXo= MIME-Version: 1.0 Received: by 10.239.150.79 with SMTP id m15mr1475479hbb.32.1263228166154; Mon, 11 Jan 2010 08:42:46 -0800 (PST) From: Lennart Borgman Date: Mon, 11 Jan 2010 17:42:26 +0100 Message-ID: Subject: Please replace font-lock-fontify-buffer with font-lock-fontify-region in js-mode To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) In `js-mode' there is a call to `font-lock-fontify-buffer' at the end. This creates problem for mumamo since it fontifies outside the region where js-mode should be applied: (let (font-lock-keywords) ; leaves syntactic keywords intact (font-lock-fontify-buffer)) Could this please be replaced by (let (font-lock-keywords ; leaves syntactic keywords intact font-lock-extend-region-functions) ;; accept narrowing (font-lock-fontify-region (point-min) (point-max))) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 11 12:37:32 2010 Received: (at 5354) by debbugs.gnu.org; 11 Jan 2010 17:37:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUOCq-000201-1I for submit@debbugs.gnu.org; Mon, 11 Jan 2010 12:37:32 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUOCp-0001zr-0U for 5354@debbugs.gnu.org; Mon, 11 Jan 2010 12:37:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArMEAMbwSkvO+KPG/2dsb2JhbACBRNcYhC8Eiik X-IronPort-AV: E=Sophos;i="4.49,257,1262581200"; d="scan'208";a="53520204" Received: from 206-248-163-198.dsl.teksavvy.com (HELO pastel.home) ([206.248.163.198]) by ironport2-out.pppoe.ca with ESMTP; 11 Jan 2010 12:37:25 -0500 Received: by pastel.home (Postfix, from userid 20848) id 685C481C9; Mon, 11 Jan 2010 12:37:25 -0500 (EST) From: Stefan Monnier To: Lennart Borgman Subject: Re: bug#5354: Please replace font-lock-fontify-buffer with font-lock-fontify-region in js-mode Message-ID: References: Date: Mon, 11 Jan 2010 12:37:25 -0500 In-Reply-To: (Lennart Borgman's message of "Mon, 11 Jan 2010 17:42:26 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 5354 Cc: 5354@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > In `js-mode' there is a call to `font-lock-fontify-buffer' at the end. > This creates problem for mumamo since it fontifies outside the region > where js-mode should be applied: > (let (font-lock-keywords) ; leaves syntactic keywords intact > (font-lock-fontify-buffer)) > Could this please be replaced by > (let (font-lock-keywords ; leaves syntactic keywords intact > font-lock-extend-region-functions) ;; accept narrowing > (font-lock-fontify-region (point-min) (point-max))) This looks majorly odd (aka difficult to explain/justify from js-mode's point of view). I suggest you instead submit a proposal for a new font-lock function that does what js-mode needs. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 11 16:33:14 2010 Received: (at 5354) by debbugs.gnu.org; 11 Jan 2010 21:33:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NURsv-0004h3-PY for submit@debbugs.gnu.org; Mon, 11 Jan 2010 16:33:14 -0500 Received: from mail-fx0-f226.google.com ([209.85.220.226]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NURsu-0004gx-9W for 5354@debbugs.gnu.org; Mon, 11 Jan 2010 16:33:13 -0500 Received: by fxm26 with SMTP id 26so19578290fxm.39 for <5354@debbugs.gnu.org>; Mon, 11 Jan 2010 13:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=BqJbF6B3GmPYkLH2P+V4de29v1W7/Bqts8AfNMcawts=; b=GahmR32VfbYiXB/AgSkmZiXJsrCWdJv3Apidwnfq0ZDW4+waKC4kjkLIjxbRst0nyn 1HboINXeqWNcrnCGXmCz0zrRvhBNeSdEkNn4qCyyROIvekrf0Yy9YenHI+g7PAnBsk/T WjdlFxGrJyjlUsc7POrGSBvW6odL3sNV8H0ns= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=MakyPOYDVa/X+VVkg2XWUj5PehyFNonG75/eXaaSUcik76gKNls10E1Hy7YAPO2kew KwgKqe3uSRdeI/O8Xa8WSjz55psBApb12WEZSaVExoI/4kjTgZ+E0GmPLZXFNkxlunD2 DGryOAdGoKGPrd28YWAmaC26ffqrfNtBhrPQA= MIME-Version: 1.0 Received: by 10.239.192.79 with SMTP id d15mr957759hbi.52.1263245587533; Mon, 11 Jan 2010 13:33:07 -0800 (PST) In-Reply-To: References: From: Lennart Borgman Date: Mon, 11 Jan 2010 22:32:47 +0100 Message-ID: Subject: Re: bug#5354: Please replace font-lock-fontify-buffer with font-lock-fontify-region in js-mode To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 5354 Cc: 5354@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Mon, Jan 11, 2010 at 6:37 PM, Stefan Monnier wrote: >> In `js-mode' there is a call to `font-lock-fontify-buffer' at the end. >> This creates problem for mumamo since it fontifies outside the region >> where js-mode should be applied: > >> =C2=A0 (let (font-lock-keywords) ; leaves syntactic keywords intact >> =C2=A0 =C2=A0 (font-lock-fontify-buffer)) > >> Could this please be replaced by > >> =C2=A0 (let (font-lock-keywords ; leaves syntactic keywords intact >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 font-lock-extend-region-functions) ;; accept= narrowing >> =C2=A0 =C2=A0 (font-lock-fontify-region (point-min) (point-max))) > > This looks majorly odd (aka difficult to explain/justify from js-mode's > point of view). =C2=A0I suggest you instead submit a proposal for a new > font-lock function that does what js-mode needs. Thanks, you are right. Looking at it again I realize I can of course instead change font-lock-fontify-buffer-function in mumamo. So I did that. Please close this bug. Sorry for the trouble and thanks for the help. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 11 16:50:59 2010 Received: (at control) by debbugs.gnu.org; 11 Jan 2010 21:50:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUSA7-0004rs-9K for submit@debbugs.gnu.org; Mon, 11 Jan 2010 16:50:59 -0500 Received: from pantheon-po29.its.yale.edu ([130.132.50.124]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUSA6-0004rn-22 for control@debbugs.gnu.org; Mon, 11 Jan 2010 16:50:58 -0500 Received: from furry (dhcp128036014123.central.yale.edu [128.36.14.123]) (authenticated bits=0) by pantheon-po29.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0BLor62007281 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 11 Jan 2010 16:50:53 -0500 Received: by furry (Postfix, from userid 1000) id 6160EC05D; Mon, 11 Jan 2010 14:50:53 -0700 (MST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 5354 Date: Mon, 11 Jan 2010 16:50:53 -0500 Message-ID: <87hbqsgvk2.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) close 5354 thanks From unknown Sun Jun 15 08:37:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Feb 2010 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator