GNU bug report logs - #5354
Please replace font-lock-fontify-buffer with font-lock-fontify-region in js-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5354 in the body.
You can then email your comments to 5354 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: Please replace font-lock-fontify-buffer with font-lock-fontify-region
	in js-mode
Date: Mon, 11 Jan 2010 17:42:26 +0100

In `js-mode' there is a call to `font-lock-fontify-buffer' at the end.
This creates problem for mumamo since it fontifies outside the region
where js-mode should be applied:

  (let (font-lock-keywords) ; leaves syntactic keywords intact
    (font-lock-fontify-buffer))

Could this please be replaced by

  (let (font-lock-keywords ; leaves syntactic keywords intact
        font-lock-extend-region-functions) ;; accept narrowing
    (font-lock-fontify-region (point-min) (point-max)))

Message #8 received at 5354 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 5354 <at> debbugs.gnu.org
Subject: Re: bug#5354: Please replace font-lock-fontify-buffer with
	font-lock-fontify-region in js-mode
Date: Mon, 11 Jan 2010 12:37:25 -0500

> In `js-mode' there is a call to `font-lock-fontify-buffer' at the end.
> This creates problem for mumamo since it fontifies outside the region
> where js-mode should be applied:

>   (let (font-lock-keywords) ; leaves syntactic keywords intact
>     (font-lock-fontify-buffer))

> Could this please be replaced by

>   (let (font-lock-keywords ; leaves syntactic keywords intact
>         font-lock-extend-region-functions) ;; accept narrowing
>     (font-lock-fontify-region (point-min) (point-max)))

This looks majorly odd (aka difficult to explain/justify from js-mode's
point of view).  I suggest you instead submit a proposal for a new
font-lock function that does what js-mode needs.


        Stefan

Message #11 received at 5354 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 5354 <at> debbugs.gnu.org
Subject: Re: bug#5354: Please replace font-lock-fontify-buffer with 
	font-lock-fontify-region in js-mode
Date: Mon, 11 Jan 2010 22:32:47 +0100

On Mon, Jan 11, 2010 at 6:37 PM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:
>> In `js-mode' there is a call to `font-lock-fontify-buffer' at the end.
>> This creates problem for mumamo since it fontifies outside the region
>> where js-mode should be applied:
>
>>   (let (font-lock-keywords) ; leaves syntactic keywords intact
>>     (font-lock-fontify-buffer))
>
>> Could this please be replaced by
>
>>   (let (font-lock-keywords ; leaves syntactic keywords intact
>>         font-lock-extend-region-functions) ;; accept narrowing
>>     (font-lock-fontify-region (point-min) (point-max)))
>
> This looks majorly odd (aka difficult to explain/justify from js-mode's
> point of view).  I suggest you instead submit a proposal for a new
> font-lock function that does what js-mode needs.

Thanks, you are right. Looking at it again I realize I can of course
instead change font-lock-fontify-buffer-function in mumamo. So I did
that.

Please close this bug. Sorry for the trouble and thanks for the help.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.