Subject: Re: [PATCH v2] gnu: Include poppler-data with poppler.

From: Liliana Marie Prikler <[email-masked]>
Date: Wed, 02 Feb 2022 08:27:52 +0100

Am Mittwoch, dem 02.02.2022 um 12:48 +0900 schrieb Taiju HIGASHI:
> ---
>  gnu/packages/djvu.scm | 1 -
>  gnu/packages/pdf.scm  | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/djvu.scm b/gnu/packages/djvu.scm
> index 07c77f318e..4773e408da 100644
> --- a/gnu/packages/djvu.scm
> +++ b/gnu/packages/djvu.scm
> @@ -159,7 +159,6 @@ (define-public pdf2djvu
>         ("exiv2" ,exiv2)
>         ("graphicsmagick" ,graphicsmagick)
>         ("poppler" ,poppler)
> -       ("poppler-data" ,poppler-data)
>         ("util-linux-lib" ,util-linux "lib"))) ; for libuuid
>      (arguments
>       `(#:test-target "test"
> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> index d4e97e1d82..6894640317 100644
> --- a/gnu/packages/pdf.scm
> +++ b/gnu/packages/pdf.scm
> @@ -241,6 +241,7 @@ (define-public poppler
>               ("libtiff" ,libtiff)
>               ("lcms" ,lcms)
>               ("openjpeg" ,openjpeg)
> +             ("poppler-data", poppler-data)
>               ("zlib" ,zlib)
> 
>               ;; To build poppler-glib (as needed by Evince), we need
> Cairo and
> --
> 2.34.0
Note that the ChangeLog is missing here.  It should be something along
the lines of

* gnu/packages/pdf.scm (poppler)[inputs]: Add poppler-data.
* gnu/packages/djvu.scm (pdf2djvu)[inputs]: Remove poppler-data.

In my personal opinion, adding and removing should be done in separate
commits, as it appears that there are other ways in which a package can
depend on poppler-data.  On that note, I haven't built the package, so
I need to ask you: are the contents of poppler-data now included in the
install of poppler?  If not, that might be a reason as to why gimp and
glimpse are failing.

Cheers