GNU bug report logs - #53535
[PATCH] gnu: Add emacs-popper

Previous Next

Full log

Message #11 received at 53535 <at> debbugs.gnu.org (full text, mbox):

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 53535 <at> debbugs.gnu.org
Subject: Re: [bug#53535] [PATCH] gnu: Add emacs-popper
Date: Tue, 01 Feb 2022 17:02:25 +0000

[Message part 1 (text/plain, inline)]

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>> Niklas Eklund <niklas.eklund <at> posteo.net> writes:
>>
>>> this patch adds the emacs-popper package.
>>
>> Thank you. Somme comments follow..
>>
>>> Subject: [PATCH] gnu: Add emacs-popper.
>>
>> The commit message is missing a line:
>>
>>   * gnu/packages/emacs-xyz.scm (emacs-popper): New variable.

Aha, I hadn't grasped that before. Thanks for mentioning it. Fixed that
in this new patch.

>>> +(define-public emacs-popper
>>> +  ;; No tagged release upstream for version 0.45
>>
>> This is true, but the commit matching release 0.45 is
>> "851d83882192ac9599ac5b053614a42d683b3fab", not the one you're using.
>>
>>> +  (let ((commit "527a85c49174e6e79220f0ed0761c204a979eae6") (revision "0"))
>>
>> Could you add a newline between (commit ...) and (revision ...)?
>>> +    (package
>>> +      (name "emacs-popper")
>>> +      (version "0.45")
>>
>> You bound revision, but you're not actually making use of it. I think
>> there are two possibilities here:
>>
>> - if you use commit 851d83882192ac9599ac5b053614a42d683b3fab, you can
>>   keep using (version "0.45"), and explain in a comment that the chosen
>>   commit matches version bump;
>>
>> - if you use another commit, you need to use (git-version "0.45"
>>   revision commit) instead, and explain in a comment why you're using an
>>   untagged commit.
>>
>> Could you send an updated patch?

Good points. I have changed to the
851d83882192ac9599ac5b053614a42d683b3fab commit and dropped revision.

>> Regards,
>> -- 
>> Nicolas Goaziou

/Niklas

[0001-gnu-Add-emacs-popper.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.