GNU bug report logs - #53531
Deprecate QSyncthingTray in favor of syncthing-gtk

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53531 in the body.
You can then email your comments to 53531 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: Deprecate QSyncthingTray in favor of syncthing-gtk
Date: Tue, 25 Jan 2022 14:35:48 -0500

[Message part 1 (text/plain, inline)]

This patch series deprecates QSyncthingTray in favor of Debian's fork of
syncthing-gtk.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 53531 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 53531 <at> debbugs.gnu.org.
Subject: [PATCH 1/2] WIP: qsyncthingtray: Use QtWebEngine instead of QtWebKit.
Date: Tue, 25 Jan 2022 14:37:26 -0500

This doesn't work. When trying to launch the web view from the tray
icon, QSyncthingTray crashes like this:

------
Could not find QtWebEngineProcess
Aborted
------

* gnu/packages/sync.scm (qsyncthingtray)[arguments]: Remove
Webkit-related argument from #:configure-flags.
[inputs]: Remove qtwebkit. Add qtdeclarative, qtwebchannel, and
qtwebengine.
---
 gnu/packages/sync.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/sync.scm b/gnu/packages/sync.scm
index 165be17e4c..d9c91804b5 100644
--- a/gnu/packages/sync.scm
+++ b/gnu/packages/sync.scm
@@ -378,8 +378,7 @@ (define-public qsyncthingtray
           "1n9g4j7qznvg9zl6x163pi9f7wsc3x6q76i33psnm7x2v1i22x5w"))))
     (build-system cmake-build-system)
     (arguments
-     `(#:configure-flags '("-DQST_BUILD_WEBKIT=1")
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          ;; The program is meant to be run from the git repo or source tarball.
          (replace 'install
@@ -394,7 +393,7 @@ (define-public qsyncthingtray
                #t))))
        #:tests? #f)) ; no test target
     (inputs
-     (list qtbase-5 qtwebkit))
+     (list qtbase-5 qtdeclarative qtwebchannel qtwebengine))
     (home-page "https://github.com/sieren/QSyncthingTray")
     (synopsis "Traybar Application for Syncthing")
     (description
-- 
2.34.0

Message #11 received at 53531 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 53531 <at> debbugs.gnu.org.
Subject: [PATCH 2/2] gnu: QSyncthingTray: Deprecate in favor of Debian's
 syncthing-gtk fork.
Date: Tue, 25 Jan 2022 14:37:27 -0500

This package is abandoned upstream and depends on the insecure and
abandoned QtWebKit.

Upstream abandonment:

https://github.com/sieren/QSyncthingTray/issues/247

See <https://issues.guix.gnu.org/53289> for more information about this change

* gnu/packages/sync.scm (qsyncthingtray): Move this variable ...
* gnu/packages/syncthing.scm (qsyncthingtray): ... to here. And make it into a
deprecated-package that points to syncthing-gtk.
---
 gnu/packages/sync.scm      | 51 --------------------------------------
 gnu/packages/syncthing.scm |  3 +++
 2 files changed, 3 insertions(+), 51 deletions(-)

diff --git a/gnu/packages/sync.scm b/gnu/packages/sync.scm
index d9c91804b5..db0e001658 100644
--- a/gnu/packages/sync.scm
+++ b/gnu/packages/sync.scm
@@ -362,57 +362,6 @@ (define-public owncloud-client
 silently and reliably flow across to every other.")
     (license license:gpl2+)))
 
-(define-public qsyncthingtray
-  (package
-    (name "qsyncthingtray")
-    (version "0.5.8")
-    (source
-      (origin
-        (method git-fetch)
-        (uri (git-reference
-               (url "https://github.com/sieren/QSyncthingTray")
-               (commit version)))
-        (file-name (git-file-name name version))
-        (sha256
-         (base32
-          "1n9g4j7qznvg9zl6x163pi9f7wsc3x6q76i33psnm7x2v1i22x5w"))))
-    (build-system cmake-build-system)
-    (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         ;; The program is meant to be run from the git repo or source tarball.
-         (replace 'install
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((out (assoc-ref outputs "out"))
-                    (bin (string-append out "/bin")))
-               (install-file "QSyncthingTray" bin)
-               (mkdir-p (string-append out "/share/pixmaps"))
-               (copy-file "../source/resources/images/Icon1024.png"
-                          (string-append
-                            out "/share/pixmaps/QSyncthingTray.png"))
-               #t))))
-       #:tests? #f)) ; no test target
-    (inputs
-     (list qtbase-5 qtdeclarative qtwebchannel qtwebengine))
-    (home-page "https://github.com/sieren/QSyncthingTray")
-    (synopsis "Traybar Application for Syncthing")
-    (description
-     "A traybar application for syncthing.
-@enumerate
-@item Shows number of connections at a glance.
-@item Traffic statistics about incoming, outgoing and total throughput.
-@item Launches Syncthing and Syncthing-iNotifier if specified.
-@item Quickly pause Syncthing with one click.
-@item Last Synced Files - Quickly see the recently synchronised files and open
-their folder.
-@item Quick Access to all shared folders.
-@item Presents Syncthing UI in a separate view instead of using the browser.
-@item Supports authenticated HTTPS connections.
-@item Uses System Notifications about current connection status.
-@item Toggle for monochrome icon.
-@end enumerate\n")
-    (license license:lgpl3+)))
-
 (define-public lsyncd
   (package
     (name "lsyncd")
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index c19cc97862..c96d5cc3f2 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -217,6 +217,9 @@ (define-public syncthing-gtk
 @end itemize\n")
       (license gpl2))))
 
+(define-public qsyncthingtray
+  (deprecated-package "qsyncthingtray" syncthing-gtk))
+
 (define-public go-github-com-jackpal-go-nat-pmp
   (package
     (name "go-github-com-jackpal-go-nat-pmp")
-- 
2.34.0

Message #16 received at 53531 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Leo Famulari <leo <at> famulari.name>
Cc: 53531 <at> debbugs.gnu.org.
Subject: Re: [bug#53531] [PATCH 2/2] gnu: QSyncthingTray: Deprecate in favor
 of Debian's syncthing-gtk fork.
Date: Wed, 26 Jan 2022 11:42:05 +0200

[Message part 1 (text/plain, inline)]

On Tue, Jan 25, 2022 at 02:37:27PM -0500, Leo Famulari wrote:
> This package is abandoned upstream and depends on the insecure and
> abandoned QtWebKit.
> 
> Upstream abandonment:
> 
> https://github.com/sieren/QSyncthingTray/issues/247
> 
> See <https://issues.guix.gnu.org/53289> for more information about this change

I like this idea. Although I'm not sure about keeping the first patch.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 53531 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Efraim Flashner <efraim <at> flashner.co.il>, 53531 <at> debbugs.gnu.org.
Subject: Re: [bug#53531] [PATCH 2/2] gnu: QSyncthingTray: Deprecate in favor
 of Debian's syncthing-gtk fork.
Date: Wed, 26 Jan 2022 13:03:59 -0500

[Message part 1 (text/plain, inline)]

On Wed, Jan 26, 2022 at 11:42:05AM +0200, Efraim Flashner wrote:
> I like this idea. Although I'm not sure about keeping the first patch.

I forgot to mention: the first patch is just a demonstration of why
using QtWebEngine doesn't work "out of the box".

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 53531-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Efraim Flashner <efraim <at> flashner.co.il>, 53531-done <at> debbugs.gnu.org.
Subject: Re: [bug#53531] [PATCH 2/2] gnu: QSyncthingTray: Deprecate in favor
 of Debian's syncthing-gtk fork.
Date: Wed, 9 Feb 2022 11:58:25 -0500

[Message part 1 (text/plain, inline)]

On Wed, Jan 26, 2022 at 11:42:05AM +0200, Efraim Flashner wrote:
> On Tue, Jan 25, 2022 at 02:37:27PM -0500, Leo Famulari wrote:
> > This package is abandoned upstream and depends on the insecure and
> > abandoned QtWebKit.
> > 
> > Upstream abandonment:
> > 
> > https://github.com/sieren/QSyncthingTray/issues/247
> > 
> > See <https://issues.guix.gnu.org/53289> for more information about this change
> 
> I like this idea. Although I'm not sure about keeping the first patch.

Pushed as 4578ad78bee1dfd450962627ae66d3e15ebadad2

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.