GNU bug report logs - #53523
[PATCH] gnu: Add tree-sitter.

Previous Next

Full log

Message #17 received at 53523 <at> debbugs.gnu.org (full text, mbox):

From: Luis Henrique Gomes Higino <luishenriquegh2701 <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53523 <at> debbugs.gnu.org
Subject: Re: [bug#53523] [PATCH 2/2] gnu: Add neovim-luajit.
Date: Wed, 26 Jan 2022 08:28:20 -0300

Maxime Devos <maximedevos <at> telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> Luis Henrique Gomes Higino schreef op di 25-01-2022 om 13:56 
> [-0300]:
>> * gnu/packages/vim.scm (neovim-luajit): New variable.
>> +(define-public neovim-luajit
>> +  (package
>> +    (inherit neovim)
>> +    (name "neovim-luajit")
>> +    (inputs (modify-inputs (package-inputs neovim)
>> +              (replace "lua" luajit)))
>> +    (arguments
>> +     (substitute-keyword-arguments (package-arguments neovim)
>> +       ((#:configure-flags cf) `(delete 
>> "-DPREFER_LUA:BOOL=YES"
>> +                                        ,cf))))
>> +    (synopsis
>> +     "Fork of vim focused on extensibility and agility - built 
>> with LuaJIT")))
>
> Does this need to be a separate package?  I.e., can we use 
> luajit
> in the 'neovim' package on systems that support luajit, so not 
> for
> powerpc)?
>
> Greetings,
> Maxime.
>
> [[End of PGP Signed Part]]

I initially choose a package variant because it seemed the easiest 
way to permit
both, but I think we can choose which implementation of Lua to use 
based on
the target's architecture and it is possibly a better solution. My 
only
problem with it is that I'm not sure this conforms to the 
reproducible
building mindset. If choosing a dependency based on hardware is
OK for Guix, I'll configure `qemu-binfmt-service-type` and try to
implement this.

-- 
Regards,
Luis H. Higino

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.