Subject: Re: [bug#53523] [PATCH v2 1/2] gnu: Add tree-sitter.

From: Maxime Devos <[email-masked]>
Date: Sat, 05 Feb 2022 12:09:11 +0100

Luis Henrique Gomes Higino schreef op di 01-02-2022 om 10:04 [-0300]:
> +                  (add-after 'unpack 'fix-hardcoded-paths
> +                    (lambda _
> +                      (substitute* "Makefile"
> +                        (("/usr/local") (assoc-ref %outputs "out"))))))

%outputs and friends are being phased out, use G-exps instead:

 (list #:phases
       #~(modify-phases ...
           (add-after 'unpack ...
             (lambda _
               (substitute* "Makefile"
                 (("/usr/local") #$output))))
           [...])
      [...])

> +       #:tests? #f

Why are they disabled?

> +       #:make-flags
> +       (list (string-append "prefix="
> +                            (assoc-ref %outputs "out"))

Likewise (G-exps).

> +             (string-append "CC="
> +                            ,(cc-for-target)))))

If G-exps are used, ',' needs to be replaced by #$.

Greetings,
Maxime.