GNU bug report logs - #53520
[PATCH] tabulated-list gradually truncate image

Previous Next

Full log

Message #8 received at 53520 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Thuna <thuna.cing <at> gmail.com>
Cc: 53520 <at> debbugs.gnu.org
Subject: Re: bug#53520: [PATCH] tabulated-list gradually truncate image
Date: Tue, 25 Jan 2022 14:36:32 +0100

Thuna <thuna.cing <at> gmail.com> writes:

> Previously images were displayed as is which would potentially cause
> misalignment if the column width were less than the image width.  Image
> is now cropped width-wise to fit the column width.  This patch, however,
> does not affect the height of the image.

[...]

> +                                          (slice 0.0 0.0
> +                                                 ,(* (frame-char-width)
> +                                                     available-space)

I think it a tabulated-list caller wants to insert images into the
table, they should ensure that the width of the image is appropriate for
the column.  And as you say, this only chops off the parts of the
image -- I think it's more likely that a caller would want to set the
width with :max-width or the like.

So I don't think this makes all that much sense as a feature.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.