From unknown Fri Jun 20 07:09:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53518 <53518@debbugs.gnu.org> To: bug#53518 <53518@debbugs.gnu.org> Subject: Status: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols Reply-To: bug#53518 <53518@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:09:48 +0000 retitle 53518 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols reassign 53518 emacs submitter 53518 Sean Whitton severity 53518 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 00:33:54 2022 Received: (at submit) by debbugs.gnu.org; 25 Jan 2022 05:33:54 +0000 Received: from localhost ([127.0.0.1]:46588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCESo-00081X-EU for submit@debbugs.gnu.org; Tue, 25 Jan 2022 00:33:54 -0500 Received: from lists.gnu.org ([209.51.188.17]:46288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCESk-00081M-Qd for submit@debbugs.gnu.org; Tue, 25 Jan 2022 00:33:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCESC-0007mm-GK for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 00:33:26 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCESA-0002rP-DV for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 00:33:16 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 99D035C0109 for ; Tue, 25 Jan 2022 00:33:13 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 25 Jan 2022 00:33:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=vc3gjLJyRZR9IDyZ+wzlohjp2xRK0mNlMZLII0 NLg/Y=; b=uKX1Ihl8Z8hnd1A+kqwF3/aeB4Q1V6J18nuY3w8qUduM8BdUQk2hVd +E0yghnTBWHQk6I5b6Zxbv3CJNcsNIY7K/Nq8tsPadYi4WZPirEfgH0p73x5XfQa 1jTVi60bhez2jyNU007dISp/dD2tjae5z5MMQX0ITp+DzOeVucnypeS6Pn1o7Vte mb7ElHS+/jkFubiTwgVoRCEAxqQBtiA42wyCwPGpr4IXCypHX5d2amf99shXt/ly hkpwY4kX/wE+8+ZxLbn49h+DJzSPX3L7FJgnEi8o84AAPCfpXiw1EU8a8PT+RG2W MkgXFDucJKWbPq6epzyUF7wpaEkveALw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=vc3gjLJyRZR9IDyZ+ wzlohjp2xRK0mNlMZLII0NLg/Y=; b=oLVAF4cIdwFpzuzCh1sfMc6Km0TVA/nMa 4nDtCUbNvhNzyMR8VJBZrUhC015Nl3YBGKZ4RpoCtpE2PIf7+mp75bAjpTakFGEv 3ac7xs6bHrUdQ1/MurqBfyo+rFl4c4gNZEABwXZjHtn2Qetn4jNOu06hyvXKgBtT QW20fHER6LIO+lXZ5M2ZRhuFmQ+udmUY4SAHvFMxnVcU3f98jkLNO4CCZeb82z7X w5UtIrULtlkckre+XQFUPZq9VZsOMvmR+yKVUB4GIh2koKClZgxPn6ic25TEqHES cezUlGEYkMcEPxaDTmGjYeTXHUuhZibhTRiaNYgWsCtd78RUU/B1A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvdekgdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehttddttd dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepleeggefgvdeijedvhf dugfegtefgkeekueeileejjeehudeggeefteeghfeuffeknecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih htthhonhdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 25 Jan 2022 00:33:13 -0500 (EST) Received: by athena.silentflame.com (Postfix, from userid 1000) id 550081B6566; Tue, 25 Jan 2022 05:33:11 +0000 (UTC) From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols In-Reply-To: <639b931e-7816-ef07-510c-71178ff19fff@gmail.com> References: <8735lersah.fsf@melete.silentflame.com> <87pmohrzcj.fsf@gmx.de> <87zgnkj2me.fsf@melete.silentflame.com> <87fspc276n.fsf@gnus.org> <639b931e-7816-ef07-510c-71178ff19fff@gmail.com> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) X-debbugs-cc: Jim Porter Date: Mon, 24 Jan 2022 22:33:10 -0700 Message-ID: <87h79s1isp.fsf@athena.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.26; envelope-from=spwhitton@spwhitton.name; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello Jim, On Mon 24 Jan 2022 at 06:39pm -08, Jim Porter wrote: > I just noticed a small bit of breakage with this. It's no longer > possible to refer to Lisp functions in Eshell like so: > > #'upcase > > Eshell explicitly supports this construct (see `eshell-lisp-regexp'), > though it doesn't appear to be documented in the manual. Currently, this > syntax is only occasionally useful, but I'm working on a patch series > where it'll likely become a lot more common. My patches will add support > for piping to Lisp functions, so that you can do the following, for example: > > $ echo hi | #'upcase > HI > > It looks like the breakage in parsing #'upcase is the result of > `eshell-parse-external-pipeline' trying to skip over args like '*|' > (with the quotes). However, it sees the single-quote in #'upcase and > then calls `eshell-parse-literal-quote', resulting in the error message: > > Expecting completion of delimiter ' ... Thanks for the report. I have a fix; incoming once I have a bug number. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 03:50:46 2022 Received: (at 53518) by debbugs.gnu.org; 25 Jan 2022 08:50:46 +0000 Received: from localhost ([127.0.0.1]:46839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCHXJ-0007Ai-SO for submit@debbugs.gnu.org; Tue, 25 Jan 2022 03:50:46 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:36785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCHXG-0007AT-71 for 53518@debbugs.gnu.org; Tue, 25 Jan 2022 03:50:44 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B792E5C01A7; Tue, 25 Jan 2022 03:50:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 25 Jan 2022 03:50:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; bh=pP2wswiicANKmS+f2KomVhjEj3QJ+MEHZlCD90 Cg4eQ=; b=LyMt71ORYTRaZ56huCMdGKQr6MaZ8h4AvkgE2ei7JGAdZQ4LITJGVo vPGrenfwde2FtrBEZm7+97++3m71VARWIELs1w5b9HjUcslCHH/NiGJXpVrtgZAQ QmkCe+EJzuof+EVdpsL9CnDzV3JSRD40srssW5GUKcGPJ7N/MJBYVw3l3XEbcY16 akuavSZAn1qKXmlJy7abqK/oXop1rcCPw1tRlTrFPw1xyBpUWodhmyWbl7i1t987 28fN0sMDrnP4EIAe3xfXel2gwPSpQU9o5Sk8fMgtshCqIJVaKtuwvki9kSKOfBof BOaXVc9w3/cJEq8TbrJW7Oo1FSo9ilmw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=pP2wswiicANKmS+f2KomVhjEj3QJ+ MEHZlCD90Cg4eQ=; b=l/pH7A6RzulppShIaFXPJXHbMSDk8VvVewyZ77rKGDpXc /Fr1rUm0jzf0mTbL8TCVk56DGZirzRnMi926rXzT9hdl6/Msqxz/eSrbHykTJOml dGHsuyU51ChUZOxSedw9t5CiKsiw/hWSk/q7w5/CbWv2+wo+v6pCiapgf3TcueRf yyFq2YBNiQ9JfSBzD6t7Vv+FrHXhP/QokPlmtXt5EsYLQT6GY0y2DbMDOTbd/I4G hbrR1gC6NSYlhK2ohX7bd7aYtbqdwk2DU5R7ghKFVqkmwz0m8w+ZmvJoxTjvPoID LMRUEY70U8uc7w4nBPmtJ7e/veOp/cQjJIf3qFdXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvdekgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfffkgggtsehmtddtredttddtnecuhfhrohhmpefuvggrnhcuhghh ihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepleefffdvvefhgfehudeugefggfeffedvvdffuedvvdelgffghfff leehheetffehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jan 2022 03:50:36 -0500 (EST) Received: by athena.silentflame.com (Postfix, from userid 1000) id 207A11B6048; Tue, 25 Jan 2022 08:50:35 +0000 (UTC) From: Sean Whitton To: 53518@debbugs.gnu.org, Jim Porter Subject: Re: bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols In-Reply-To: <639b931e-7816-ef07-510c-71178ff19fff@gmail.com> Date: Tue, 25 Jan 2022 01:50:35 -0700 Message-ID: <87a6fk19no.fsf@athena.silentflame.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53518 Cc: Lars Ingebrigtsen , Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello again, On Mon 24 Jan 2022 at 06:39pm -08, Jim Porter wrote: > I just noticed a small bit of breakage with this. It's no longer > possible to refer to Lisp functions in Eshell like so: > > #'upcase > > Eshell explicitly supports this construct (see `eshell-lisp-regexp'), > though it doesn't appear to be documented in the manual. Currently, this > syntax is only occasionally useful, but I'm working on a patch series > where it'll likely become a lot more common. My patches will add support > for piping to Lisp functions, so that you can do the following, for example: > > $ echo hi | #'upcase > HI Out of curiosity, why is there a need for the sharpquote? Why not just 'echo hi | upcase'? Is it to do with requesting the new piping? > It looks like the breakage in parsing #'upcase is the result of > `eshell-parse-external-pipeline' trying to skip over args like '*|' > (with the quotes). However, it sees the single-quote in #'upcase and > then calls `eshell-parse-literal-quote', resulting in the error message: > > Expecting completion of delimiter ' ... Here is a patch which has `eshell-parse-external-pipeline' try skipping over sharp-quoted symbols before trying to skip over single-quoted strings. -- Sean Whitton --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-input-of-sharp-quoted-symbols-in-Eshell-with-em-.patch >From 8725495cb91ebf831cd623c58f84a4347e6f1651 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Mon, 24 Jan 2022 22:39:15 -0700 Subject: [PATCH] Fix input of sharp-quoted symbols in Eshell with em-extpipe * lisp/eshell/em-extpipe.el (eshell-parse-external-pipeline): Fix misinterpreting sharp-quoted symbols as the beginning of single-quoted strings (Bug#53518). Add protection against a possible infinite loop. * test/lisp/eshell/em-extpipe-tests.el (em-extpipe-test-17): New test. --- lisp/eshell/em-extpipe.el | 12 +++++++++--- test/lisp/eshell/em-extpipe-tests.el | 4 ++++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/lisp/eshell/em-extpipe.el b/lisp/eshell/em-extpipe.el index 57aeec38ff..b0f92e41dc 100644 --- a/lisp/eshell/em-extpipe.el +++ b/lisp/eshell/em-extpipe.el @@ -97,15 +97,21 @@ eshell-parse-external-pipeline (while (> bound (point)) (let* ((found (save-excursion - (re-search-forward "['\"\\]" bound t))) + (re-search-forward + "\\(?:#?'\\|\"\\|\\\\\\)" bound t))) (next (or (and found (match-beginning 0)) bound))) (if (re-search-forward pat next t) (throw 'found (match-beginning 1)) (goto-char next) - (while (or (eshell-parse-backslash) + (while (or (eshell-parse-lisp-argument) + (eshell-parse-backslash) (eshell-parse-double-quote) - (eshell-parse-literal-quote))))))))) + (eshell-parse-literal-quote))) + ;; Guard against an infinite loop if none of + ;; the parsers moved us forward. + (unless (or (> (point) next) (eobp)) + (forward-char 1)))))))) (goto-char (if (and result go) (match-end 0) start)) result))) (unless (or eshell-current-argument eshell-current-quoted) diff --git a/test/lisp/eshell/em-extpipe-tests.el b/test/lisp/eshell/em-extpipe-tests.el index 1283b6b361..0879ad5b0c 100644 --- a/test/lisp/eshell/em-extpipe-tests.el +++ b/test/lisp/eshell/em-extpipe-tests.el @@ -202,4 +202,8 @@ em-extpipe-test-16 (eshell-command-result-p input "rab") (eshell-command-result-p "echo \"bar\" | rev" "nonsense")))) +;; Confirm we don't break input of sharp-quoted symbols (Bug#53518). +(em-extpipe-tests--deftest em-extpipe-test-17 "funcall #'upcase foo" + (eshell-command-result-p input "FOO")) + ;;; em-extpipe-tests.el ends here -- 2.30.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 07:27:12 2022 Received: (at 53518) by debbugs.gnu.org; 25 Jan 2022 12:27:12 +0000 Received: from localhost ([127.0.0.1]:47228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCKum-0000k4-1J for submit@debbugs.gnu.org; Tue, 25 Jan 2022 07:27:12 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCKuk-0000jp-GK for 53518@debbugs.gnu.org; Tue, 25 Jan 2022 07:27:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sPNe4CmKDiwBmu0OOYHjEn9ry5VA8Qurx7RSYPIKLyw=; b=HpyBWHpQ1JnbMr8nYMF+u+n4+z zLwIUa/XtX8x+YJ1pjim9QhzfpGDtK8SnghKtUlK5fSFsZo2+xe52lb6jY1M6fBQ0JSgFemBKLzt4 gbVx1u8CT3FzIEQReBP9rINejbYg9sMtwMHH+8CkcijPB1ASzWS4dQ1gsFi3V0vx593k=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCKua-0003P9-Vd; Tue, 25 Jan 2022 13:27:03 +0100 From: Lars Ingebrigtsen To: Sean Whitton Subject: Re: bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols References: <87h79s1isp.fsf@athena.silentflame.com> <87a6fk19no.fsf@athena.silentflame.com> X-Now-Playing: David Bowie's _Brilliant Adventure (9): Re:Call 5_: "Buddha Of Suburbia (single version)" Date: Tue, 25 Jan 2022 13:26:59 +0100 In-Reply-To: <87a6fk19no.fsf@athena.silentflame.com> (Sean Whitton's message of "Tue, 25 Jan 2022 01:50:35 -0700") Message-ID: <87sftcxap8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sean Whitton writes: > Here is a patch which has `eshell-parse-external-pipeline' try skipping > over sharp-quoted symbols before trying to skip over single-quoted > strings. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53518 Cc: 53518@debbugs.gnu.org, Michael Albinus , Jim Porter X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Sean Whitton writes: > Here is a patch which has `eshell-parse-external-pipeline' try skipping > over sharp-quoted symbols before trying to skip over single-quoted > strings. This leads to the following compilation warning: ELC eshell/em-extpipe.elc In end of data: eshell/em-extpipe.el:107:38: Warning: the function `eshell-parse-lisp-argument' is not known to be defined. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 11:48:34 2022 Received: (at 53518) by debbugs.gnu.org; 25 Jan 2022 16:48:34 +0000 Received: from localhost ([127.0.0.1]:49911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCOzh-00012j-J9 for submit@debbugs.gnu.org; Tue, 25 Jan 2022 11:48:33 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:35619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCOzc-00012R-3v for 53518@debbugs.gnu.org; Tue, 25 Jan 2022 11:48:32 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 41B5E320232A; Tue, 25 Jan 2022 11:48:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 25 Jan 2022 11:48:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=Xj2QQm07wmF+zhJ9zKjAv4uCdupZYI XVGT+aLnvdlUw=; b=3vkJHGdURRTkupErmguR3nG6Y4Dj7HEc75Kp3F6JV8CwqE DzBhgtquHCE7Qy7+6OgCOvEOfFMn/RySoiEU3oA9iRqpAyA2HzIQLAQAMikaLyYj fKDUIPzO+gQnp10NZxHIC9E225ZggzNstIXTBoKLXsAiEiMDBLSqo3qeFTugZqqK uL/x9eyhcKfxEoqRnGUBOq8sxr40XVFyMk6S7SW3oqJ/BdFJJJCZLz6P/LDCJJSo ybFwwR3UJehKq65LBQ+r68J8pcxS1VYZczs9uEsccfZ+p4vOSBUUpZe+8nlsIZIU lB0GwGd+qL2zVA+q0nvpTkFYDgWwty+LZthu6OJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Xj2QQm07wmF+zhJ9z KjAv4uCdupZYIXVGT+aLnvdlUw=; b=XCNQlzb3IR/n49Td5CGlqI/KUEB2/XSjd iTFBkU9je/MRbpasDUuNEJsT5iJcFJO0xo8v8NElc5WYiRRw2jrw4Yx2YNjbnJE7 Jmqqro5p0hrwOvTMCJ5UVea0nvfxwVPmegnoSaTsKkGjn4VKdrMlGt4R1fO7SQRe YTCUy0eeeSR3xJbLyCxA2XHYrVm5UvKzmUTeUeMMfjb5s/NFZisvH4Z8f0bUlDXi wmu1mJwIug4qKSKeo0oymzlbCfN6rfyeMhuPuLaLjSejCFbRuCTaUPjq1mMSj0kg Z5iQ0m9Lei8ZhMIu+aPahju1QXTchs7HvS2+Cs0fIrI6QOLhs6+nQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvdelgdelvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesmhdttdertdertdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpefgueeutedvkeffgedvveetheejieetvdduvdffheevgfetvdfg hfetteffvdevjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jan 2022 11:48:18 -0500 (EST) Received: by athena.silentflame.com (Postfix, from userid 1000) id 4C13F1B6558; Tue, 25 Jan 2022 16:48:16 +0000 (UTC) From: Sean Whitton To: Lars Ingebrigtsen Subject: Re: bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols In-Reply-To: <87sftcxap8.fsf@gnus.org> References: <87h79s1isp.fsf@athena.silentflame.com> <87a6fk19no.fsf@athena.silentflame.com> <87sftcxap8.fsf@gnus.org> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Tue, 25 Jan 2022 09:48:16 -0700 Message-ID: <875yq7223z.fsf@athena.silentflame.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53518 Cc: 53518@debbugs.gnu.org, Michael Albinus , Jim Porter X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello, On Tue 25 Jan 2022 at 01:26pm +01, Lars Ingebrigtsen wrote: > This leads to the following compilation warning: > > ELC eshell/em-extpipe.elc > In end of data: > eshell/em-extpipe.el:107:38: Warning: the function `eshell-parse-lisp-argument' is not known to be defined. Apologies for this. Here is a fixed patch. -- Sean Whitton --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=v2-0001-Fix-input-of-sharp-quoted-symbols-in-Eshell-with-.patch >From 7981a5de5f06fd8879e57ac4d780370965999d7b Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Mon, 24 Jan 2022 22:39:15 -0700 Subject: [PATCH v2] Fix input of sharp-quoted symbols in Eshell with em-extpipe * lisp/eshell/em-extpipe.el (eshell-parse-external-pipeline): Fix misinterpreting sharp-quoted symbols as the beginning of single-quoted strings (Bug#53518). Add protection against a possible infinite loop. * test/lisp/eshell/em-extpipe-tests.el (em-extpipe-test-17): New test. --- lisp/eshell/em-extpipe.el | 13 ++++++++++--- test/lisp/eshell/em-extpipe-tests.el | 4 ++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/lisp/eshell/em-extpipe.el b/lisp/eshell/em-extpipe.el index 57aeec38ff..eb5b3bfe1d 100644 --- a/lisp/eshell/em-extpipe.el +++ b/lisp/eshell/em-extpipe.el @@ -30,6 +30,7 @@ (require 'cl-lib) (require 'esh-arg) +(require 'esh-cmd) (require 'esh-io) (require 'esh-util) @@ -97,15 +98,21 @@ eshell-parse-external-pipeline (while (> bound (point)) (let* ((found (save-excursion - (re-search-forward "['\"\\]" bound t))) + (re-search-forward + "\\(?:#?'\\|\"\\|\\\\\\)" bound t))) (next (or (and found (match-beginning 0)) bound))) (if (re-search-forward pat next t) (throw 'found (match-beginning 1)) (goto-char next) - (while (or (eshell-parse-backslash) + (while (or (eshell-parse-lisp-argument) + (eshell-parse-backslash) (eshell-parse-double-quote) - (eshell-parse-literal-quote))))))))) + (eshell-parse-literal-quote))) + ;; Guard against an infinite loop if none of + ;; the parsers moved us forward. + (unless (or (> (point) next) (eobp)) + (forward-char 1)))))))) (goto-char (if (and result go) (match-end 0) start)) result))) (unless (or eshell-current-argument eshell-current-quoted) diff --git a/test/lisp/eshell/em-extpipe-tests.el b/test/lisp/eshell/em-extpipe-tests.el index 1283b6b361..0879ad5b0c 100644 --- a/test/lisp/eshell/em-extpipe-tests.el +++ b/test/lisp/eshell/em-extpipe-tests.el @@ -202,4 +202,8 @@ em-extpipe-test-16 (eshell-command-result-p input "rab") (eshell-command-result-p "echo \"bar\" | rev" "nonsense")))) +;; Confirm we don't break input of sharp-quoted symbols (Bug#53518). +(em-extpipe-tests--deftest em-extpipe-test-17 "funcall #'upcase foo" + (eshell-command-result-p input "FOO")) + ;;; em-extpipe-tests.el ends here -- 2.30.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 13:15:02 2022 Received: (at 53518) by debbugs.gnu.org; 25 Jan 2022 18:15:02 +0000 Received: from localhost ([127.0.0.1]:50026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCQLN-0005YO-Mx for submit@debbugs.gnu.org; Tue, 25 Jan 2022 13:15:02 -0500 Received: from mail-pl1-f178.google.com ([209.85.214.178]:37801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCQLK-0005Xy-5Z for 53518@debbugs.gnu.org; Tue, 25 Jan 2022 13:15:00 -0500 Received: by mail-pl1-f178.google.com with SMTP id j16so9569476plx.4 for <53518@debbugs.gnu.org>; Tue, 25 Jan 2022 10:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=9SkNRtb1GKthyepu1uv2OMUZMFZk1/CDOY4MNdiqG+I=; b=qGWlLmlhj1o+2ZV8iyBg2YcKvcD4lWGnt6JgiaPSj5P60++X2K2/Ef2xbJLXqhAh+W lZ+96JGnNkftQ7lnnfxO0/Hl5fM2Vjo8OFWhx+lZuitFsrKmEmYQ3T4l3xEMq50HNYg/ mxq7c25i8dBs2NkzGrBXPBMDkGx53izH/NxUfbuXt/AGbryhjS1ySaMugN/mU92+d0iv W/kZK1QeNfhdumZfC8gV/RedMU75uLCKqzrU2ln0iFEbAeFFa+AfTyr3Wr40svuJv8B6 JzAbmYuQkKeHtvrY5OXCPJpy3/Bp9CQtTrblEwfznjnIFQIYQQfUEb7xHPbxu41vcCyb 9Ekg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9SkNRtb1GKthyepu1uv2OMUZMFZk1/CDOY4MNdiqG+I=; b=geihXTpFosGOAcb4Ex9zx+0djXuPrgZcKNDJa3xbZ3luhwDuqORQvyyvCQsjnPIwb9 RGdm7j/dcV+kNMjfsUw4hoXR3mqWcIwQ/q8IAtVhAQXKOkQ8umxdaCv6baxrcwX0qEm1 t9wYhaFzzSRxTOOa4zNC4zr9IZkXmvc80Qfi0h2uDyHE2hLj2nwRNXrmHDKIDfhs2kWI HNSBvURcvlYD194m+lh3RDsMi+bSEOZYIztx9dmP//7txgwHFEWyua2e2H7Dio83kCN8 n+Ttwn6jmf8YK7QO2c5rGglrdBkxBHsttYH0bUIi/Mp2RtgEK75ydmZAED7SxkFKFAzn yWbA== X-Gm-Message-State: AOAM531pgTbPtPEGaizRCPstzM5sGFw98iBh0uqCQ167rHozonMthOXa xiVm43V+C4FrayFeHZIe7xU= X-Google-Smtp-Source: ABdhPJzHk5g1jd6JHUklTm11LaiddrL7h20jxIHsEoOZ0gbJ0me5g9kPPMM7AJqk5nqboIVIEv2E8A== X-Received: by 2002:a17:902:ab8f:b0:14a:adaa:93f2 with SMTP id f15-20020a170902ab8f00b0014aadaa93f2mr19435027plr.131.1643134492268; Tue, 25 Jan 2022 10:14:52 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id u21sm21167043pfi.149.2022.01.25.10.14.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jan 2022 10:14:50 -0800 (PST) Subject: Re: bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols To: Sean Whitton , 53518@debbugs.gnu.org References: <87h79s1isp.fsf@athena.silentflame.com> <87a6fk19no.fsf@athena.silentflame.com> From: Jim Porter Message-ID: <50d26e9c-1b7f-5f1f-fcd6-545403f9e86c@gmail.com> Date: Tue, 25 Jan 2022 10:14:52 -0800 MIME-Version: 1.0 In-Reply-To: <87a6fk19no.fsf@athena.silentflame.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53518 Cc: Lars Ingebrigtsen , Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/25/2022 12:50 AM, Sean Whitton wrote: > Hello again, > > On Mon 24 Jan 2022 at 06:39pm -08, Jim Porter wrote: > >> I just noticed a small bit of breakage with this. It's no longer >> possible to refer to Lisp functions in Eshell like so: >> >> #'upcase >> >> Eshell explicitly supports this construct (see `eshell-lisp-regexp'), >> though it doesn't appear to be documented in the manual. Currently, this >> syntax is only occasionally useful, but I'm working on a patch series >> where it'll likely become a lot more common. My patches will add support >> for piping to Lisp functions, so that you can do the following, for example: >> >> $ echo hi | #'upcase >> HI > > Out of curiosity, why is there a need for the sharpquote? Why not just > 'echo hi | upcase'? Is it to do with requesting the new piping? It becomes more relevant with my WIP patches to support piping to Lisp functions, but it means something different today too. "upcase" *calls* the function `upcase', whereas "#'upcase" evaluates to the function object itself. For example: $ upcase Wrong number of arguments: #, 0 $ #'upcase upcase Or, for a slightly different, but more practical example today: $ mapcar upcase $(list "foo" "bar") Invalid function: "upcase" $ mapcar #'upcase $(list "foo" "bar") ("FOO" "BAR") In this case, "upcase" in the first command is just the string "upcase", whereas "#'upcase" refers to the function as in the other case. The shortest other way I'm aware of to spell that using shell-like invocation would be: $ mapcar $(quote upcase) $(list "foo" "bar") ("FOO" "BAR") For testing purposes, it would probably also be useful to ensure that Lisp syntax works too: $ (mapcar #'upcase '("foo" "bar")) ("FOO" "BAR") Just for the sake of completeness, in my WIP patches, "echo hi | #'upcase" and "echo hi | upcase" will also do different things, following the above precedent. The former pipes the output of echo to the function upcase. The latter pipes the output of echo to the *result* of calling the function upcase with no arguments. In addition to being consistent with how Eshell currently works, this allows you to do things like "echo hi | less -N", where "less -N" is evaluated as an Eshell command and then returns a pseudo-pipe for echo to connect to. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 15:02:03 2022 Received: (at 53518) by debbugs.gnu.org; 25 Jan 2022 20:02:03 +0000 Received: from localhost ([127.0.0.1]:50223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCS0x-0002LY-Ai for submit@debbugs.gnu.org; Tue, 25 Jan 2022 15:02:03 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCS0s-0002Ku-B2 for 53518@debbugs.gnu.org; Tue, 25 Jan 2022 15:02:02 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C54B85C0189; Tue, 25 Jan 2022 15:01:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 25 Jan 2022 15:01:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=m/6Xr9P+3iAMQMXYMhnQa86IAgf6mZ loM8A/R88Sn+E=; b=WKMAuDa4lpsu5JqvNfol1kbfiscXVqIqBdEBVLzQCVFq2Z jeqcg/p6RiCYUTxKYkDqqJfG6K97bTHcD/woqTk/pOtyEh0KJbZGQBoBy6eWooh+ dV5HuWs8n5SBZY+QxNNSoiZid+kk6BT+hQ7fLgKwsUDg1Bk/BfB5DX2/bNTO2p/O I3xNa4C8L6m4Dlw+Ld+rGDFcKSXgYKlmEoarHHe8YKPRJO/85/VknZznlWPZShPI ibyKTO5fw22j/L2MEpKi5KY6HxHlq7qFm9LJ5I3gA1+4iT+ORQnx8Nvxc1XwKFie dD7Ospn8KjYoysdJwuCmhRJuczKt4fmpM2Kr9fPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=m/6Xr9P+3iAMQMXYM hnQa86IAgf6mZloM8A/R88Sn+E=; b=A5fcJ/FdfPDrQvSehr98UTu+jCPicGCwI D/uTUBHN8cite/HUxizaWFeUN3CiO+EGERbCD+l4CUx49mVbnZ0k3tt3qwRTUPVD HnhJ2sQhznjM7h//eMwpKeUEgao1hz3ndUzXcmkS+eEz8yp9Bpt37YajZq2usOvf cP55T4WmRb1bIn7CtOKDJEArZaR+NO9cKqqyr6VGSF0EfNbjzEq1IHpvqim9qeT2 7w0+XPFc8KeNDf0z+Kw8WJa7/msSGbksWUslBXzeCyJY/a+KMp9z9Ni/C3fY3nSa UlvzeHMYPC+qBFKyAxpqYBERMrtgM6Bkv5741P1t5xjLl54dWFgyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvdelgddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepleeggefgvdeijedvhfdugfegtefgkeekueeileejjeehudeg geefteeghfeuffeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jan 2022 15:01:52 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 8BD4E7E4FF0; Tue, 25 Jan 2022 13:01:51 -0700 (MST) From: Sean Whitton To: Jim Porter , 53518@debbugs.gnu.org Subject: Re: bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols In-Reply-To: <50d26e9c-1b7f-5f1f-fcd6-545403f9e86c@gmail.com> References: <87h79s1isp.fsf@athena.silentflame.com> <87a6fk19no.fsf@athena.silentflame.com> <50d26e9c-1b7f-5f1f-fcd6-545403f9e86c@gmail.com> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Tue, 25 Jan 2022 13:01:51 -0700 Message-ID: <87h79rtwi8.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53518 Cc: Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 25 Jan 2022 at 10:14AM -08, Jim Porter wrote: > It becomes more relevant with my WIP patches to support piping to Lisp > functions, but it means something different today too. Indeed. > Just for the sake of completeness, in my WIP patches, "echo hi | > #'upcase" and "echo hi | upcase" will also do different things, > following the above precedent. The former pipes the output of echo to > the function upcase. The latter pipes the output of echo to the *result* > of calling the function upcase with no arguments. Okay, thanks. I asked because I thought you were only planning support the former case. > In addition to being consistent with how Eshell currently works, this > allows you to do things like "echo hi | less -N", where "less -N" is > evaluated as an Eshell command and then returns a pseudo-pipe for echo > to connect to. It's not quite clear to me how this is consistent with how Eshell currently works. When you type "echo hi | cat" is it right to say that "cat" is evaluated to produce the thing to which the output of the first command is piped? Perhaps I'm not thinking broadly enough. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 15:52:46 2022 Received: (at 53518) by debbugs.gnu.org; 25 Jan 2022 20:52:46 +0000 Received: from localhost ([127.0.0.1]:50272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCSo2-0008AH-Dl for submit@debbugs.gnu.org; Tue, 25 Jan 2022 15:52:46 -0500 Received: from mail-pj1-f44.google.com ([209.85.216.44]:51045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCSo0-0008A0-1x for 53518@debbugs.gnu.org; Tue, 25 Jan 2022 15:52:45 -0500 Received: by mail-pj1-f44.google.com with SMTP id o11so3975215pjf.0 for <53518@debbugs.gnu.org>; Tue, 25 Jan 2022 12:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=SdB1pPz6dJt8Oyf0aVzSSQoOa2sqTOCBzpWSD2MqfDE=; b=aveRSLtpZwo90j+cIMOMY0h0Hvvt5gdP+KkpiSNqbukY7ilx+vB8jrNy0mC4y7W3g9 IAJukQsRT9vo+i7oGXP4E7E8FzcbcYQMQKDToUB8S7xu3eB+AjA2vvIK+sKbXWL4pQ6K ijC0DCnEs/PunYVxSw7Jjnubst7FutsLnHsnKTAq1lmqck69uwoOj+sU4HDLwTuNX8Fn J/FHJ40Iev622hXnm8ybeTo3IQ+lz5tsxiEARJj2wD++WQnF2FUhav6/aMgrdcMMxW4Q JNiDcDa/y6T58G4ry82vfAfXPVrz16FYCzQAr90/JQTosGOKZwkqu2LFd9jPWX9lxwYs 1tVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SdB1pPz6dJt8Oyf0aVzSSQoOa2sqTOCBzpWSD2MqfDE=; b=hf9Hy9SwVF2ECBOIaANH4nyiOdXNNjobvCtBrJBDvGBj6W2tvNudeQa287+5JUEncM GQdTB7FDUGI7jVIzLYuvjUhPDwctU4V3a3tb3OLVqMu4GZA1j4hL/62wj30WjA39z3Sx ZSAur6bAsZZo/oFvaQHDG/ignGhnWk7z+h76sWPvVLlImUTGlZE9ZhucjxtrTREaooB8 xZ3BgVv5MA9o7SUuakE1Ji1LdvE+/qRil9ugaBKxLUeACVTx3O1ta3ovnN/Sn1LTrmfQ Sm8ZqSuy0aDW3KSMBR6EgXhgzIb2xjFD/w0zn5nkLITnAdLcPq+TC5EvtnSxaCrS+Le7 3CdA== X-Gm-Message-State: AOAM533X6Mxe0+PyNvg84MqnAo08xdsxPIRyVYwvu4BvJ0TMRlXTCZeV QN3R9RFV3bBChd+OfaV1Plc= X-Google-Smtp-Source: ABdhPJx3GOVDb20mO/K97TFECkVjRrfNfLezhzrcu67cMXnJ20Zhf831tZON4mIQCaxchDcLrqFncw== X-Received: by 2002:a17:903:404c:b0:14b:6dd8:9c3b with SMTP id n12-20020a170903404c00b0014b6dd89c3bmr5594021pla.80.1643143958046; Tue, 25 Jan 2022 12:52:38 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id l4sm5380468pfu.90.2022.01.25.12.52.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jan 2022 12:52:37 -0800 (PST) Subject: Re: bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols To: Sean Whitton , 53518@debbugs.gnu.org References: <87h79s1isp.fsf@athena.silentflame.com> <87a6fk19no.fsf@athena.silentflame.com> <50d26e9c-1b7f-5f1f-fcd6-545403f9e86c@gmail.com> <87h79rtwi8.fsf@melete.silentflame.com> From: Jim Porter Message-ID: <23a3a554-5ad3-b55b-1eb7-10d72528d55a@gmail.com> Date: Tue, 25 Jan 2022 12:52:36 -0800 MIME-Version: 1.0 In-Reply-To: <87h79rtwi8.fsf@melete.silentflame.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53518 Cc: Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/25/2022 12:01 PM, Sean Whitton wrote: >> In addition to being consistent with how Eshell currently works, this >> allows you to do things like "echo hi | less -N", where "less -N" is >> evaluated as an Eshell command and then returns a pseudo-pipe for echo >> to connect to. > > It's not quite clear to me how this is consistent with how Eshell > currently works. When you type "echo hi | cat" is it right to say that > "cat" is evaluated to produce the thing to which the output of the first > command is piped? Perhaps I'm not thinking broadly enough. In general, I just mean that when running a command "foo" (in a pipeline or not), if Eshell finds a Lisp function for "foo", it always calls that function. On the other hand, "#'foo" always evaluates to the function object itself. So, since "cat" points to a Lisp function, your summary is pretty close, I'd say. However, I think I'd describe it as "cat is evaluated to hook up the pipeline into what the user meant". Currently, it works like so: 1. `eshell-parse-command' turns "echo hi | cat" into: (eshell-commands (progn (run-hooks 'eshell-pre-command-hook) (catch 'top-level (progn (eshell-trap-errors (eshell-execute-pipeline '((eshell-named-command "echo" (list "hi")) (eshell-named-command "cat")))))) (run-hooks 'eshell-post-command-hook))) 2. Eshell iteratively evaluates that, eventually getting to to the "cat" part 3. `eshell-named-command' looks for "cat" and calls the function `eshell/cat' 4. `eshell/cat' notices that it's being called in a pipeline and bails out, throwing `eshell-replace-command' to convert "cat" into "/bin/cat" (or wherever your cat program lives) 5. This gets reevaluated in `eshell-do-eval' and calls `eshell-external-command' for "/bin/cat" 6. This calls `eshell-gather-process-output', returning a process object with the pipes connected That is, Eshell evaluates `eshell/cat' (which could do anything, really) with the ultimate goal of hooking up the pipeline. Currently that just means "call /bin/cat and connect pipes to the external process", but `eshell/cat' can do whatever it wants to achieve the result. For the "pipe to a Lisp function" case, like "echo hi | #'upcase", what's actually happening under the hood in my patch it that "#'upcase" is evaluated, Eshell sees that the result is a function, and then the function is converted into a pseudo-pipe that gets properly hooked up to echo. For a case like "echo hi | less -N", where "less" has a Lisp implementation, Eshell evaluates `(eshell/less "-N")', which could return a function that gets converted into a pseudo-pipe like above. Or (and this is how `eshell/less' will actually work), it returns its own pseudo-pipe that's hooked up properly; this case is analogous to `eshell-gather-process-output' returning a properly-connected process object. The subtleties of Lisp functions in pipelines will probably be a bit easier to understand once I post patches, which should hopefully be this week or next. :) The patches work already, but I'm still implementing a few more pipeable Eshell commands in Lisp so that I can be sure the core implementation is flexible enough to be used for practical cases. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 17:39:07 2022 Received: (at 53518) by debbugs.gnu.org; 25 Jan 2022 22:39:07 +0000 Received: from localhost ([127.0.0.1]:50444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCUSw-0002W4-QA for submit@debbugs.gnu.org; Tue, 25 Jan 2022 17:39:06 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCUSu-0002VV-Is for 53518@debbugs.gnu.org; Tue, 25 Jan 2022 17:39:05 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5A5C85C0242; Tue, 25 Jan 2022 17:38:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 25 Jan 2022 17:38:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=j+cEsAvQlRlUSxv1bmuMtNz90pQ/3k xaGUzv4cQybwg=; b=FiZRyY0qECTMpAzQp5gLEVjs9lgP65dznpmvqSsvN6wTOL 53Kb0upmlHELg8u0kw970r70LT5HxrR15jBU4bwDG6HB9RzZuJiVEcjrTm4aEvNh 2tCe+HArFkS24z2U7JMhIoONsjzi2olGO8Xz5MVeBIljeZy4TY5CHaHehuEsZ4tO 3Jj4GnYy76k2B3nTXi5k7FYV4BqTg30R9uyVtD0Ej/CVoCUfjokYqADzX/WSnZka EdHq/nUAzHWMaegt6SRcPd7z3FeHRtL/vBCgYvQsfDv+9q2uq2NHbEG/l8e2xJS5 ZkV0+9yQQABP7pwRTcVaI8k85UU3b4UYmebkJeEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=j+cEsAvQlRlUSxv1b muMtNz90pQ/3kxaGUzv4cQybwg=; b=D/RxEU1CCbyK35l2DnDhCbs265M1gebIV zGyaxCEWgUBOPiL9qFvFwR1276MRjNRetX+CAQk0OFGFdTMC+tkEGVM3b8Bhy0Gy iPgGU4aLQiPUXodomaK9r13kljmw/4fVWkXsltTRJfHVFiXvZhEESKw8SjTjliR/ hoJvIZckqS/rldH2p5/f/ishZhDT+WNIl/i14MCsQdjAnUAd7GIRfy3cjgDKkFyU 0b4WYHYiVedRVFLk7Pga5cFyC0WgdCLV4y8yzF92yOTZZQqEaXxuxOh7V3LgPSYJ TwgBpbYkvGGTTHNbeWd+881Iyz2zVBMuqqPcTZAkXSbTs6okDWFPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrfedtgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeelgeeggfdvieejvdfhudfggeetgfekkeeuieeljeejhedugeeg feetgefhueffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jan 2022 17:38:59 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 697077E5505; Tue, 25 Jan 2022 15:38:58 -0700 (MST) From: Sean Whitton To: Jim Porter , 53518@debbugs.gnu.org Subject: Re: bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols In-Reply-To: <23a3a554-5ad3-b55b-1eb7-10d72528d55a@gmail.com> References: <87h79s1isp.fsf@athena.silentflame.com> <87a6fk19no.fsf@athena.silentflame.com> <50d26e9c-1b7f-5f1f-fcd6-545403f9e86c@gmail.com> <87h79rtwi8.fsf@melete.silentflame.com> <23a3a554-5ad3-b55b-1eb7-10d72528d55a@gmail.com> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Tue, 25 Jan 2022 15:38:58 -0700 Message-ID: <87pmoftp8d.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53518 Cc: Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 25 Jan 2022 at 12:52PM -08, Jim Porter wrote: > The subtleties of Lisp functions in pipelines will probably be a bit > easier to understand once I post patches, which should hopefully be this > week or next. :) The patches work already, but I'm still implementing a > few more pipeable Eshell commands in Lisp so that I can be sure the core > implementation is flexible enough to be used for practical cases. Thank you for the explanation. I still don't see how your proposal is a natural extension of what Eshell already does, to be honest, but I'm sure things will become clearer once you post your docs and tests, as you say. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 26 00:38:09 2022 Received: (at 53518) by debbugs.gnu.org; 26 Jan 2022 05:38:09 +0000 Received: from localhost ([127.0.0.1]:50807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCb0T-00012G-12 for submit@debbugs.gnu.org; Wed, 26 Jan 2022 00:38:09 -0500 Received: from mail-pj1-f47.google.com ([209.85.216.47]:51853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCb0S-000122-2r for 53518@debbugs.gnu.org; Wed, 26 Jan 2022 00:38:08 -0500 Received: by mail-pj1-f47.google.com with SMTP id q63so17615011pja.1 for <53518@debbugs.gnu.org>; Tue, 25 Jan 2022 21:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=teifnaxbc8ZPJwv2O9+sRnCn7rfoNljrQkMc/mSw1pQ=; b=atKIeXJ6JDMlntTvY2aLINw74hZKTeIly7LUwBS/nz7r2+YbzOLZRQQHVlt0ulFWXh eDXT33rpbqvAZOZKOt/XtLii9ct+U1owocSJrjuslQcj2zJZEflMNfzXfiMDr7TijEIX NEB4zGZHGthyhO3E5/04e81YvmLwYYcRzXz95RxJ1ouGZqtHOMeyaZZQc3UfA/HA6UEW TLegEvn4RtjK6T4cYHAzwmOdL4sAlO8jE7ChU1xXdAYv3YtD8GngsDmN4ohnF2P86I4K aLzDjFsyD4PwJxGGWrwCzvLzfAVB5HvHj6WPnAj2RDXtD28n24Tj/ER4horOQcdDwFrh CsFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=teifnaxbc8ZPJwv2O9+sRnCn7rfoNljrQkMc/mSw1pQ=; b=Xw4KJ1XZDRtYssgBq7pNaik+wwSd0rqzI9iVWSx+ko5As78WU952mvly3K6jM+nc3K Av8KCQyjbJXOYNBLWdZtnD4avlSLfXr1XOPVQ70Lv8FGENXbpqFuyky4QZvSpmuGYTDy hywlsk3fq9ZgY5FfHwEhkFvHyZOpJiPmugFTKsUithKGqoaT+Ml6M28vL/ThlZPjjjXs eNFB+CFxuI0ynqMckdz17IKxD5b3b1KgeYnBSmc7M0RXSeX4dLqbX495qA62j6GpP7Mi t9EDf4Ta9o9XH1IvTKkbK5FPugFbry3f3xUb8umOjp/rwjOS+rwW02SYyQudUJC+/d2B 7yRQ== X-Gm-Message-State: AOAM532RnAFbQxIQBSuMUpxr5uXD0+HwTmNXZBsrZJZ+rEeXOG6ejChY dj2TkGw0yy0ZBwHjWlqTQJQ= X-Google-Smtp-Source: ABdhPJwr1oG6LvZK06w7LeAkvbZJVQQcUgEEyy9ngIZvZhCgrMRg2QXPERISqrJIYJRlMc3L8QCyFw== X-Received: by 2002:a17:90b:4a47:: with SMTP id lb7mr6968451pjb.55.1643175481940; Tue, 25 Jan 2022 21:38:01 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id u16sm749605pfg.196.2022.01.25.21.38.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jan 2022 21:38:01 -0800 (PST) Subject: Re: bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols To: Sean Whitton , Lars Ingebrigtsen References: <87h79s1isp.fsf@athena.silentflame.com> <87a6fk19no.fsf@athena.silentflame.com> <87sftcxap8.fsf@gnus.org> <875yq7223z.fsf@athena.silentflame.com> From: Jim Porter Message-ID: <2f3e987b-6d35-db52-777b-a73ff9d38b8f@gmail.com> Date: Tue, 25 Jan 2022 21:38:01 -0800 MIME-Version: 1.0 In-Reply-To: <875yq7223z.fsf@athena.silentflame.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53518 Cc: 53518@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/25/2022 8:48 AM, Sean Whitton wrote: > On Tue 25 Jan 2022 at 01:26pm +01, Lars Ingebrigtsen wrote: > >> This leads to the following compilation warning: >> >> ELC eshell/em-extpipe.elc >> In end of data: >> eshell/em-extpipe.el:107:38: Warning: the function `eshell-parse-lisp-argument' is not known to be defined. > > Apologies for this. Here is a fixed patch. Thanks for the quick fix, this resolves everything on my end. I applied the patch to my local branch for Lisp function pipelining and all the tests in test/lisp/eshell/ now pass, including the new ones I'm working on. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 26 08:13:30 2022 Received: (at 53518) by debbugs.gnu.org; 26 Jan 2022 13:13:30 +0000 Received: from localhost ([127.0.0.1]:51191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCi78-0000Hk-Ax for submit@debbugs.gnu.org; Wed, 26 Jan 2022 08:13:30 -0500 Received: from quimby.gnus.org ([95.216.78.240]:47366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCi76-0000HU-7H for 53518@debbugs.gnu.org; Wed, 26 Jan 2022 08:13:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=81UiNadCfpPnuiuHK4tPsUcvXWnj5zP6H2xhurRDV5Q=; b=M5Y4Oxqa61UGDAsC9MhfAAAZFB dNuTdxt50xvTswHg0WwRkFmdgsxd7YHmzAZ8D5/Kg2eSsUq8AXDt/mVPqof2jJy2784btK4rrpeXE fKvrqVyJXBQJq53ZKZ1mufd5JaibjN/OlEADZLjGBzbpd7daWiTxiUy+wsjdlvsNLqF8=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCi6w-00016W-LF; Wed, 26 Jan 2022 14:13:21 +0100 From: Lars Ingebrigtsen To: Sean Whitton Subject: Re: bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols References: <87h79s1isp.fsf@athena.silentflame.com> <87a6fk19no.fsf@athena.silentflame.com> <87sftcxap8.fsf@gnus.org> <875yq7223z.fsf@athena.silentflame.com> X-Now-Playing: Dry Cleaning's _New Long Leg_: "John Wick" Date: Wed, 26 Jan 2022 14:13:18 +0100 In-Reply-To: <875yq7223z.fsf@athena.silentflame.com> (Sean Whitton's message of "Tue, 25 Jan 2022 09:48:16 -0700") Message-ID: <87czketzbl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sean Whitton writes: > Apologies for this. Here is a fixed patch. Thanks; applied to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53518 Cc: 53518@debbugs.gnu.org, Michael Albinus , Jim Porter X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Sean Whitton writes: > Apologies for this. Here is a fixed patch. Thanks; applied to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 26 08:13:37 2022 Received: (at control) by debbugs.gnu.org; 26 Jan 2022 13:13:37 +0000 Received: from localhost ([127.0.0.1]:51194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCi7E-0000I3-Hp for submit@debbugs.gnu.org; Wed, 26 Jan 2022 08:13:37 -0500 Received: from quimby.gnus.org ([95.216.78.240]:47380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCi7B-0000Hc-CU for control@debbugs.gnu.org; Wed, 26 Jan 2022 08:13:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/gN66sEUSIsEjhD65NFUL7XCJxL+uJ89FIhpGhmfq2A=; b=Z6zKSStb8Gcy7SbD1LOX9bkvuU PZxKzIpD8q3tVTKFwAJhnzlyJFiUkXBVoZ/ij8bkL6sLth4crEaxaPTIMUDtIBPFK15VyLya9Y7yf Y5gy91U8Kv0zbMd62yWJzFlYBp6NzZvI4wiCHGM3jnDQbce1k0eunk93bvHZ4U83ykug=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCi73-00016n-K5 for control@debbugs.gnu.org; Wed, 26 Jan 2022 14:13:27 +0100 Date: Wed, 26 Jan 2022 14:13:25 +0100 Message-Id: <87bkzytzbe.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #53518 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 53518 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 53518 29.1 quit From unknown Fri Jun 20 07:09:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Feb 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator